diff options
author | wxiaoguang <wxiaoguang@gmail.com> | 2023-04-30 23:51:20 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-04-30 11:51:20 -0400 |
commit | 14c142b0bca2af79f30fcf221479fb66d63dbdf8 (patch) | |
tree | 9262eade4d2e21210cd66618468d99162a66707b /web_src/css | |
parent | e8173c2c33f1dd5b0a2c044255434d414cab62d2 (diff) | |
download | gitea-14c142b0bca2af79f30fcf221479fb66d63dbdf8.tar.gz gitea-14c142b0bca2af79f30fcf221479fb66d63dbdf8.zip |
Improve issue list filter (#24425)
Partial regression of #24393, not only regression, but broken for long
time, 24393 didn't really improve it but used wrong `overflow: scroll`.
Actually, that "ui secondary filter menu labels" shouldn't be set as
scrollable (I missed that at that time), the problem is: if a "ui menu"
has "dropdown" items, then it should not be scrollable. Otherwise the
dropdown menu can't be shown correctly.
And there are more problems:
* The "issue-filters" shouldn't be used anywhere else (copying&pasting
problem again ....)
* There is also an "issue-actions" container, it should also be fixed.
* There are similar problems on the milestone page.
* The old comment in code: "grid column" doesn't work well.
The major changes of this PR are: use "flex: 1" instead of "ui grid
column".
After this PR, not 100% perfect but much better than before.
Diffstat (limited to 'web_src/css')
-rw-r--r-- | web_src/css/index.css | 1 | ||||
-rw-r--r-- | web_src/css/repository.css | 17 | ||||
-rw-r--r-- | web_src/css/repository/issue-list.css | 14 |
3 files changed, 25 insertions, 7 deletions
diff --git a/web_src/css/index.css b/web_src/css/index.css index cdd0c51a54..d6ef1da9b9 100644 --- a/web_src/css/index.css +++ b/web_src/css/index.css @@ -32,6 +32,7 @@ @import "./repository.css"; @import "./repository/release-tag.css"; @import "./repository/issue-label.css"; +@import "./repository/issue-list.css"; @import "./repository/list-header.css"; @import "./editor.css"; @import "./editor/combomarkdowneditor.css"; diff --git a/web_src/css/repository.css b/web_src/css/repository.css index 6ad6ba88a8..259cfda3a1 100644 --- a/web_src/css/repository.css +++ b/web_src/css/repository.css @@ -141,12 +141,19 @@ font-size: 11px; } -.repository .filter.menu .menu { +/* make all issue filter dropdown menus popup leftward, to avoid go out the viewport (right side) */ +.repository .filter.menu .ui.dropdown .menu { max-height: 500px; max-width: 300px; overflow-x: hidden; - right: 0 !important; - left: auto !important; + right: 0; + left: auto; +} + +/* the label-filter is the first dropdown, it shouldn't be shown leftward, otherwise it may go out the viewport (left side) */ +.repository .filter.menu .ui.dropdown.label-filter .menu { + right: unset; + left: 0; } .repository .select-label .desc { @@ -2394,10 +2401,6 @@ margin: 6px 0; } -#issue-actions { - margin-top: -1rem !important; /* counteract padding from Semantic */ -} - .ui.menu .item > img:not(.ui) { width: auto; } diff --git a/web_src/css/repository/issue-list.css b/web_src/css/repository/issue-list.css new file mode 100644 index 0000000000..2c2d3572e0 --- /dev/null +++ b/web_src/css/repository/issue-list.css @@ -0,0 +1,14 @@ +.issue-list-toolbar { + display: flex; + flex-wrap: wrap; + align-items: flex-start; + gap: 1rem; +} + +.issue-list-toolbar-left { + display: flex; +} + +.issue-list-toolbar-right { + margin-left: auto; +} |