diff options
author | wxiaoguang <wxiaoguang@gmail.com> | 2021-12-10 10:51:27 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-12-10 10:51:27 +0800 |
commit | 0a9fcf63a49799ad3b0f146c54879161bac61e10 (patch) | |
tree | e4a6382fc1a2de403f2fec47886348dae5e72d2b /web_src/js/features/comp/ImagePaste.js | |
parent | 719bddcd76610a63dadc8555760072957a11cf30 (diff) | |
download | gitea-0a9fcf63a49799ad3b0f146c54879161bac61e10.tar.gz gitea-0a9fcf63a49799ad3b0f146c54879161bac61e10.zip |
Clean legacy SimpleMDE code (#17926)
Since we are using EasyMDE now, we do not need to keep the SimpleMDE code anymore.
This PR removes all legacy SimpleMDE code, and makes some related changes:
* `createCommentEasyMDE` can accept native DOM element, and it doesn't need `jQuery.data` to store EasyMDE editor object (as discussed about the frontend guideline).
* introduce `getAttachedEasyMDE` to get the attached EasyMDE editor object, it's easier to find all the usage of EasyMDE.
* rename variable names from `$simplemde` to `easyMDE`, the `$` was incorrect because it is a EasyMDE editor, not a jQuery object.
With this PR, it will be easier to do more refactoring or replacing EasyMDE with other editors.
Diffstat (limited to 'web_src/js/features/comp/ImagePaste.js')
-rw-r--r-- | web_src/js/features/comp/ImagePaste.js | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/web_src/js/features/comp/ImagePaste.js b/web_src/js/features/comp/ImagePaste.js index 99f4e069cc..8c8a4186c7 100644 --- a/web_src/js/features/comp/ImagePaste.js +++ b/web_src/js/features/comp/ImagePaste.js @@ -76,14 +76,14 @@ export function initCompImagePaste($target) { }); } -export function initSimpleMDEImagePaste(simplemde, dropzone, files) { +export function initEasyMDEImagePaste(easyMDE, dropzone, files) { const uploadUrl = dropzone.getAttribute('data-upload-url'); - simplemde.codemirror.on('paste', async (_, e) => { + easyMDE.codemirror.on('paste', async (_, e) => { for (const img of clipboardPastedImages(e)) { const name = img.name.substr(0, img.name.lastIndexOf('.')); const data = await uploadFile(img, uploadUrl); - const pos = simplemde.codemirror.getCursor(); - simplemde.codemirror.replaceRange(`![${name}](/attachments/${data.uuid})`, pos); + const pos = easyMDE.codemirror.getCursor(); + easyMDE.codemirror.replaceRange(`![${name}](/attachments/${data.uuid})`, pos); const input = $(`<input id="${data.uuid}" name="files" type="hidden">`).val(data.uuid); files.append(input); } |