diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-02-19 12:06:14 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-19 12:06:14 +0800 |
| commit | d32af84a1002ceb235c86e4ac569c866ab7816d4 (patch) | |
| tree | 3832638122aac31fdc2215f85873629fd8ef2fd2 /web_src/js/features/org-team.js | |
| parent | 6221a6fd5450692ae27e5602b41fc9ebd9150736 (diff) | |
| download | gitea-d32af84a1002ceb235c86e4ac569c866ab7816d4.tar.gz gitea-d32af84a1002ceb235c86e4ac569c866ab7816d4.zip | |
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
Close #22847
This PR:
* introduce Gitea's own `showElem` and related functions
* remove jQuery show/hide
* remove .hide class
* remove inline style=display:none
From now on:
do not use:
* "[hidden]" attribute: it's too weak, can not be applied to an element
with "display: flex"
* ".hidden" class: it has been polluted by Fomantic UI in many cases
* inline style="display: none": it's difficult to tweak
* jQuery's show/hide/toggle: it can not show/hide elements with
"display: xxx !important"
only use:
* this ".gt-hidden" class
* showElem/hideElem/toggleElem functions in "utils/dom.js"
cc: @silverwind , this is the all-in-one PR
Diffstat (limited to 'web_src/js/features/org-team.js')
| -rw-r--r-- | web_src/js/features/org-team.js | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/web_src/js/features/org-team.js b/web_src/js/features/org-team.js index 9e6c3c7ff1..3640bb96f7 100644 --- a/web_src/js/features/org-team.js +++ b/web_src/js/features/org-team.js @@ -1,4 +1,5 @@ import $ from 'jquery'; +import {hideElem, showElem} from '../utils/dom.js'; const {appSubUrl} = window.config; @@ -7,9 +8,9 @@ export function initOrgTeamSettings() { $('.organization.new.team input[name=permission]').on('change', () => { const val = $('input[name=permission]:checked', '.organization.new.team').val(); if (val === 'admin') { - $('.organization.new.team .team-units').hide(); + hideElem($('.organization.new.team .team-units')); } else { - $('.organization.new.team .team-units').show(); + showElem($('.organization.new.team .team-units')); } }); } |