aboutsummaryrefslogtreecommitdiffstats
path: root/web_src/js/features/repo-code.js
diff options
context:
space:
mode:
authordelvh <dev.lh@web.de>2023-05-21 22:47:41 +0200
committerGitHub <noreply@github.com>2023-05-21 20:47:41 +0000
commite95b42e187cde9ac4bd541cd714bdb4f5c1fd8bc (patch)
tree473584ab54af5220390413f2199843597f2be5f2 /web_src/js/features/repo-code.js
parentc59a057297c782f44a81a3e630b5094a58099edb (diff)
downloadgitea-e95b42e187cde9ac4bd541cd714bdb4f5c1fd8bc.tar.gz
gitea-e95b42e187cde9ac4bd541cd714bdb4f5c1fd8bc.zip
Improve accessibility when (re-)viewing files (#24817)
Visually, nothing should have changed. Changes include - Convert most `<a [no href]>` to `<button>` when (re-)viewing files: - `<a [no href]>` are, by HTML definition, not a link and hence cannot be focused - `<a class="ui button">` can now be clicked (again?) using <kbd>Enter</kbd> - Previously, the installed keypress handler on `.ui.button` elements disabled it for links somehow - The `(un)escape file`, the `expand section` and the `expand/collapse file` buttons can now be focused (and subsequently clicked using only the keyboard) - You can now press <kbd>Space</kbd> on a focused `View file` checkbox to mark the file as viewed. - previously, this was impossible as this checkbox listened on the wrong event listener The `add code comment` button has been left inaccessible for now as it requires quite a bit of extra logic so that it is unhidden when it is focused (you can otherwise focus it without seeing it as you are not hovering on the corresponding line). --------- Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'web_src/js/features/repo-code.js')
-rw-r--r--web_src/js/features/repo-code.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/web_src/js/features/repo-code.js b/web_src/js/features/repo-code.js
index 9b504068f6..73eccaf193 100644
--- a/web_src/js/features/repo-code.js
+++ b/web_src/js/features/repo-code.js
@@ -181,7 +181,7 @@ export function initRepoCodeView() {
$(document).on('click', '.fold-file', ({currentTarget}) => {
invertFileFolding(currentTarget.closest('.file-content'), currentTarget);
});
- $(document).on('click', '.blob-excerpt', async ({currentTarget}) => {
+ $(document).on('click', '.code-expander-button', async ({currentTarget}) => {
const url = currentTarget.getAttribute('data-url');
const query = currentTarget.getAttribute('data-query');
const anchor = currentTarget.getAttribute('data-anchor');