Add new JS linter rules (#17699)

* Add new JS linter rules

Adds a few useful rules from eslint-plugin-github. Notable changes:

- Forbid dataset usage, its camel-casing behaviour makes it hard to
  grep for attributes.
- Forbid .then() and .catch(), we should generally prefer await for new
  code. For rare cases where they are useful, a eslint-disable-line
  directive can be set.
- Add docs js to linting

* also enable github/array-foreach

* small tweak

Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

1 files changed, 5 insertions, 3 deletions

diff --git a/web_src/js/features/repo-home.js b/web_src/js/features/repo-home.js
index f8bf9318ce..29b4470619 100644
--- a/web_src/js/features/repo-home.js
+++ b/web_src/js/features/repo-home.js
@@ -57,13 +57,13 @@ export function initRepoTopicBar() {
           const {invalidTopics} = xhr.responseJSON;
           const topicLables = topicDropdown.children('a.ui.label');
 
-          topics.split(',').forEach((value, index) => {
+          for (const [index, value] of topics.split(',').entries()) {
             for (let i = 0; i < invalidTopics.length; i++) {
               if (invalidTopics[i] === value) {
                 topicLables.eq(index).removeClass('green').addClass('red');
               }
             }
-          });
+          }
         } else {
           topicPrompts.countPrompt = xhr.responseJSON.message;
         }
@@ -101,7 +101,9 @@ export function initRepoTopicBar() {
         const query = stripTags(this.urlData.query.trim());
         let found_query = false;
         const current_topics = [];
-        topicDropdown.find('div.label.visible.topic,a.label.visible').each((_, e) => { current_topics.push(e.dataset.value) });
+        topicDropdown.find('div.label.visible.topic,a.label.visible').each((_, el) => {
+          current_topics.push(el.getAttribute('data-value'));
+        });
 
         if (res.topics) {
           let found = false;