diff options
author | Gusted <williamzijl7@hotmail.com> | 2022-10-25 11:11:49 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-10-25 19:11:49 +0800 |
commit | 29c00eb1ed13fbcd2a5e493d075c2bbd0e2a26f7 (patch) | |
tree | f89469e7905d14f15a7dca66a0977f4c3813cfb8 /web_src/js/features/repo-issue.js | |
parent | 06a7ed4e04deec7718d3a3c0b4ae1c27f6cacc2c (diff) | |
download | gitea-29c00eb1ed13fbcd2a5e493d075c2bbd0e2a26f7.tar.gz gitea-29c00eb1ed13fbcd2a5e493d075c2bbd0e2a26f7.zip |
Improve code comment review on mobile (#21461)
- Fix placement of avatar image, this was not placed in the
`comment-header-left` and add CSS to cover the limiting of width+height
of avatar for code-review comment on "Files changed" page. This fixes
the big noticeable avatar issue.
- Apply `margin-bottom` to the "next" button, so it's consistent with
the "previous" button.
- Make sure the "next"/"previous" start at `flex-start` on mobile and
not off-screen at `flex-end`. As well force them to have `flex: 1` so
they won't overflow on x-asis. This also requires the `width: 100%` for
the `.ui.buttons` div.
- Resolves #20074
### Before
<details><img width="512"
src="https://user-images.githubusercontent.com/25481501/195952930-09560cad-419f-43a3-a8a4-a4166c117994.jpg"></details>
### After
<details><img width="512"
src="https://user-images.githubusercontent.com/25481501/197340081-0365dfa8-4344-46b4-8702-a40c778c073f.jpg"></details>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'web_src/js/features/repo-issue.js')
-rw-r--r-- | web_src/js/features/repo-issue.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/web_src/js/features/repo-issue.js b/web_src/js/features/repo-issue.js index 9dbe78edf5..54cdeb383b 100644 --- a/web_src/js/features/repo-issue.js +++ b/web_src/js/features/repo-issue.js @@ -513,16 +513,16 @@ export function initRepoPullRequestReview() { <td class="lines-num"></td> <td class="lines-escape"></td> <td class="lines-type-marker"></td> - <td class="add-comment-left"></td> + <td class="add-comment-left" colspan="4"></td> <td class="lines-num"></td> <td class="lines-escape"></td> <td class="lines-type-marker"></td> - <td class="add-comment-right"></td> + <td class="add-comment-right" colspan="4"></td> ` : ` <td class="lines-num"></td> <td class="lines-num"></td> <td class="lines-escape"></td> - <td class="add-comment-left add-comment-right" colspan="2"></td> + <td class="add-comment-left add-comment-right" colspan="5"></td> `} </tr>`); tr.after(ntr); |