Clean legacy SimpleMDE code (#17926)

Since we are using EasyMDE now, we do not need to keep the SimpleMDE code anymore.

This PR removes all legacy SimpleMDE code, and makes some related changes:
* `createCommentEasyMDE` can accept native DOM element, and it doesn't need `jQuery.data` to store EasyMDE editor object (as discussed about the frontend guideline).
* introduce `getAttachedEasyMDE` to get the attached EasyMDE editor object, it's easier to find all the usage of EasyMDE.
* rename variable names from `$simplemde` to `easyMDE`, the `$` was incorrect because it is a EasyMDE editor, not a jQuery object.

With this PR, it will be easier to do more refactoring or replacing EasyMDE with other editors.

1 files changed, 4 insertions, 4 deletions

diff --git a/web_src/js/features/repo-release.js b/web_src/js/features/repo-release.js
index 08e3e9e026..f69ce37d6b 100644
--- a/web_src/js/features/repo-release.js
+++ b/web_src/js/features/repo-release.js
@@ -1,7 +1,7 @@
 import attachTribute from './tribute.js';
 import {initCompMarkupContentPreviewTab} from './comp/MarkupContentPreview.js';
-import {initSimpleMDEImagePaste} from './comp/ImagePaste.js';
-import {createCommentSimpleMDE} from './comp/CommentSimpleMDE.js';
+import {initEasyMDEImagePaste} from './comp/ImagePaste.js';
+import {createCommentEasyMDE} from './comp/CommentEasyMDE.js';
 
 export function initRepoRelease() {
   $(document).on('click', '.remove-rel-attach', function() {
@@ -22,8 +22,8 @@ export function initRepoReleaseEditor() {
   const $textarea = $editor.find('textarea');
   attachTribute($textarea.get(), {mentions: false, emoji: true});
   const $files = $editor.parent().find('.files');
-  const $simplemde = createCommentSimpleMDE($textarea);
+  const easyMDE = createCommentEasyMDE($textarea);
   initCompMarkupContentPreviewTab($editor);
   const dropzone = $editor.parent().find('.dropzone')[0];
-  initSimpleMDEImagePaste($simplemde, dropzone, $files);
+  initEasyMDEImagePaste(easyMDE, dropzone, $files);
 }