diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-03-22 10:52:01 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-22 10:52:01 +0800 |
| commit | d4f35bd681af0632da988e15306f330e020422b2 (patch) | |
| tree | bf1f139baf61a3ece1d3da3b2daf199e4054acc8 /web_src/js/index.js | |
| parent | 43809e66ac4c36e153bacedd78400e8232f03a6c (diff) | |
| download | gitea-d4f35bd681af0632da988e15306f330e020422b2.tar.gz gitea-d4f35bd681af0632da988e15306f330e020422b2.zip | |
Use a general approch to improve a11y for all checkboxes and dropdowns. (#23542)
This PR follows #22599 and #23450
The major improvements:
1. The `aria-*.js` are totally transparent now, no need to call
`attachDropdownAria` explicitly anymore.
* It hooks the `$.fn.checkbox` and `$.fn.dropdown`, then our patch
works.
* It makes all dynamically generated checkbox/dropdown work with a11y
without any change
* eg: the `conversation.find('.dropdown').dropdown();` in `repo-diff.js`
2. Since it's totally transparent now, it could be easier to modify or
remove in the future.
3. It handles all selection labels as well (by onLabelCreate), so it
supports "multiple selection dropdown" now.
* It partially completes one of my TODOs: `TODO: multiple selection is
not supported yet.`
4. The code structure is clearer, code blocks are splitted into
different functions.
* The old `attachOneDropdownAria` was splitted into separate functions.
* It makes it easier to add more fine tunes in the future, and co-work
with contributors.
6. The code logic is similar as before, only two new parts:
1. the `ariaCheckboxFn` and `ariaDropdownFn` functions
2. the `onLabelCreate` and `updateSelectionLabel` functions
In `aria-dropdown.js` I had to mix jQuery and Vanilla JS somewhat, I
think the code is still understandable, otherwise the code would be much
more complex to read.
Thanks to fsologureng for the idea about "improving the 'delete icon'
with aria attributes".
If there is anything unclear or incorrect, feel free to ask and discuss,
or propose new PRs for it.
Diffstat (limited to 'web_src/js/index.js')
| -rw-r--r-- | web_src/js/index.js | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/web_src/js/index.js b/web_src/js/index.js index 480661118b..7d74ee6b94 100644 --- a/web_src/js/index.js +++ b/web_src/js/index.js @@ -89,6 +89,8 @@ import {initFormattingReplacements} from './features/formatting.js'; import {initCopyContent} from './features/copycontent.js'; import {initCaptcha} from './features/captcha.js'; import {initRepositoryActionView} from './components/RepoActionView.vue'; +import {initAriaCheckboxPatch} from './modules/aria/checkbox.js'; +import {initAriaDropdownPatch} from './modules/aria/dropdown.js'; // Run time-critical code as soon as possible. This is safe to do because this // script appears at the end of <body> and rendered HTML is accessible at that point. @@ -98,6 +100,9 @@ initFormattingReplacements(); $.fn.tab.settings.silent = true; // Disable the behavior of fomantic to toggle the checkbox when you press enter on a checkbox element. $.fn.checkbox.settings.enableEnterKey = false; +// Use the patches to improve accessibility, these patches are designed to be as independent as possible, make it easy to modify or remove in the future. +initAriaCheckboxPatch(); +initAriaDropdownPatch(); $(document).ready(() => { initGlobalCommon(); |