aboutsummaryrefslogtreecommitdiffstats
path: root/web_src/js/modules/fomantic.js
diff options
context:
space:
mode:
authorsilverwind <me@silverwind.io>2024-04-18 11:01:06 +0200
committerGitHub <noreply@github.com>2024-04-18 09:01:06 +0000
commitd4ec6b3d16496ce3b479d5a08f79823122dc2b7b (patch)
treeea9fd4541f9c529b0e65514fd133ba05214fca47 /web_src/js/modules/fomantic.js
parent31538133c32009532897989ad623067bd224f924 (diff)
downloadgitea-d4ec6b3d16496ce3b479d5a08f79823122dc2b7b.tar.gz
gitea-d4ec6b3d16496ce3b479d5a08f79823122dc2b7b.zip
Add form field id generation, remove duplicated ids (#30546)
Fixes: https://github.com/go-gitea/gitea/issues/30384 On repo settings page, there id `repo_name` was used 5 times on the same page, some in modal and such. I think we are better off just auto-generating these IDs in the future so that labels link up with their form element. Ideally this id generation would be done in backend in a subtemplate, but seeing that we already have similar JS patches for checkboxes, I took the easy path for now. I also checked that these `#repo_name` were not in use in JS and the only case where this id appears in JS is on the migration page where it's still there. --------- Co-authored-by: Giteabot <teabot@gitea.io>
Diffstat (limited to 'web_src/js/modules/fomantic.js')
-rw-r--r--web_src/js/modules/fomantic.js2
1 files changed, 2 insertions, 0 deletions
diff --git a/web_src/js/modules/fomantic.js b/web_src/js/modules/fomantic.js
index d205c2b2ee..c04bc6e863 100644
--- a/web_src/js/modules/fomantic.js
+++ b/web_src/js/modules/fomantic.js
@@ -1,6 +1,7 @@
import $ from 'jquery';
import {initFomanticApiPatch} from './fomantic/api.js';
import {initAriaCheckboxPatch} from './fomantic/checkbox.js';
+import {initAriaFormFieldPatch} from './fomantic/form.js';
import {initAriaDropdownPatch} from './fomantic/dropdown.js';
import {initAriaModalPatch} from './fomantic/modal.js';
import {initFomanticTransition} from './fomantic/transition.js';
@@ -27,6 +28,7 @@ export function initGiteaFomantic() {
// Use the patches to improve accessibility, these patches are designed to be as independent as possible, make it easy to modify or remove in the future.
initAriaCheckboxPatch();
+ initAriaFormFieldPatch();
initAriaDropdownPatch();
initAriaModalPatch();
}