aboutsummaryrefslogtreecommitdiffstats
path: root/web_src/js/modules/toast.js
diff options
context:
space:
mode:
authorHesterG <hestergong@gmail.com>2023-07-21 19:20:04 +0800
committerGitHub <noreply@github.com>2023-07-21 11:20:04 +0000
commit2f0e79e6393df13930eaa419273d24dc2ef36cfa (patch)
tree878d19f8055f7f5c5ce114620c05d18cbfb6c79a /web_src/js/modules/toast.js
parentdbbae67f44364eb965f516bfc77ba25dd5242c16 (diff)
downloadgitea-2f0e79e6393df13930eaa419273d24dc2ef36cfa.tar.gz
gitea-2f0e79e6393df13930eaa419273d24dc2ef36cfa.zip
Use frontend fetch for branch dropdown component (#25719)
- Send request to get branch/tag list, use loading icon when waiting for response. - Only fetch when the first time branch/tag list shows. - For backend, removed assignment to `ctx.Data["Branches"]` and `ctx.Data["Tags"]` from `context/repo.go` and passed these data wherever needed. - Changed some `v-if` to `v-show` and used native `svg` as mentioned in https://github.com/go-gitea/gitea/pull/25719#issuecomment-1631712757 to improve perfomance when there are a lot of branches. - Places Used the dropdown component: Repo Home Page <img width="1429" alt="Screen Shot 2023-07-06 at 12 17 51" src="https://github.com/go-gitea/gitea/assets/17645053/6accc7b6-8d37-4e88-ae1a-bd2b3b927ea0"> Commits Page <img width="1431" alt="Screen Shot 2023-07-06 at 12 18 34" src="https://github.com/go-gitea/gitea/assets/17645053/2d0bf306-d1e2-45a8-a784-bc424879f537"> Specific commit -> operations -> cherry-pick <img width="758" alt="Screen Shot 2023-07-06 at 12 23 28" src="https://github.com/go-gitea/gitea/assets/17645053/1e557948-3881-4e45-a625-8ef36d45ae2d"> Release Page <img width="1433" alt="Screen Shot 2023-07-06 at 12 25 05" src="https://github.com/go-gitea/gitea/assets/17645053/3ec82af1-15a4-4162-a50b-04a9502161bb"> - Demo https://github.com/go-gitea/gitea/assets/17645053/d45d266b-3eb0-465a-82f9-57f78dc5f9f3 - Note: UI of dropdown menu could be improved in another PR as it should apply to more dropdown menus. Fix #14180 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Diffstat (limited to 'web_src/js/modules/toast.js')
-rw-r--r--web_src/js/modules/toast.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/web_src/js/modules/toast.js b/web_src/js/modules/toast.js
index b0d02dc644..b5899052d4 100644
--- a/web_src/js/modules/toast.js
+++ b/web_src/js/modules/toast.js
@@ -1,5 +1,6 @@
import {htmlEscape} from 'escape-goat';
import {svg} from '../svg.js';
+import Toastify from 'toastify-js';
const levels = {
info: {
@@ -23,7 +24,6 @@ const levels = {
async function showToast(message, level, {gravity, position, duration, ...other} = {}) {
if (!message) return;
- const {default: Toastify} = await import(/* webpackChunkName: 'toastify' */'toastify-js');
const {icon, background, duration: levelDuration} = levels[level ?? 'info'];
const toast = Toastify({