diff options
| author | silverwind <me@silverwind.io> | 2024-06-10 22:49:33 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-10 22:49:33 +0200 |
| commit | 507fbf4c3ceffba9143edbe421a134b904210a4c (patch) | |
| tree | 9ff231551355bed43efdab5d27d7723b151c16b2 /web_src/js/standalone | |
| parent | a2304cb163ce5e097078e71f49d4d5cb4c8b20d9 (diff) | |
| download | gitea-507fbf4c3ceffba9143edbe421a134b904210a4c.tar.gz gitea-507fbf4c3ceffba9143edbe421a134b904210a4c.zip | |
Use `querySelector` over alternative DOM methods (#31280)
As per
https://github.com/go-gitea/gitea/pull/30115#discussion_r1626060164,
prefer `querySelector` by enabling
[`unicorn/prefer-query-selector`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-query-selector.md)
and autofixing all except 10 issues.
According to
[this](https://old.reddit.com/r/learnjavascript/comments/i0f5o8/performance_of_getelementbyid_vs_queryselector/),
querySelector may be faster as well, so it's a win-win.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
Diffstat (limited to 'web_src/js/standalone')
| -rw-r--r-- | web_src/js/standalone/devtest.js | 6 | ||||
| -rw-r--r-- | web_src/js/standalone/swagger.js | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/web_src/js/standalone/devtest.js b/web_src/js/standalone/devtest.js index d0ca511c0f..8dbba554ac 100644 --- a/web_src/js/standalone/devtest.js +++ b/web_src/js/standalone/devtest.js @@ -1,11 +1,11 @@ import {showInfoToast, showWarningToast, showErrorToast} from '../modules/toast.js'; -document.getElementById('info-toast').addEventListener('click', () => { +document.querySelector('#info-toast').addEventListener('click', () => { showInfoToast('success 😀'); }); -document.getElementById('warning-toast').addEventListener('click', () => { +document.querySelector('#warning-toast').addEventListener('click', () => { showWarningToast('warning 😐'); }); -document.getElementById('error-toast').addEventListener('click', () => { +document.querySelector('#error-toast').addEventListener('click', () => { showErrorToast('error 🙁'); }); diff --git a/web_src/js/standalone/swagger.js b/web_src/js/standalone/swagger.js index 00854ef5d7..2928813167 100644 --- a/web_src/js/standalone/swagger.js +++ b/web_src/js/standalone/swagger.js @@ -2,7 +2,7 @@ import SwaggerUI from 'swagger-ui-dist/swagger-ui-es-bundle.js'; import 'swagger-ui-dist/swagger-ui.css'; window.addEventListener('load', async () => { - const url = document.getElementById('swagger-ui').getAttribute('data-source'); + const url = document.querySelector('#swagger-ui').getAttribute('data-source'); const res = await fetch(url); const spec = await res.json(); |