diff options
| author | Hester Gong <hestergong@gmail.com> | 2023-05-10 19:19:03 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-10 11:19:03 +0000 |
| commit | ea7954f069bf8bcb87d520f8aab0a80b0768590d (patch) | |
| tree | f5edc566c9dbafa3507ed8ef3ffaa32944f80797 /web_src/js/utils.js | |
| parent | 0ca5adee16a9de0fb0bd410aa841eeeda3372e23 (diff) | |
| download | gitea-ea7954f069bf8bcb87d520f8aab0a80b0768590d.tar.gz gitea-ea7954f069bf8bcb87d520f8aab0a80b0768590d.zip | |
Modify luminance calculation and extract related functions into single files (#24586)
Close #24508
Main changes:
As discussed in the issue
1. Change luminance calculation function to use [Relative
Luminance](https://www.w3.org/WAI/GL/wiki/Relative_luminance)
2. Move the luminance related functions into color.go/color.js
3. Add tests for both the files (Not sure if test cases are too many
now)
Before (tests included by `UseLightTextOnBackground` are labels started
with `##`):
https://try.gitea.io/HesterG/testrepo/labels
After:
<img width="1307" alt="Screen Shot 2023-05-08 at 13 37 55"
src="https://user-images.githubusercontent.com/17645053/236742562-fdfc3a4d-2fab-466b-9613-96f2bf96b4bc.png">
<img width="1289" alt="Screen Shot 2023-05-08 at 13 38 06"
src="https://user-images.githubusercontent.com/17645053/236742570-022db68e-cec0-43bb-888a-fc54f5332cc3.png">
<img width="1299" alt="Screen Shot 2023-05-08 at 13 38 20"
src="https://user-images.githubusercontent.com/17645053/236742572-9af1de45-fb7f-460b-828d-ba25fae20f51.png">
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
Diffstat (limited to 'web_src/js/utils.js')
| -rw-r--r-- | web_src/js/utils.js | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/web_src/js/utils.js b/web_src/js/utils.js index 25094deea2..2a2d6df0b4 100644 --- a/web_src/js/utils.js +++ b/web_src/js/utils.js @@ -135,17 +135,3 @@ export function toAbsoluteUrl(url) { return `${window.location.origin}${url}`; } -// determine if light or dark text color should be used on a given background color -// NOTE: see models/issue_label.go for similar implementation -export function useLightTextOnBackground(backgroundColor) { - if (backgroundColor[0] === '#') { - backgroundColor = backgroundColor.substring(1); - } - // Perceived brightness from: https://www.w3.org/TR/AERT/#color-contrast - // In the future WCAG 3 APCA may be a better solution. - const r = parseInt(backgroundColor.substring(0, 2), 16); - const g = parseInt(backgroundColor.substring(2, 4), 16); - const b = parseInt(backgroundColor.substring(4, 6), 16); - const brightness = (0.299 * r + 0.587 * g + 0.114 * b) / 255; - return brightness < 0.35; -} |