diff options
author | Lunny Xiao <xiaolunwen@gmail.com> | 2022-04-08 02:59:56 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-04-07 20:59:56 +0200 |
commit | 783a02188970ba5800514f7c64f6a818f65c04a1 (patch) | |
tree | 8c7dc3bbe00abbc245203f94c437f157168cc54a /web_src | |
parent | bb7e0619c3356227d6c5826cb789841f6bc4a05a (diff) | |
download | gitea-783a02188970ba5800514f7c64f6a818f65c04a1.tar.gz gitea-783a02188970ba5800514f7c64f6a818f65c04a1.zip |
Never use /api/v1 from Gitea UI Pages (#19318)
Reusing `/api/v1` from Gitea UI Pages have pros and cons.
Pros:
1) Less code copy
Cons:
1) API/v1 have to support shared session with page requests.
2) You need to consider for each other when you want to change something about api/v1 or page.
This PR moves all dependencies to API/v1 from UI Pages.
Partially replace #16052
Diffstat (limited to 'web_src')
-rw-r--r-- | web_src/js/components/ContextPopup.vue | 2 | ||||
-rw-r--r-- | web_src/js/components/DashboardRepoList.js | 4 | ||||
-rw-r--r-- | web_src/js/features/comp/SearchUserBox.js | 2 | ||||
-rw-r--r-- | web_src/js/features/notification.js | 2 | ||||
-rw-r--r-- | web_src/js/features/org-team.js | 2 | ||||
-rw-r--r-- | web_src/js/features/repo-home.js | 2 | ||||
-rw-r--r-- | web_src/js/features/repo-issue.js | 8 | ||||
-rw-r--r-- | web_src/js/features/repo-settings.js | 2 | ||||
-rw-r--r-- | web_src/js/features/repo-template.js | 2 | ||||
-rw-r--r-- | web_src/js/features/stopwatch.js | 2 |
10 files changed, 14 insertions, 14 deletions
diff --git a/web_src/js/components/ContextPopup.vue b/web_src/js/components/ContextPopup.vue index 0ff141476a..c176a18659 100644 --- a/web_src/js/components/ContextPopup.vue +++ b/web_src/js/components/ContextPopup.vue @@ -120,7 +120,7 @@ export default { load(data, callback) { this.loading = true; this.i18nErrorMessage = null; - $.get(`${appSubUrl}/api/v1/repos/${data.owner}/${data.repo}/issues/${data.index}`).done((issue) => { + $.get(`${appSubUrl}/${data.owner}/${data.repo}/issues/${data.index}/info`).done((issue) => { this.issue = issue; }).fail((jqXHR) => { if (jqXHR.responseJSON && jqXHR.responseJSON.message) { diff --git a/web_src/js/components/DashboardRepoList.js b/web_src/js/components/DashboardRepoList.js index 8d8f186cc6..e4847ec2f0 100644 --- a/web_src/js/components/DashboardRepoList.js +++ b/web_src/js/components/DashboardRepoList.js @@ -124,7 +124,7 @@ function initVueComponents() { return this.repos.length > 0 && this.repos.length < this.counts[`${this.reposFilter}:${this.archivedFilter}:${this.privateFilter}`]; }, searchURL() { - return `${this.subUrl}/api/v1/repos/search?sort=updated&order=desc&uid=${this.uid}&team_id=${this.teamId}&q=${this.searchQuery + return `${this.subUrl}/repo/search?sort=updated&order=desc&uid=${this.uid}&team_id=${this.teamId}&q=${this.searchQuery }&page=${this.page}&limit=${this.searchLimit}&mode=${this.repoTypes[this.reposFilter].searchMode }${this.reposFilter !== 'all' ? '&exclusive=1' : '' }${this.archivedFilter === 'archived' ? '&archived=true' : ''}${this.archivedFilter === 'unarchived' ? '&archived=false' : '' @@ -302,7 +302,7 @@ function initVueComponents() { this.isLoading = true; if (!this.reposTotalCount) { - const totalCountSearchURL = `${this.subUrl}/api/v1/repos/search?sort=updated&order=desc&uid=${this.uid}&team_id=${this.teamId}&q=&page=1&mode=`; + const totalCountSearchURL = `${this.subUrl}/repo/search?sort=updated&order=desc&uid=${this.uid}&team_id=${this.teamId}&q=&page=1&mode=`; $.getJSON(totalCountSearchURL, (_result, _textStatus, request) => { this.reposTotalCount = request.getResponseHeader('X-Total-Count'); }); diff --git a/web_src/js/features/comp/SearchUserBox.js b/web_src/js/features/comp/SearchUserBox.js index 18b67919b5..08f97595af 100644 --- a/web_src/js/features/comp/SearchUserBox.js +++ b/web_src/js/features/comp/SearchUserBox.js @@ -8,7 +8,7 @@ export function initCompSearchUserBox() { $searchUserBox.search({ minCharacters: 2, apiSettings: { - url: `${appSubUrl}/api/v1/users/search?q={query}`, + url: `${appSubUrl}/user/search?q={query}`, onResponse(response) { const items = []; const searchQueryUppercase = $searchUserBox.find('input').val().toUpperCase(); diff --git a/web_src/js/features/notification.js b/web_src/js/features/notification.js index 68b23ef162..36df196cac 100644 --- a/web_src/js/features/notification.js +++ b/web_src/js/features/notification.js @@ -158,7 +158,7 @@ async function updateNotificationTable() { async function updateNotificationCount() { const data = await $.ajax({ type: 'GET', - url: `${appSubUrl}/api/v1/notifications/new`, + url: `${appSubUrl}/notifications/new`, headers: { 'X-Csrf-Token': csrfToken, }, diff --git a/web_src/js/features/org-team.js b/web_src/js/features/org-team.js index 1a045022d2..9e6c3c7ff1 100644 --- a/web_src/js/features/org-team.js +++ b/web_src/js/features/org-team.js @@ -20,7 +20,7 @@ export function initOrgTeamSearchRepoBox() { $searchRepoBox.search({ minCharacters: 2, apiSettings: { - url: `${appSubUrl}/api/v1/repos/search?q={query}&uid=${$searchRepoBox.data('uid')}`, + url: `${appSubUrl}/repo/search?q={query}&uid=${$searchRepoBox.data('uid')}`, onResponse(response) { const items = []; $.each(response.data, (_i, item) => { diff --git a/web_src/js/features/repo-home.js b/web_src/js/features/repo-home.js index c718bd75d8..2a66dbc6f1 100644 --- a/web_src/js/features/repo-home.js +++ b/web_src/js/features/repo-home.js @@ -91,7 +91,7 @@ export function initRepoTopicBar() { label: 'ui small label' }, apiSettings: { - url: `${appSubUrl}/api/v1/topics/search?q={query}`, + url: `${appSubUrl}/explore/topics/search?q={query}`, throttle: 500, cache: false, onResponse(res) { diff --git a/web_src/js/features/repo-issue.js b/web_src/js/features/repo-issue.js index 43ce8a9f1b..14b1976bbb 100644 --- a/web_src/js/features/repo-issue.js +++ b/web_src/js/features/repo-issue.js @@ -54,7 +54,7 @@ function updateDeadline(deadlineString) { realDeadline = new Date(newDate); } - $.ajax(`${$('#update-issue-deadline-form').attr('action')}/deadline`, { + $.ajax(`${$('#update-issue-deadline-form').attr('action')}`, { data: JSON.stringify({ due_date: realDeadline, }), @@ -91,9 +91,9 @@ export function initRepoIssueList() { const repoId = $('#repoId').val(); const crossRepoSearch = $('#crossRepoSearch').val(); const tp = $('#type').val(); - let issueSearchUrl = `${appSubUrl}/api/v1/repos/${repolink}/issues?q={query}&type=${tp}`; + let issueSearchUrl = `${appSubUrl}/${repolink}/issues/search?q={query}&type=${tp}`; if (crossRepoSearch === 'true') { - issueSearchUrl = `${appSubUrl}/api/v1/repos/issues/search?q={query}&priority_repo_id=${repoId}&type=${tp}`; + issueSearchUrl = `${appSubUrl}/issues/search?q={query}&priority_repo_id=${repoId}&type=${tp}`; } $('#new-dependency-drop-list') .dropdown({ @@ -292,7 +292,7 @@ export function initRepoIssueReferenceRepositorySearch() { $('.issue_reference_repository_search') .dropdown({ apiSettings: { - url: `${appSubUrl}/api/v1/repos/search?q={query}&limit=20`, + url: `${appSubUrl}/repo/search?q={query}&limit=20`, onResponse(response) { const filteredResponse = {success: true, results: []}; $.each(response.data, (_r, repo) => { diff --git a/web_src/js/features/repo-settings.js b/web_src/js/features/repo-settings.js index dcb0788350..2c3694d458 100644 --- a/web_src/js/features/repo-settings.js +++ b/web_src/js/features/repo-settings.js @@ -21,7 +21,7 @@ export function initRepoSettingSearchTeamBox() { $searchTeamBox.search({ minCharacters: 2, apiSettings: { - url: `${appSubUrl}/api/v1/orgs/${$searchTeamBox.data('org')}/teams/search?q={query}`, + url: `${appSubUrl}/org/${$searchTeamBox.data('org')}/teams/-/search?q={query}`, headers: {'X-Csrf-Token': csrfToken}, onResponse(response) { const items = []; diff --git a/web_src/js/features/repo-template.js b/web_src/js/features/repo-template.js index e387678909..dc4ae1e268 100644 --- a/web_src/js/features/repo-template.js +++ b/web_src/js/features/repo-template.js @@ -23,7 +23,7 @@ export function initRepoTemplateSearch() { $('#repo_template_search') .dropdown({ apiSettings: { - url: `${appSubUrl}/api/v1/repos/search?q={query}&template=true&priority_owner_id=${$('#uid').val()}`, + url: `${appSubUrl}/repo/search?q={query}&template=true&priority_owner_id=${$('#uid').val()}`, onResponse(response) { const filteredResponse = {success: true, results: []}; filteredResponse.results.push({ diff --git a/web_src/js/features/stopwatch.js b/web_src/js/features/stopwatch.js index 1748c5119c..f86a801038 100644 --- a/web_src/js/features/stopwatch.js +++ b/web_src/js/features/stopwatch.js @@ -111,7 +111,7 @@ async function updateStopwatchWithCallback(callback, timeout) { async function updateStopwatch() { const data = await $.ajax({ type: 'GET', - url: `${appSubUrl}/api/v1/user/stopwatches`, + url: `${appSubUrl}/user/stopwatches`, headers: {'X-Csrf-Token': csrfToken}, }); |