aboutsummaryrefslogtreecommitdiffstats
path: root/web_src
diff options
context:
space:
mode:
authorqwerty287 <80460567+qwerty287@users.noreply.github.com>2022-04-28 17:45:33 +0200
committerGitHub <noreply@github.com>2022-04-28 17:45:33 +0200
commit8eb1cd9264af9493e0f57a4a4c0a1f764f7cefcf (patch)
tree46049742d086daa7683db502883a58e94370a583 /web_src
parent92dfbada3793fc2be23d38783d6842eac9825f58 (diff)
downloadgitea-8eb1cd9264af9493e0f57a4a4c0a1f764f7cefcf.tar.gz
gitea-8eb1cd9264af9493e0f57a4a4c0a1f764f7cefcf.zip
Add "Allow edits from maintainer" feature (#18002)
Adds a feature [like GitHub has](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork) (step 7). If you create a new PR from a forked repo, you can select (and change later, but only if you are the PR creator/poster) the "Allow edits from maintainers" option. Then users with write access to the base branch get more permissions on this branch: * use the update pull request button * push directly from the command line (`git push`) * edit/delete/upload files via web UI * use related API endpoints You can't merge PRs to this branch with this enabled, you'll need "full" code write permissions. This feature has a pretty big impact on the permission system. I might forgot changing some things or didn't find security vulnerabilities. In this case, please leave a review or comment on this PR. Closes #17728 Co-authored-by: 6543 <6543@obermui.de>
Diffstat (limited to 'web_src')
-rw-r--r--web_src/js/features/repo-issue.js33
-rw-r--r--web_src/js/index.js2
2 files changed, 35 insertions, 0 deletions
diff --git a/web_src/js/features/repo-issue.js b/web_src/js/features/repo-issue.js
index 14b1976bbb..a39a704f47 100644
--- a/web_src/js/features/repo-issue.js
+++ b/web_src/js/features/repo-issue.js
@@ -288,6 +288,39 @@ export function initRepoPullRequestMergeInstruction() {
});
}
+export function initRepoPullRequestAllowMaintainerEdit() {
+ const $checkbox = $('#allow-edits-from-maintainers');
+ if (!$checkbox.length) return;
+
+ const promptTip = $checkbox.attr('data-prompt-tip');
+ const promptError = $checkbox.attr('data-prompt-error');
+ $checkbox.popup({content: promptTip});
+ $checkbox.checkbox({
+ 'onChange': () => {
+ const checked = $checkbox.checkbox('is checked');
+ let url = $checkbox.attr('data-url');
+ url += '/set_allow_maintainer_edit';
+ $checkbox.checkbox('set disabled');
+ $.ajax({url, type: 'POST',
+ data: {_csrf: csrfToken, allow_maintainer_edit: checked},
+ error: () => {
+ $checkbox.popup({
+ content: promptError,
+ onHidden: () => {
+ // the error popup should be shown only once, then we restore the popup to the default message
+ $checkbox.popup({content: promptTip});
+ },
+ });
+ $checkbox.popup('show');
+ },
+ complete: () => {
+ $checkbox.checkbox('set enabled');
+ },
+ });
+ },
+ });
+}
+
export function initRepoIssueReferenceRepositorySearch() {
$('.issue_reference_repository_search')
.dropdown({
diff --git a/web_src/js/index.js b/web_src/js/index.js
index f5d72aff93..5b95a0d8ef 100644
--- a/web_src/js/index.js
+++ b/web_src/js/index.js
@@ -36,6 +36,7 @@ import {
initRepoIssueTimeTracking,
initRepoIssueWipTitle,
initRepoPullRequestMergeInstruction,
+ initRepoPullRequestAllowMaintainerEdit,
initRepoPullRequestReview,
} from './features/repo-issue.js';
import {
@@ -158,6 +159,7 @@ $(document).ready(() => {
initRepoMigrationStatusChecker();
initRepoProject();
initRepoPullRequestMergeInstruction();
+ initRepoPullRequestAllowMaintainerEdit();
initRepoPullRequestReview();
initRepoRelease();
initRepoReleaseEditor();