diff options
author | wxiaoguang <wxiaoguang@gmail.com> | 2021-10-22 02:19:32 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-10-21 19:19:32 +0100 |
commit | a115309f4f2e3389d8d86aff8e827b59ebc090fa (patch) | |
tree | b6f91553a5eb371402bd2d7029c0c8e238378623 /web_src | |
parent | 960c322586eceb9598bb0a9985a8dd987dc74807 (diff) | |
download | gitea-a115309f4f2e3389d8d86aff8e827b59ebc090fa.tar.gz gitea-a115309f4f2e3389d8d86aff8e827b59ebc090fa.zip |
Fix the click behavior for <tr> and <td> with [data-href] (#17388)
Diffstat (limited to 'web_src')
-rw-r--r-- | web_src/js/features/common-global.js | 21 |
1 files changed, 13 insertions, 8 deletions
diff --git a/web_src/js/features/common-global.js b/web_src/js/features/common-global.js index bf4e97769d..b345afd4cf 100644 --- a/web_src/js/features/common-global.js +++ b/web_src/js/features/common-global.js @@ -119,14 +119,19 @@ export function initGlobalCommon() { $($(this).data('target')).slideToggle(100); }); - // make table <tr> element clickable like a link - $('tr[data-href]').on('click', function () { - window.location = $(this).data('href'); - }); - - // make table <td> element clickable like a link - $('td[data-href]').click(function () { - window.location = $(this).data('href'); + // make table <tr> and <td> elements clickable like a link + $('tr[data-href], td[data-href]').on('click', function (e) { + const href = $(this).data('href'); + if (e.target.nodeName === 'A') { + // if a user clicks on <a>, then the <tr> or <td> should not act as a link. + return; + } + if (e.ctrlKey || e.metaKey) { + // ctrl+click or meta+click opens a new window in modern browsers + window.open(href); + } else { + window.location = href; + } }); } |