aboutsummaryrefslogtreecommitdiffstats
path: root/web_src
diff options
context:
space:
mode:
authorzeripath <art27@cantab.net>2022-11-25 20:58:20 +0000
committerGitHub <noreply@github.com>2022-11-25 20:58:20 +0000
commitd7f12af805e33e327ec0c7a250ad8ed09a88e8fd (patch)
treebb78847a996b9a0381332536fab00da9280182aa /web_src
parentabecf632d2886149474471a0e41e14dc3e15340e (diff)
downloadgitea-d7f12af805e33e327ec0c7a250ad8ed09a88e8fd.tar.gz
gitea-d7f12af805e33e327ec0c7a250ad8ed09a88e8fd.zip
Prevent NPE if trying to restore an already restored deleted branch (#21940)
If a deleted-branch has already been restored, a request to restore it again will cause a NPE. This PR adds detection for this case, but also disables buttons when they're clicked in order to help prevent accidental repeat requests. Fix #21930 Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'web_src')
-rw-r--r--web_src/js/features/common-global.js6
1 files changed, 6 insertions, 0 deletions
diff --git a/web_src/js/features/common-global.js b/web_src/js/features/common-global.js
index b00b4aea9c..7efefd7084 100644
--- a/web_src/js/features/common-global.js
+++ b/web_src/js/features/common-global.js
@@ -260,6 +260,7 @@ export function initGlobalLinkActions() {
e.preventDefault();
const $this = $(this);
const redirect = $this.data('redirect');
+ $this.prop('disabled', true);
$.post($this.data('url'), {
_csrf: csrfToken
}).done((data) => {
@@ -270,6 +271,8 @@ export function initGlobalLinkActions() {
} else {
window.location.reload();
}
+ }).always(() => {
+ $this.prop('disabled', false);
});
}
@@ -283,11 +286,14 @@ export function initGlobalLinkActions() {
// FIXME: this is only used once, and should be replace with `link-action` instead
$('.undo-button').on('click', function () {
const $this = $(this);
+ $this.prop('disabled', true);
$.post($this.data('url'), {
_csrf: csrfToken,
id: $this.data('id')
}).done((data) => {
window.location.href = data.redirect;
+ }).always(() => {
+ $this.prop('disabled', false);
});
});
}