diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-02-14 21:04:22 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-14 21:04:22 +0800 |
| commit | e314c9e86656333e9ec956f0d825ef920f491de6 (patch) | |
| tree | 7244bba51094dcf139b7f35988506b6c3e2e6200 /web_src | |
| parent | d306ab2b8f871fbf505519468bfbaed91deaf7e0 (diff) | |
| download | gitea-e314c9e86656333e9ec956f0d825ef920f491de6.tar.gz gitea-e314c9e86656333e9ec956f0d825ef920f491de6.zip | |
Fix the full-height problem for all pages (#22905)
Really fix #22883, close #22901
I made a mistake that the global styles in RepoActionView.vue could
still pollute global styles (I forgot that the code of this component is
still loaded on every page, instead of loaded on demand)
This PR makes a complete fix: only change the page's full-height
behavior if the component is used.
Screenshot after the fix:
<details>
</details>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'web_src')
| -rw-r--r-- | web_src/js/components/RepoActionView.vue | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/web_src/js/components/RepoActionView.vue b/web_src/js/components/RepoActionView.vue index deb071da5a..e0ec488933 100644 --- a/web_src/js/components/RepoActionView.vue +++ b/web_src/js/components/RepoActionView.vue @@ -268,6 +268,11 @@ export function initRepositoryActionView() { const el = document.getElementById('repo-action-view'); if (!el) return; + // TODO: the parent element's full height doesn't work well now, + // but we can not pollute the global style at the moment, only fix the height problem for pages with this component + const parentFullHeight = document.querySelector('body > div.full.height'); + if (parentFullHeight) parentFullHeight.style.paddingBottom = '0'; + const view = createApp(sfc, { runIndex: el.getAttribute('data-run-index'), jobIndex: el.getAttribute('data-job-index'), @@ -412,11 +417,6 @@ export function initRepositoryActionView() { <style lang="less"> // some elements are not managed by vue, so we need to use global style -// TODO: the parent element's full height doesn't work well now -body > div.full.height { - padding-bottom: 0; -} - .job-status-rotate { animation: job-status-rotate-keyframes 1s linear infinite; } |