diff options
| -rw-r--r-- | models/issue.go | 30 | ||||
| -rw-r--r-- | models/models.go | 6 |
2 files changed, 36 insertions, 0 deletions
diff --git a/models/issue.go b/models/issue.go index 52d22f1509..4c33767d2a 100644 --- a/models/issue.go +++ b/models/issue.go @@ -1352,6 +1352,36 @@ type IssueStatsOptions struct { // GetIssueStats returns issue statistic information by given conditions. func GetIssueStats(opts *IssueStatsOptions) (*IssueStats, error) { + if len(opts.IssueIDs) <= maxQueryParameters { + return getIssueStatsChunk(opts, opts.IssueIDs) + } + + // If too long a list of IDs is provided, we get the statistics in + // smaller chunks and get accumulates. Note: this could potentially + // get us invalid results. The alternative is to insert the list of + // ids in a temporary table and join from them. + accum := &IssueStats{} + for i := 0; i < len(opts.IssueIDs); { + chunk := i + maxQueryParameters + if chunk > len(opts.IssueIDs) { + chunk = len(opts.IssueIDs) + } + stats, err := getIssueStatsChunk(opts, opts.IssueIDs[i:chunk]) + if err != nil { + return nil, err + } + accum.OpenCount += stats.OpenCount + accum.ClosedCount += stats.ClosedCount + accum.YourRepositoriesCount += stats.YourRepositoriesCount + accum.AssignCount += stats.AssignCount + accum.CreateCount += stats.CreateCount + accum.OpenCount += stats.MentionCount + i = chunk + } + return accum, nil +} + +func getIssueStatsChunk(opts *IssueStatsOptions, issueIDs []int64) (*IssueStats, error) { stats := &IssueStats{} countSession := func(opts *IssueStatsOptions) *xorm.Session { diff --git a/models/models.go b/models/models.go index b84a179e37..088445590f 100644 --- a/models/models.go +++ b/models/models.go @@ -48,6 +48,12 @@ type Engine interface { SumInt(bean interface{}, columnName string) (res int64, err error) } +const ( + // When queries are broken down in parts because of the number + // of parameters, attempt to break by this amount + maxQueryParameters = 300 +) + var ( x *xorm.Engine tables []interface{} |