diff options
Diffstat (limited to 'modules/repofiles')
-rw-r--r-- | modules/repofiles/temp_repo.go | 35 | ||||
-rw-r--r-- | modules/repofiles/update.go | 1 |
2 files changed, 14 insertions, 22 deletions
diff --git a/modules/repofiles/temp_repo.go b/modules/repofiles/temp_repo.go index d8b816dfa1..89f9b0b208 100644 --- a/modules/repofiles/temp_repo.go +++ b/modules/repofiles/temp_repo.go @@ -242,30 +242,21 @@ func (t *TemporaryUploadRepository) CommitTreeWithDate(author, committer *models func (t *TemporaryUploadRepository) Push(doer *models.User, commitHash string, branch string) error { // Because calls hooks we need to pass in the environment env := models.PushingEnvironment(doer, t.repo) - stdout := &strings.Builder{} - stderr := &strings.Builder{} - - if err := git.NewCommand("push", t.repo.RepoPath(), strings.TrimSpace(commitHash)+":refs/heads/"+strings.TrimSpace(branch)).RunInDirTimeoutEnvPipeline(env, -1, t.basePath, stdout, stderr); err != nil { - errString := stderr.String() - if strings.Contains(errString, "non-fast-forward") { - return models.ErrMergePushOutOfDate{ - StdOut: stdout.String(), - StdErr: errString, - Err: err, - } - } else if strings.Contains(errString, "! [remote rejected]") { - log.Error("Unable to push back to repo from temporary repo due to rejection: %s (%s)\nStdout: %s\nStderr: %s\nError: %v", - t.repo.FullName(), t.basePath, stdout, errString, err) - err := models.ErrPushRejected{ - StdOut: stdout.String(), - StdErr: errString, - Err: err, - } - err.GenerateMessage() + if err := git.Push(t.basePath, git.PushOptions{ + Remote: t.repo.RepoPath(), + Branch: strings.TrimSpace(commitHash) + ":refs/heads/" + strings.TrimSpace(branch), + Env: env, + }); err != nil { + if git.IsErrPushOutOfDate(err) { + return err + } else if git.IsErrPushRejected(err) { + rejectErr := err.(*git.ErrPushRejected) + log.Info("Unable to push back to repo from temporary repo due to rejection: %s (%s)\nStdout: %s\nStderr: %s\nError: %v", + t.repo.FullName(), t.basePath, rejectErr.StdOut, rejectErr.StdErr, rejectErr.Err) return err } - log.Error("Unable to push back to repo from temporary repo: %s (%s)\nStdout: %s\nError: %v", - t.repo.FullName(), t.basePath, stdout, err) + log.Error("Unable to push back to repo from temporary repo: %s (%s)\nError: %v", + t.repo.FullName(), t.basePath, err) return fmt.Errorf("Unable to push back to repo from temporary repo: %s (%s) Error: %v", t.repo.FullName(), t.basePath, err) } diff --git a/modules/repofiles/update.go b/modules/repofiles/update.go index 86f53d4a1c..d65f61c840 100644 --- a/modules/repofiles/update.go +++ b/modules/repofiles/update.go @@ -446,6 +446,7 @@ func CreateOrUpdateRepoFile(repo *models.Repository, doer *models.User, opts *Up // Then push this tree to NewBranch if err := t.Push(doer, commitHash, opts.NewBranch); err != nil { + log.Error("%T %v", err, err) return nil, err } |