summaryrefslogtreecommitdiffstats
path: root/routers/repo
diff options
context:
space:
mode:
Diffstat (limited to 'routers/repo')
-rw-r--r--routers/repo/activity.go2
-rw-r--r--routers/repo/branch.go12
-rw-r--r--routers/repo/commit.go34
-rw-r--r--routers/repo/download.go6
-rw-r--r--routers/repo/editor.go20
-rw-r--r--routers/repo/http.go20
-rw-r--r--routers/repo/issue.go130
-rw-r--r--routers/repo/issue_label.go18
-rw-r--r--routers/repo/issue_stopwatch.go8
-rw-r--r--routers/repo/issue_timetrack.go4
-rw-r--r--routers/repo/issue_watch.go4
-rw-r--r--routers/repo/middlewares.go4
-rw-r--r--routers/repo/pull.go160
-rw-r--r--routers/repo/release.go28
-rw-r--r--routers/repo/repo.go32
-rw-r--r--routers/repo/search.go2
-rw-r--r--routers/repo/setting.go60
-rw-r--r--routers/repo/setting_protected_branch.go24
-rw-r--r--routers/repo/view.go18
-rw-r--r--routers/repo/webhook.go72
-rw-r--r--routers/repo/wiki.go38
21 files changed, 348 insertions, 348 deletions
diff --git a/routers/repo/activity.go b/routers/repo/activity.go
index fbe51e152e..a0a25dc936 100644
--- a/routers/repo/activity.go
+++ b/routers/repo/activity.go
@@ -48,7 +48,7 @@ func Activity(ctx *context.Context) {
ctx.Repo.Repository.UnitEnabled(models.UnitTypeReleases),
ctx.Repo.Repository.UnitEnabled(models.UnitTypeIssues),
ctx.Repo.Repository.UnitEnabled(models.UnitTypePullRequests)); err != nil {
- ctx.Handle(500, "GetActivityStats", err)
+ ctx.ServerError("GetActivityStats", err)
return
}
diff --git a/routers/repo/branch.go b/routers/repo/branch.go
index c56e8e86b2..7b1e2a8bbe 100644
--- a/routers/repo/branch.go
+++ b/routers/repo/branch.go
@@ -136,7 +136,7 @@ func deleteBranch(ctx *context.Context, branchName string) error {
func loadBranches(ctx *context.Context) []*Branch {
rawBranches, err := ctx.Repo.Repository.GetBranches()
if err != nil {
- ctx.Handle(500, "GetBranches", err)
+ ctx.ServerError("GetBranches", err)
return nil
}
@@ -144,13 +144,13 @@ func loadBranches(ctx *context.Context) []*Branch {
for i := range rawBranches {
commit, err := rawBranches[i].GetCommit()
if err != nil {
- ctx.Handle(500, "GetCommit", err)
+ ctx.ServerError("GetCommit", err)
return nil
}
isProtected, err := ctx.Repo.Repository.IsProtectedBranch(rawBranches[i].Name, ctx.User)
if err != nil {
- ctx.Handle(500, "IsProtectedBranch", err)
+ ctx.ServerError("IsProtectedBranch", err)
return nil
}
@@ -164,7 +164,7 @@ func loadBranches(ctx *context.Context) []*Branch {
if ctx.Repo.IsWriter() {
deletedBranches, err := getDeletedBranches(ctx)
if err != nil {
- ctx.Handle(500, "getDeletedBranches", err)
+ ctx.ServerError("getDeletedBranches", err)
return nil
}
branches = append(branches, deletedBranches...)
@@ -196,7 +196,7 @@ func getDeletedBranches(ctx *context.Context) ([]*Branch, error) {
// CreateBranch creates new branch in repository
func CreateBranch(ctx *context.Context, form auth.NewBranchForm) {
if !ctx.Repo.CanCreateBranch() {
- ctx.Handle(404, "CreateBranch", nil)
+ ctx.NotFound("CreateBranch", nil)
return
}
@@ -232,7 +232,7 @@ func CreateBranch(ctx *context.Context, form auth.NewBranchForm) {
return
}
- ctx.Handle(500, "CreateNewBranch", err)
+ ctx.ServerError("CreateNewBranch", err)
return
}
diff --git a/routers/repo/commit.go b/routers/repo/commit.go
index 2fcb65557d..02ccb0caab 100644
--- a/routers/repo/commit.go
+++ b/routers/repo/commit.go
@@ -40,14 +40,14 @@ func RefCommits(ctx *context.Context) {
func Commits(ctx *context.Context) {
ctx.Data["PageIsCommits"] = true
if ctx.Repo.Commit == nil {
- ctx.Handle(404, "Commit not found", nil)
+ ctx.NotFound("Commit not found", nil)
return
}
ctx.Data["PageIsViewCode"] = true
commitsCount, err := ctx.Repo.GetCommitsCount()
if err != nil {
- ctx.Handle(500, "GetCommitsCount", err)
+ ctx.ServerError("GetCommitsCount", err)
return
}
@@ -60,7 +60,7 @@ func Commits(ctx *context.Context) {
// Both `git log branchName` and `git log commitId` work.
commits, err := ctx.Repo.Commit.CommitsByRange(page)
if err != nil {
- ctx.Handle(500, "CommitsByRange", err)
+ ctx.ServerError("CommitsByRange", err)
return
}
commits = models.ValidateCommitsWithEmails(commits)
@@ -82,13 +82,13 @@ func Graph(ctx *context.Context) {
commitsCount, err := ctx.Repo.GetCommitsCount()
if err != nil {
- ctx.Handle(500, "GetCommitsCount", err)
+ ctx.ServerError("GetCommitsCount", err)
return
}
graph, err := models.GetCommitGraph(ctx.Repo.GitRepo)
if err != nil {
- ctx.Handle(500, "GetCommitGraph", err)
+ ctx.ServerError("GetCommitGraph", err)
return
}
@@ -116,7 +116,7 @@ func SearchCommits(ctx *context.Context) {
commits, err := ctx.Repo.Commit.SearchCommits(keyword, all)
if err != nil {
- ctx.Handle(500, "SearchCommits", err)
+ ctx.ServerError("SearchCommits", err)
return
}
commits = models.ValidateCommitsWithEmails(commits)
@@ -148,10 +148,10 @@ func FileHistory(ctx *context.Context) {
branchName := ctx.Repo.BranchName
commitsCount, err := ctx.Repo.GitRepo.FileCommitsCount(branchName, fileName)
if err != nil {
- ctx.Handle(500, "FileCommitsCount", err)
+ ctx.ServerError("FileCommitsCount", err)
return
} else if commitsCount == 0 {
- ctx.Handle(404, "FileCommitsCount", nil)
+ ctx.NotFound("FileCommitsCount", nil)
return
}
@@ -163,7 +163,7 @@ func FileHistory(ctx *context.Context) {
commits, err := ctx.Repo.GitRepo.CommitsByFileAndRange(branchName, fileName, page)
if err != nil {
- ctx.Handle(500, "CommitsByFileAndRange", err)
+ ctx.ServerError("CommitsByFileAndRange", err)
return
}
commits = models.ValidateCommitsWithEmails(commits)
@@ -191,9 +191,9 @@ func Diff(ctx *context.Context) {
commit, err := ctx.Repo.GitRepo.GetCommit(commitID)
if err != nil {
if git.IsErrNotExist(err) {
- ctx.Handle(404, "Repo.GitRepo.GetCommit", err)
+ ctx.NotFound("Repo.GitRepo.GetCommit", err)
} else {
- ctx.Handle(500, "Repo.GitRepo.GetCommit", err)
+ ctx.ServerError("Repo.GitRepo.GetCommit", err)
}
return
}
@@ -212,7 +212,7 @@ func Diff(ctx *context.Context) {
commitID, setting.Git.MaxGitDiffLines,
setting.Git.MaxGitDiffLineCharacters, setting.Git.MaxGitDiffFiles)
if err != nil {
- ctx.Handle(404, "GetDiffCommit", err)
+ ctx.NotFound("GetDiffCommit", err)
return
}
@@ -221,7 +221,7 @@ func Diff(ctx *context.Context) {
sha, err := commit.ParentID(i)
parents[i] = sha.String()
if err != nil {
- ctx.Handle(404, "repo.Diff", err)
+ ctx.NotFound("repo.Diff", err)
return
}
}
@@ -253,7 +253,7 @@ func RawDiff(ctx *context.Context) {
models.RawDiffType(ctx.Params(":ext")),
ctx.Resp,
); err != nil {
- ctx.Handle(500, "GetRawDiff", err)
+ ctx.ServerError("GetRawDiff", err)
return
}
}
@@ -269,7 +269,7 @@ func CompareDiff(ctx *context.Context) {
commit, err := ctx.Repo.GitRepo.GetCommit(afterCommitID)
if err != nil {
- ctx.Handle(404, "GetCommit", err)
+ ctx.NotFound("GetCommit", err)
return
}
@@ -277,13 +277,13 @@ func CompareDiff(ctx *context.Context) {
afterCommitID, setting.Git.MaxGitDiffLines,
setting.Git.MaxGitDiffLineCharacters, setting.Git.MaxGitDiffFiles)
if err != nil {
- ctx.Handle(404, "GetDiffRange", err)
+ ctx.NotFound("GetDiffRange", err)
return
}
commits, err := commit.CommitsBeforeUntil(beforeCommitID)
if err != nil {
- ctx.Handle(500, "CommitsBeforeUntil", err)
+ ctx.ServerError("CommitsBeforeUntil", err)
return
}
commits = models.ValidateCommitsWithEmails(commits)
diff --git a/routers/repo/download.go b/routers/repo/download.go
index 78c4b519be..820a98c0dc 100644
--- a/routers/repo/download.go
+++ b/routers/repo/download.go
@@ -59,13 +59,13 @@ func SingleDownload(ctx *context.Context) {
blob, err := ctx.Repo.Commit.GetBlobByPath(ctx.Repo.TreePath)
if err != nil {
if git.IsErrNotExist(err) {
- ctx.Handle(404, "GetBlobByPath", nil)
+ ctx.NotFound("GetBlobByPath", nil)
} else {
- ctx.Handle(500, "GetBlobByPath", err)
+ ctx.ServerError("GetBlobByPath", err)
}
return
}
if err = ServeBlob(ctx, blob); err != nil {
- ctx.Handle(500, "ServeBlob", err)
+ ctx.ServerError("ServeBlob", err)
}
}
diff --git a/routers/repo/editor.go b/routers/repo/editor.go
index 82b04a84d2..6c6bf304fc 100644
--- a/routers/repo/editor.go
+++ b/routers/repo/editor.go
@@ -73,19 +73,19 @@ func editFile(ctx *context.Context, isNewFile bool) {
// No way to edit a directory online.
if entry.IsDir() {
- ctx.Handle(404, "entry.IsDir", nil)
+ ctx.NotFound("entry.IsDir", nil)
return
}
blob := entry.Blob()
if blob.Size() >= setting.UI.MaxDisplayFileSize {
- ctx.Handle(404, "blob.Size", err)
+ ctx.NotFound("blob.Size", err)
return
}
dataRc, err := blob.Data()
if err != nil {
- ctx.Handle(404, "blob.Data", err)
+ ctx.NotFound("blob.Data", err)
return
}
@@ -98,7 +98,7 @@ func editFile(ctx *context.Context, isNewFile bool) {
// Only text file are editable online.
if !base.IsTextFile(buf) {
- ctx.Handle(404, "base.IsTextFile", nil)
+ ctx.NotFound("base.IsTextFile", nil)
return
}
@@ -214,7 +214,7 @@ func editFilePost(ctx *context.Context, form auth.EditRepoFileForm, isNewFile bo
break
}
- ctx.Handle(500, "Repo.Commit.GetTreeEntryByPath", err)
+ ctx.ServerError("Repo.Commit.GetTreeEntryByPath", err)
return
}
if index != len(treeNames)-1 {
@@ -244,14 +244,14 @@ func editFilePost(ctx *context.Context, form auth.EditRepoFileForm, isNewFile bo
ctx.Data["Err_TreePath"] = true
ctx.RenderWithErr(ctx.Tr("repo.editor.file_editing_no_longer_exists", oldTreePath), tplEditFile, &form)
} else {
- ctx.Handle(500, "GetTreeEntryByPath", err)
+ ctx.ServerError("GetTreeEntryByPath", err)
}
return
}
if lastCommit != ctx.Repo.CommitID {
files, err := ctx.Repo.Commit.GetFilesChangedSinceCommit(lastCommit)
if err != nil {
- ctx.Handle(500, "GetFilesChangedSinceCommit", err)
+ ctx.ServerError("GetFilesChangedSinceCommit", err)
return
}
@@ -269,7 +269,7 @@ func editFilePost(ctx *context.Context, form auth.EditRepoFileForm, isNewFile bo
entry, err := ctx.Repo.Commit.GetTreeEntryByPath(form.TreePath)
if err != nil {
if !git.IsErrNotExist(err) {
- ctx.Handle(500, "GetTreeEntryByPath", err)
+ ctx.ServerError("GetTreeEntryByPath", err)
return
}
}
@@ -422,7 +422,7 @@ func DeleteFilePost(ctx *context.Context, form auth.DeleteRepoFileForm) {
TreePath: ctx.Repo.TreePath,
Message: message,
}); err != nil {
- ctx.Handle(500, "DeleteRepoFile", err)
+ ctx.ServerError("DeleteRepoFile", err)
return
}
@@ -521,7 +521,7 @@ func UploadFilePost(ctx *context.Context, form auth.UploadRepoFileForm) {
break
}
- ctx.Handle(500, "Repo.Commit.GetTreeEntryByPath", err)
+ ctx.ServerError("Repo.Commit.GetTreeEntryByPath", err)
return
}
diff --git a/routers/repo/http.go b/routers/repo/http.go
index c1fdad5350..08ccf3ed65 100644
--- a/routers/repo/http.go
+++ b/routers/repo/http.go
@@ -120,7 +120,7 @@ func HTTP(ctx *context.Context) {
authUser, err = models.UserSignIn(authUsername, authPasswd)
if err != nil {
if !models.IsErrUserNotExist(err) {
- ctx.Handle(http.StatusInternalServerError, "UserSignIn error: %v", err)
+ ctx.ServerError("UserSignIn error: %v", err)
return
}
}
@@ -140,7 +140,7 @@ func HTTP(ctx *context.Context) {
if models.IsErrUserNotExist(err) {
ctx.HandleText(http.StatusUnauthorized, "invalid credentials")
} else {
- ctx.Handle(http.StatusInternalServerError, "GetUserByName", err)
+ ctx.ServerError("GetUserByName", err)
}
return
}
@@ -152,7 +152,7 @@ func HTTP(ctx *context.Context) {
if models.IsErrAccessTokenNotExist(err) || models.IsErrAccessTokenEmpty(err) {
ctx.HandleText(http.StatusUnauthorized, "invalid credentials")
} else {
- ctx.Handle(http.StatusInternalServerError, "GetAccessTokenBySha", err)
+ ctx.ServerError("GetAccessTokenBySha", err)
}
return
}
@@ -160,7 +160,7 @@ func HTTP(ctx *context.Context) {
if isUsernameToken {
authUser, err = models.GetUserByID(token.UID)
if err != nil {
- ctx.Handle(http.StatusInternalServerError, "GetUserByID", err)
+ ctx.ServerError("GetUserByID", err)
return
}
} else if authUser.ID != token.UID {
@@ -170,7 +170,7 @@ func HTTP(ctx *context.Context) {
token.UpdatedUnix = util.TimeStampNow()
if err = models.UpdateAccessToken(token); err != nil {
- ctx.Handle(http.StatusInternalServerError, "UpdateAccessToken", err)
+ ctx.ServerError("UpdateAccessToken", err)
}
} else {
_, err = models.GetTwoFactorByUID(authUser.ID)
@@ -180,7 +180,7 @@ func HTTP(ctx *context.Context) {
ctx.HandleText(http.StatusUnauthorized, "Users with two-factor authentication enabled cannot perform HTTP/HTTPS operations via plain username and password. Please create and use a personal access token on the user settings page")
return
} else if !models.IsErrTwoFactorNotEnrolled(err) {
- ctx.Handle(http.StatusInternalServerError, "IsErrTwoFactorNotEnrolled", err)
+ ctx.ServerError("IsErrTwoFactorNotEnrolled", err)
return
}
}
@@ -188,13 +188,13 @@ func HTTP(ctx *context.Context) {
if !isPublicPull {
has, err := models.HasAccess(authUser.ID, repo, accessMode)
if err != nil {
- ctx.Handle(http.StatusInternalServerError, "HasAccess", err)
+ ctx.ServerError("HasAccess", err)
return
} else if !has {
if accessMode == models.AccessModeRead {
has, err = models.HasAccess(authUser.ID, repo, models.AccessModeWrite)
if err != nil {
- ctx.Handle(http.StatusInternalServerError, "HasAccess2", err)
+ ctx.ServerError("HasAccess2", err)
return
} else if !has {
ctx.HandleText(http.StatusForbidden, "User permission denied")
@@ -501,7 +501,7 @@ func HTTPBackend(ctx *context.Context, cfg *serviceConfig) http.HandlerFunc {
dir, err := getGitRepoPath(m[1])
if err != nil {
log.GitLogger.Error(4, err.Error())
- ctx.Handle(http.StatusNotFound, "HTTPBackend", err)
+ ctx.NotFound("HTTPBackend", err)
return
}
@@ -510,7 +510,7 @@ func HTTPBackend(ctx *context.Context, cfg *serviceConfig) http.HandlerFunc {
}
}
- ctx.Handle(http.StatusNotFound, "HTTPBackend", nil)
+ ctx.NotFound("HTTPBackend", nil)
return
}
}
diff --git a/routers/repo/issue.go b/routers/repo/issue.go
index e4aecf152e..230b0e939d 100644
--- a/routers/repo/issue.go
+++ b/routers/repo/issue.go
@@ -64,7 +64,7 @@ var (
func MustEnableIssues(ctx *context.Context) {
if !ctx.Repo.Repository.UnitEnabled(models.UnitTypeIssues) &&
!ctx.Repo.Repository.UnitEnabled(models.UnitTypeExternalTracker) {
- ctx.Handle(404, "MustEnableIssues", nil)
+ ctx.NotFound("MustEnableIssues", nil)
return
}
@@ -78,7 +78,7 @@ func MustEnableIssues(ctx *context.Context) {
// MustAllowPulls check if repository enable pull requests
func MustAllowPulls(ctx *context.Context) {
if !ctx.Repo.Repository.AllowsPulls() {
- ctx.Handle(404, "MustAllowPulls", nil)
+ ctx.NotFound("MustAllowPulls", nil)
return
}
@@ -167,7 +167,7 @@ func Issues(ctx *context.Context) {
IssueIDs: issueIDs,
})
if err != nil {
- ctx.Handle(500, "GetIssueStats", err)
+ ctx.ServerError("GetIssueStats", err)
return
}
}
@@ -204,7 +204,7 @@ func Issues(ctx *context.Context) {
IssueIDs: issueIDs,
})
if err != nil {
- ctx.Handle(500, "Issues", err)
+ ctx.ServerError("Issues", err)
return
}
}
@@ -215,7 +215,7 @@ func Issues(ctx *context.Context) {
if !ctx.IsSigned {
issues[i].IsRead = true
} else if err = issues[i].GetIsRead(ctx.User.ID); err != nil {
- ctx.Handle(500, "GetIsRead", err)
+ ctx.ServerError("GetIsRead", err)
return
}
}
@@ -224,14 +224,14 @@ func Issues(ctx *context.Context) {
// Get milestones.
ctx.Data["Milestones"], err = models.GetMilestonesByRepoID(repo.ID)
if err != nil {
- ctx.Handle(500, "GetAllRepoMilestones", err)
+ ctx.ServerError("GetAllRepoMilestones", err)
return
}
// Get assignees.
ctx.Data["Assignees"], err = repo.GetAssignees()
if err != nil {
- ctx.Handle(500, "GetAssignees", err)
+ ctx.ServerError("GetAssignees", err)
return
}
@@ -261,18 +261,18 @@ func RetrieveRepoMilestonesAndAssignees(ctx *context.Context, repo *models.Repos
var err error
ctx.Data["OpenMilestones"], err = models.GetMilestones(repo.ID, -1, false, "")
if err != nil {
- ctx.Handle(500, "GetMilestones", err)
+ ctx.ServerError("GetMilestones", err)
return
}
ctx.Data["ClosedMilestones"], err = models.GetMilestones(repo.ID, -1, true, "")
if err != nil {
- ctx.Handle(500, "GetMilestones", err)
+ ctx.ServerError("GetMilestones", err)
return
}
ctx.Data["Assignees"], err = repo.GetAssignees()
if err != nil {
- ctx.Handle(500, "GetAssignees", err)
+ ctx.ServerError("GetAssignees", err)
return
}
}
@@ -285,7 +285,7 @@ func RetrieveRepoMetas(ctx *context.Context, repo *models.Repository) []*models.
labels, err := models.GetLabelsByRepoID(repo.ID, "")
if err != nil {
- ctx.Handle(500, "GetLabelsByRepoID", err)
+ ctx.ServerError("GetLabelsByRepoID", err)
return nil
}
ctx.Data["Labels"] = labels
@@ -297,7 +297,7 @@ func RetrieveRepoMetas(ctx *context.Context, repo *models.Repository) []*models.
brs, err := ctx.Repo.GitRepo.GetBranches()
if err != nil {
- ctx.Handle(500, "GetBranches", err)
+ ctx.ServerError("GetBranches", err)
return nil
}
ctx.Data["Branches"] = brs
@@ -406,7 +406,7 @@ func ValidateRepoMetas(ctx *context.Context, form auth.CreateIssueForm) ([]int64
if milestoneID > 0 {
ctx.Data["Milestone"], err = repo.GetMilestoneByID(milestoneID)
if err != nil {
- ctx.Handle(500, "GetMilestoneByID", err)
+ ctx.ServerError("GetMilestoneByID", err)
return nil, 0, 0
}
ctx.Data["milestone_id"] = milestoneID
@@ -417,7 +417,7 @@ func ValidateRepoMetas(ctx *context.Context, form auth.CreateIssueForm) ([]int64
if assigneeID > 0 {
ctx.Data["Assignee"], err = repo.GetAssigneeByID(assigneeID)
if err != nil {
- ctx.Handle(500, "GetAssigneeByID", err)
+ ctx.ServerError("GetAssigneeByID", err)
return nil, 0, 0
}
ctx.Data["assignee_id"] = assigneeID
@@ -465,7 +465,7 @@ func NewIssuePost(ctx *context.Context, form auth.CreateIssueForm) {
Ref: form.Ref,
}
if err := models.NewIssue(repo, issue, labelIDs, attachments); err != nil {
- ctx.Handle(500, "NewIssue", err)
+ ctx.ServerError("NewIssue", err)
return
}
@@ -505,9 +505,9 @@ func ViewIssue(ctx *context.Context) {
issue, err := models.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index"))
if err != nil {
if models.IsErrIssueNotExist(err) {
- ctx.Handle(404, "GetIssueByIndex", err)
+ ctx.NotFound("GetIssueByIndex", err)
} else {
- ctx.Handle(500, "GetIssueByIndex", err)
+ ctx.ServerError("GetIssueByIndex", err)
}
return
}
@@ -518,7 +518,7 @@ func ViewIssue(ctx *context.Context) {
if ctx.User != nil {
iw, exists, err = models.GetIssueWatch(ctx.User.ID, issue.ID)
if err != nil {
- ctx.Handle(500, "GetIssueWatch", err)
+ ctx.ServerError("GetIssueWatch", err)
return
}
if !exists {
@@ -581,7 +581,7 @@ func ViewIssue(ctx *context.Context) {
}
labels, err := models.GetLabelsByRepoID(repo.ID, "")
if err != nil {
- ctx.Handle(500, "GetLabelsByRepoID", err)
+ ctx.ServerError("GetLabelsByRepoID", err)
return
}
hasSelected := false
@@ -605,7 +605,7 @@ func ViewIssue(ctx *context.Context) {
if ctx.IsSigned {
// Update issue-user.
if err = issue.ReadBy(ctx.User.ID); err != nil {
- ctx.Handle(500, "ReadBy", err)
+ ctx.ServerError("ReadBy", err)
return
}
}
@@ -625,7 +625,7 @@ func ViewIssue(ctx *context.Context) {
var exists bool
var sw *models.Stopwatch
if exists, sw, err = models.HasUserStopwatch(ctx.User.ID); err != nil {
- ctx.Handle(500, "HasUserStopwatch", err)
+ ctx.ServerError("HasUserStopwatch", err)
return
}
ctx.Data["HasUserStopwatch"] = exists
@@ -633,7 +633,7 @@ func ViewIssue(ctx *context.Context) {
// Add warning if the user has already a stopwatch
var otherIssue *models.Issue
if otherIssue, err = models.GetIssueByID(sw.IssueID); err != nil {
- ctx.Handle(500, "GetIssueByID", err)
+ ctx.ServerError("GetIssueByID", err)
return
}
// Add link to the issue of the already running stopwatch
@@ -645,7 +645,7 @@ func ViewIssue(ctx *context.Context) {
ctx.Data["CanUseTimetracker"] = false
}
if ctx.Data["WorkingUsers"], err = models.TotalTimes(models.FindTrackedTimesOptions{IssueID: issue.ID}); err != nil {
- ctx.Handle(500, "TotalTimes", err)
+ ctx.ServerError("TotalTimes", err)
return
}
}
@@ -666,7 +666,7 @@ func ViewIssue(ctx *context.Context) {
comment.ShowTag, err = commentTag(repo, comment.Poster, issue)
if err != nil {
- ctx.Handle(500, "commentTag", err)
+ ctx.ServerError("commentTag", err)
return
}
marked[comment.PosterID] = comment.ShowTag
@@ -683,12 +683,12 @@ func ViewIssue(ctx *context.Context) {
}
} else if comment.Type == models.CommentTypeLabel {
if err = comment.LoadLabel(); err != nil {
- ctx.Handle(500, "LoadLabel", err)
+ ctx.ServerError("LoadLabel", err)
return
}
} else if comment.Type == models.CommentTypeMilestone {
if err = comment.LoadMilestone(); err != nil {
- ctx.Handle(500, "LoadMilestone", err)
+ ctx.ServerError("LoadMilestone", err)
return
}
ghostMilestone := &models.Milestone{
@@ -703,7 +703,7 @@ func ViewIssue(ctx *context.Context) {
}
} else if comment.Type == models.CommentTypeAssignees {
if err = comment.LoadAssignees(); err != nil {
- ctx.Handle(500, "LoadAssignees", err)
+ ctx.ServerError("LoadAssignees", err)
return
}
}
@@ -729,7 +729,7 @@ func ViewIssue(ctx *context.Context) {
prUnit, err := repo.GetUnit(models.UnitTypePullRequests)
if err != nil {
- ctx.Handle(500, "GetUnit", err)
+ ctx.ServerError("GetUnit", err)
return
}
prConfig := prUnit.PullRequestsConfig()
@@ -771,7 +771,7 @@ func GetActionIssue(ctx *context.Context) *models.Issue {
return nil
}
if err = issue.LoadAttributes(); err != nil {
- ctx.Handle(500, "LoadAttributes", nil)
+ ctx.ServerError("LoadAttributes", nil)
return nil
}
return issue
@@ -780,7 +780,7 @@ func GetActionIssue(ctx *context.Context) *models.Issue {
func checkIssueRights(ctx *context.Context, issue *models.Issue) {
if issue.IsPull && !ctx.Repo.Repository.UnitEnabled(models.UnitTypePullRequests) ||
!issue.IsPull && !ctx.Repo.Repository.UnitEnabled(models.UnitTypeIssues) {
- ctx.Handle(404, "IssueOrPullRequestUnitNotAllowed", nil)
+ ctx.NotFound("IssueOrPullRequestUnitNotAllowed", nil)
}
}
@@ -793,14 +793,14 @@ func getActionIssues(ctx *context.Context) []*models.Issue {
for _, stringIssueID := range strings.Split(commaSeparatedIssueIDs, ",") {
issueID, err := strconv.ParseInt(stringIssueID, 10, 64)
if err != nil {
- ctx.Handle(500, "ParseInt", err)
+ ctx.ServerError("ParseInt", err)
return nil
}
issueIDs = append(issueIDs, issueID)
}
issues, err := models.GetIssuesByIDs(issueIDs)
if err != nil {
- ctx.Handle(500, "GetIssuesByIDs", err)
+ ctx.ServerError("GetIssuesByIDs", err)
return nil
}
// Check access rights for all issues
@@ -808,11 +808,11 @@ func getActionIssues(ctx *context.Context) []*models.Issue {
prUnitEnabled := ctx.Repo.Repository.UnitEnabled(models.UnitTypePullRequests)
for _, issue := range issues {
if issue.IsPull && !prUnitEnabled || !issue.IsPull && !issueUnitEnabled {
- ctx.Handle(404, "IssueOrPullRequestUnitNotAllowed", nil)
+ ctx.NotFound("IssueOrPullRequestUnitNotAllowed", nil)
return nil
}
if err = issue.LoadAttributes(); err != nil {
- ctx.Handle(500, "LoadAttributes", err)
+ ctx.ServerError("LoadAttributes", err)
return nil
}
}
@@ -838,7 +838,7 @@ func UpdateIssueTitle(ctx *context.Context) {
}
if err := issue.ChangeTitle(ctx.User, title); err != nil {
- ctx.Handle(500, "ChangeTitle", err)
+ ctx.ServerError("ChangeTitle", err)
return
}
@@ -861,7 +861,7 @@ func UpdateIssueContent(ctx *context.Context) {
content := ctx.Query("content")
if err := issue.ChangeContent(ctx.User, content); err != nil {
- ctx.Handle(500, "ChangeContent", err)
+ ctx.ServerError("ChangeContent", err)
return
}
@@ -885,7 +885,7 @@ func UpdateIssueMilestone(ctx *context.Context) {
}
issue.MilestoneID = milestoneID
if err := models.ChangeMilestoneAssign(issue, ctx.User, oldMilestoneID); err != nil {
- ctx.Handle(500, "ChangeMilestoneAssign", err)
+ ctx.ServerError("ChangeMilestoneAssign", err)
return
}
}
@@ -908,7 +908,7 @@ func UpdateIssueAssignee(ctx *context.Context) {
continue
}
if err := issue.ChangeAssignee(ctx.User, assigneeID); err != nil {
- ctx.Handle(500, "ChangeAssignee", err)
+ ctx.ServerError("ChangeAssignee", err)
return
}
}
@@ -935,12 +935,12 @@ func UpdateIssueStatus(ctx *context.Context) {
}
if _, err := models.IssueList(issues).LoadRepositories(); err != nil {
- ctx.Handle(500, "LoadRepositories", err)
+ ctx.ServerError("LoadRepositories", err)
return
}
for _, issue := range issues {
if err := issue.ChangeStatus(ctx.User, issue.Repo, isClosed); err != nil {
- ctx.Handle(500, "ChangeStatus", err)
+ ctx.ServerError("ChangeStatus", err)
return
}
}
@@ -982,7 +982,7 @@ func NewComment(ctx *context.Context, form auth.CreateCommentForm) {
pr, err := models.GetUnmergedPullRequest(pull.HeadRepoID, pull.BaseRepoID, pull.HeadBranch, pull.BaseBranch)
if err != nil {
if !models.IsErrPullRequestNotExist(err) {
- ctx.Handle(500, "GetUnmergedPullRequest", err)
+ ctx.ServerError("GetUnmergedPullRequest", err)
return
}
}
@@ -990,7 +990,7 @@ func NewComment(ctx *context.Context, form auth.CreateCommentForm) {
// Regenerate patch and test conflict.
if pr == nil {
if err = issue.PullRequest.UpdatePatch(); err != nil {
- ctx.Handle(500, "UpdatePatch", err)
+ ctx.ServerError("UpdatePatch", err)
return
}
@@ -1030,7 +1030,7 @@ func NewComment(ctx *context.Context, form auth.CreateCommentForm) {
comment, err := models.CreateIssueComment(ctx.User, ctx.Repo.Repository, issue, form.Content, attachments)
if err != nil {
- ctx.Handle(500, "CreateIssueComment", err)
+ ctx.ServerError("CreateIssueComment", err)
return
}
@@ -1063,7 +1063,7 @@ func UpdateCommentContent(ctx *context.Context) {
return
}
if err = models.UpdateComment(comment); err != nil {
- ctx.Handle(500, "UpdateComment", err)
+ ctx.ServerError("UpdateComment", err)
return
}
@@ -1089,7 +1089,7 @@ func DeleteComment(ctx *context.Context) {
}
if err = models.DeleteComment(comment); err != nil {
- ctx.Handle(500, "DeleteCommentByID", err)
+ ctx.ServerError("DeleteCommentByID", err)
return
}
@@ -1105,7 +1105,7 @@ func Milestones(ctx *context.Context) {
isShowClosed := ctx.Query("state") == "closed"
openCount, closedCount, err := models.MilestoneStats(ctx.Repo.Repository.ID)
if err != nil {
- ctx.Handle(500, "MilestoneStats", err)
+ ctx.ServerError("MilestoneStats", err)
return
}
ctx.Data["OpenCount"] = openCount
@@ -1127,7 +1127,7 @@ func Milestones(ctx *context.Context) {
miles, err := models.GetMilestones(ctx.Repo.Repository.ID, page, isShowClosed, sortType)
if err != nil {
- ctx.Handle(500, "GetMilestones", err)
+ ctx.ServerError("GetMilestones", err)
return
}
for _, m := range miles {
@@ -1185,7 +1185,7 @@ func NewMilestonePost(ctx *context.Context, form auth.CreateMilestoneForm) {
Content: form.Content,
DeadlineUnix: util.TimeStamp(deadline.Unix()),
}); err != nil {
- ctx.Handle(500, "NewMilestone", err)
+ ctx.ServerError("NewMilestone", err)
return
}
@@ -1204,9 +1204,9 @@ func EditMilestone(ctx *context.Context) {
m, err := models.GetMilestoneByRepoID(ctx.Repo.Repository.ID, ctx.ParamsInt64(":id"))
if err != nil {
if models.IsErrMilestoneNotExist(err) {
- ctx.Handle(404, "", nil)
+ ctx.NotFound("", nil)
} else {
- ctx.Handle(500, "GetMilestoneByRepoID", err)
+ ctx.ServerError("GetMilestoneByRepoID", err)
}
return
}
@@ -1244,9 +1244,9 @@ func EditMilestonePost(ctx *context.Context, form auth.CreateMilestoneForm) {
m, err := models.GetMilestoneByRepoID(ctx.Repo.Repository.ID, ctx.ParamsInt64(":id"))
if err != nil {
if models.IsErrMilestoneNotExist(err) {
- ctx.Handle(404, "", nil)
+ ctx.NotFound("", nil)
} else {
- ctx.Handle(500, "GetMilestoneByRepoID", err)
+ ctx.ServerError("GetMilestoneByRepoID", err)
}
return
}
@@ -1254,7 +1254,7 @@ func EditMilestonePost(ctx *context.Context, form auth.CreateMilestoneForm) {
m.Content = form.Content
m.DeadlineUnix = util.TimeStamp(deadline.Unix())
if err = models.UpdateMilestone(m); err != nil {
- ctx.Handle(500, "UpdateMilestone", err)
+ ctx.ServerError("UpdateMilestone", err)
return
}
@@ -1267,9 +1267,9 @@ func ChangeMilestonStatus(ctx *context.Context) {
m, err := models.GetMilestoneByRepoID(ctx.Repo.Repository.ID, ctx.ParamsInt64(":id"))
if err != nil {
if models.IsErrMilestoneNotExist(err) {
- ctx.Handle(404, "", err)
+ ctx.NotFound("", err)
} else {
- ctx.Handle(500, "GetMilestoneByRepoID", err)
+ ctx.ServerError("GetMilestoneByRepoID", err)
}
return
}
@@ -1278,7 +1278,7 @@ func ChangeMilestonStatus(ctx *context.Context) {
case "open":
if m.IsClosed {
if err = models.ChangeMilestoneStatus(m, false); err != nil {
- ctx.Handle(500, "ChangeMilestoneStatus", err)
+ ctx.ServerError("ChangeMilestoneStatus", err)
return
}
}
@@ -1287,7 +1287,7 @@ func ChangeMilestonStatus(ctx *context.Context) {
if !m.IsClosed {
m.ClosedDateUnix = util.TimeStampNow()
if err = models.ChangeMilestoneStatus(m, true); err != nil {
- ctx.Handle(500, "ChangeMilestoneStatus", err)
+ ctx.ServerError("ChangeMilestoneStatus", err)
return
}
}
@@ -1318,7 +1318,7 @@ func ChangeIssueReaction(ctx *context.Context, form auth.ReactionForm) {
}
if ctx.HasError() {
- ctx.Handle(500, "ChangeIssueReaction", errors.New(ctx.GetErrMsg()))
+ ctx.ServerError("ChangeIssueReaction", errors.New(ctx.GetErrMsg()))
return
}
@@ -1339,7 +1339,7 @@ func ChangeIssueReaction(ctx *context.Context, form auth.ReactionForm) {
log.Trace("Reaction for issue created: %d/%d/%d", ctx.Repo.Repository.ID, issue.ID, reaction.ID)
case "unreact":
if err := models.DeleteIssueReaction(ctx.User, issue, form.Content); err != nil {
- ctx.Handle(500, "DeleteIssueReaction", err)
+ ctx.ServerError("DeleteIssueReaction", err)
return
}
@@ -1352,7 +1352,7 @@ func ChangeIssueReaction(ctx *context.Context, form auth.ReactionForm) {
log.Trace("Reaction for issue removed: %d/%d", ctx.Repo.Repository.ID, issue.ID)
default:
- ctx.Handle(404, fmt.Sprintf("Unknown action %s", ctx.Params(":action")), nil)
+ ctx.NotFound(fmt.Sprintf("Unknown action %s", ctx.Params(":action")), nil)
return
}
@@ -1370,7 +1370,7 @@ func ChangeIssueReaction(ctx *context.Context, form auth.ReactionForm) {
"Reactions": issue.Reactions.GroupByType(),
})
if err != nil {
- ctx.Handle(500, "ChangeIssueReaction.HTMLString", err)
+ ctx.ServerError("ChangeIssueReaction.HTMLString", err)
return
}
ctx.JSON(200, map[string]interface{}{
@@ -1393,7 +1393,7 @@ func ChangeCommentReaction(ctx *context.Context, form auth.ReactionForm) {
}
if ctx.HasError() {
- ctx.Handle(500, "ChangeCommentReaction", errors.New(ctx.GetErrMsg()))
+ ctx.ServerError("ChangeCommentReaction", errors.New(ctx.GetErrMsg()))
return
}
@@ -1414,7 +1414,7 @@ func ChangeCommentReaction(ctx *context.Context, form auth.ReactionForm) {
log.Trace("Reaction for comment created: %d/%d/%d/%d", ctx.Repo.Repository.ID, issue.ID, comment.ID, reaction.ID)
case "unreact":
if err := models.DeleteCommentReaction(ctx.User, issue, comment, form.Content); err != nil {
- ctx.Handle(500, "DeleteCommentReaction", err)
+ ctx.ServerError("DeleteCommentReaction", err)
return
}
@@ -1427,7 +1427,7 @@ func ChangeCommentReaction(ctx *context.Context, form auth.ReactionForm) {
log.Trace("Reaction for comment removed: %d/%d/%d", ctx.Repo.Repository.ID, issue.ID, comment.ID)
default:
- ctx.Handle(404, fmt.Sprintf("Unknown action %s", ctx.Params(":action")), nil)
+ ctx.NotFound(fmt.Sprintf("Unknown action %s", ctx.Params(":action")), nil)
return
}
@@ -1445,7 +1445,7 @@ func ChangeCommentReaction(ctx *context.Context, form auth.ReactionForm) {
"Reactions": comment.Reactions.GroupByType(),
})
if err != nil {
- ctx.Handle(500, "ChangeCommentReaction.HTMLString", err)
+ ctx.ServerError("ChangeCommentReaction.HTMLString", err)
return
}
ctx.JSON(200, map[string]interface{}{
diff --git a/routers/repo/issue_label.go b/routers/repo/issue_label.go
index f8a955ba6d..a197256be8 100644
--- a/routers/repo/issue_label.go
+++ b/routers/repo/issue_label.go
@@ -48,7 +48,7 @@ func InitializeLabels(ctx *context.Context, form auth.InitializeLabelsForm) {
}
}
if err := models.NewLabels(labels...); err != nil {
- ctx.Handle(500, "NewLabels", err)
+ ctx.ServerError("NewLabels", err)
return
}
ctx.Redirect(ctx.Repo.RepoLink + "/labels")
@@ -58,7 +58,7 @@ func InitializeLabels(ctx *context.Context, form auth.InitializeLabelsForm) {
func RetrieveLabels(ctx *context.Context) {
labels, err := models.GetLabelsByRepoID(ctx.Repo.Repository.ID, ctx.Query("sort"))
if err != nil {
- ctx.Handle(500, "RetrieveLabels.GetLabels", err)
+ ctx.ServerError("RetrieveLabels.GetLabels", err)
return
}
for _, l := range labels {
@@ -86,7 +86,7 @@ func NewLabel(ctx *context.Context, form auth.CreateLabelForm) {
Color: form.Color,
}
if err := models.NewLabel(l); err != nil {
- ctx.Handle(500, "NewLabel", err)
+ ctx.ServerError("NewLabel", err)
return
}
ctx.Redirect(ctx.Repo.RepoLink + "/labels")
@@ -100,7 +100,7 @@ func UpdateLabel(ctx *context.Context, form auth.CreateLabelForm) {
case models.IsErrLabelNotExist(err):
ctx.Error(404)
default:
- ctx.Handle(500, "UpdateLabel", err)
+ ctx.ServerError("UpdateLabel", err)
}
return
}
@@ -108,7 +108,7 @@ func UpdateLabel(ctx *context.Context, form auth.CreateLabelForm) {
l.Name = form.Title
l.Color = form.Color
if err := models.UpdateLabel(l); err != nil {
- ctx.Handle(500, "UpdateLabel", err)
+ ctx.ServerError("UpdateLabel", err)
return
}
ctx.Redirect(ctx.Repo.RepoLink + "/labels")
@@ -139,7 +139,7 @@ func UpdateIssueLabel(ctx *context.Context) {
case "clear":
for _, issue := range issues {
if err := issue.ClearLabels(ctx.User); err != nil {
- ctx.Handle(500, "ClearLabels", err)
+ ctx.ServerError("ClearLabels", err)
return
}
}
@@ -149,7 +149,7 @@ func UpdateIssueLabel(ctx *context.Context) {
if models.IsErrLabelNotExist(err) {
ctx.Error(404, "GetLabelByID")
} else {
- ctx.Handle(500, "GetLabelByID", err)
+ ctx.ServerError("GetLabelByID", err)
}
return
}
@@ -168,14 +168,14 @@ func UpdateIssueLabel(ctx *context.Context) {
if action == "attach" {
for _, issue := range issues {
if err = issue.AddLabel(ctx.User, label); err != nil {
- ctx.Handle(500, "AddLabel", err)
+ ctx.ServerError("AddLabel", err)
return
}
}
} else {
for _, issue := range issues {
if err = issue.RemoveLabel(ctx.User, label); err != nil {
- ctx.Handle(500, "RemoveLabel", err)
+ ctx.ServerError("RemoveLabel", err)
return
}
}
diff --git a/routers/repo/issue_stopwatch.go b/routers/repo/issue_stopwatch.go
index f4392849aa..a7d6ed39cc 100644
--- a/routers/repo/issue_stopwatch.go
+++ b/routers/repo/issue_stopwatch.go
@@ -18,12 +18,12 @@ func IssueStopwatch(c *context.Context) {
return
}
if !c.Repo.CanUseTimetracker(issue, c.User) {
- c.Handle(http.StatusNotFound, "CanUseTimetracker", nil)
+ c.NotFound("CanUseTimetracker", nil)
return
}
if err := models.CreateOrStopIssueStopwatch(c.User, issue); err != nil {
- c.Handle(http.StatusInternalServerError, "CreateOrStopIssueStopwatch", err)
+ c.ServerError("CreateOrStopIssueStopwatch", err)
return
}
@@ -38,12 +38,12 @@ func CancelStopwatch(c *context.Context) {
return
}
if !c.Repo.CanUseTimetracker(issue, c.User) {
- c.Handle(http.StatusNotFound, "CanUseTimetracker", nil)
+ c.NotFound("CanUseTimetracker", nil)
return
}
if err := models.CancelStopwatch(c.User, issue); err != nil {
- c.Handle(http.StatusInternalServerError, "CancelStopwatch", err)
+ c.ServerError("CancelStopwatch", err)
return
}
diff --git a/routers/repo/issue_timetrack.go b/routers/repo/issue_timetrack.go
index d89c67b497..05cf137931 100644
--- a/routers/repo/issue_timetrack.go
+++ b/routers/repo/issue_timetrack.go
@@ -20,7 +20,7 @@ func AddTimeManually(c *context.Context, form auth.AddTimeManuallyForm) {
return
}
if !c.Repo.CanUseTimetracker(issue, c.User) {
- c.Handle(http.StatusNotFound, "CanUseTimetracker", nil)
+ c.NotFound("CanUseTimetracker", nil)
return
}
url := issue.HTMLURL()
@@ -40,7 +40,7 @@ func AddTimeManually(c *context.Context, form auth.AddTimeManuallyForm) {
}
if _, err := models.AddTime(c.User, issue, int64(total.Seconds())); err != nil {
- c.Handle(http.StatusInternalServerError, "AddTime", err)
+ c.ServerError("AddTime", err)
return
}
diff --git a/routers/repo/issue_watch.go b/routers/repo/issue_watch.go
index 42ffaec5b8..a499b70d9c 100644
--- a/routers/repo/issue_watch.go
+++ b/routers/repo/issue_watch.go
@@ -17,7 +17,7 @@ import (
func IssueWatch(c *context.Context) {
watch, err := strconv.ParseBool(c.Req.PostForm.Get("watch"))
if err != nil {
- c.Handle(http.StatusInternalServerError, "watch is not bool", err)
+ c.ServerError("watch is not bool", err)
return
}
@@ -27,7 +27,7 @@ func IssueWatch(c *context.Context) {
}
if err := models.CreateOrUpdateIssueWatch(c.User.ID, issue.ID, watch); err != nil {
- c.Handle(http.StatusInternalServerError, "CreateOrUpdateIssueWatch", err)
+ c.ServerError("CreateOrUpdateIssueWatch", err)
return
}
diff --git a/routers/repo/middlewares.go b/routers/repo/middlewares.go
index 1829e0d491..8afad5be64 100644
--- a/routers/repo/middlewares.go
+++ b/routers/repo/middlewares.go
@@ -15,7 +15,7 @@ func SetEditorconfigIfExists(ctx *context.Context) {
if err != nil && !git.IsErrNotExist(err) {
description := fmt.Sprintf("Error while getting .editorconfig file: %v", err)
if err := models.CreateRepositoryNotice(description); err != nil {
- ctx.Handle(500, "ErrCreatingReporitoryNotice", err)
+ ctx.ServerError("ErrCreatingReporitoryNotice", err)
}
return
}
@@ -47,6 +47,6 @@ func SetDiffViewStyle(ctx *context.Context) {
ctx.Data["IsSplitStyle"] = style == "split"
if err := ctx.User.UpdateDiffViewStyle(style); err != nil {
- ctx.Handle(500, "ErrUpdateDiffViewStyle", err)
+ ctx.ServerError("ErrUpdateDiffViewStyle", err)
}
}
diff --git a/routers/repo/pull.go b/routers/repo/pull.go
index 35b5b0be2b..c06c67552f 100644
--- a/routers/repo/pull.go
+++ b/routers/repo/pull.go
@@ -50,15 +50,15 @@ func getForkRepository(ctx *context.Context) *models.Repository {
forkRepo, err := models.GetRepositoryByID(ctx.ParamsInt64(":repoid"))
if err != nil {
if models.IsErrRepoNotExist(err) {
- ctx.Handle(404, "GetRepositoryByID", nil)
+ ctx.NotFound("GetRepositoryByID", nil)
} else {
- ctx.Handle(500, "GetRepositoryByID", err)
+ ctx.ServerError("GetRepositoryByID", err)
}
return nil
}
if !forkRepo.CanBeForked() || !forkRepo.HasAccess(ctx.User) {
- ctx.Handle(404, "getForkRepository", nil)
+ ctx.NotFound("getForkRepository", nil)
return nil
}
@@ -68,14 +68,14 @@ func getForkRepository(ctx *context.Context) *models.Repository {
canForkToUser := forkRepo.OwnerID != ctx.User.ID && !ctx.User.HasForkedRepo(forkRepo.ID)
if err = forkRepo.GetOwner(); err != nil {
- ctx.Handle(500, "GetOwner", err)
+ ctx.ServerError("GetOwner", err)
return nil
}
ctx.Data["ForkFrom"] = forkRepo.Owner.Name + "/" + forkRepo.Name
ctx.Data["ForkFromOwnerID"] = forkRepo.Owner.ID
if err := ctx.User.GetOwnedOrganizations(); err != nil {
- ctx.Handle(500, "GetOwnedOrganizations", err)
+ ctx.ServerError("GetOwnedOrganizations", err)
return nil
}
var orgs []*models.User
@@ -103,7 +103,7 @@ func getForkRepository(ctx *context.Context) *models.Repository {
}
traverseParentRepo, err = models.GetRepositoryByID(traverseParentRepo.ForkID)
if err != nil {
- ctx.Handle(500, "GetRepositoryByID", err)
+ ctx.ServerError("GetRepositoryByID", err)
return nil
}
}
@@ -170,7 +170,7 @@ func ForkPost(ctx *context.Context, form auth.CreateRepoForm) {
}
traverseParentRepo, err = models.GetRepositoryByID(traverseParentRepo.ForkID)
if err != nil {
- ctx.Handle(500, "GetRepositoryByID", err)
+ ctx.ServerError("GetRepositoryByID", err)
return
}
}
@@ -179,7 +179,7 @@ func ForkPost(ctx *context.Context, form auth.CreateRepoForm) {
if ctxUser.IsOrganization() {
isOwner, err := ctxUser.IsOwnedBy(ctx.User.ID)
if err != nil {
- ctx.Handle(500, "IsOwnedBy", err)
+ ctx.ServerError("IsOwnedBy", err)
return
} else if !isOwner {
ctx.Error(403)
@@ -198,7 +198,7 @@ func ForkPost(ctx *context.Context, form auth.CreateRepoForm) {
case models.IsErrNamePatternNotAllowed(err):
ctx.RenderWithErr(ctx.Tr("repo.form.name_pattern_not_allowed", err.(models.ErrNamePatternNotAllowed).Pattern), tplFork, &form)
default:
- ctx.Handle(500, "ForkPost", err)
+ ctx.ServerError("ForkPost", err)
}
return
}
@@ -211,9 +211,9 @@ func checkPullInfo(ctx *context.Context) *models.Issue {
issue, err := models.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index"))
if err != nil {
if models.IsErrIssueNotExist(err) {
- ctx.Handle(404, "GetIssueByIndex", err)
+ ctx.NotFound("GetIssueByIndex", err)
} else {
- ctx.Handle(500, "GetIssueByIndex", err)
+ ctx.ServerError("GetIssueByIndex", err)
}
return nil
}
@@ -221,19 +221,19 @@ func checkPullInfo(ctx *context.Context) *models.Issue {
ctx.Data["Issue"] = issue
if !issue.IsPull {
- ctx.Handle(404, "ViewPullCommits", nil)
+ ctx.NotFound("ViewPullCommits", nil)
return nil
}
if err = issue.PullRequest.GetHeadRepo(); err != nil {
- ctx.Handle(500, "GetHeadRepo", err)
+ ctx.ServerError("GetHeadRepo", err)
return nil
}
if ctx.IsSigned {
// Update issue-user.
if err = issue.ReadBy(ctx.User.ID); err != nil {
- ctx.Handle(500, "ReadBy", err)
+ ctx.ServerError("ReadBy", err)
return nil
}
}
@@ -258,7 +258,7 @@ func PrepareMergedViewPullInfo(ctx *context.Context, issue *models.Issue) {
var err error
if err = pull.GetHeadRepo(); err != nil {
- ctx.Handle(500, "GetHeadRepo", err)
+ ctx.ServerError("GetHeadRepo", err)
return
}
@@ -267,24 +267,24 @@ func PrepareMergedViewPullInfo(ctx *context.Context, issue *models.Issue) {
mergedCommit, err := ctx.Repo.GitRepo.GetCommit(pull.MergedCommitID)
if err != nil {
- ctx.Handle(500, "GetCommit", err)
+ ctx.ServerError("GetCommit", err)
return
}
// the ID of the last commit in the PR (not including the merge commit)
endCommitID, err := mergedCommit.ParentID(mergedCommit.ParentCount() - 1)
if err != nil {
- ctx.Handle(500, "ParentID", err)
+ ctx.ServerError("ParentID", err)
return
}
ctx.Data["NumCommits"], err = ctx.Repo.GitRepo.CommitsCountBetween(pull.MergeBase, endCommitID.String())
if err != nil {
- ctx.Handle(500, "Repo.GitRepo.CommitsCountBetween", err)
+ ctx.ServerError("Repo.GitRepo.CommitsCountBetween", err)
return
}
ctx.Data["NumFiles"], err = ctx.Repo.GitRepo.FilesCountBetween(pull.MergeBase, endCommitID.String())
if err != nil {
- ctx.Handle(500, "Repo.GitRepo.FilesCountBetween", err)
+ ctx.ServerError("Repo.GitRepo.FilesCountBetween", err)
return
}
}
@@ -296,7 +296,7 @@ func PrepareViewPullInfo(ctx *context.Context, issue *models.Issue) *git.PullReq
var err error
if err = pull.GetHeadRepo(); err != nil {
- ctx.Handle(500, "GetHeadRepo", err)
+ ctx.ServerError("GetHeadRepo", err)
return nil
}
@@ -306,7 +306,7 @@ func PrepareViewPullInfo(ctx *context.Context, issue *models.Issue) *git.PullReq
if pull.HeadRepo != nil {
headGitRepo, err = git.OpenRepository(pull.HeadRepo.RepoPath())
if err != nil {
- ctx.Handle(500, "OpenRepository", err)
+ ctx.ServerError("OpenRepository", err)
return nil
}
}
@@ -330,7 +330,7 @@ func PrepareViewPullInfo(ctx *context.Context, issue *models.Issue) *git.PullReq
return nil
}
- ctx.Handle(500, "GetPullRequestInfo", err)
+ ctx.ServerError("GetPullRequestInfo", err)
return nil
}
ctx.Data["NumCommits"] = prInfo.Commits.Len()
@@ -360,17 +360,17 @@ func ViewPullCommits(ctx *context.Context) {
mergedCommit, err := ctx.Repo.GitRepo.GetCommit(pull.MergedCommitID)
if err != nil {
- ctx.Handle(500, "Repo.GitRepo.GetCommit", err)
+ ctx.ServerError("Repo.GitRepo.GetCommit", err)
return
}
endCommitID, err := mergedCommit.ParentID(mergedCommit.ParentCount() - 1)
if err != nil {
- ctx.Handle(500, "ParentID", err)
+ ctx.ServerError("ParentID", err)
return
}
commits, err = ctx.Repo.GitRepo.CommitsBetweenIDs(endCommitID.String(), pull.MergeBase)
if err != nil {
- ctx.Handle(500, "Repo.GitRepo.CommitsBetweenIDs", err)
+ ctx.ServerError("Repo.GitRepo.CommitsBetweenIDs", err)
return
}
} else {
@@ -378,7 +378,7 @@ func ViewPullCommits(ctx *context.Context) {
if ctx.Written() {
return
} else if prInfo == nil {
- ctx.Handle(404, "ViewPullCommits", nil)
+ ctx.NotFound("ViewPullCommits", nil)
return
}
ctx.Data["Username"] = pull.HeadUserName
@@ -424,12 +424,12 @@ func ViewPullFiles(ctx *context.Context) {
startCommitID = pull.MergeBase
mergedCommit, err := ctx.Repo.GitRepo.GetCommit(pull.MergedCommitID)
if err != nil {
- ctx.Handle(500, "GetCommit", err)
+ ctx.ServerError("GetCommit", err)
return
}
endCommitSha, err := mergedCommit.ParentID(mergedCommit.ParentCount() - 1)
if err != nil {
- ctx.Handle(500, "ParentID", err)
+ ctx.ServerError("ParentID", err)
return
}
endCommitID = endCommitSha.String()
@@ -443,7 +443,7 @@ func ViewPullFiles(ctx *context.Context) {
if ctx.Written() {
return
} else if prInfo == nil {
- ctx.Handle(404, "ViewPullFiles", nil)
+ ctx.NotFound("ViewPullFiles", nil)
return
}
@@ -451,13 +451,13 @@ func ViewPullFiles(ctx *context.Context) {
headGitRepo, err := git.OpenRepository(headRepoPath)
if err != nil {
- ctx.Handle(500, "OpenRepository", err)
+ ctx.ServerError("OpenRepository", err)
return
}
headCommitID, err := headGitRepo.GetBranchCommitID(pull.HeadBranch)
if err != nil {
- ctx.Handle(500, "GetBranchCommitID", err)
+ ctx.ServerError("GetBranchCommitID", err)
return
}
@@ -475,7 +475,7 @@ func ViewPullFiles(ctx *context.Context) {
startCommitID, endCommitID, setting.Git.MaxGitDiffLines,
setting.Git.MaxGitDiffLineCharacters, setting.Git.MaxGitDiffFiles)
if err != nil {
- ctx.Handle(500, "GetDiffRange", err)
+ ctx.ServerError("GetDiffRange", err)
return
}
ctx.Data["Diff"] = diff
@@ -483,7 +483,7 @@ func ViewPullFiles(ctx *context.Context) {
commit, err := gitRepo.GetCommit(endCommitID)
if err != nil {
- ctx.Handle(500, "GetCommit", err)
+ ctx.ServerError("GetCommit", err)
return
}
@@ -503,23 +503,23 @@ func MergePullRequest(ctx *context.Context, form auth.MergePullRequestForm) {
return
}
if issue.IsClosed {
- ctx.Handle(404, "MergePullRequest", nil)
+ ctx.NotFound("MergePullRequest", nil)
return
}
pr, err := models.GetPullRequestByIssueID(issue.ID)
if err != nil {
if models.IsErrPullRequestNotExist(err) {
- ctx.Handle(404, "GetPullRequestByIssueID", nil)
+ ctx.NotFound("GetPullRequestByIssueID", nil)
} else {
- ctx.Handle(500, "GetPullRequestByIssueID", err)
+ ctx.ServerError("GetPullRequestByIssueID", err)
}
return
}
pr.Issue = issue
if !pr.CanAutoMerge() || pr.HasMerged {
- ctx.Handle(404, "MergePullRequest", nil)
+ ctx.NotFound("MergePullRequest", nil)
return
}
@@ -552,7 +552,7 @@ func MergePullRequest(ctx *context.Context, form auth.MergePullRequestForm) {
ctx.Redirect(ctx.Repo.RepoLink + "/pulls/" + com.ToStr(pr.Index))
return
}
- ctx.Handle(500, "Merge", err)
+ ctx.ServerError("Merge", err)
return
}
@@ -580,12 +580,12 @@ func ParseCompareInfo(ctx *context.Context) (*models.User, *models.Repository, *
)
infoPath, err = url.QueryUnescape(ctx.Params("*"))
if err != nil {
- ctx.Handle(404, "QueryUnescape", err)
+ ctx.NotFound("QueryUnescape", err)
}
infos := strings.Split(infoPath, "...")
if len(infos) != 2 {
log.Trace("ParseCompareInfo[%d]: not enough compared branches information %s", baseRepo.ID, infos)
- ctx.Handle(404, "CompareAndPullRequest", nil)
+ ctx.NotFound("CompareAndPullRequest", nil)
return nil, nil, nil, nil, "", ""
}
@@ -603,16 +603,16 @@ func ParseCompareInfo(ctx *context.Context) (*models.User, *models.Repository, *
headUser, err = models.GetUserByName(headInfos[0])
if err != nil {
if models.IsErrUserNotExist(err) {
- ctx.Handle(404, "GetUserByName", nil)
+ ctx.NotFound("GetUserByName", nil)
} else {
- ctx.Handle(500, "GetUserByName", err)
+ ctx.ServerError("GetUserByName", err)
}
return nil, nil, nil, nil, "", ""
}
headBranch = headInfos[1]
isSameRepo = headUser.ID == ctx.Repo.Owner.ID
} else {
- ctx.Handle(404, "CompareAndPullRequest", nil)
+ ctx.NotFound("CompareAndPullRequest", nil)
return nil, nil, nil, nil, "", ""
}
ctx.Data["HeadUser"] = headUser
@@ -621,7 +621,7 @@ func ParseCompareInfo(ctx *context.Context) (*models.User, *models.Repository, *
// Check if base branch is valid.
if !ctx.Repo.GitRepo.IsBranchExist(baseBranch) {
- ctx.Handle(404, "IsBranchExist", nil)
+ ctx.NotFound("IsBranchExist", nil)
return nil, nil, nil, nil, "", ""
}
@@ -629,7 +629,7 @@ func ParseCompareInfo(ctx *context.Context) (*models.User, *models.Repository, *
headRepo, has := models.HasForkedRepo(headUser.ID, baseRepo.ID)
if !has && !isSameRepo {
log.Trace("ParseCompareInfo[%d]: does not have fork or in same repository", baseRepo.ID)
- ctx.Handle(404, "ParseCompareInfo", nil)
+ ctx.NotFound("ParseCompareInfo", nil)
return nil, nil, nil, nil, "", ""
}
@@ -640,33 +640,33 @@ func ParseCompareInfo(ctx *context.Context) (*models.User, *models.Repository, *
} else {
headGitRepo, err = git.OpenRepository(models.RepoPath(headUser.Name, headRepo.Name))
if err != nil {
- ctx.Handle(500, "OpenRepository", err)
+ ctx.ServerError("OpenRepository", err)
return nil, nil, nil, nil, "", ""
}
}
if !ctx.User.IsWriterOfRepo(headRepo) && !ctx.User.IsAdmin {
log.Trace("ParseCompareInfo[%d]: does not have write access or site admin", baseRepo.ID)
- ctx.Handle(404, "ParseCompareInfo", nil)
+ ctx.NotFound("ParseCompareInfo", nil)
return nil, nil, nil, nil, "", ""
}
// Check if head branch is valid.
if !headGitRepo.IsBranchExist(headBranch) {
- ctx.Handle(404, "IsBranchExist", nil)
+ ctx.NotFound("IsBranchExist", nil)
return nil, nil, nil, nil, "", ""
}
headBranches, err := headGitRepo.GetBranches()
if err != nil {
- ctx.Handle(500, "GetBranches", err)
+ ctx.ServerError("GetBranches", err)
return nil, nil, nil, nil, "", ""
}
ctx.Data["HeadBranches"] = headBranches
prInfo, err := headGitRepo.GetPullRequestInfo(models.RepoPath(baseRepo.Owner.Name, baseRepo.Name), baseBranch, headBranch)
if err != nil {
- ctx.Handle(500, "GetPullRequestInfo", err)
+ ctx.ServerError("GetPullRequestInfo", err)
return nil, nil, nil, nil, "", ""
}
ctx.Data["BeforeCommitID"] = prInfo.MergeBase
@@ -693,7 +693,7 @@ func PrepareCompareDiff(
headCommitID, err := headGitRepo.GetBranchCommitID(headBranch)
if err != nil {
- ctx.Handle(500, "GetBranchCommitID", err)
+ ctx.ServerError("GetBranchCommitID", err)
return false
}
ctx.Data["AfterCommitID"] = headCommitID
@@ -707,7 +707,7 @@ func PrepareCompareDiff(
prInfo.MergeBase, headCommitID, setting.Git.MaxGitDiffLines,
setting.Git.MaxGitDiffLineCharacters, setting.Git.MaxGitDiffFiles)
if err != nil {
- ctx.Handle(500, "GetDiffRange", err)
+ ctx.ServerError("GetDiffRange", err)
return false
}
ctx.Data["Diff"] = diff
@@ -715,7 +715,7 @@ func PrepareCompareDiff(
headCommit, err := headGitRepo.GetCommit(headCommitID)
if err != nil {
- ctx.Handle(500, "GetCommit", err)
+ ctx.ServerError("GetCommit", err)
return false
}
@@ -753,7 +753,7 @@ func CompareAndPullRequest(ctx *context.Context) {
pr, err := models.GetUnmergedPullRequest(headRepo.ID, ctx.Repo.Repository.ID, headBranch, baseBranch)
if err != nil {
if !models.IsErrPullRequestNotExist(err) {
- ctx.Handle(500, "GetUnmergedPullRequest", err)
+ ctx.ServerError("GetUnmergedPullRequest", err)
return
}
} else {
@@ -822,7 +822,7 @@ func CompareAndPullRequestPost(ctx *context.Context, form auth.CreateIssueForm)
patch, err := headGitRepo.GetPatch(prInfo.MergeBase, headBranch)
if err != nil {
- ctx.Handle(500, "GetPatch", err)
+ ctx.ServerError("GetPatch", err)
return
}
@@ -851,10 +851,10 @@ func CompareAndPullRequestPost(ctx *context.Context, form auth.CreateIssueForm)
// FIXME: check error in the case two people send pull request at almost same time, give nice error prompt
// instead of 500.
if err := models.NewPullRequest(repo, pullIssue, labelIDs, attachments, pullRequest, patch); err != nil {
- ctx.Handle(500, "NewPullRequest", err)
+ ctx.ServerError("NewPullRequest", err)
return
} else if err := pullRequest.PushToBaseRepo(); err != nil {
- ctx.Handle(500, "PushToBaseRepo", err)
+ ctx.ServerError("PushToBaseRepo", err)
return
}
@@ -889,7 +889,7 @@ func TriggerTask(ctx *context.Context) {
if models.IsErrUserNotExist(err) {
ctx.Error(404)
} else {
- ctx.Handle(500, "GetUserByID", err)
+ ctx.ServerError("GetUserByID", err)
}
return
}
@@ -911,36 +911,36 @@ func CleanUpPullRequest(ctx *context.Context) {
pr, err := models.GetPullRequestByIssueID(issue.ID)
if err != nil {
if models.IsErrPullRequestNotExist(err) {
- ctx.Handle(404, "GetPullRequestByIssueID", nil)
+ ctx.NotFound("GetPullRequestByIssueID", nil)
} else {
- ctx.Handle(500, "GetPullRequestByIssueID", err)
+ ctx.ServerError("GetPullRequestByIssueID", err)
}
return
}
// Allow cleanup only for merged PR
if !pr.HasMerged {
- ctx.Handle(404, "CleanUpPullRequest", nil)
+ ctx.NotFound("CleanUpPullRequest", nil)
return
}
if err = pr.GetHeadRepo(); err != nil {
- ctx.Handle(500, "GetHeadRepo", err)
+ ctx.ServerError("GetHeadRepo", err)
return
} else if pr.HeadRepo == nil {
// Forked repository has already been deleted
- ctx.Handle(404, "CleanUpPullRequest", nil)
+ ctx.NotFound("CleanUpPullRequest", nil)
return
} else if pr.GetBaseRepo(); err != nil {
- ctx.Handle(500, "GetBaseRepo", err)
+ ctx.ServerError("GetBaseRepo", err)
return
} else if pr.HeadRepo.GetOwner(); err != nil {
- ctx.Handle(500, "HeadRepo.GetOwner", err)
+ ctx.ServerError("HeadRepo.GetOwner", err)
return
}
if !ctx.User.IsWriterOfRepo(pr.HeadRepo) {
- ctx.Handle(403, "CleanUpPullRequest", nil)
+ ctx.NotFound("CleanUpPullRequest", nil)
return
}
@@ -948,13 +948,13 @@ func CleanUpPullRequest(ctx *context.Context) {
gitRepo, err := git.OpenRepository(pr.HeadRepo.RepoPath())
if err != nil {
- ctx.Handle(500, fmt.Sprintf("OpenRepository[%s]", pr.HeadRepo.RepoPath()), err)
+ ctx.ServerError(fmt.Sprintf("OpenRepository[%s]", pr.HeadRepo.RepoPath()), err)
return
}
gitBaseRepo, err := git.OpenRepository(pr.BaseRepo.RepoPath())
if err != nil {
- ctx.Handle(500, fmt.Sprintf("OpenRepository[%s]", pr.BaseRepo.RepoPath()), err)
+ ctx.ServerError(fmt.Sprintf("OpenRepository[%s]", pr.BaseRepo.RepoPath()), err)
return
}
@@ -1033,16 +1033,16 @@ func DownloadPullDiff(ctx *context.Context) {
issue, err := models.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index"))
if err != nil {
if models.IsErrIssueNotExist(err) {
- ctx.Handle(404, "GetIssueByIndex", err)
+ ctx.NotFound("GetIssueByIndex", err)
} else {
- ctx.Handle(500, "GetIssueByIndex", err)
+ ctx.ServerError("GetIssueByIndex", err)
}
return
}
// Return not found if it's not a pull request
if !issue.IsPull {
- ctx.Handle(404, "DownloadPullDiff",
+ ctx.NotFound("DownloadPullDiff",
fmt.Errorf("Issue is not a pull request"))
return
}
@@ -1050,12 +1050,12 @@ func DownloadPullDiff(ctx *context.Context) {
pr := issue.PullRequest
if err = pr.GetBaseRepo(); err != nil {
- ctx.Handle(500, "GetBaseRepo", err)
+ ctx.ServerError("GetBaseRepo", err)
return
}
patch, err := pr.BaseRepo.PatchPath(pr.Index)
if err != nil {
- ctx.Handle(500, "PatchPath", err)
+ ctx.ServerError("PatchPath", err)
return
}
@@ -1067,16 +1067,16 @@ func DownloadPullPatch(ctx *context.Context) {
issue, err := models.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index"))
if err != nil {
if models.IsErrIssueNotExist(err) {
- ctx.Handle(404, "GetIssueByIndex", err)
+ ctx.NotFound("GetIssueByIndex", err)
} else {
- ctx.Handle(500, "GetIssueByIndex", err)
+ ctx.ServerError("GetIssueByIndex", err)
}
return
}
// Return not found if it's not a pull request
if !issue.IsPull {
- ctx.Handle(404, "DownloadPullDiff",
+ ctx.NotFound("DownloadPullDiff",
fmt.Errorf("Issue is not a pull request"))
return
}
@@ -1084,25 +1084,25 @@ func DownloadPullPatch(ctx *context.Context) {
pr := issue.PullRequest
if err = pr.GetHeadRepo(); err != nil {
- ctx.Handle(500, "GetHeadRepo", err)
+ ctx.ServerError("GetHeadRepo", err)
return
}
headGitRepo, err := git.OpenRepository(pr.HeadRepo.RepoPath())
if err != nil {
- ctx.Handle(500, "OpenRepository", err)
+ ctx.ServerError("OpenRepository", err)
return
}
patch, err := headGitRepo.GetFormatPatch(pr.MergeBase, pr.HeadBranch)
if err != nil {
- ctx.Handle(500, "GetFormatPatch", err)
+ ctx.ServerError("GetFormatPatch", err)
return
}
_, err = io.Copy(ctx, patch)
if err != nil {
- ctx.Handle(500, "io.Copy", err)
+ ctx.ServerError("io.Copy", err)
return
}
}
diff --git a/routers/repo/release.go b/routers/repo/release.go
index a1babbc295..a54576b91b 100644
--- a/routers/repo/release.go
+++ b/routers/repo/release.go
@@ -72,19 +72,19 @@ func Releases(ctx *context.Context) {
releases, err := models.GetReleasesByRepoID(ctx.Repo.Repository.ID, opts, page, limit)
if err != nil {
- ctx.Handle(500, "GetReleasesByRepoID", err)
+ ctx.ServerError("GetReleasesByRepoID", err)
return
}
count, err := models.GetReleaseCountByRepoID(ctx.Repo.Repository.ID, opts)
if err != nil {
- ctx.Handle(500, "GetReleaseCountByRepoID", err)
+ ctx.ServerError("GetReleaseCountByRepoID", err)
return
}
err = models.GetReleaseAttachments(releases...)
if err != nil {
- ctx.Handle(500, "GetReleaseAttachments", err)
+ ctx.ServerError("GetReleaseAttachments", err)
return
}
@@ -103,14 +103,14 @@ func Releases(ctx *context.Context) {
if models.IsErrUserNotExist(err) {
r.Publisher = models.NewGhostUser()
} else {
- ctx.Handle(500, "GetUserByID", err)
+ ctx.ServerError("GetUserByID", err)
return
}
}
cacheUsers[r.PublisherID] = r.Publisher
}
if err := calReleaseNumCommitsBehind(ctx.Repo, r, countCache); err != nil {
- ctx.Handle(500, "calReleaseNumCommitsBehind", err)
+ ctx.ServerError("calReleaseNumCommitsBehind", err)
return
}
r.Note = markdown.RenderString(r.Note, ctx.Repo.RepoLink, ctx.Repo.Repository.ComposeMetas())
@@ -154,7 +154,7 @@ func NewReleasePost(ctx *context.Context, form auth.NewReleaseForm) {
rel, err := models.GetRelease(ctx.Repo.Repository.ID, form.TagName)
if err != nil {
if !models.IsErrReleaseNotExist(err) {
- ctx.Handle(500, "GetRelease", err)
+ ctx.ServerError("GetRelease", err)
return
}
@@ -178,7 +178,7 @@ func NewReleasePost(ctx *context.Context, form auth.NewReleaseForm) {
case models.IsErrInvalidTagName(err):
ctx.RenderWithErr(ctx.Tr("repo.release.tag_name_invalid"), tplReleaseNew, &form)
default:
- ctx.Handle(500, "CreateRelease", err)
+ ctx.ServerError("CreateRelease", err)
}
return
}
@@ -199,7 +199,7 @@ func NewReleasePost(ctx *context.Context, form auth.NewReleaseForm) {
if err = models.UpdateRelease(ctx.Repo.GitRepo, rel, attachmentUUIDs); err != nil {
ctx.Data["Err_TagName"] = true
- ctx.Handle(500, "UpdateRelease", err)
+ ctx.ServerError("UpdateRelease", err)
return
}
}
@@ -219,9 +219,9 @@ func EditRelease(ctx *context.Context) {
rel, err := models.GetRelease(ctx.Repo.Repository.ID, tagName)
if err != nil {
if models.IsErrReleaseNotExist(err) {
- ctx.Handle(404, "GetRelease", err)
+ ctx.NotFound("GetRelease", err)
} else {
- ctx.Handle(500, "GetRelease", err)
+ ctx.ServerError("GetRelease", err)
}
return
}
@@ -246,14 +246,14 @@ func EditReleasePost(ctx *context.Context, form auth.EditReleaseForm) {
rel, err := models.GetRelease(ctx.Repo.Repository.ID, tagName)
if err != nil {
if models.IsErrReleaseNotExist(err) {
- ctx.Handle(404, "GetRelease", err)
+ ctx.NotFound("GetRelease", err)
} else {
- ctx.Handle(500, "GetRelease", err)
+ ctx.ServerError("GetRelease", err)
}
return
}
if rel.IsTag {
- ctx.Handle(404, "GetRelease", err)
+ ctx.NotFound("GetRelease", err)
return
}
ctx.Data["tag_name"] = rel.TagName
@@ -277,7 +277,7 @@ func EditReleasePost(ctx *context.Context, form auth.EditReleaseForm) {
rel.IsDraft = len(form.Draft) > 0
rel.IsPrerelease = form.Prerelease
if err = models.UpdateRelease(ctx.Repo.GitRepo, rel, attachmentUUIDs); err != nil {
- ctx.Handle(500, "UpdateRelease", err)
+ ctx.ServerError("UpdateRelease", err)
return
}
ctx.Redirect(ctx.Repo.RepoLink + "/releases")
diff --git a/routers/repo/repo.go b/routers/repo/repo.go
index 4cd7c8062c..20ea1e24a2 100644
--- a/routers/repo/repo.go
+++ b/routers/repo/repo.go
@@ -31,14 +31,14 @@ const (
// MustBeNotBare render when a repo is a bare git dir
func MustBeNotBare(ctx *context.Context) {
if ctx.Repo.Repository.IsBare {
- ctx.Handle(404, "MustBeNotBare", nil)
+ ctx.NotFound("MustBeNotBare", nil)
}
}
// MustBeEditable check that repo can be edited
func MustBeEditable(ctx *context.Context) {
if !ctx.Repo.Repository.CanEnableEditor() || ctx.Repo.IsViewCommit {
- ctx.Handle(404, "", nil)
+ ctx.NotFound("", nil)
return
}
}
@@ -46,14 +46,14 @@ func MustBeEditable(ctx *context.Context) {
// MustBeAbleToUpload check that repo can be uploaded to
func MustBeAbleToUpload(ctx *context.Context) {
if !setting.Repository.Upload.Enabled {
- ctx.Handle(404, "", nil)
+ ctx.NotFound("", nil)
}
}
func checkContextUser(ctx *context.Context, uid int64) *models.User {
orgs, err := models.GetOwnedOrgsByUserIDDesc(ctx.User.ID, "updated_unix")
if err != nil {
- ctx.Handle(500, "GetOwnedOrgsByUserIDDesc", err)
+ ctx.ServerError("GetOwnedOrgsByUserIDDesc", err)
return nil
}
ctx.Data["Orgs"] = orgs
@@ -69,7 +69,7 @@ func checkContextUser(ctx *context.Context, uid int64) *models.User {
}
if err != nil {
- ctx.Handle(500, "GetUserByID", fmt.Errorf("[%d]: %v", uid, err))
+ ctx.ServerError("GetUserByID", fmt.Errorf("[%d]: %v", uid, err))
return nil
}
@@ -81,7 +81,7 @@ func checkContextUser(ctx *context.Context, uid int64) *models.User {
if !ctx.User.IsAdmin {
isOwner, err := org.IsOwnedBy(ctx.User.ID)
if err != nil {
- ctx.Handle(500, "IsOwnedBy", err)
+ ctx.ServerError("IsOwnedBy", err)
return nil
} else if !isOwner {
ctx.Error(403)
@@ -143,7 +143,7 @@ func handleCreateError(ctx *context.Context, owner *models.User, err error, name
ctx.Data["Err_RepoName"] = true
ctx.RenderWithErr(ctx.Tr("repo.form.name_pattern_not_allowed", err.(models.ErrNamePatternNotAllowed).Pattern), tpl, form)
default:
- ctx.Handle(500, name, err)
+ ctx.ServerError(name, err)
}
}
@@ -235,10 +235,10 @@ func MigratePost(ctx *context.Context, form auth.MigrateRepoForm) {
case addrErr.IsInvalidPath:
ctx.RenderWithErr(ctx.Tr("repo.migrate.invalid_local_path"), tplMigrate, &form)
default:
- ctx.Handle(500, "Unknown error", err)
+ ctx.ServerError("Unknown error", err)
}
} else {
- ctx.Handle(500, "ParseRemoteAddr", err)
+ ctx.ServerError("ParseRemoteAddr", err)
}
return
}
@@ -303,7 +303,7 @@ func Action(ctx *context.Context) {
}
if err != nil {
- ctx.Handle(500, fmt.Sprintf("Action (%s)", ctx.Params(":action")), err)
+ ctx.ServerError(fmt.Sprintf("Action (%s)", ctx.Params(":action")), err)
return
}
@@ -342,7 +342,7 @@ func Download(ctx *context.Context) {
if !com.IsDir(archivePath) {
if err := os.MkdirAll(archivePath, os.ModePerm); err != nil {
- ctx.Handle(500, "Download -> os.MkdirAll(archivePath)", err)
+ ctx.ServerError("Download -> os.MkdirAll(archivePath)", err)
return
}
}
@@ -356,30 +356,30 @@ func Download(ctx *context.Context) {
if gitRepo.IsBranchExist(refName) {
commit, err = gitRepo.GetBranchCommit(refName)
if err != nil {
- ctx.Handle(500, "GetBranchCommit", err)
+ ctx.ServerError("GetBranchCommit", err)
return
}
} else if gitRepo.IsTagExist(refName) {
commit, err = gitRepo.GetTagCommit(refName)
if err != nil {
- ctx.Handle(500, "GetTagCommit", err)
+ ctx.ServerError("GetTagCommit", err)
return
}
} else if len(refName) >= 4 && len(refName) <= 40 {
commit, err = gitRepo.GetCommit(refName)
if err != nil {
- ctx.Handle(404, "GetCommit", nil)
+ ctx.NotFound("GetCommit", nil)
return
}
} else {
- ctx.Handle(404, "Download", nil)
+ ctx.NotFound("Download", nil)
return
}
archivePath = path.Join(archivePath, base.ShortSha(commit.ID.String())+ext)
if !com.IsFile(archivePath) {
if err := commit.CreateArchive(archivePath, archiveType); err != nil {
- ctx.Handle(500, "Download -> CreateArchive "+archivePath, err)
+ ctx.ServerError("Download -> CreateArchive "+archivePath, err)
return
}
}
diff --git a/routers/repo/search.go b/routers/repo/search.go
index bf260ac8e4..ed209f2ddc 100644
--- a/routers/repo/search.go
+++ b/routers/repo/search.go
@@ -31,7 +31,7 @@ func Search(ctx *context.Context) {
}
total, searchResults, err := search.PerformSearch(ctx.Repo.Repository.ID, keyword, page, setting.UI.RepoSearchPagingNum)
if err != nil {
- ctx.Handle(500, "SearchResults", err)
+ ctx.ServerError("SearchResults", err)
return
}
ctx.Data["Keyword"] = keyword
diff --git a/routers/repo/setting.go b/routers/repo/setting.go
index d7a61ba268..6986658b75 100644
--- a/routers/repo/setting.go
+++ b/routers/repo/setting.go
@@ -67,14 +67,14 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
case models.IsErrNamePatternNotAllowed(err):
ctx.RenderWithErr(ctx.Tr("repo.form.name_pattern_not_allowed", err.(models.ErrNamePatternNotAllowed).Pattern), tplSettingsOptions, &form)
default:
- ctx.Handle(500, "ChangeRepositoryName", err)
+ ctx.ServerError("ChangeRepositoryName", err)
}
return
}
err := models.NewRepoRedirect(ctx.Repo.Owner.ID, repo.ID, repo.Name, newRepoName)
if err != nil {
- ctx.Handle(500, "NewRepoRedirect", err)
+ ctx.ServerError("NewRepoRedirect", err)
return
}
@@ -94,7 +94,7 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
visibilityChanged := repo.IsPrivate != form.Private
repo.IsPrivate = form.Private
if err := models.UpdateRepository(repo, visibilityChanged); err != nil {
- ctx.Handle(500, "UpdateRepository", err)
+ ctx.ServerError("UpdateRepository", err)
return
}
log.Trace("Repository basic settings updated: %s/%s", ctx.Repo.Owner.Name, repo.Name)
@@ -110,7 +110,7 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
case "mirror":
if !repo.IsMirror {
- ctx.Handle(404, "", nil)
+ ctx.NotFound("", nil)
return
}
@@ -127,7 +127,7 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
}
}
if err := ctx.Repo.Mirror.SaveAddress(form.MirrorAddress); err != nil {
- ctx.Handle(500, "SaveAddress", err)
+ ctx.ServerError("SaveAddress", err)
return
}
@@ -136,7 +136,7 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
case "mirror-sync":
if !repo.IsMirror {
- ctx.Handle(404, "", nil)
+ ctx.NotFound("", nil)
return
}
@@ -221,7 +221,7 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
}
if err := models.UpdateRepositoryUnits(repo, units); err != nil {
- ctx.Handle(500, "UpdateRepositoryUnits", err)
+ ctx.ServerError("UpdateRepositoryUnits", err)
return
}
log.Trace("Repository advanced settings updated: %s/%s", ctx.Repo.Owner.Name, repo.Name)
@@ -246,10 +246,10 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
repo.IsMirror = false
if _, err := models.CleanUpMigrateInfo(repo); err != nil {
- ctx.Handle(500, "CleanUpMigrateInfo", err)
+ ctx.ServerError("CleanUpMigrateInfo", err)
return
} else if err = models.DeleteMirrorByRepoID(ctx.Repo.Repository.ID); err != nil {
- ctx.Handle(500, "DeleteMirrorByRepoID", err)
+ ctx.ServerError("DeleteMirrorByRepoID", err)
return
}
log.Trace("Repository converted from mirror to regular: %s/%s", ctx.Repo.Owner.Name, repo.Name)
@@ -269,7 +269,7 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
newOwner := ctx.Query("new_owner_name")
isExist, err := models.IsUserExist(0, newOwner)
if err != nil {
- ctx.Handle(500, "IsUserExist", err)
+ ctx.ServerError("IsUserExist", err)
return
} else if !isExist {
ctx.RenderWithErr(ctx.Tr("form.enterred_invalid_owner_name"), tplSettingsOptions, nil)
@@ -280,7 +280,7 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
if models.IsErrRepoAlreadyExist(err) {
ctx.RenderWithErr(ctx.Tr("repo.settings.new_owner_has_same_repo"), tplSettingsOptions, nil)
} else {
- ctx.Handle(500, "TransferOwnership", err)
+ ctx.ServerError("TransferOwnership", err)
}
return
}
@@ -299,7 +299,7 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
}
if err := models.DeleteRepository(ctx.User, ctx.Repo.Owner.ID, repo.ID); err != nil {
- ctx.Handle(500, "DeleteRepository", err)
+ ctx.ServerError("DeleteRepository", err)
return
}
log.Trace("Repository deleted: %s/%s", ctx.Repo.Owner.Name, repo.Name)
@@ -324,7 +324,7 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
ctx.Redirect(ctx.Repo.RepoLink + "/settings")
default:
- ctx.Handle(404, "", nil)
+ ctx.NotFound("", nil)
}
}
@@ -335,7 +335,7 @@ func Collaboration(ctx *context.Context) {
users, err := ctx.Repo.Repository.GetCollaborators()
if err != nil {
- ctx.Handle(500, "GetCollaborators", err)
+ ctx.ServerError("GetCollaborators", err)
return
}
ctx.Data["Collaborators"] = users
@@ -357,7 +357,7 @@ func CollaborationPost(ctx *context.Context) {
ctx.Flash.Error(ctx.Tr("form.user_not_exist"))
ctx.Redirect(setting.AppSubURL + ctx.Req.URL.Path)
} else {
- ctx.Handle(500, "GetUserByName", err)
+ ctx.ServerError("GetUserByName", err)
}
return
}
@@ -373,7 +373,7 @@ func CollaborationPost(ctx *context.Context) {
if ctx.Repo.Owner.IsOrganization() {
isMember, err := ctx.Repo.Owner.IsOrgMember(u.ID)
if err != nil {
- ctx.Handle(500, "IsOrgMember", err)
+ ctx.ServerError("IsOrgMember", err)
return
} else if isMember {
ctx.Flash.Info(ctx.Tr("repo.settings.user_is_org_member"))
@@ -383,7 +383,7 @@ func CollaborationPost(ctx *context.Context) {
}
if err = ctx.Repo.Repository.AddCollaborator(u); err != nil {
- ctx.Handle(500, "AddCollaborator", err)
+ ctx.ServerError("AddCollaborator", err)
return
}
@@ -422,9 +422,9 @@ func parseOwnerAndRepo(ctx *context.Context) (*models.User, *models.Repository)
owner, err := models.GetUserByName(ctx.Params(":username"))
if err != nil {
if models.IsErrUserNotExist(err) {
- ctx.Handle(404, "GetUserByName", err)
+ ctx.NotFound("GetUserByName", err)
} else {
- ctx.Handle(500, "GetUserByName", err)
+ ctx.ServerError("GetUserByName", err)
}
return nil, nil
}
@@ -432,9 +432,9 @@ func parseOwnerAndRepo(ctx *context.Context) (*models.User, *models.Repository)
repo, err := models.GetRepositoryByName(owner.ID, ctx.Params(":reponame"))
if err != nil {
if models.IsErrRepoNotExist(err) {
- ctx.Handle(404, "GetRepositoryByName", err)
+ ctx.NotFound("GetRepositoryByName", err)
} else {
- ctx.Handle(500, "GetRepositoryByName", err)
+ ctx.ServerError("GetRepositoryByName", err)
}
return nil, nil
}
@@ -449,7 +449,7 @@ func GitHooks(ctx *context.Context) {
hooks, err := ctx.Repo.GitRepo.Hooks()
if err != nil {
- ctx.Handle(500, "Hooks", err)
+ ctx.ServerError("Hooks", err)
return
}
ctx.Data["Hooks"] = hooks
@@ -466,9 +466,9 @@ func GitHooksEdit(ctx *context.Context) {
hook, err := ctx.Repo.GitRepo.GetHook(name)
if err != nil {
if err == git.ErrNotValidHook {
- ctx.Handle(404, "GetHook", err)
+ ctx.NotFound("GetHook", err)
} else {
- ctx.Handle(500, "GetHook", err)
+ ctx.ServerError("GetHook", err)
}
return
}
@@ -482,15 +482,15 @@ func GitHooksEditPost(ctx *context.Context) {
hook, err := ctx.Repo.GitRepo.GetHook(name)
if err != nil {
if err == git.ErrNotValidHook {
- ctx.Handle(404, "GetHook", err)
+ ctx.NotFound("GetHook", err)
} else {
- ctx.Handle(500, "GetHook", err)
+ ctx.ServerError("GetHook", err)
}
return
}
hook.Content = ctx.Query("content")
if err = hook.Update(); err != nil {
- ctx.Handle(500, "hook.Update", err)
+ ctx.ServerError("hook.Update", err)
return
}
ctx.Redirect(ctx.Repo.RepoLink + "/settings/hooks/git")
@@ -504,7 +504,7 @@ func DeployKeys(ctx *context.Context) {
keys, err := models.ListDeployKeys(ctx.Repo.Repository.ID)
if err != nil {
- ctx.Handle(500, "ListDeployKeys", err)
+ ctx.ServerError("ListDeployKeys", err)
return
}
ctx.Data["Deploykeys"] = keys
@@ -519,7 +519,7 @@ func DeployKeysPost(ctx *context.Context, form auth.AddKeyForm) {
keys, err := models.ListDeployKeys(ctx.Repo.Repository.ID)
if err != nil {
- ctx.Handle(500, "ListDeployKeys", err)
+ ctx.ServerError("ListDeployKeys", err)
return
}
ctx.Data["Deploykeys"] = keys
@@ -555,7 +555,7 @@ func DeployKeysPost(ctx *context.Context, form auth.AddKeyForm) {
ctx.Data["Err_Title"] = true
ctx.RenderWithErr(ctx.Tr("repo.settings.key_name_used"), tplDeployKeys, &form)
default:
- ctx.Handle(500, "AddDeployKey", err)
+ ctx.ServerError("AddDeployKey", err)
}
return
}
diff --git a/routers/repo/setting_protected_branch.go b/routers/repo/setting_protected_branch.go
index 7ab8ca218e..b8ff6d6ecd 100644
--- a/routers/repo/setting_protected_branch.go
+++ b/routers/repo/setting_protected_branch.go
@@ -24,7 +24,7 @@ func ProtectedBranch(ctx *context.Context) {
protectedBranches, err := ctx.Repo.Repository.GetProtectedBranches()
if err != nil {
- ctx.Handle(500, "GetProtectedBranches", err)
+ ctx.ServerError("GetProtectedBranches", err)
return
}
ctx.Data["ProtectedBranches"] = protectedBranches
@@ -71,12 +71,12 @@ func ProtectedBranchPost(ctx *context.Context) {
repo.DefaultBranch = branch
if err := ctx.Repo.GitRepo.SetDefaultBranch(branch); err != nil {
if !git.IsErrUnsupportedVersion(err) {
- ctx.Handle(500, "SetDefaultBranch", err)
+ ctx.ServerError("SetDefaultBranch", err)
return
}
}
if err := repo.UpdateDefaultBranch(); err != nil {
- ctx.Handle(500, "SetDefaultBranch", err)
+ ctx.ServerError("SetDefaultBranch", err)
return
}
}
@@ -86,7 +86,7 @@ func ProtectedBranchPost(ctx *context.Context) {
ctx.Flash.Success(ctx.Tr("repo.settings.update_settings_success"))
ctx.Redirect(setting.AppSubURL + ctx.Req.URL.Path)
default:
- ctx.Handle(404, "", nil)
+ ctx.NotFound("", nil)
}
}
@@ -94,7 +94,7 @@ func ProtectedBranchPost(ctx *context.Context) {
func SettingsProtectedBranch(c *context.Context) {
branch := c.Params("*")
if !c.Repo.GitRepo.IsBranchExist(branch) {
- c.NotFound()
+ c.NotFound("IsBranchExist", nil)
return
}
@@ -104,7 +104,7 @@ func SettingsProtectedBranch(c *context.Context) {
protectBranch, err := models.GetProtectedBranchBy(c.Repo.Repository.ID, branch)
if err != nil {
if !models.IsErrBranchNotExist(err) {
- c.Handle(500, "GetProtectBranchOfRepoByName", err)
+ c.ServerError("GetProtectBranchOfRepoByName", err)
return
}
}
@@ -118,7 +118,7 @@ func SettingsProtectedBranch(c *context.Context) {
users, err := c.Repo.Repository.GetWriters()
if err != nil {
- c.Handle(500, "Repo.Repository.GetWriters", err)
+ c.ServerError("Repo.Repository.GetWriters", err)
return
}
c.Data["Users"] = users
@@ -127,7 +127,7 @@ func SettingsProtectedBranch(c *context.Context) {
if c.Repo.Owner.IsOrganization() {
teams, err := c.Repo.Owner.TeamsWithAccessToRepo(c.Repo.Repository.ID, models.AccessModeWrite)
if err != nil {
- c.Handle(500, "Repo.Owner.TeamsWithAccessToRepo", err)
+ c.ServerError("Repo.Owner.TeamsWithAccessToRepo", err)
return
}
c.Data["Teams"] = teams
@@ -142,14 +142,14 @@ func SettingsProtectedBranch(c *context.Context) {
func SettingsProtectedBranchPost(ctx *context.Context, f auth.ProtectBranchForm) {
branch := ctx.Params("*")
if !ctx.Repo.GitRepo.IsBranchExist(branch) {
- ctx.NotFound()
+ ctx.NotFound("IsBranchExist", nil)
return
}
protectBranch, err := models.GetProtectedBranchBy(ctx.Repo.Repository.ID, branch)
if err != nil {
if !models.IsErrBranchNotExist(err) {
- ctx.Handle(500, "GetProtectBranchOfRepoByName", err)
+ ctx.ServerError("GetProtectBranchOfRepoByName", err)
return
}
}
@@ -168,7 +168,7 @@ func SettingsProtectedBranchPost(ctx *context.Context, f auth.ProtectBranchForm)
whitelistTeams, _ := base.StringsToInt64s(strings.Split(f.WhitelistTeams, ","))
err = models.UpdateProtectBranch(ctx.Repo.Repository, protectBranch, whitelistUsers, whitelistTeams)
if err != nil {
- ctx.Handle(500, "UpdateProtectBranch", err)
+ ctx.ServerError("UpdateProtectBranch", err)
return
}
ctx.Flash.Success(ctx.Tr("repo.settings.update_protect_branch_success", branch))
@@ -176,7 +176,7 @@ func SettingsProtectedBranchPost(ctx *context.Context, f auth.ProtectBranchForm)
} else {
if protectBranch != nil {
if err := ctx.Repo.Repository.DeleteProtectedBranch(protectBranch.ID); err != nil {
- ctx.Handle(500, "DeleteProtectedBranch", err)
+ ctx.ServerError("DeleteProtectedBranch", err)
return
}
}
diff --git a/routers/repo/view.go b/routers/repo/view.go
index 512af27fc4..685dd411d6 100644
--- a/routers/repo/view.go
+++ b/routers/repo/view.go
@@ -44,14 +44,14 @@ func renderDirectory(ctx *context.Context, treeLink string) {
entries, err := tree.ListEntries()
if err != nil {
- ctx.Handle(500, "ListEntries", err)
+ ctx.ServerError("ListEntries", err)
return
}
entries.CustomSort(base.NaturalSortLess)
ctx.Data["Files"], err = entries.GetCommitsInfo(ctx.Repo.Commit, ctx.Repo.TreePath)
if err != nil {
- ctx.Handle(500, "GetCommitsInfo", err)
+ ctx.ServerError("GetCommitsInfo", err)
return
}
@@ -78,7 +78,7 @@ func renderDirectory(ctx *context.Context, treeLink string) {
dataRc, err := readmeFile.DataAsync()
if err != nil {
- ctx.Handle(500, "Data", err)
+ ctx.ServerError("Data", err)
return
}
defer dataRc.Close()
@@ -117,7 +117,7 @@ func renderDirectory(ctx *context.Context, treeLink string) {
if len(ctx.Repo.TreePath) > 0 {
latestCommit, err = ctx.Repo.Commit.GetCommitByPath(ctx.Repo.TreePath)
if err != nil {
- ctx.Handle(500, "GetCommitByPath", err)
+ ctx.ServerError("GetCommitByPath", err)
return
}
}
@@ -145,7 +145,7 @@ func renderFile(ctx *context.Context, entry *git.TreeEntry, treeLink, rawLink st
blob := entry.Blob()
dataRc, err := blob.DataAsync()
if err != nil {
- ctx.Handle(500, "DataAsync", err)
+ ctx.ServerError("DataAsync", err)
return
}
defer dataRc.Close()
@@ -288,7 +288,7 @@ func Home(ctx *context.Context) {
}
}
- ctx.Handle(404, "Home", fmt.Errorf(ctx.Tr("units.error.no_unit_allowed_repo")))
+ ctx.NotFound("Home", fmt.Errorf(ctx.Tr("units.error.no_unit_allowed_repo")))
}
func renderCode(ctx *context.Context) {
@@ -362,7 +362,7 @@ func RenderUserCards(ctx *context.Context, total int, getter func(page int) ([]*
items, err := getter(pager.Current())
if err != nil {
- ctx.Handle(500, "getter", err)
+ ctx.ServerError("getter", err)
return
}
ctx.Data["Cards"] = items
@@ -392,13 +392,13 @@ func Forks(ctx *context.Context) {
forks, err := ctx.Repo.Repository.GetForks()
if err != nil {
- ctx.Handle(500, "GetForks", err)
+ ctx.ServerError("GetForks", err)
return
}
for _, fork := range forks {
if err = fork.GetOwner(); err != nil {
- ctx.Handle(500, "GetOwner", err)
+ ctx.ServerError("GetOwner", err)
return
}
}
diff --git a/routers/repo/webhook.go b/routers/repo/webhook.go
index 8fdc32849d..35fdf796b5 100644
--- a/routers/repo/webhook.go
+++ b/routers/repo/webhook.go
@@ -37,7 +37,7 @@ func Webhooks(ctx *context.Context) {
ws, err := models.GetWebhooksByRepoID(ctx.Repo.Repository.ID)
if err != nil {
- ctx.Handle(500, "GetWebhooksByRepoID", err)
+ ctx.ServerError("GetWebhooksByRepoID", err)
return
}
ctx.Data["Webhooks"] = ws
@@ -76,7 +76,7 @@ func getOrgRepoCtx(ctx *context.Context) (*orgRepoCtx, error) {
func checkHookType(ctx *context.Context) string {
hookType := strings.ToLower(ctx.Params(":type"))
if !com.IsSliceContainsStr(setting.Webhook.Types, hookType) {
- ctx.Handle(404, "checkHookType", nil)
+ ctx.NotFound("checkHookType", nil)
return ""
}
return hookType
@@ -91,7 +91,7 @@ func WebhooksNew(ctx *context.Context) {
orCtx, err := getOrgRepoCtx(ctx)
if err != nil {
- ctx.Handle(500, "getOrgRepoCtx", err)
+ ctx.ServerError("getOrgRepoCtx", err)
return
}
@@ -136,7 +136,7 @@ func WebHooksNewPost(ctx *context.Context, form auth.NewWebhookForm) {
orCtx, err := getOrgRepoCtx(ctx)
if err != nil {
- ctx.Handle(500, "getOrgRepoCtx", err)
+ ctx.ServerError("getOrgRepoCtx", err)
return
}
ctx.Data["BaseLink"] = orCtx.Link
@@ -162,10 +162,10 @@ func WebHooksNewPost(ctx *context.Context, form auth.NewWebhookForm) {
OrgID: orCtx.OrgID,
}
if err := w.UpdateEvent(); err != nil {
- ctx.Handle(500, "UpdateEvent", err)
+ ctx.ServerError("UpdateEvent", err)
return
} else if err := models.CreateWebhook(w); err != nil {
- ctx.Handle(500, "CreateWebhook", err)
+ ctx.ServerError("CreateWebhook", err)
return
}
@@ -183,7 +183,7 @@ func GogsHooksNewPost(ctx *context.Context, form auth.NewGogshookForm) {
orCtx, err := getOrgRepoCtx(ctx)
if err != nil {
- ctx.Handle(500, "getOrgRepoCtx", err)
+ ctx.ServerError("getOrgRepoCtx", err)
return
}
ctx.Data["BaseLink"] = orCtx.Link
@@ -209,10 +209,10 @@ func GogsHooksNewPost(ctx *context.Context, form auth.NewGogshookForm) {
OrgID: orCtx.OrgID,
}
if err := w.UpdateEvent(); err != nil {
- ctx.Handle(500, "UpdateEvent", err)
+ ctx.ServerError("UpdateEvent", err)
return
} else if err := models.CreateWebhook(w); err != nil {
- ctx.Handle(500, "CreateWebhook", err)
+ ctx.ServerError("CreateWebhook", err)
return
}
@@ -229,7 +229,7 @@ func DiscordHooksNewPost(ctx *context.Context, form auth.NewDiscordHookForm) {
orCtx, err := getOrgRepoCtx(ctx)
if err != nil {
- ctx.Handle(500, "getOrgRepoCtx", err)
+ ctx.ServerError("getOrgRepoCtx", err)
return
}
@@ -243,7 +243,7 @@ func DiscordHooksNewPost(ctx *context.Context, form auth.NewDiscordHookForm) {
IconURL: form.IconURL,
})
if err != nil {
- ctx.Handle(500, "Marshal", err)
+ ctx.ServerError("Marshal", err)
return
}
@@ -258,10 +258,10 @@ func DiscordHooksNewPost(ctx *context.Context, form auth.NewDiscordHookForm) {
OrgID: orCtx.OrgID,
}
if err := w.UpdateEvent(); err != nil {
- ctx.Handle(500, "UpdateEvent", err)
+ ctx.ServerError("UpdateEvent", err)
return
} else if err := models.CreateWebhook(w); err != nil {
- ctx.Handle(500, "CreateWebhook", err)
+ ctx.ServerError("CreateWebhook", err)
return
}
@@ -278,7 +278,7 @@ func DingtalkHooksNewPost(ctx *context.Context, form auth.NewDingtalkHookForm) {
orCtx, err := getOrgRepoCtx(ctx)
if err != nil {
- ctx.Handle(500, "getOrgRepoCtx", err)
+ ctx.ServerError("getOrgRepoCtx", err)
return
}
@@ -298,10 +298,10 @@ func DingtalkHooksNewPost(ctx *context.Context, form auth.NewDingtalkHookForm) {
OrgID: orCtx.OrgID,
}
if err := w.UpdateEvent(); err != nil {
- ctx.Handle(500, "UpdateEvent", err)
+ ctx.ServerError("UpdateEvent", err)
return
} else if err := models.CreateWebhook(w); err != nil {
- ctx.Handle(500, "CreateWebhook", err)
+ ctx.ServerError("CreateWebhook", err)
return
}
@@ -318,7 +318,7 @@ func SlackHooksNewPost(ctx *context.Context, form auth.NewSlackHookForm) {
orCtx, err := getOrgRepoCtx(ctx)
if err != nil {
- ctx.Handle(500, "getOrgRepoCtx", err)
+ ctx.ServerError("getOrgRepoCtx", err)
return
}
@@ -334,7 +334,7 @@ func SlackHooksNewPost(ctx *context.Context, form auth.NewSlackHookForm) {
Color: form.Color,
})
if err != nil {
- ctx.Handle(500, "Marshal", err)
+ ctx.ServerError("Marshal", err)
return
}
@@ -349,10 +349,10 @@ func SlackHooksNewPost(ctx *context.Context, form auth.NewSlackHookForm) {
OrgID: orCtx.OrgID,
}
if err := w.UpdateEvent(); err != nil {
- ctx.Handle(500, "UpdateEvent", err)
+ ctx.ServerError("UpdateEvent", err)
return
} else if err := models.CreateWebhook(w); err != nil {
- ctx.Handle(500, "CreateWebhook", err)
+ ctx.ServerError("CreateWebhook", err)
return
}
@@ -365,7 +365,7 @@ func checkWebhook(ctx *context.Context) (*orgRepoCtx, *models.Webhook) {
orCtx, err := getOrgRepoCtx(ctx)
if err != nil {
- ctx.Handle(500, "getOrgRepoCtx", err)
+ ctx.ServerError("getOrgRepoCtx", err)
return nil, nil
}
ctx.Data["BaseLink"] = orCtx.Link
@@ -378,9 +378,9 @@ func checkWebhook(ctx *context.Context) (*orgRepoCtx, *models.Webhook) {
}
if err != nil {
if models.IsErrWebhookNotExist(err) {
- ctx.Handle(404, "GetWebhookByID", nil)
+ ctx.NotFound("GetWebhookByID", nil)
} else {
- ctx.Handle(500, "GetWebhookByID", err)
+ ctx.ServerError("GetWebhookByID", err)
}
return nil, nil
}
@@ -395,7 +395,7 @@ func checkWebhook(ctx *context.Context) (*orgRepoCtx, *models.Webhook) {
ctx.Data["History"], err = w.History(1)
if err != nil {
- ctx.Handle(500, "History", err)
+ ctx.ServerError("History", err)
}
return orCtx, w
}
@@ -443,10 +443,10 @@ func WebHooksEditPost(ctx *context.Context, form auth.NewWebhookForm) {
w.HookEvent = ParseHookEvent(form.WebhookForm)
w.IsActive = form.Active
if err := w.UpdateEvent(); err != nil {
- ctx.Handle(500, "UpdateEvent", err)
+ ctx.ServerError("UpdateEvent", err)
return
} else if err := models.UpdateWebhook(w); err != nil {
- ctx.Handle(500, "WebHooksEditPost", err)
+ ctx.ServerError("WebHooksEditPost", err)
return
}
@@ -482,10 +482,10 @@ func GogsHooksEditPost(ctx *context.Context, form auth.NewGogshookForm) {
w.HookEvent = ParseHookEvent(form.WebhookForm)
w.IsActive = form.Active
if err := w.UpdateEvent(); err != nil {
- ctx.Handle(500, "UpdateEvent", err)
+ ctx.ServerError("UpdateEvent", err)
return
} else if err := models.UpdateWebhook(w); err != nil {
- ctx.Handle(500, "GogsHooksEditPost", err)
+ ctx.ServerError("GogsHooksEditPost", err)
return
}
@@ -517,7 +517,7 @@ func SlackHooksEditPost(ctx *context.Context, form auth.NewSlackHookForm) {
Color: form.Color,
})
if err != nil {
- ctx.Handle(500, "Marshal", err)
+ ctx.ServerError("Marshal", err)
return
}
@@ -526,10 +526,10 @@ func SlackHooksEditPost(ctx *context.Context, form auth.NewSlackHookForm) {
w.HookEvent = ParseHookEvent(form.WebhookForm)
w.IsActive = form.Active
if err := w.UpdateEvent(); err != nil {
- ctx.Handle(500, "UpdateEvent", err)
+ ctx.ServerError("UpdateEvent", err)
return
} else if err := models.UpdateWebhook(w); err != nil {
- ctx.Handle(500, "UpdateWebhook", err)
+ ctx.ServerError("UpdateWebhook", err)
return
}
@@ -559,7 +559,7 @@ func DiscordHooksEditPost(ctx *context.Context, form auth.NewDiscordHookForm) {
IconURL: form.IconURL,
})
if err != nil {
- ctx.Handle(500, "Marshal", err)
+ ctx.ServerError("Marshal", err)
return
}
@@ -568,10 +568,10 @@ func DiscordHooksEditPost(ctx *context.Context, form auth.NewDiscordHookForm) {
w.HookEvent = ParseHookEvent(form.WebhookForm)
w.IsActive = form.Active
if err := w.UpdateEvent(); err != nil {
- ctx.Handle(500, "UpdateEvent", err)
+ ctx.ServerError("UpdateEvent", err)
return
} else if err := models.UpdateWebhook(w); err != nil {
- ctx.Handle(500, "UpdateWebhook", err)
+ ctx.ServerError("UpdateWebhook", err)
return
}
@@ -600,10 +600,10 @@ func DingtalkHooksEditPost(ctx *context.Context, form auth.NewDingtalkHookForm)
w.HookEvent = ParseHookEvent(form.WebhookForm)
w.IsActive = form.Active
if err := w.UpdateEvent(); err != nil {
- ctx.Handle(500, "UpdateEvent", err)
+ ctx.ServerError("UpdateEvent", err)
return
} else if err := models.UpdateWebhook(w); err != nil {
- ctx.Handle(500, "UpdateWebhook", err)
+ ctx.ServerError("UpdateWebhook", err)
return
}
diff --git a/routers/repo/wiki.go b/routers/repo/wiki.go
index 8aa9ed8df7..7befe7c687 100644
--- a/routers/repo/wiki.go
+++ b/routers/repo/wiki.go
@@ -32,7 +32,7 @@ const (
func MustEnableWiki(ctx *context.Context) {
if !ctx.Repo.Repository.UnitEnabled(models.UnitTypeWiki) &&
!ctx.Repo.Repository.UnitEnabled(models.UnitTypeExternalWiki) {
- ctx.Handle(404, "MustEnableWiki", nil)
+ ctx.NotFound("MustEnableWiki", nil)
return
}
@@ -67,13 +67,13 @@ func findEntryForFile(commit *git.Commit, target string) (*git.TreeEntry, error)
func findWikiRepoCommit(ctx *context.Context) (*git.Repository, *git.Commit, error) {
wikiRepo, err := git.OpenRepository(ctx.Repo.Repository.WikiPath())
if err != nil {
- ctx.Handle(500, "OpenRepository", err)
+ ctx.ServerError("OpenRepository", err)
return nil, nil, err
}
commit, err := wikiRepo.GetBranchCommit("master")
if err != nil {
- ctx.Handle(500, "GetBranchCommit", err)
+ ctx.ServerError("GetBranchCommit", err)
return wikiRepo, nil, err
}
return wikiRepo, commit, nil
@@ -84,12 +84,12 @@ func findWikiRepoCommit(ctx *context.Context) (*git.Repository, *git.Commit, err
func wikiContentsByEntry(ctx *context.Context, entry *git.TreeEntry) []byte {
reader, err := entry.Blob().Data()
if err != nil {
- ctx.Handle(500, "Blob.Data", err)
+ ctx.ServerError("Blob.Data", err)
return nil
}
content, err := ioutil.ReadAll(reader)
if err != nil {
- ctx.Handle(500, "ReadAll", err)
+ ctx.ServerError("ReadAll", err)
return nil
}
return content
@@ -100,7 +100,7 @@ func wikiContentsByEntry(ctx *context.Context, entry *git.TreeEntry) []byte {
func wikiContentsByName(ctx *context.Context, commit *git.Commit, wikiName string) ([]byte, bool) {
entry, err := findEntryForFile(commit, models.WikiNameToFilename(wikiName))
if err != nil {
- ctx.Handle(500, "findEntryForFile", err)
+ ctx.ServerError("findEntryForFile", err)
return nil, false
} else if entry == nil {
return nil, false
@@ -118,7 +118,7 @@ func renderWikiPage(ctx *context.Context, isViewPage bool) (*git.Repository, *gi
if isViewPage {
entries, err := commit.ListEntries()
if err != nil {
- ctx.Handle(500, "ListEntries", err)
+ ctx.ServerError("ListEntries", err)
return nil, nil
}
pages := make([]PageMeta, 0, len(entries))
@@ -128,7 +128,7 @@ func renderWikiPage(ctx *context.Context, isViewPage bool) (*git.Repository, *gi
}
wikiName, err := models.WikiFilenameToName(entry.Name())
if err != nil {
- ctx.Handle(500, "WikiFilenameToName", err)
+ ctx.ServerError("WikiFilenameToName", err)
return nil, nil
} else if wikiName == "_Sidebar" || wikiName == "_Footer" {
continue
@@ -155,7 +155,7 @@ func renderWikiPage(ctx *context.Context, isViewPage bool) (*git.Repository, *gi
pageFilename := models.WikiNameToFilename(pageName)
var entry *git.TreeEntry
if entry, err = findEntryForFile(commit, pageFilename); err != nil {
- ctx.Handle(500, "findEntryForFile", err)
+ ctx.ServerError("findEntryForFile", err)
return nil, nil
} else if entry == nil {
ctx.Redirect(ctx.Repo.RepoLink + "/wiki/_pages")
@@ -222,7 +222,7 @@ func Wiki(ctx *context.Context) {
// Get last change information.
lastCommit, err := wikiRepo.GetCommitByPath(wikiPath)
if err != nil {
- ctx.Handle(500, "GetCommitByPath", err)
+ ctx.ServerError("GetCommitByPath", err)
return
}
ctx.Data["Author"] = lastCommit.Author
@@ -247,7 +247,7 @@ func WikiPages(ctx *context.Context) {
entries, err := commit.ListEntries()
if err != nil {
- ctx.Handle(500, "ListEntries", err)
+ ctx.ServerError("ListEntries", err)
return
}
pages := make([]PageMeta, 0, len(entries))
@@ -257,12 +257,12 @@ func WikiPages(ctx *context.Context) {
}
c, err := wikiRepo.GetCommitByPath(entry.Name())
if err != nil {
- ctx.Handle(500, "GetCommit", err)
+ ctx.ServerError("GetCommit", err)
return
}
wikiName, err := models.WikiFilenameToName(entry.Name())
if err != nil {
- ctx.Handle(500, "WikiFilenameToName", err)
+ ctx.ServerError("WikiFilenameToName", err)
return
}
pages = append(pages, PageMeta{
@@ -294,15 +294,15 @@ func WikiRaw(ctx *context.Context) {
entry, err = findEntryForFile(commit, wikiPath)
}
if err != nil {
- ctx.Handle(500, "findFile", err)
+ ctx.ServerError("findFile", err)
return
} else if entry == nil {
- ctx.Handle(404, "findEntryForFile", nil)
+ ctx.NotFound("findEntryForFile", nil)
return
}
if err = ServeBlob(ctx, entry.Blob()); err != nil {
- ctx.Handle(500, "ServeBlob", err)
+ ctx.ServerError("ServeBlob", err)
}
}
@@ -339,7 +339,7 @@ func NewWikiPost(ctx *context.Context, form auth.NewWikiForm) {
ctx.Data["Err_Title"] = true
ctx.RenderWithErr(ctx.Tr("repo.wiki.page_already_exists"), tplWikiNew, &form)
} else {
- ctx.Handle(500, "AddWikiPage", err)
+ ctx.ServerError("AddWikiPage", err)
}
return
}
@@ -381,7 +381,7 @@ func EditWikiPost(ctx *context.Context, form auth.NewWikiForm) {
newWikiName := models.NormalizeWikiName(form.Title)
if err := ctx.Repo.Repository.EditWikiPage(ctx.User, oldWikiName, newWikiName, form.Content, form.Message); err != nil {
- ctx.Handle(500, "EditWikiPage", err)
+ ctx.ServerError("EditWikiPage", err)
return
}
@@ -396,7 +396,7 @@ func DeleteWikiPagePost(ctx *context.Context) {
}
if err := ctx.Repo.Repository.DeleteWikiPage(ctx.User, wikiName); err != nil {
- ctx.Handle(500, "DeleteWikiPage", err)
+ ctx.ServerError("DeleteWikiPage", err)
return
}
generated by cgit v1.2.3 (git 2.39.1) at 2025-02-07 07:52:12 +0000