summaryrefslogtreecommitdiffstats
path: root/services/issue/assignee.go
diff options
context:
space:
mode:
Diffstat (limited to 'services/issue/assignee.go')
-rw-r--r--services/issue/assignee.go19
1 files changed, 9 insertions, 10 deletions
diff --git a/services/issue/assignee.go b/services/issue/assignee.go
index 943a761e28..8fe35b5602 100644
--- a/services/issue/assignee.go
+++ b/services/issue/assignee.go
@@ -46,13 +46,12 @@ func DeleteNotPassedAssignee(ctx context.Context, issue *issues_model.Issue, doe
func ToggleAssignee(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, assigneeID int64) (removed bool, comment *issues_model.Comment, err error) {
removed, comment, err = issues_model.ToggleIssueAssignee(ctx, issue, doer, assigneeID)
if err != nil {
- return
+ return false, nil, err
}
- assignee, err1 := user_model.GetUserByID(ctx, assigneeID)
- if err1 != nil {
- err = err1
- return
+ assignee, err := user_model.GetUserByID(ctx, assigneeID)
+ if err != nil {
+ return false, nil, err
}
notification.NotifyIssueChangeAssignee(ctx, doer, issue, assignee, removed, comment)
@@ -236,23 +235,23 @@ func TeamReviewRequest(ctx context.Context, issue *issues_model.Issue, doer *use
}
if err != nil {
- return
+ return nil, err
}
if comment == nil || !isAdd {
- return
+ return nil, nil
}
// notify all user in this team
- if err = comment.LoadIssue(ctx); err != nil {
- return
+ if err := comment.LoadIssue(ctx); err != nil {
+ return nil, err
}
members, err := organization.GetTeamMembers(ctx, &organization.SearchMembersOptions{
TeamID: reviewer.ID,
})
if err != nil {
- return
+ return nil, err
}
for _, member := range members {