summaryrefslogtreecommitdiffstats
path: root/services/pull/pull.go
diff options
context:
space:
mode:
Diffstat (limited to 'services/pull/pull.go')
-rw-r--r--services/pull/pull.go5
1 files changed, 4 insertions, 1 deletions
diff --git a/services/pull/pull.go b/services/pull/pull.go
index d8923d0d57..a5541b8460 100644
--- a/services/pull/pull.go
+++ b/services/pull/pull.go
@@ -274,9 +274,12 @@ func AddTestPullRequestTask(doer *user_model.User, repoID int64, branch string,
continue
}
+ // If the PR is closed, someone still push some commits to the PR,
+ // 1. We will insert comments of commits, but hidden until the PR is reopened.
+ // 2. We won't send any notification.
AddToTaskQueue(pr)
comment, err := CreatePushPullComment(ctx, doer, pr, oldCommitID, newCommitID)
- if err == nil && comment != nil {
+ if err == nil && comment != nil && !pr.Issue.IsClosed {
notification.NotifyPullRequestPushCommits(ctx, doer, pr, comment)
}
}