summaryrefslogtreecommitdiffstats
path: root/web_src/js
diff options
context:
space:
mode:
Diffstat (limited to 'web_src/js')
-rw-r--r--web_src/js/features/common-global.js5
-rw-r--r--web_src/js/features/pull-view-file.js2
-rw-r--r--web_src/js/features/repo-code.js2
-rw-r--r--web_src/js/features/repo-diff.js4
-rw-r--r--web_src/js/features/repo-issue.js6
-rw-r--r--web_src/js/features/repo-unicode-escape.js18
6 files changed, 18 insertions, 19 deletions
diff --git a/web_src/js/features/common-global.js b/web_src/js/features/common-global.js
index 8245aa57f8..d4d955601e 100644
--- a/web_src/js/features/common-global.js
+++ b/web_src/js/features/common-global.js
@@ -56,9 +56,8 @@ export function initGlobalEnterQuickSubmit() {
}
export function initGlobalButtonClickOnEnter() {
- $(document).on('keypress', '.ui.button', (e) => {
- if (e.keyCode === 13 || e.keyCode === 32) { // enter key or space bar
- if (e.target.nodeName === 'BUTTON') return; // button already handles space&enter correctly
+ $(document).on('keypress', 'div.ui.button,span.ui.button', (e) => {
+ if (e.code === ' ' || e.code === 'Enter') {
$(e.target).trigger('click');
e.preventDefault();
}
diff --git a/web_src/js/features/pull-view-file.js b/web_src/js/features/pull-view-file.js
index e57663736a..daa520ea7e 100644
--- a/web_src/js/features/pull-view-file.js
+++ b/web_src/js/features/pull-view-file.js
@@ -38,7 +38,7 @@ export function initViewedCheckboxListenerFor() {
// The checkbox consists of a div containing the real checkbox with its label and the CSRF token,
// hence the actual checkbox first has to be found
const checkbox = form.querySelector('input[type=checkbox]');
- checkbox.addEventListener('change', function() {
+ checkbox.addEventListener('input', function() {
// Mark the file as viewed visually - will especially change the background
if (this.checked) {
form.classList.add(viewedStyleClass);
diff --git a/web_src/js/features/repo-code.js b/web_src/js/features/repo-code.js
index 9b504068f6..73eccaf193 100644
--- a/web_src/js/features/repo-code.js
+++ b/web_src/js/features/repo-code.js
@@ -181,7 +181,7 @@ export function initRepoCodeView() {
$(document).on('click', '.fold-file', ({currentTarget}) => {
invertFileFolding(currentTarget.closest('.file-content'), currentTarget);
});
- $(document).on('click', '.blob-excerpt', async ({currentTarget}) => {
+ $(document).on('click', '.code-expander-button', async ({currentTarget}) => {
const url = currentTarget.getAttribute('data-url');
const query = currentTarget.getAttribute('data-query');
const anchor = currentTarget.getAttribute('data-anchor');
diff --git a/web_src/js/features/repo-diff.js b/web_src/js/features/repo-diff.js
index 5a9f5ba0a2..d0622254bf 100644
--- a/web_src/js/features/repo-diff.js
+++ b/web_src/js/features/repo-diff.js
@@ -62,9 +62,9 @@ function initRepoDiffConversationForm() {
$form.closest('.conversation-holder').replaceWith($newConversationHolder);
if ($form.closest('tr').data('line-type') === 'same') {
- $(`[data-path="${path}"] a.add-code-comment[data-idx="${idx}"]`).addClass('invisible');
+ $(`[data-path="${path}"] .add-code-comment[data-idx="${idx}"]`).addClass('invisible');
} else {
- $(`[data-path="${path}"] a.add-code-comment[data-side="${side}"][data-idx="${idx}"]`).addClass('invisible');
+ $(`[data-path="${path}"] .add-code-comment[data-side="${side}"][data-idx="${idx}"]`).addClass('invisible');
}
$newConversationHolder.find('.dropdown').dropdown();
initCompReactionSelector($newConversationHolder);
diff --git a/web_src/js/features/repo-issue.js b/web_src/js/features/repo-issue.js
index 3723e0f627..cf6e09472e 100644
--- a/web_src/js/features/repo-issue.js
+++ b/web_src/js/features/repo-issue.js
@@ -177,9 +177,9 @@ export function initRepoIssueCommentDelete() {
const idx = $conversationHolder.data('idx');
const lineType = $conversationHolder.closest('tr').data('line-type');
if (lineType === 'same') {
- $(`[data-path="${path}"] a.add-code-comment[data-idx="${idx}"]`).removeClass('invisible');
+ $(`[data-path="${path}"] .add-code-comment[data-idx="${idx}"]`).removeClass('invisible');
} else {
- $(`[data-path="${path}"] a.add-code-comment[data-side="${side}"][data-idx="${idx}"]`).removeClass('invisible');
+ $(`[data-path="${path}"] .add-code-comment[data-side="${side}"][data-idx="${idx}"]`).removeClass('invisible');
}
$conversationHolder.remove();
}
@@ -488,7 +488,7 @@ export function initRepoPullRequestReview() {
});
}
- $(document).on('click', 'a.add-code-comment', async function (e) {
+ $(document).on('click', '.add-code-comment', async function (e) {
if ($(e.target).hasClass('btn-add-single')) return; // https://github.com/go-gitea/gitea/issues/4745
e.preventDefault();
diff --git a/web_src/js/features/repo-unicode-escape.js b/web_src/js/features/repo-unicode-escape.js
index 67f2df1d9a..6a201ec4d1 100644
--- a/web_src/js/features/repo-unicode-escape.js
+++ b/web_src/js/features/repo-unicode-escape.js
@@ -2,30 +2,30 @@ import $ from 'jquery';
import {hideElem, showElem} from '../utils/dom.js';
export function initUnicodeEscapeButton() {
- $(document).on('click', 'a.escape-button', (e) => {
+ $(document).on('click', '.escape-button', (e) => {
e.preventDefault();
$(e.target).parents('.file-content, .non-diff-file-content').find('.file-code, .file-view').addClass('unicode-escaped');
hideElem($(e.target));
- showElem($(e.target).siblings('a.unescape-button'));
+ showElem($(e.target).siblings('.unescape-button'));
});
- $(document).on('click', 'a.unescape-button', (e) => {
+ $(document).on('click', '.unescape-button', (e) => {
e.preventDefault();
$(e.target).parents('.file-content, .non-diff-file-content').find('.file-code, .file-view').removeClass('unicode-escaped');
hideElem($(e.target));
- showElem($(e.target).siblings('a.escape-button'));
+ showElem($(e.target).siblings('.escape-button'));
});
- $(document).on('click', 'a.toggle-escape-button', (e) => {
+ $(document).on('click', '.toggle-escape-button', (e) => {
e.preventDefault();
const fileContent = $(e.target).parents('.file-content, .non-diff-file-content');
const fileView = fileContent.find('.file-code, .file-view');
if (fileView.hasClass('unicode-escaped')) {
fileView.removeClass('unicode-escaped');
- hideElem(fileContent.find('a.unescape-button'));
- showElem(fileContent.find('a.escape-button'));
+ hideElem(fileContent.find('.unescape-button'));
+ showElem(fileContent.find('.escape-button'));
} else {
fileView.addClass('unicode-escaped');
- showElem(fileContent.find('a.unescape-button'));
- hideElem(fileContent.find('a.escape-button'));
+ showElem(fileContent.find('.unescape-button'));
+ hideElem(fileContent.find('.escape-button'));
}
});
}