aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix missing check (#28406) (#28413)release/v1.20Lunny Xiao2023-12-122-4/+24
| | | backport #28406
* Check for v prefix on tags for release clean branch name (#28257) (#28270) ↵John Olheiser2023-11-281-1/+1
| | | | (#28273)
* Fix links in docs (#28234) (#28250)v1.20.6yp053272023-11-281-1/+1
| | | Backport #28234
* Use github actions instead of drone to release versions (#28221)Lunny Xiao2023-11-283-426/+151
|
* Fix some incorrect links in docs (#28191) (#28233)yp053272023-11-272-2/+2
| | | Backport https://github.com/go-gitea/gitea/pull/28191
* Change log for v1.20.6 (#28223)Lunny Xiao2023-11-261-0/+32
| | | As title.
* Fix comment permissions (#28213) (#28217)Lunny Xiao2023-11-2635-109/+422
| | | | | | backport #28213 This PR will fix some missed checks for private repositories' data on web routes and API routes.
* Fix no ActionTaskOutput table waring (#28149) (#28151)Giteabot2023-11-211-0/+4
| | | | | | | | | | | | | | | | | | | Backport #28149 by @yp05327 Reproduce: - Create a new Gitea instance - Register a runner - Create a repo and add a workflow - Check the log, you will see warnings: ![image](https://github.com/go-gitea/gitea/assets/18380374/5f1278e0-114b-48bc-8113-8ba1404d9975) It comes from: ![image](https://github.com/go-gitea/gitea/assets/18380374/c2807831-e137-4229-9536-87f6114c8a5b) The reason is that we forgot registering `ActionTaskOutput` model. So `action_table_output` table will be missing in your db. Co-authored-by: yp05327 <576951401@qq.com>
* Update docs for docusaurus v3 (#28127)John Olheiser2023-11-203-6/+6
| | | Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Restricted users only see repos in orgs which their team was assigned to ↵Giteabot2023-11-141-5/+5
| | | | | | | | | | | (#28025) (#28050) Backport #28025 by @6543 --- *Sponsored by Kithara Software GmbH* Co-authored-by: 6543 <m.huber@kithara.com>
* Dont leak private users via extensions (#28023) (#28028)Giteabot2023-11-141-0/+5
| | | | | | Backport #28023 by @6543 there was no check in place if a user could see a other user, if you append e.g. `.rss`
* Fix wrong xorm Delete usage(backport for 1.20) (#28003)Nanguan Lin2023-11-121-1/+1
| | | | manually backport for https://github.com/go-gitea/gitea/pull/27995 The conflict is `ctx` and `db.Defaultctx`.
* Render email addresses as such if followed by punctuation (#27987) (#27991)Giteabot2023-11-112-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | Backport #27987 by @yardenshoham Added the following characters to the regular expression for the email: - , - ; - ? - ! Also added a test case. - Fixes #27616 # Before ![image](https://github.com/go-gitea/gitea/assets/20454870/c57eac26-f281-43ef-a51d-9c9a81b63efa) # After ![image](https://github.com/go-gitea/gitea/assets/20454870/fc7d5c08-4350-4af0-a7f0-d1444d2d75af) Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: Yarden Shoham <git@yardenshoham.com>
* Remove duplicated button in Install web page (#27941)Nanguan Lin2023-11-071-2/+0
| | | | Fix #27934 Regression #25648
* Unify two factor check (#27915) (#27939)KN4CK3R2023-11-065-66/+76
| | | | | | | | | | Backport of #27915 Fixes #27819 We have support for two factor logins with the normal web login and with basic auth. For basic auth the two factor check was implemented at three different places and you need to know that this check is necessary. This PR moves the check into the basic auth itself.
* Fix DownloadFunc when migrating releases (#27887) (#27889)Giteabot2023-11-032-6/+9
| | | | | | | | | | | | | Backport #27887 by @Zettat123 We should not use `asset.ID` in DownloadFunc because DownloadFunc is a closure. https://github.com/go-gitea/gitea/blob/1bf5527eac6b947010c8faf408f6747de2a2384f/services/migrations/gitea_downloader.go#L284-L295 A similar bug when migrating from GitHub has been fixed in #14703. This PR fixes the bug when migrating from Gitea and GitLab. Co-authored-by: Zettat123 <zettat123@gmail.com>
* Fix http protocol auth (#27875) (#27878)Lunny Xiao2023-11-024-14/+46
| | | backport #27875
* Fix package webhook (#27839) (#27854)Giteabot2023-10-3114-1/+97
| | | | | | | | Backport #27839 by @lunny Fix #23742 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Revert "fix orphan check for deleted branch (#27310) (#27320)" (#27763)Lunny Xiao2023-10-241-3/+3
| | | | Because branch table is created until 1.21 Fix #27508
* Fix label render containing invalid HTML (#27752) (#27761)Giteabot2023-10-241-1/+1
| | | | | | | | | | | | Backport #27752 by @earl-warren - The label HTML contained a quote that wasn't being closed. Refs: https://codeberg.org/forgejo/forgejo/pulls/1651 (cherry picked from commit e2bc2c9a1fff482c49dbeb3a51e4e1c698bf506c) Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com> Co-authored-by: Gusted <postmaster@gusted.xyz>
* Fix org team endpoint (#27721) (#27729)Giteabot2023-10-221-4/+4
| | | | | | | Backport #27721 by @lng2020 Fix #27711 Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
* Adapt `.changelog.yml` to new labeling system (#27701) (#27708)Giteabot2023-10-201-16/+12
| | | | | | | Backport #27701 by @delvh Otherwise, it is not possible anymore to generate changelogs. Co-authored-by: delvh <dev.lh@web.de>
* Support allowed hosts for webhook to work with proxy (#27655) (#27674)Giteabot2023-10-183-21/+73
| | | | | | | | | | | | | | | | | | | | | Backport #27655 by @wolfogre When `webhook.PROXY_URL` has been set, the old code will check if the proxy host is in `ALLOWED_HOST_LIST` or reject requests through the proxy. It requires users to add the proxy host to `ALLOWED_HOST_LIST`. However, it actually allows all requests to any port on the host, when the proxy host is probably an internal address. But things may be even worse. `ALLOWED_HOST_LIST` doesn't really work when requests are sent to the allowed proxy, and the proxy could forward them to any hosts. This PR fixes it by: - If the proxy has been set, always allow connectioins to the host and port. - Check `ALLOWED_HOST_LIST` before forwarding. Co-authored-by: Jason Song <i@wolfogre.com>
* Fix poster is not loaded in get default merge message (#27657) (#27665)Giteabot2023-10-171-0/+3
| | | | | Backport #27657 by @lunny Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Fix 404 when deleting Docker package with an internal version (#27615) (#27629)Giteabot2023-10-151-1/+1
| | | | | | | | Backport #27615 by @lng2020 close #27601 The Docker registry has an internal version, which leads to 404 Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
* Fix attachment download bug (#27486) (#27570)Giteabot2023-10-116-21/+21
| | | | | | | | | | | Backport #27486 by @lunny Fix #27204 This PR allows `/<username>/<reponame>/attachments/<uuid>` access with personal access token and also changed attachments API download url to it so it can be download correctly. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Avoid run change title process when the title is same (#27467) (#27557)yp053272023-10-101-0/+4
| | | Backport #27467 manually.
* Fix mermaid flowchart margin issue (#27503) (#27517)silverwind2023-10-081-1/+3
| | | | | | | | | | Backport https://github.com/go-gitea/gitea/pull/27503 to 1.20 Fixes: https://github.com/go-gitea/gitea/issues/27435 Related: https://github.com/mermaid-js/mermaid/issues/4907 <img width="924" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/494a1d2e-4c56-48d0-9843-82a5e5aa977e">
* Fix panic in storageHandler (#27446) (#27478)Giteabot2023-10-061-51/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #27446 by @sryze storageHandler() is written as a middleware but is used as an endpoint handler, and thus `next` is actually `nil`, which causes a null pointer dereference when a request URL does not match the pattern (where it calls `next.ServerHTTP()`). Example CURL command to trigger the panic: ``` curl -I "http://yourhost/gitea//avatars/a" ``` Fixes #27409 --- Note: the diff looks big but it's actually a small change - all I did was to remove the outer closure (and one level of indentation) ~and removed the HTTP method and pattern checks as they seem redundant because go-chi already does those checks~. You might want to check "Hide whitespace" when reviewing it. Alternative solution (a bit simpler): append `, misc.DummyOK` to the route declarations that utilize `storageHandler()` - this makes it return an empty response when the URL is invalid. I've tested this one and it works too. Or maybe it would be better to return a 400 error in that case (?) Co-authored-by: Sergey Zolotarev <sryze@outlook.com>
* When comparing with an non-exist repository, return 404 but 500 (#27437) ↵Giteabot2023-10-041-1/+3
| | | | | | | (#27441) Backport #27437 by @lunny Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Add 1.20.5 changelog (#27404)v1.20.5Lunny Xiao2023-10-031-0/+27
|
* Fix bug of review request number (#27406)Lunny Xiao2023-10-031-1/+8
| | | | Manually backport #27104 without tests because too many conflicted files to backport it completely.
* Fix git 2.11 error when checking IsEmpty (#27393) (#27396)Giteabot2023-10-021-1/+2
| | | | | | | | | Backport #27393 by @wxiaoguang Fix #27389 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Allow get release download files and lfs files with oauth2 token format ↵Giteabot2023-10-018-6/+66
| | | | | | | | | | (#26430) (#27378) Backport #26430 by @lunny Fix #26165 Fix #25257 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Add logs for data broken of comment review (#27326) (#27344)Giteabot2023-09-291-27/+9
| | | | | | | Backport #27326 by @lunny Fix #27306 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* fix orphan check for deleted branch (#27310) (#27320)Giteabot2023-09-281-3/+3
| | | | | | | | | | | | | Backport #27310 by @earl-warren - Modify the deleted branch orphan check to check for the new table instead. - Regression from 6e19484f4d3bf372212f2da462110a1a8c10cbf2 - Resolves https://codeberg.org/forgejo/forgejo/issues/1522 (cherry picked from commit c1d888686fe445e4edecb9d835c5b3893b574b75) Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com> Co-authored-by: Gusted <postmaster@gusted.xyz>
* Fix PushEvent NullPointerException jenkinsci/github-plugin (#27203) (#27249)Giteabot2023-09-253-0/+6
| | | | | | | Backport #27203 by @Nabapadma-sarker Fixes #27202 Co-authored-by: Nabapadma-sarker <nabapadmacse1991@gmail.com>
* Fix z-index on markdown completion (#27237) (#27242)Giteabot2023-09-250-0/+0
| | | | | | | Backport #27237 by @silverwind Fixes: https://github.com/go-gitea/gitea/issues/27230 Co-authored-by: silverwind <me@silverwind.io>
* Fix z-index on markdown completion (#27237) (#27238)Giteabot2023-09-241-0/+1
| | | | | | | Backport #27237 by @silverwind Fixes: https://github.com/go-gitea/gitea/issues/27230 Co-authored-by: silverwind <me@silverwind.io>
* Update database-preparation and add note re: MariaDB (#27232) (#27235)Giteabot2023-09-251-3/+3
| | | | | | | | Backport #27232 by @techknowlogick update DB docs per feedback. https://gitea.com/gitea/gitea-docusaurus/issues/69 Co-authored-by: techknowlogick <techknowlogick@gitea.com>
* Quote table `release` in sql queries (#27205) (#27219)KN4CK3R2023-09-242-6/+6
| | | | | | | | | Backport of #27205 Fixes #27174 `release` is a reserved keyword in MySql. I can't reproduce the issue on my setup and we have a test for that code but it seems there can be setups where it fails.
* Fix release URL in webhooks (#27182) (#27184)Giteabot2023-09-219-9/+9
| | | | | | | | | | | | Backport #27182 by @jolheiser Resolves #27180 `URL` points to the API URL, `HTMLURL` points to the web page. Notably, however, for PRs they are the same URL. I switched them to use HTMLURL to match the rest of the codebase terminology. Co-authored-by: John Olheiser <john.olheiser@gmail.com>
* Fix organization field being null in POST /orgs/{orgid}/teams (#27150) (#27167)Giteabot2023-09-210-0/+0
| | | | | | | | | | | | | | | | | Backport #27150 by @memphis88 Similarly to the fix in https://github.com/go-gitea/gitea/pull/24694, this addresses the team creation not returning the organization information in the response. This fix is connected to the [issue](https://gitea.com/gitea/terraform-provider-gitea/issues/27) discovered in the terraform provider. Moreover, the [documentation](https://docs.gitea.com/api/1.20/#tag/organization/operation/orgCreateTeam) suggests that the response body should include the `organization` field (currently being `null`). Co-authored-by: Dionysios Kakouris <1369451+memphis88@users.noreply.github.com>
* Fix organization field being null in POST /orgs/{orgid}/teams (#27150) (#27162)Giteabot2023-09-211-1/+1
| | | | | | | | | | | | | | | | | Backport #27150 by @memphis88 Similarly to the fix in https://github.com/go-gitea/gitea/pull/24694, this addresses the team creation not returning the organization information in the response. This fix is connected to the [issue](https://gitea.com/gitea/terraform-provider-gitea/issues/27) discovered in the terraform provider. Moreover, the [documentation](https://docs.gitea.com/api/1.20/#tag/organization/operation/orgCreateTeam) suggests that the response body should include the `organization` field (currently being `null`). Co-authored-by: Dionysios Kakouris <1369451+memphis88@users.noreply.github.com>
* Fix successful return value for `SyncAndGetUserSpecificDiff` (#27152) (#27156)Giteabot2023-09-211-1/+1
| | | | | | | | | | Backport #27152 by @delvh A function should not return an error when it is successful. Otherwise, things like https://discord.com/channels/322538954119184384/322538954119184384/1153705341620600833 happen… Co-authored-by: delvh <dev.lh@web.de>
* Improve actions docs related to `pull_request` event (#27126) (#27145)Giteabot2023-09-202-0/+6
| | | | | | | | | | Backport #27126 by @Zettat123 Related to #27039 The `ref` property in Gitea Actions is different from GitHub Actions. This PR improves the documentation to explain the difference. Co-authored-by: Zettat123 <zettat123@gmail.com>
* fix pagination for followers and following (#27127) (#27138)Giteabot2023-09-191-2/+2
| | | | | | | | | | | | | | Backport #27127 by @earl-warren - Use the correct total amount for pagination. Thereby correctly show the pagination bare when there's more than one page of followers/followings. Refs: https://codeberg.org/forgejo/forgejo/pulls/1477 (cherry picked from commit c1a136318be3bf72511bed108f2d67f2cf34e1b8) Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com> Co-authored-by: Gusted <postmaster@gusted.xyz>
* services/wiki: Close() after error handling (#27129) (#27137)Giteabot2023-09-191-2/+2
| | | | | | | | | | | Backport #27129 by @earl-warren Refs: https://codeberg.org/forgejo/forgejo/pulls/1385 Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com> (cherry picked from commit 589e7d346f51de4a0e2c461b220c8cad34133b2f) Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com> Co-authored-by: Lars Lehtonen <lars.lehtonen@gmail.com>
* Fix issue templates when blank isses are disabled (#27061) (#27082)Giteabot2023-09-142-11/+14
| | | | | | | | | Backport #27061 by @JakobDev Fixes #27060 Co-authored-by: JakobDev <jakobdev@gmx.de> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: delvh <dev.lh@web.de>
* Load reviewer before sending notification (#27063) (#27064)sebastian-sauer2023-09-131-0/+3
| | | | Fixes #27035