aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Various improvements for long file and commit names (#30374) (#30386)Giteabot2024-04-108-78/+107
| | | | | | | | | | | | | | | | | | | | | | | | Backport #30374 by @silverwind Fixes: https://github.com/go-gitea/gitea/issues/29438 This contains numerous enhancements for how large commit messages and large filenames render. Another notable change is that the file path is no longer cut off by backend at 30 chars, but rendered in full with wrapping. <img width="1329" alt="Screenshot 2024-04-09 at 21 53 57" src="https://github.com/go-gitea/gitea/assets/115237/5ccbb3d6-643a-4f60-ba79-3572b36d5182"> <hr> <img width="711" alt="Screenshot 2024-04-09 at 21 44 24" src="https://github.com/go-gitea/gitea/assets/115237/6ffe8fbb-407c-4aa7-b591-3d80daea7d57"> <hr> <img width="439" alt="Screenshot 2024-04-09 at 21 19 03" src="https://github.com/go-gitea/gitea/assets/115237/1ec7f6e9-2fd8-4841-87eb-6ca02ab9cd61"> <hr> <img width="444" alt="Screenshot 2024-04-09 at 21 18 52" src="https://github.com/go-gitea/gitea/assets/115237/70931b9e-5841-477e-b3bc-98f8d2662964"> Co-authored-by: silverwind <me@silverwind.io>
* Fix line height on inline code preview (#30372) (#30385)Giteabot2024-04-101-0/+1
| | | | | | | | | | | | | | Backport #30372 by @silverwind Fixes https://github.com/go-gitea/gitea/issues/30353. I don't know what causes `code-inner` to not inherit `line-height` from its direct parent `.lines-code` but instead from grandparent `.markup` even thought MDN tells me it's [inherited](https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#formal_definition). This causes no negative impact on other code views, so I think it's the best solution. Co-authored-by: silverwind <me@silverwind.io>
* Fix label-list rendering in timeline, decrease gap (#30342) (#30380)Giteabot2024-04-101-2/+2
| | | | | | | | | | | | | | | | | Backport #30342 by @silverwind Not sure exactly when this regressed, but has been a while I think. Before: <img width="895" alt="Screenshot 2024-04-08 at 22 46 50" src="https://github.com/go-gitea/gitea/assets/115237/9b1788f8-017e-4fe1-8ab9-938e0d76fb41"> After: <img width="689" alt="Screenshot 2024-04-08 at 23 00 58" src="https://github.com/go-gitea/gitea/assets/115237/90193df9-5c24-4a1a-96fe-3d4e8392063c"> Co-authored-by: silverwind <me@silverwind.io>
* Fix ambiguous id when fetch Actions tasks (#30382) (#30383)Giteabot2024-04-101-1/+1
| | | | | | | | | | | | | Backport #30382 by @wolfogre Fix regression of #30331. ```txt time="2024-04-10T02:23:49Z" level=error msg="failed to fetch task" func="[fetchTask]" file="[poller.go:91]" error="unknown: rpc error: code = Internal desc = pick task: CreateTaskForRunner: Error 1052 (23000): Column 'id' in field list is ambiguous" ``` I have tested it in my local env, and it should work now. Co-authored-by: Jason Song <i@wolfogre.com>
* Fix actions design about default actions download url (#30360) (#30371)Giteabot2024-04-102-2/+3
| | | | | | | Backport #30360 by @lunny Fix #30359 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Fix and rewrite contrast color calculation, fix project-related bugs (#30326)silverwind2024-04-0914-203/+148
| | | | | | | Backport https://github.com/go-gitea/gitea/pull/30237 to 1.22. Also includes https://github.com/go-gitea/gitea/pull/30183. Both were clean cherry-picks. Co-authored-by: Giteabot <teabot@gitea.io>
* Performance optimization for git push (#30104) (#30348)Giteabot2024-04-095-73/+109
| | | | | | | | | Backport #30104 by @lunny Agit returned result should be from `ProcReceive` hook but not `PostReceive` hook. Then for all non-agit pull requests, it will not check the pull requests for every pushing `refs/pull/%d/head`. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Reduce checkbox size to 15px (#30346) (#30347)Giteabot2024-04-092-2/+2
| | | | | | | | | | Backport #30346 by @silverwind 16 seems to big, 14 too small. Let's do 15. Alignment: <img width="181" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/f2988611-dee2-492e-a18f-dc5ab3a1cd6c"> Co-authored-by: silverwind <me@silverwind.io>
* Fix missed doer (#30231) (#30343)Giteabot2024-04-0911-55/+55
| | | | | | | Backport #30231 by @lunny Fix #29879 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Avoid running action when action unit is disabled after workflows detected ↵Giteabot2024-04-081-1/+4
| | | | | | | | | | | | | | | | | (#30331) (#30338) Backport #30331 by @yp05327 Fix #30243 We only checking unit disabled when detecting workflows, but not in runner `FetchTask`. So if a workflow was detected when action unit is enabled, but disabled later, `FetchTask` will still return these detected actions. Global setting: repo.ENABLED and repository.`DISABLED_REPO_UNITS` will not effect this. Co-authored-by: yp05327 <576951401@qq.com>
* Fix create commit status (#30225)Lunny Xiao2024-04-081-7/+5
| | | | | | Partially backport #30223 This PR uses the service layer `CreateCommitstatus` method instead of the git model method.
* Avoid showing `Failed to change the default wiki branch` if repo has no wiki ↵Giteabot2024-04-082-0/+10
| | | | | | | | | | | when saving repo settings (#30329) (#30337) Backport #30329 by @yp05327 If repo does not have wiki, we should return after save the default wiki branch into DB. Or you will always see `Failed to change the default wiki branch` error. Co-authored-by: yp05327 <576951401@qq.com>
* Fix oauth2 builtin application logic (#30304) (#30327)Giteabot2024-04-086-17/+107
| | | | | | | | | | Backport #30304 by wxiaoguang Fix #29074 (allow to disable all builtin apps) and don't make the doctor command remove the builtin apps. By the way, rename refobject and joincond to camel case. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Add `--page-spacing` variable, fix admin dashboard notice (#30302) (#30323)Giteabot2024-04-083-6/+11
| | | | | | | | | | | | | | | | | | | | | | | | Backport #30302 by @silverwind Fixes https://github.com/go-gitea/gitea/issues/30293 and introduce the `--page-spacing` variable which holds the spacing between the elements on the page. This is working vertically for all pages, including ones that have fomantic grid, and horizontally for all that use `flex-container`. The `.page-content > :first-child:not(.secondary-nav)` selector uses margin which in some cases enables to adjacent margins to overlap, which is nice. <img width="1320" alt="Screenshot 2024-04-06 at 01 35 19" src="https://github.com/go-gitea/gitea/assets/115237/3e81e707-e9ff-4b7f-a211-3d98f4f85353"> --- <img width="1327" alt="Screenshot 2024-04-06 at 01 35 45" src="https://github.com/go-gitea/gitea/assets/115237/aad196c0-9e21-4c06-ae59-7e33a76c61e1"> --- <img width="1321" alt="Screenshot 2024-04-06 at 01 35 31" src="https://github.com/go-gitea/gitea/assets/115237/785f6c5d-08b6-4e66-aa16-aeca7cfed3ad"> Co-authored-by: silverwind <me@silverwind.io>
* Some NuGet package enhancements (#30280) (#30324)Giteabot2024-04-073-32/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #30280 by @KN4CK3R Fixes #30265 1. Read second type of dependencies 2. Render `Description` and `ReleaseNotes` old: ![grafik](https://github.com/go-gitea/gitea/assets/1666336/abac057c-11cd-4d25-b196-01ff899d948e) new: ![grafik](https://github.com/go-gitea/gitea/assets/1666336/35302273-740c-481a-a031-1f80d2d7d336) The NuGet spec does not specify what kind of text can be stored in the description but we can best guess markdown. The official NuGet registry just [converts the newlines to html lines](https://www.nuget.org/packages/rb.Firefox#readme-body-tab). 3. Extract and render the readme. This is the new and better place to store larger text than in the description. The content is markdown. ![grafik](https://github.com/go-gitea/gitea/assets/1666336/f442264e-3735-4b55-92c4-3b89a8ebafb0) Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: Benjamin Heemann <benjamin.heemann@raith.de>
* Action view mobile improvements and fixes (#30309) (#30320)Giteabot2024-04-074-14/+30
| | | | | | | | | | | | | | | | | | | Backport #30309 by @silverwind Fix the action issue in https://github.com/go-gitea/gitea/issues/30303, specifically: - Use opaque step header hover background to avoid transparency issue - Un-sticky the `action-view-left` on mobile, it would otherwise overlap into right view - Improve commit summary, let it wrap - Fix and comment z-indexes - Tweak width for run-list-item-right so it wastes less space on desktop - Synced latest changes to console colors from dark to light theme <img width="467" alt="Screenshot 2024-04-06 at 18 58 15" src="https://github.com/go-gitea/gitea/assets/115237/8ad26b72-6cd9-4522-8ad1-6fd86b2d0d53"> Co-authored-by: silverwind <me@silverwind.io>
* Fix checkboxes on mobile view, remove some dead css (#30308) (#30319)Giteabot2024-04-071-26/+4
| | | | | | | | | | | | | | | | | | Backport #30308 by @silverwind Fix the checkbox issues in https://github.com/go-gitea/gitea/issues/30303 which were existing problems with these selectors, but made visible with https://github.com/go-gitea/gitea/pull/30162. There is a lot of dead/useless CSS in `form.css`, I only fixed the two problems and remove CSS that was definitely not in use or needed. <img width="369" alt="Screenshot 2024-04-06 at 18 00 08" src="https://github.com/go-gitea/gitea/assets/115237/720f178b-1b22-48d4-8704-becb8ce66129"> <img width="405" alt="Screenshot 2024-04-06 at 18 00 28" src="https://github.com/go-gitea/gitea/assets/115237/61c0f8ec-34af-46c5-a3fa-7c5c4d30c7d2"> Co-authored-by: silverwind <me@silverwind.io>
* Clean up log messages (#30313) (#30318)Giteabot2024-04-0717-47/+31
| | | | | | | | Backport #30313 by wxiaoguang `log.Xxx("%v")` is not ideal, this PR adds necessary context messages. Remove some unnecessary logs. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Refactor startup deprecation messages (#30305) (#30312)Giteabot2024-04-0711-28/+30
| | | | | | | | | | | Backport #30305 by wxiaoguang It doesn't change logic, it only does: 1. Rename the variable and function names 2. Use more consistent format when mentioning config section&key 3. Improve some messages Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Markup color and font size fixes (#30282) (#30310)Giteabot2024-04-073-6/+8
| | | | | | | | | | | | | | Backport #30282 by @silverwind 1. Distinguish inline an block code with new CSS variable `--color-markup-code-inline` 2. Various color tweaks, better contrast from background <img width="447" alt="Screenshot 2024-04-05 at 00 51 00" src="https://github.com/go-gitea/gitea/assets/115237/93e069f4-6807-4f2c-9331-2d69730919d4"> <img width="456" alt="Screenshot 2024-04-05 at 00 50 44" src="https://github.com/go-gitea/gitea/assets/115237/0dc9c745-c531-40fa-94ec-b0ba10bd7ccf"> Co-authored-by: silverwind <me@silverwind.io>
* Always use `octicon-eye` on watch button (#30288) (#30307)Giteabot2024-04-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Backport #30288 by @silverwind This might appear odd but I think it's the right thing to do: On Github, the "Watch" button always has the open eye icon: <img width="177" alt="Screenshot 2024-04-05 at 08 26 48" src="https://github.com/go-gitea/gitea/assets/115237/0c1188d1-145b-4c6d-909f-2e1460499941"> <img width="179" alt="Screenshot 2024-04-05 at 08 26 40" src="https://github.com/go-gitea/gitea/assets/115237/e29d91fa-f122-4e10-9589-f79c1d612cf9"> On Gitea, while watching, the icon is this and this sometimes confuses me slightly, being used to above: <img width="158" alt="Screenshot 2024-04-05 at 08 29 08" src="https://github.com/go-gitea/gitea/assets/115237/3301021b-744e-409f-a9d8-887ec2772fdc"> After this PR, both states will use the same icon: <img width="145" alt="Screenshot 2024-04-05 at 08 26 27" src="https://github.com/go-gitea/gitea/assets/115237/8addfa5b-c009-4bdb-bfa1-4f3dfaffa4cd"> <img width="161" alt="Screenshot 2024-04-05 at 08 26 33" src="https://github.com/go-gitea/gitea/assets/115237/cef383e6-2cc0-460f-a4d3-83ebb321debe"> Co-authored-by: silverwind <me@silverwind.io>
* Fix code block style for code preview (#30298) (#30306)Giteabot2024-04-064-6/+6
| | | | | | | | | Backport #30298 by wxiaoguang Fix #30292 To avoid unnecessary style overriding, use "div" instead of "code" Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix view commit link (#30297) (#30299)wxiaoguang2024-04-061-85/+84
| | | Backport #30297
* Add gap to commit status details (#30284) (#30290)Giteabot2024-04-051-0/+1
| | | | | Backport #30284 by @silverwind Co-authored-by: silverwind <me@silverwind.io>
* Upgrade `golang.org/x/net` to v0.24.0 (#30283) (#30286)Giteabot2024-04-052-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #30283 by @silverwind Result of `go get -u golang.org/x/net; make tidy`. This is related to the following vulncheck warning: ``` There are 2 vulnerabilities in modules that you require that are neither imported nor called. You may not need to take any action. See https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck for details. Vulnerability #1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/net@v0.22.0 Fixed in: golang.org/x/net@v0.23.0 Vulnerability #2: GO-2022-0470 No access control in github.com/blevesearch/bleve and bleve/v2 More info: https://pkg.go.dev/vuln/GO-2022-0470 Module: github.com/blevesearch/bleve/v2 Found in: github.com/blevesearch/bleve/v2@v2.3.10 Fixed in: N/A ``` Co-authored-by: silverwind <me@silverwind.io>
* Commit-Dropdown: Show Author of commit if available (#30272) (#30285)Giteabot2024-04-051-4/+4
| | | | | | | | | | | | | | | | | | | Backport #30272 by @sebastian-sauer As in commits page we show the author of the commit in the commits dropdown and not the committer. Commits Page: ![Screenshot from 2024-04-03 22-34-41](https://github.com/go-gitea/gitea/assets/1135157/1c7c5c19-6d0a-4176-8a87-7bca6a0c6dc8) and the same contents in our dropdown: ![image](https://github.com/go-gitea/gitea/assets/1135157/aa094af2-c369-47ac-9c27-ca208d1d03f0) fixes #29588 Co-authored-by: sebastian-sauer <sauer.sebastian@gmail.com>
* update mailer example config, remove deprecated HOST (#30267) (#30274)Giteabot2024-04-031-1/+2
|
* Close file in the Upload func (#30262) (#30270)Giteabot2024-04-031-2/+2
| | | Co-authored-by: guangwu <guoguangwu@magic-shield.com>
* Fixes #27605: inline math blocks can't be preceeded/followed by ↵Giteabot2024-04-032-7/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | alphanumerical characters (#30175) (#30251) Backport #30175 by @jmlt2002 - Inline math blocks couldn't be preceeded or succeeded by alphanumerical characters due to changes introduced in PR #21171. Removed the condition that caused this (precedingCharacter condition) and added a new exit condition of the for-loop that checks if a specific '$' was escaped using '\' so that the math expression can be rendered as intended. - Additionally this PR fixes another bug where math blocks of the type '$xyz$abc$' where the dollar sign was not escaped by the user, generated an error (shown in the screenshots below) - Altered the tests to accomodate for the changes Former behaviour (from try.gitea.io): ![image](https://github.com/go-gitea/gitea/assets/114936010/8f0cbb21-321d-451c-b871-c67a8e1e9235) Fixed behaviour (from my local build): ![image](https://github.com/go-gitea/gitea/assets/114936010/5c22687c-6f11-4407-b5e7-c14b838bc20d) (Edit) Source code for the README.md file: ``` $x$ -$x$ $x$- a$xa$ $xa$a 1$xb$ $xb$1 $a a$b b$ a$b $a a$b b$ $a a\$b b$ ``` Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt> Co-authored-by: João Tiago <114936010+jmlt2002@users.noreply.github.com>
* Add -u git to docs when using docker exec with root installation (#29314) ↵Giteabot2024-04-031-2/+2
| | | | | | | | | | | | | | | | | | (#30259) Backport #29314 by @scribblemaniac This fixes a minor issue in the documentation for SSH Container Passthrough for non-rootless installs. The non-rootless Dockerfile and docker-compose do not set `USER`/`user` instructions so `docker exec` will run as root by default. While running as root, gitea commands will refuse to execute, breaking these approaches. For containers built with the rootless instructions, `docker exec` will run as git by default so this is not necessary in that case. This issue was already discussed in #19065, but it does not appear this part of the issue was ever added to the documentation. Co-authored-by: scribblemaniac <scribblemaniac@users.noreply.github.com>
* Show 12 lines in markup code preview (#30255) (#30257)Giteabot2024-04-031-1/+1
| | | | | | | | | | Backport #30255 by @silverwind Show up to 12 lines instead of previous 5. <img width="929" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/de68f200-b9e2-4a25-bd6e-c46849849620"> Co-authored-by: silverwind <me@silverwind.io>
* Refactor "dump" sub-command (#30240) (#30260)Giteabot2024-04-036-224/+369
| | | | | | | | | | | | Backport #30240 by wxiaoguang Major changes: * Move some functions like "addReader" / "isSubDir" / "addRecursiveExclude" to a separate package, and add tests * Clarify the filename&dump type logic and add tests * Clarify the logger behavior and remove FIXME comments Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Render embedded code preview by permlink in markdown (#30234) (#30249)Giteabot2024-04-0322-21/+450
| | | | | | | | Backport #30234 by wxiaoguang The permlink in markdown will be rendered as a code preview block, like GitHub Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
* Fix missing 0 prefix of GPG key id (#30245) (#30248)Giteabot2024-04-023-7/+23
| | | | | | | | | | | | | | Backport #30245 by @KN4CK3R Fixes #30235 If the key id "front" byte has a single digit, `%X` is missing the 0 prefix. ` 38D1A3EADDBEA9C` instead of `038D1A3EADDBEA9C` When using the `IssuerFingerprint` slice `%X` is enough but I changed it to `%016X` too to be consistent. Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Fix spacing in issue navbar (#30238) (#30242)Giteabot2024-04-024-3/+8
| | | | | | | | | | | Backport #30238 by @silverwind Create a new `issue-navbar` class specifically for this bar, previous class used in many places and I thought I had them all removed, but not this one. Fixes: https://github.com/go-gitea/gitea/issues/30226 Co-authored-by: silverwind <me@silverwind.io>
* Refactor dropzone (#30232) (#30233)Giteabot2024-04-021-29/+21
| | | | | | | Backport #30232 by wxiaoguang Simplify code and use `.files` elements Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Remove scheduled action tasks if the repo is archived (#30224) (#30230)Giteabot2024-04-014-2/+29
| | | | | | | Backport #30224 by @Zettat123 Fix #30220 Co-authored-by: Zettat123 <zettat123@gmail.com>
* Refactor file view & render (#30227) (#30229)Giteabot2024-04-017-33/+40
| | | | | | | Backport #30227 by wxiaoguang The old code is inconsistent and fragile, and the UI isn't right. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Prevent flash of dropdown menu on labels list (#30215) (#30216)Giteabot2024-04-012-1/+7
| | | | | | | | | | | | | Backport #30215 by @silverwind On the labels list, This `left` class caused the dropdown content to flash on page load until JS had hidden it. Remove it as I see no purpose to it. <img width="215" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/9e1de97f-dd89-41e0-9229-5c4a786ba762"> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Refactor DeleteInactiveUsers, fix bug and add tests (#30206) (#30222)Giteabot2024-04-013-33/+45
| | | | | | | | | | | | | Backport #30206 by wxiaoguang 1. check `IsActive` before calling `IsLastAdminUser`. 2. Fix some comments and error messages. 3. Don't `return err` if "removing file" fails in `DeleteUser`. 4. Remove incorrect `DeleteInactiveEmailAddresses`. Active users could also have inactive emails, and inactive emails do not support "olderThan" 5. Add tests Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix home topic edit form layout (#30213)wxiaoguang2024-03-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | The UI has been refactored by #30191 , so here are 2 choices: 1. Backport #30191 2. Apply this quick fix Before: <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/0db583cf-8ce8-4fdb-9e4d-8c93fe6766c7) </details> After: <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/0e732c4c-d28d-4c04-b328-72b9efd7daa9) </details> Co-authored-by: Giteabot <teabot@gitea.io>
* Fix markdown color code detection (#30208) (#30211)Giteabot2024-03-312-3/+26
| | | | | | | | | Backport #30208 by wxiaoguang When reviewing PRs, some color names might be mentioned, the `transformCodeSpan` (which calls `css.ColorHandler`) considered it as a valid color, but actually it shouldn't be rendered as a color codespan. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Remove `modifies/frontend` from labeler (#30198) (#30212)Giteabot2024-03-311-7/+0
| | | | | | | | | Backport #30198 by @silverwind Remove this label, I find it barely useful and we already have more useful labels like `modifies/js`. Backport so that we can eventually delete that label. Co-authored-by: silverwind <me@silverwind.io>
* Fix GPG subkey verify (#30193) (#30203)Giteabot2024-03-311-0/+4
| | | | | | | | | Backport #30193 by @KN4CK3R Fixes #30189 Can't verify subkeys if they are not loaded. Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Do not allow different storage configurations to point to the same directory ↵Giteabot2024-03-3112-47/+75
| | | | | | | | | (#30169) (#30204) Backport #30169 by wxiaoguang Replace #29171 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix unclickable checkboxes (#30195) (#30199)Giteabot2024-03-312-5/+14
| | | | | | | | | | | | | | | | | | Backport #30195 by @silverwind Fix https://github.com/go-gitea/gitea/issues/30185, regression from https://github.com/go-gitea/gitea/pull/30162. The checkboxes were unclickable because the label was positioned over the checkbox with `padding`. Now it uses `margin` so the checkbox itself will be clickable in all cases. Secondly, I changed the for/id linking to also add missing `for` attributes when `id` is present. The other way around (only `for` present) is currently not handled and I think there are likey no occurences in the code and introducing new non-generated `id`s might cause problems elsewhere if we do, so I skipped on that. Co-authored-by: silverwind <me@silverwind.io>
* Include encoding in signature payload (#30174) (#30182)Giteabot2024-03-303-0/+75
| | | | | | | | | | | | | | | | | Backport #30174 by @KN4CK3R Fixes #30119 Include the encoding in the signature payload. before ![grafik](https://github.com/go-gitea/gitea/assets/1666336/01ab94a3-8af5-4d6f-be73-a10b65a15421) after ![grafik](https://github.com/go-gitea/gitea/assets/1666336/3a37d438-c70d-4d69-b178-d170e74aa683) Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Remove fomantic checkbox module (#30162) (#30168)Giteabot2024-03-2918-1730/+181
| | | | | | | | | | | | | | | | | | | | Backport #30162 by @silverwind CSS is pretty slim already and the `.ui.toggle.checkbox` sliders on admin page also still work. The only necessary JS is the one that links `input` and `label` so that it can be toggled via label. All checkboxes except the markdown ones render at `--checkbox-size: 16px` now. <img width="174" alt="Screenshot 2024-03-28 at 22 15 10" src="https://github.com/go-gitea/gitea/assets/115237/3455c1bb-166b-47e4-9847-2d20dd1f04db"> <img width="499" alt="Screenshot 2024-03-28 at 21 00 07" src="https://github.com/go-gitea/gitea/assets/115237/412be2b3-d5a0-478a-b17b-43e6bc12e8ce"> <img width="83" alt="Screenshot 2024-03-28 at 22 14 34" src="https://github.com/go-gitea/gitea/assets/115237/d8c89838-a420-4723-8c49-89405bb39474"> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: delvh <dev.lh@web.de>
* Fix:the rounded corners of the folded file are not displayed correctly ↵Giteabot2024-03-291-1/+2
| | | | | | | | | | | | | | | | | | (#29953) (#30177) Backport #29953 by @HEREYUA Fix: [#29933](https://github.com/go-gitea/gitea/issues/29933) **Before** ![image](https://github.com/go-gitea/gitea/assets/37935145/71ec80f6-5896-4e4a-b686-4d792c11ebe2) **After** ![image](https://github.com/go-gitea/gitea/assets/37935145/81348a61-946a-4562-881d-8d873e50228f) Co-authored-by: HEREYUA <37935145+HEREYUA@users.noreply.github.com> Co-authored-by: silverwind <me@silverwind.io>
* Refactor topic Find functions and add more tests for pagination (#30127) ↵Giteabot2024-03-297-32/+70
| | | | | | | | | (#30167) Backport #30127 by @lunny This also fixed #22238 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>