aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Refactor SecToTime() function (#18863)René Schaar2022-02-283-40/+64
| | | | | - Add helper method to reduce redundancy - Expand the scope from displaying days to years - Reduce irrelevance by not displaying small units (hours, minutes, seconds) when bigger ones apply (years)
* Improve mirror iterator (#18928)Lunny Xiao2022-02-284-19/+19
| | | | | * Improve mirror iterator * fix test
* Fix login with email panic when email is not exist (#18941)Lunny Xiao2022-02-281-1/+1
|
* Adjust error for already locked db and prevent level db lock on malformed ↵zeripath2022-02-271-6/+42
| | | | | | | | | | | | connstr (#18923) This PR adjusts the error returned when there is failure to lock the level db, and permits a connections to the same leveldb where there is a different connection string. Reference #18921 Reference #18917 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Avoid database lookups for `DescriptionHTML` (#18924)Gusted2022-02-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Avoid database lookups for `DescriptionHTML` - Don't Compose meta's for DescriptionHTML, they are only needed in order to correctly format and show issue's but it's highly unlikely that a repository description will refer to a local issue. Using 125 Connections for 5 seconds: on `/explore/repos`(which is the most noticeable usage by this function's database lookups): Before: Statistics Avg Stdev Max Reqs/sec 569.41 506.05 2715.00 Latency 214.27ms 16.60ms 294.84ms HTTP codes: 1xx - 0, 2xx - 2974, 3xx - 0, 4xx - 0, 5xx - 0 others - 0 Throughput: 27.17MB/s After: Statistics Avg Stdev Max Reqs/sec 1585.04 789.84 4144.56 Latency 78.89ms 15.89ms 206.94ms HTTP codes: 1xx - 0, 2xx - 7975, 3xx - 0, 4xx - 0, 5xx - 0 others - 0 Throughput: 73.85MB/s Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: zeripath <art27@cantab.net>
* Update go-org to v1.6.1 (#18932)Gusted2022-02-272-6/+4
| | | | | - v1.6.0 has a inconsistency with the proxy and github's tagged version, updating to v1.6.1 should fix this issue. - Resolves #18864
* Fix trace log to show value instead of pointers (#18926)Gusted2022-02-271-1/+8
| | | | | | | | | | - Fixes a issue with a trace of repo.Units whereby it would show the pointers. Before: ![image](https://user-images.githubusercontent.com/25481501/155876811-036bf40e-db89-4e09-ac00-0c78ce3f5bef.png) After: ![image](https://user-images.githubusercontent.com/25481501/155885102-16c9cf29-314b-4f32-bcee-80e332f63dec.png)
* Add announcement steps to release-howto (#18896)Norwin2022-02-271-0/+5
| | | | | | * add announcements steps to release-howto * Also add homebrew update
* Fix `<strong>` html in translation (#18929)Gusted2022-02-271-2/+2
|
* Fix page and missing return on unadopted repos API (#18848)qwerty2872022-02-273-2/+4
| | | | | | | | | * Fix page and missing return on unadopted repos API Page must be 1 if it's not specified and it should return after sending an internal server error. * Allow ignore pages Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* [skip ci] Updated licenses and gitignoresGiteaBot2022-02-271-0/+58
|
* Allow adminstrator teams members to see other teams (#18918)Gusted2022-02-261-0/+16
| | | | | | * Allow adminstrator teams to see other teams - Allow team members with adminstrator access, to view other teams. - Resolves #18885
* Update nginx reverse proxy docs (#18922)JonRB2022-02-261-0/+8
| | | | | Add additional config lines for the set_header to forward additional information (eg the IP) Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Don't treat BOM escape sequence as hidden character. (#18909)Gusted2022-02-262-4/+25
| | | | | | | | | | | * Don't treat BOM escape sequence as hidden character. - BOM sequence is a common non-harmfull escape sequence, it shouldn't be shown as hidden character. - Follows GitHub's behavior. - Resolves #18837 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Remove CodeMirror dependencies (#18911)silverwind2022-02-26360-61916/+3
| | | EasyMDE already loads all the modes and plugins it needs, so there is no reason for neither the webpack dependency nor the vendored copy
* Uncapitalize errors (#18915)Gusted2022-02-263-9/+9
| | | | | - See: https://github.com/golang/go/wiki/CodeReviewComments#error-strings Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Disable service worker by default (#18914)silverwind2022-02-264-5/+3
| | | | | | | | The service worker causes a lot of issues with JS errors after instance upgrades while not bringing any real performance gain over regular HTTP caching. Disable it by default for this reason. Maybe later we can remove it completely, as I simply see no benefit in having it.
* Set is_empty in fixtures (#18869)KN4CK3R2022-02-265-6/+43
|
* Don't update email for organisation (#18905)Gusted2022-02-261-1/+1
| | | | | | | - Fix regression caused by: f1b1472632e36c3bb5df73f184a6efeef47f5d01 - Don't try to insert a email for Organisation(as they don't have one). - Resolves #18891 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Correctly link URLs to users/repos with dashes, dots or underscores (#18890)Alexander Neumann2022-02-262-1/+10
| | | | | | | | * Add tests for references with dashes This commit adds tests for full URLs referencing repos names and user names containing a dash. * Extend regex to match URLs to repos/users with dashes
* Set is_private in fixtures. (#18868)KN4CK3R2022-02-251-0/+2
| | | Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Fix team management UI (#18886)Lunny Xiao2022-02-252-3/+3
| | | Co-authored-by: 6543 <6543@obermui.de>
* Update JS dependencies (#18898)silverwind2022-02-254-943/+936
| | | | | - Updated all JS dependencies minus Vue (update 2 to 3 requires a ton of work and is probably blocked by dependencies) - Tested editor, swagger-ui
* Fix migration v210 (#18892)Lunny Xiao2022-02-251-4/+10
|
* migrations: add test for importing pull requests in gitea uploader (#18752)singuliere2022-02-2512-20/+512
| | | | | | | | | | | | | | | | | | | * logs: add the buffer logger to inspect logs during testing Signed-off-by: Loïc Dachary <loic@dachary.org> * migrations: add test for importing pull requests in gitea uploader Signed-off-by: Loïc Dachary <loic@dachary.org> * for each git.OpenRepositoryCtx, call Close * Content is expected to return the content of the log * test for errors before defer Co-authored-by: Loïc Dachary <loic@dachary.org> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* BeforeSourcePath should point to base commit (#18799)Jimmy Praet2022-02-251-2/+2
| | | Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Prevent Stats Indexer reporting error if repo dir missing (#18870)zeripath2022-02-241-0/+3
| | | | | | | | | | Repositories missing their directory should not report an error from the stats indexer. Close #18847 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* [skip ci] Updated translations via CrowdinGiteaBot2022-02-251-1/+1
|
* Fix update user (#18878)Lunny Xiao2022-02-241-3/+4
|
* Fix ldap user sync missed email in email_address table (#18786)Lunny Xiao2022-02-242-6/+27
| | | | | * Fix ldap user sync missed email in email_address table * Fix test
* Update assignees check to include any writing team and change org sidebar ↵zeripath2022-02-233-33/+88
| | | | | | | | | | | | (#18680) Following the merging of #17811 teams can now have differing write and readonly permissions, however the assignee list will not include teams which have mixed perms. Further the org sidebar is no longer helpful as it can't describe these mixed permissions situations. Fix #18572 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Set max text height to prevent overflow (#18862)Kyle D2022-02-231-1/+1
| | | | | | | | | | | Sets a max height for review text boxes to prevent a very annoying bug where users cannot access the "submit" button. Before: ![image](https://user-images.githubusercontent.com/12700993/155253001-e1dab086-aaf3-4338-889d-6a861728274a.png) After: ![image](https://user-images.githubusercontent.com/12700993/155253144-5b9a3547-9582-412f-867f-41a45a14a0fe.png) Interestingly, I don't see this bug on Firefox.
* Lock gofumpt to v0.3.0 and run it (#18866)silverwind2022-02-2315-17/+30
| | | | | We can't depend on `latest` version of gofumpt because the output will not be stable across versions. Lock it down to the latest version released yesterday and run it again.
* Fix ldap edit bug (#18856)Lunny Xiao2022-02-221-1/+1
| | | Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Fix behavior or checkbox submission. (#18851)Gusted2022-02-221-0/+2
|
* Don't report signal: killed errors in serviceRPC (#18850)zeripath2022-02-221-1/+3
| | | | | Fix #18849 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Fix bug for get user by email (#18833)Lunny Xiao2022-02-211-12/+2
| | | Co-authored-by: zeripath <art27@cantab.net>
* migrations: remove dead code in gitea uploader (#18725)singuliere2022-02-211-13/+3
| | | | | | | | When migrating, g.issues is a map with all issues created during the migration. If an issue is not found in g.issues when inserting a comment or a review, it cannot exist in the database and trying to get it via GetIssueByIndex() will always fail and return an error. Signed-off-by: singuliere <singuliere@autistici.org>
* [skip ci] Updated translations via CrowdinGiteaBot2022-02-211-3/+1
|
* Show fullname on issue edits and gpg/ssh signing info (#18827)Wim2022-02-204-6/+16
| | | | | Show missing full names when configured to do so Co-authored-by: zeripath <art27@cantab.net>
* Update go-org to 1.6.0 (#18824)zeripath2022-02-202-9/+14
| | | | | | Fix #14074 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Fix login with email for ldap users (#18800)Lunny Xiao2022-02-201-1/+1
| | | `authenticator.Authenticate` has assume the login name is not an email, but `username` maybe an email. So when we find the user via email address, we should use `user.LoginName` instead of `username` which is an email address.
* [skip ci] Updated licenses and gitignoresGiteaBot2022-02-2011-191/+685
|
* Immediately Hammer if second kill is sent (#18823)zeripath2022-02-192-2/+7
| | | | | | | Currently Gitea will wait for HammerTime or nice shutdown if kill -1 or kill -2 is sent. We should just immediately hammer if there is a second kill. Signed-off-by: Andrew Thornton <art27@cantab.net>
* Fix panic in EscapeReader (#18820)zeripath2022-02-192-0/+10
| | | | | | There is a potential panic due to a mistaken resetting of the length parameter when multibyte characters go over a read boundary. Signed-off-by: Andrew Thornton <art27@cantab.net>
* Put buttons back in org dashboard (#18817)Lunny Xiao2022-02-191-0/+9
| | | Fix #18523
* Generate coverage with sqlite. (#18813)KN4CK3R2022-02-191-0/+7
|
* Update on-cloud-provider.md (#18807)Nicolas Ferrari2022-02-181-0/+6
|
* Fix ldap loginname (#18789)Johan Van de Wauw2022-02-184-8/+25
| | | | | | | | | | | | | | | | | | | | * Use email_address table to check user's email when login with email adress * Update services/auth/signin.go * Fix test * Fix test * Fix logging in with ldap username != loginname * Fix if user does not exist yet * Make more clear this is loginName * Fix formatting Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: zeripath <art27@cantab.net>
* Replace deprecated String.prototype.substr() with String.prototype.slice() ↵CommanderRoot2022-02-186-11/+11
| | | | | | | | | (#18796) String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with the slice() method which works similarily but isn't deprecated. Signed-off-by: Tobias Speicher <rootcommander@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>