summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix dump and restore respository (#16698) (#16898)Lunny Xiao2021-08-316-4/+17
| | | | | | | | | | * Fix dump and restore * return different error message for get commit * Fix missing delete release attachment when deleting repository * Fix ci and add some comments back port #16698 Co-authored-by: zeripath <art27@cantab.net>
* Fix git.Blob.DataAsync(): close pipe since we return a NopCloser (#16899) ↵65432021-08-314-9/+7
| | | | | | | | | (#16900) * make sure headGitRepo is closed on err too * refactor * Fix git.Blob.DataAsync(): exec cancel since we already read all bytes (close pipe since we return a NopCloser) Co-authored-by: zeripath <art27@cantab.net>
* Fix wiki raw commit diff/patch view (#16891) (#16892)65432021-08-311-1/+1
|
* Repare and Improve GetDiffRangeWithWhitespaceBehavior (#16894) (#16895)65432021-08-315-37/+26
| | | fix pipe leak
* Ensure wiki repos are all closed (#16886) (#16888)65432021-08-301-32/+34
| | | | | | | | There are multiple places where wiki git repositories are not properly closed. This PR ensures they are closed. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Andrew Thornton <art27@cantab.net>
* Simplify split diff view generation and remove JS dependency (#16775) (#16863)zeripath2021-08-304-75/+109
| | | | | | | | | | | | | Backport #16775 Gitea has relied on some slow JS code to match up added and deleted lines on the diff pages. This can cause a considerable slow down on large diff pages. This PR makes a small change meaning that the matching up can occur much more simply. Partial fix #1351 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Ensure that the default visibility is set on the user create page (#16845) ↵zeripath2021-08-291-1/+1
| | | | | | | | | | | (#16862) Backport #16845 Set the default visibility on the user create page. Fix #16840 Signed-off-by: Andrew Thornton <art27@cantab.net>
* In Render tolerate not being passed a context (#16842) (#16858)65432021-08-297-1/+20
| | | | | | | | | | | | | | | | | | | * In Render tolerate not being passed a context It is possible for RenderString to be passed to an external renderer if markdown is set to be rendered by an external renderer. No context is currently sent to these meaning that this will error out. Fix #16835 Signed-off-by: Andrew Thornton <art27@cantab.net> * Add Context to Repo calls for RenderString All calls from routers can easily add the context - so add it. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: zeripath <art27@cantab.net>
* Upgrade xorm to v1.2.2 (#16663) & Add test to ensure that dumping of login ↵zeripath2021-08-28135-5404/+42891
| | | | | | | | | | | | | | | | | | sources remains correct (#16847) (#16848) * Upgrade xorm to v1.2.2 (#16663) Backport #16663 Fix #16683 * Add test to ensure that dumping of login sources remains correct (#16847) #16831 has occurred because of a missed regression. This PR adds a simple test to try to prevent this occuring again. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Report the correct number of pushes on the feeds (#16811) (#16822)techknowlogick2021-08-263-2/+15
| | | | | | | | | | | | | | | | | | * Report the correct number of pushes on the feeds Since the number of commits in the Action table has been limited to 5 the number of commits reported on the feeds page is now incorrectly also limited to 5. The correct number is available as the Len and this PR changes this to report this. Fix #16804 Signed-off-by: Andrew Thornton <art27@cantab.net> * Update templates/user/dashboard/feeds.tmpl Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: zeripath <art27@cantab.net>
* Add primary_key to issue_index (#16813) (#16820)zeripath2021-08-253-5/+5
| | | | | | | | | | | | | | | | | | | | Backport #16813 Make the group_id a primary key in issue_index. This already has an unique index and therefore is a good candidate for becoming a primary key. This PR also changes all other uses of this table to add the group_id as the primary key. The migration v192 from #16813 has not been backported but Xorm will work fine with non-primary keyed tables. If a user on 1.15 wishes to have the correct schema sooner than 1.16 - they can use gitea doctor recreate-table issue_index and gitea will recreate the table with the primary key. Fix #16802 Signed-off-by: Andrew Thornton art27@cantab.net
* Prevent NPE on empty commit (#16812) (#16819)zeripath2021-08-251-0/+3
| | | | | | | | | Backport #16812 Handle completely empty commit as the first commit to a repository. Fix #16668 Signed-off-by: Andrew Thornton art27@cantab.net
* Fix branch pagination error (#16805) (#16816)Lunny Xiao2021-08-251-1/+1
| | | | | | | Backport #16805 Fix #16801 Even if default branch is removed from the current page, but the total branches number should be still kept. So that the pagination calculation will be correct.
* Ensure that template compilation panics are sent to the logs (#16788) (#16792)zeripath2021-08-231-0/+5
| | | | | | | | | | | | | | Backport #16788 Although panics within the rendering pipeline are caught and dealt with, panics that occur before that starts are unprotected and will kill Gitea without being sent to the logs. This PR adds a basic recovery handler to catch panics that occur after the logger is initialised and ensure that they're sent to the logger. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Remove spurious / from issues.opened_by (#16793)zeripath2021-08-232-2/+2
| | | | | | | Fix #16713 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Add missing return to handleSettingRemoteAddrError (#16794) (#16795)zeripath2021-08-231-0/+1
| | | | | | | | | | | | Backport #16794 There is a missing return in handleSettingRemoteAddrError which means that the error page for repo settings is duplicately rendered. Fix #16771 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Update only certmagic (#16790)zeripath2021-08-234-14/+20
| | | | | Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: jolheiser <john.olheiser@gmail.com>
* changelog for 1.15.0 (#16760)v1.15.0techknowlogick2021-08-211-47/+45
| | | | | | | | | | | | | | * changelog for 1.15.0 * Slight rename of GPG feature Signed-off-by: Andrew Thornton <art27@cantab.net> * Apply suggestions from code review Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de>
* Keep attachments on tasklist update (#16750) (#16757)KN4CK3R2021-08-212-16/+21
| | | | | | | | | | | | | * Send attachments too. * Use tasklist flag. * use action="ignoreAttachments" instead of "tasklist" * Use boolean parameter. * when the update request doesn't intend to update attachments (eg: change checkbox state), ignore attachment updates (#16762) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Recreate Tables should Recreate indexes on MySQL (#16718) (#16739)zeripath2021-08-201-0/+15
| | | | | | | | The MySQL indexes are not being renamed at the same time as RENAME table despite the CASCADE. Therefore it is probably better to just recreate the indexes instead. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Fix dependency translations (#16755)Steven2021-08-2020-40/+40
| | | Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
* Do not use thin scrollbars on Firefox (#16738) (#16745)Elouan Martinet2021-08-201-1/+0
| | | | | | | | | | | In #7269, thin scrollbars were added in Arc Green theme. It got moved in base theme in #13361. This PR removes the use of thin scrollbars which causes an accessibility issue. The scrollbars become too thin to be dragged. Signed-off-by: Elouan Martinet <exa@elou.world> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Fix wrong user in OpenID response (#16736) (#16741)KN4CK3R2021-08-203-10/+101
| | | | | | | | | | | * Fix wrong user in OpenID response (#16736) * Fixed usage of wrong user. * Added tests. * Fixed wrong import. Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Restore functionality for pushing non-standard refs (Partial #16705) (#16706)zeripath2021-08-171-5/+0
| | | | | | | | | | | | Partial Backport #16705 There was an inadvertent breaking change in #15629 meaning that notes refs and other git extension refs will be automatically rejected. This PR removes this incorrect forced rejection of non-standard refs. Fix #16688 Signed-off-by: Andrew Thornton <art27@cantab.net>
* release/v1.15: set min go version to min upstream supported go1.16 (#16710)techknowlogick2021-08-173-4/+4
| | | | | * release/v1.15: set min go version to min upstream supported 1.16 * update drone
* Upgrade levelqueue 0.4.1 (#16696) (#16700)Lunny Xiao2021-08-164-8/+8
|
* Ensure empty lines are copiable and final new line too (#16678) (#16692)zeripath2021-08-152-0/+116
| | | | | | | | | | Backport #16678 When files are highlighted the newline character needs to be added in a whitespace compliant mode. Also ensure the final empty newline is rendered. Fix #16434 Signed-off-by: Andrew Thornton <art27@cantab.net>
* If PatchURL is empty, skip pull patch download when migrating (Partial ↵65432021-08-131-0/+3
| | | | | | | #16356) (#16681) Partial backport #16356 Whilst looking at adding migration support for onedev it has become apparent that gitea would attempt to pull patches on other migration targets even if that PatchURL was empty.
* Update issue_index to finish migration (#16685) (#16687)65432021-08-132-0/+30
| | | | | * update issue_index to finish migration * One Func to RecalculateIssueIndexForRepo
* Fix NPE in fuzzer (#16680) (#16682)65432021-08-133-1/+20
| | | | | | | | | The fuzzer found an issue with the issue pattern processor where there is a spurious path.Clean which does not need to be there. This PR also sets the default AppURL for the fuzzer too. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: zeripath <art27@cantab.net>
* Change the implementation of the go-git version of GetNote to mirror the non ↵nitul19912021-08-092-0/+15
| | | | | | | go-git version when passed a non-existent commit (#16658) (#16659) Backport #16658 Fixes #16657
* Fix direct creation of external users on admin page (#16613)zeripath2021-08-091-1/+3
| | | | | | From #16612 it was noticed that when creating new external users directly it was not possible to set their username correctly. This PR restores this ability. Signed-off-by: Andrew Thornton <art27@cantab.net>
* Restore compatibility with SQLServer 2008 R2 in migrations (#16638)zeripath2021-08-081-6/+3
| | | | | | | | | | | | | | | | This fixes two problems with MSSQL: * `ALTER TABLE DROP ... IF EXISTS ...` is only supported in SQL Server >16. The `IF EXISTS` here is a belt-and-braces and does not need to be present. Therefore can be dropped. Also stop attempting to drop the indexes as constraints as they're indexes! * System tables like: `sys.indexes` should be lowercase not uppercase because of collation issues. Fix #13615 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Changelog for 1.15.0-rc3 (#16621)v1.15.0-rc3zeripath2021-08-061-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Changelog for 1.15.0-rc3 ## [1.15.0-rc3](https://github.com/go-gitea/gitea/releases/tag/v1.15.0-rc3) - 2021-08-04 * BREAKING * Upgrade to the latest version of golang-jwt and increase minimum go to 1.15 (#16590) (#16606) * SECURITY * Upgrade to the latest version of golang-jwt and increase minimum go to 1.15 (#16590) (#16606) * Switch to maintained jwt lib (#16532) (#16533) * Correctly create of git-daemon-export-ok files (#16508) (#16514) * Don't show private user's repo in explore view (#16550) (#16554) * API * Swagger AccessToken fixes (#16574) (#16597) * Set AllowedHeaders on API CORS handler (#16524) (#16618) * BUGFIXES * Restore Accessibility for Dropdown (#16576) (#16617) * Pass down SignedUserName down to AccessLogger context (#16605) (#16616) * Fix table alignment in markdown (#16596) (#16602) * Fix 500 on first wiki page (#16586) (#16598) * Lock goth/gothic and Re-attempt OAuth2 registration on login if registration failed at startup (#16564) (#16570) * Upgrade levelqueue to v0.4.0 (#16560) (#16561) * Handle too long PR titles correctly (#16517) (#16549) * Fix data race in bleve indexer (#16474) (#16509) * Restore CORS on git smart http protocol (#16496) (#16506) * Fix race in log (#16490) (#16505) * Fix prepareWikiFileName to respect existing unescaped files (#16487) (#16498) * Make cancel from CatFileBatch and CatFileBatchCheck wait for the command to end (#16479) (#16480) * Update notification table with only latest data (#16445) (#16469) * Revert to use alpine 3.13 (#16451) (#16452) * Fix crash following ldap authentication update (#16447) (#16448) * Fix direct creation of external users on admin page (partial #16612) (#16613) Signed-off-by: Andrew Thornton <art27@cantab.net> * Update CHANGELOG.md Co-authored-by: techknowlogick <techknowlogick@gitea.io> * Update CHANGELOG.md Co-authored-by: zeripath <art27@cantab.net> * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lauris BH <lauris@nix.lv>
* Prevent 500 on draft releases without tag (#16634) (#16636)techknowlogick2021-08-061-1/+3
| | | | | | | | | | | | | | | | It is possible to create draft releases prior to creating a tag. This will cause a 500 on the releases page due to compare page failing. This PR only shows the compare button if there is a SHA1 present. Fix #16610 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
* Frontport changelog for v1.14.6 (#16633)zeripath2021-08-062-1/+11
| | | | | | | | | | | | | * Frontport changelog for v1.14.6 Frontport #16619 Changelog frontported to below v1.15.0-rc1. Signed-off-by: Andrew Thornton <art27@cantab.net> * Update config.yaml Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Update node tar dependency to 6.1.6 (#16622) (#16623)zeripath2021-08-051-6/+6
| | | | | | | | | Backport #16622 Forcibly update dev dependency on tar to 6.1.6 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Set AllowedHeaders on API CORS handler (#16524) (#16618)zeripath2021-08-042-0/+2
| | | | | | | | | | Backport #16524 Set AllowedHeaders on API CORS handler and add missing Access-Control-Expose-Headers to pull API. Fix #16100 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Pass down SignedUserName down to AccessLogger context (#16605) (#16616)zeripath2021-08-043-4/+28
| | | | | | | | | | | | | | | | Backport #16605 Unfortunately when the AccessLogger was moved back before the contexters the SignedUserName reporting was lost. This is due to Request.WithContext leading to a shallow copy of the Request and the modules/context/Context being within that request. This PR adds a new context variable of a string pointer which is set and handled in the contexters. Fix #16600 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Restore #10096/#8638 and re-fix #15172 (#16576) (#16617)zeripath2021-08-045-10/+4450
| | | | | | | | | | | | | | | | | | | Backport #16576 This PR restores the vendored and patched dropdow from #8638. It however, it partially abandons the call to `click()` using instead the default dropdown click calls instead. This prevents the issue of the dropdown grabbing focus permanently however, this may have negative effects on the effect of focus on the dropdowns. Of note, the behaviour of the template selector dropdown on the repo creation page is slightly odd - I don't believe that this odd behaviour is caused by this PR but rather by the feed source for this. I suspect that the dropdown should be adding a delete button to its selection. Fix #15172 References: #7057 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Fix table alignment in markdown (#16596) (#16602)zeripath2021-08-041-1/+3
| | | | | | | | | | Backport #16596 Set the TableOptions in markdown to allow alignment of the tables to work correctly Fix #15959 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Fix 500 on first wiki page (#16586) (#16598)zeripath2021-08-032-0/+32
| | | | | | | | | | | | | | Backport #16586 There is a mistake in #16319 and #16487 which means that the first time a wiki page is created a 500 is reported because the `master` branch is not in existence in that wiki yet. This PR simply checks for this error and returns not found. Fix #16584 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Upgrade to the latest version of golang-jwt (#16590) (#16606)zeripath2021-08-0314-52/+203
| | | | | | | | | | | | | | | | | | | | | | | | * Upgrade to the latest version of golang-jwt. Backport #16590 * Forcibly update the vendored versions too * Update our minimal go lang version to 1.15 (differs from 1.16 in #16590) Signed-off-by: Andrew Thornton <art27@cantab.net> ### :warning: BREAKING :warning: This PR raises the minimal version of go supported to 1.15 which will mean the end of support of 32-bit Mac and Mac OS versions before Sierra. Signed-off-by: Andrew Thornton <art27@cantab.net> * update minimal go required Signed-off-by: Andrew Thornton <art27@cantab.net> * update config.yaml Signed-off-by: Andrew Thornton <art27@cantab.net>
* Swagger AccessToken fixes (#16574) (#16597)zeripath2021-08-024-31/+27
| | | | | | | | | | | | | | | Backport #16574 There is a subtle problem with the Swagger definition for AccessTokens which causes autogeneration of APIs for these endpoints to fail. This PR corrects these errors. Ref: https://github.com/zeripath/java-gitea-api/issues/4 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* [CI] Use node v14 instead of node v16 until it will pass again (#16595) (#16599)65432021-08-021-7/+7
| | | | | * for CI release: use node 14 (lts) to build until 16 do fail * all in for node v14.x
* Lock goth/gothic and Re-attempt OAuth2 registration on login if registration ↵zeripath2021-07-292-5/+21
| | | | | | | | | | | | | | | | | | | | failed at startup (#16570) Backport #16564 This PR has two parts: * Add locking to goth and gothic calls with a RWMutex The goth and gothic calls are currently unlocked and thus are a cause of multiple potential races * Reattempt OAuth2 registration on login if registration failed If OAuth2 registration fails at startup we currently disable the login_source however an alternative approach could be to reattempt registration on login attempt. Fix #16096 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Upgrade levelqueue to v0.4.0 (#16560) (#16561)Lunny Xiao2021-07-276-2/+13
| | | Fix #16546
* not show private user's repo in explore view (#16550) (#16554)a10121127962021-07-271-5/+3
| | | | | | after #16069, visibility is also usefull for user, so this limit is not usefull. fix #16545
* Fix session bugs (#16552) (#16553)65432021-07-273-17/+47
| | | | | | | | | | | | | | | * Fix session bugs (#16552) * fix deadlog bug * Fix models/issue_stopwatch.go * Update models/issue_stopwatch.go Co-authored-by: zeripath <art27@cantab.net> * fix getLatestCommitStatus Co-authored-by: zeripath <art27@cantab.net>
* Handle too long PR titles correctly (#16517) (#16549)zeripath2021-07-264-4/+64
| | | | | | | | | | | | | | | | Backport #16517 The CompareAndPullRequestPost handler for POST to /compare incorrectly handles returning errors to the user. For a start it does not set the necessary markers to switch SimpleMDE but it also does not immediately return to the form. This PR fixes this by setting the appropriate values, fixing the templates and preventing the suggestion of a too long title. Fix #16507 Signed-off-by: Andrew Thornton <art27@cantab.net>
generated by cgit v1.2.3 (git 2.39.1) at 2025-03-10 09:13:19 +0000