summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Disable core.protectNTFS (#17300) (#17302)zeripath2021-10-134-0/+10
| | | | | | | | | | | | | | | | Backport #17300 core.protectNTFS protects NTFS from files which may be difficult to remove or interact with using the win32 api, however, it also appears to prevent such files from being entered into the git indexes - fundamentally causing breakages with PRs that affect these files. However, deliberately setting this to false may cause security issues due to the remain sparse checkout of files in the merge pipeline. The only sensible option therefore is to provide an optional setting which admins could set which would forcibly switch this off if they are affected by this issue. Fix #17092 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Use pointer for wrappedConn methods (#17295) (#17296)zeripath2021-10-121-3/+3
| | | | | | | Backport #17295 Fix #17294 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Backport of fix for auto registration - PR #17219 (#17292)Viktor Kuzmin2021-10-121-1/+1
|
* Handle duplicate keys on GPG key ring (#17242) (#17284)zeripath2021-10-111-0/+40
| | | | | | | | | | | | | | Backport #17242 It is possible that a keyring can contain duplicate keys on a keyring due to jpegs or other layers. This currently leads to a confusing error for the user - where we report a duplicate key insertion. This PR simply coalesces keys into one key if there are duplicates. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: 6543 <6543@obermui.de>
* Changelog for 1.15.4v1.15.4Matti R2021-10-081-0/+24
|
* API: don't allow merged PRs to be reopened (#17271)Norwin2021-10-082-1/+14
|
* don't try to interpret treepath as hash (#17272)Norwin2021-10-081-1/+1
| | | | | | | | | | | | | ...when path contains no hash-path-separator ('/') This is a workaround to #17179. Entering this case when `path` does not contain a '/' does not really make sense, as that means the tree path is empty, but this case is only entered for routes that expect a non-empty tree path. Treepaths like <40-char-dirname>/<filename> will still fail, but hopefully don't occur that often. A more complete fix that avoids this case too is outlined in #17185, but too big of a change to backport
* Fix incorrect repository count on organization tab of dashboard (#17266)Jimmy Praet2021-10-081-1/+1
| | | Fixes #17249
* Fix unwanted team review request deletion (#17257) (#17264)Jimmy Praet2021-10-071-1/+1
| | | | Add missing issue_id = ? to where clause Fixes #17251
* CI: migrate from 'plugins/s3:1' to 'woodpeckerci/plugin-s3:latest' (#17234) ↵65432021-10-071-3/+3
| | | | | | (#17260) - this fixes the CI release upload issues, as the docker image for this is freshly built (unlike the mostly unmaintained "official" drone plugins), thus containing current CA certs needed for letsencrypt since 2021-09-31. - woodpecker is a drone-ci fork maintained partially by @6543. it's API compatible with current drone plugins afaik
* Remove dead badge on README.md (#17261)65432021-10-071-3/+0
|
* Fix broken Activities link in team dashboard (#17255) (#17258)Jimmy Praet2021-10-071-1/+1
| | | | | Remove '/' suffix from organization dashboard link Fixes #17250
* API pull's head/base have correct permission(#17214) (#17245)pricly-yellow2021-10-074-22/+34
| | | | | | | | | | | | | | | | | | | * for all pull requests API return permissions of caller * for all webhook return empty permissions Signed-off-by: Danila Kryukov <pricly_yellow@dismail.de> * Fix incorrect error handler Co-authored-by: delvh <dev.lh@web.de> * Fix wrong assumption in tests * Change paramenter name to doer to indicate source Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: 6543 <6543@obermui.de>
* Fix stange behavior of DownloadPullDiffOrPatch in incorect index (#17223) ↵pricly-yellow2021-10-053-18/+11
| | | | | | | | (#17227) Fix GetPullRequestByIndex by validate index > 1 Signed-off-by: Danila Kryukov <pricly_yellow@dismail.de> Co-authored-by: a1012112796 <1012112796@qq.com>
* Check user instead of organization when creating a repo from a template via ↵65432021-10-011-4/+9
| | | | | | | | | API (#16346) (#17195) * Check user instead of organization * Enforce that only admins can copy a repo to another user Co-authored-by: Ion Jaureguialzo Sarasola <ion@jaureguialzo.com>
* upgrade xorm to v1.2.5 (#17177) (#17188)Lunny Xiao2021-09-306-8/+8
|
* fix sprintf verbs in locales (#17187)Alexey 〒erentyev2021-09-309-19/+19
| | | | | Signed-off-by: Alexey Terentyev <axifnx@gmail.com> Co-authored-by: 6543 <6543@obermui.de>
* Fix missing repo link in issue/pull assigned emails (#17183) (#17184)zeripath2021-09-304-4/+14
| | | | | | | | | | | | | | | Backport #17183 There was a mistake in the template file: `templates/mail/issue/assigned.tmpl` where the repourl was generated from a non-existent release instead of the issue. This PR changes this to use the issue but also ensure that the issue repo is loaded. It also slightly improves the English and the Russian locale string. Fix #17160 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de>
* Fix bug of get context user (#17169) (#17172)Lunny Xiao2021-09-282-10/+12
| | | Co-authored-by: 6543 <6543@obermui.de>
* Nicely handle missing user in collaborations (#17049) (#17166)zeripath2021-09-284-222/+155
| | | | | | | | | | | | | | | | | Backport #17049 It is possible to have a collaboration in a repository which refers to a no-longer existing user. This causes the repository transfer to fail with an unusual error. This PR makes `repo.getCollaborators()` nicely handle the missing user by ghosting the collaboration but also adds consistency check. It also adds an Access consistency check. Fix #17044 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Create doctor command to fix repo_units broken by dumps from 1.14.3-1.14.6 ↵zeripath2021-09-274-13/+607
| | | | | | | | | | | | | | | | | | (#17136) (#17137) Backport #17136 There was a serious issue with the `gitea dump` command in 1.14.3-1.14.6 which led to corruption of the `config` field of the `repo_unit` table. This PR adds a doctor command to attempt to fix the broken repo_units. Users affected by #16961 should run: ``` gitea doctor --fix --run fix-broken-repo-units ``` Fix #16961 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Add Horizontal scrollbar to inner menu on Chrome (#17086) (#17164)zeripath2021-09-271-0/+2
|
* Fix wrong i18n keys (#17150) (#17153)65432021-09-262-5/+5
| | | | | Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* correct transaction ending (#17151)Alexey 〒erentyev2021-09-251-2/+4
| | | Signed-off-by: Alexey Terentyev <axifnx@gmail.com>
* Prevent panic in Org mode HighlightCodeBlock (#17140) (#17141)zeripath2021-09-243-12/+46
| | | | | | | | | | | | | Backport #17140 When rendering source in org mode there is a mistake in the highlight code that causes a panic. This PR fixes this. Fix #17139 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Changelog 1.15.3 (#17091)v1.15.3zeripath2021-09-201-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | ## [1.15.3](https://github.com/go-gitea/gitea/releases/tag/v1.15.3) - 2021-09-19 * ENHANCEMENTS * Add fluid to ui container class to remove margin (#16396) (#16976) * Add caller to cat-file batch calls (#17082) (#17089) * BUGFIXES * Render full plain readme. (#17083) (#17090) * Upgrade xorm to v1.2.4 (#17059) * Fix bug of migrate comments which only fetch one page (#17055) (#17058) * Do not show issue context popup on external issues (#17050) (#17054) * Decrement Fork Num when converting from Fork (#17035) (#17046) * Correctly rollback in ForkRepository (#17034) (#17045) * Fix missing close in WalkGitLog (#17008) (#17009) * Add prefix to SVG id/class attributes (#16997) (#17000) * Fix bug of migrated repository not index (#16991) (#16996) * Skip AllowedUserVisibilityModes validation on update user if it is an organisation (#16988) (#16990) * Fix storage Iterate bug and Add storage doctor to delete garbage attachments (#16971) (#16977) * Fix issue with issue default mail template (#16956) (#16975) * Ensure that rebase conflicts are handled in updates (#16952) (#16960) * Prevent panic on diff generation (#16950) (#16951) Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Add caller to cat-file batch calls (#17082) (#17089)zeripath2021-09-202-8/+29
| | | | | | | | | | | Some people still appear to report unclosed cat-files. This PR simply adds the caller to the process descriptor for the CatFileBatch and CatFileBatchCheck calls. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Render full plain readme. (#17083) (#17090)zeripath2021-09-191-0/+4
| | | | | | | Backport #17083 Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Fix bug of migrate comments which only fetch one page (#17055) (#17058)Lunny Xiao2021-09-151-2/+7
| | | | | | | | | * Fix bug of migrate comments which only fetch one page * add next page to trace Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: zeripath <art27@cantab.net>
* Upgrade xorm to v1.2.4 (#17059)Lunny Xiao2021-09-1513-163/+151
|
* Do not show issue context popup on external issues (#17050) (#17054)zeripath2021-09-154-4/+14
| | | | | | | | | | Backport #17050 The issues pop-up context cannot work for external issues - therefore do not show these. Fix #17047 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Correctly rollback in ForkRepository (#17034) (#17045)zeripath2021-09-152-21/+41
| | | | | | | | | | | | | | | | | Backport #17034 The rollback functionality in services/repository/repository.go:ForkRepository is incorrect and could lead to a deadlock as it uses DeleteRepository to delete the rolled-back repository - a function which creates its own transaction. This PR adjusts the rollback function to only use RemoveAll as any database changes will be automatically rolled-back. It also handles panics and adjusts the Close within WithTx to ensure that if there is a panic the session will always be closed. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Decrement Fork Num when converting from Fork (#17035) (#17046)zeripath2021-09-153-4/+39
| | | | | | | | | | Backport #17035 When converting repositories from forks to normal the root NumFork needs to be decremented too. Fix #17026 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Fix missing close in WalkGitLog (#17008) (#17009)zeripath2021-09-101-7/+16
| | | | | | | | | | | | | | | | | | | | Backport #17008 When the external context is cancelled it is possible for the GitLogReader to not itself be Closed. This PR does three things: 1. Instead of adding a plain defer it wraps the `g.Close` in a func as `g` may change. 2. It adds the missing explicit g.Close - although the defer fix makes this unnecessary. 3. It passes down the external context as the base context for the GitLogReader meaning that the cancellation of the external context will pass down automatically. Fix #17007 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Use filename as id/class prefix. (#16997) (#17000)KN4CK3R2021-09-092-1/+2
| | | | | | | | | | | | | Currently the svg minifier (`make svg`) rewrites all `id` and `class` attributes in svg files. Every file gets the ids `a, b, ...`. If multiple svgs with ids are used on a page these ids are conflicting and the results are broken images. | minified ids | unique ids | | - | - | | ![grafik](https://user-images.githubusercontent.com/1666336/132579375-59d3996f-c4e5-43b8-8c8d-82280c90d9e3.png) | ![grafik](https://user-images.githubusercontent.com/1666336/132579413-05bf9285-4e3b-4d0d-8f95-90b212405b05.png) | This PR adds a prefix (the filename) to every id/class. Follow up problem: Because we embed svg images there are duplicated ids if one svg image is used multiple times on a page. As those ids refer to the same content it may be no real problem because browser handle that fine.
* Fix bug of migrated repository not index (#16991) (#16996)65432021-09-091-3/+2
| | | | | Fix #16986, #16152 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Skip AllowedUserVisibilityModes validation on update user if it is an ↵65432021-09-081-2/+2
| | | | | | | | | organisation (#16988) (#16990) if AllowedUserVisibilityModes allow only public & limited, and orgs can be private, a user can create a repo to that organisation whitch will result in an update of the user. On this call the user is validaten and will be rejected since private is not allowed, but its not an user its an valid org ... Co-authored-by: Alexey 〒erentyev <axifnx@gmail.com> Co-authored-by: Alexey 〒erentyev <axifnx@gmail.com>
* Fix storage Iterate bug and Add storage doctor to delete garbage attachments ↵Lunny Xiao2021-09-074-3/+83
| | | | | | | | | (#16971) (#16977) * Fix storage Iterate bug and Add storage doctor to delete garbage attachments * Close object when used
* Fix issue with issue default mail template (#16956) (#16975)Prasad Katti2021-09-071-1/+1
| | | | | | | | | | | | Backport #16956 The mail template rendering was failing with the error - `...vices/mailer/mail.go:301:composeIssueCommentMessages() [E] ExecuteTemplate [issue/default/body]: template: issue/default:65:10: executing "issue/default" at <.i18n.Tr>: can't evaluate field i18n in type *models.Comment` The issue was the template variable i18n is available in the outer scope. Fix #16877 Co-authored-by: 6543 <6543@obermui.de>
* Add fluid to ui container class to remove margin (#16396) (#16976)silverwind2021-09-072-2/+2
| | | Co-authored-by: Stanley Hu <stanthetiger@yahoo.com>
* Ensure that rebase conflicts are handled in updates (#16952) (#16960)zeripath2021-09-052-0/+18
| | | | | | | | | | Backport #16952 PR #16125 did not update the error handlers to handle conflict errors relating to rebases. This PR adds them. Fix #16922 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Prevent panic on diff generation (#16950) (#16951)zeripath2021-09-051-0/+4
| | | | | | | | | | Backport #16950 The lastLeftIdx should be reset at the same time as creating a new section otherwise it is possible for a second addition to end up attempting to read a nil entry. Fix #16943 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Changelog 1.15.2 (#16940)v1.15.2zeripath2021-09-031-0/+6
| | | | | | | | | | ## [1.15.2](https://github.com/go-gitea/gitea/releases/tag/v1.15.2) - 2021-09-03 * BUGFIXES * Add unique constraint back into issue_index (#16938) * Close storage objects before cleaning (#16934) (#16942) Signed-off-by: Andrew Thornton <art27@cantab.net>
* Close storage objects before cleaning (#16934) (#16942)zeripath2021-09-031-0/+1
| | | | | | | | | | | | | Backport #16934 Storage.Iterate provides the path and an open object. On windows using local storage means that the objects will be locked thus preventing clean from deleting them. This PR simply closes the objects early. Fix #16932 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Add unique constraint back into issue_index (#16938)zeripath2021-09-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | There is a flaw in #16820 where it was missed that although xorm will not add a primary key to a table during syncing, it will remove an unique constraint. Users upgrading from 1.15.0 to 1.15.1 will therefore lose the unique constraint that makes this table work unless they run `gitea doctor recreate-table issue_index`. Postgres helpfully warns about this situation but MySQL does not. Main/1.16-dev is not affected by this issue as there is a migration that does the above recreation by default. Users moving directly to 1.15.1 from 1.14.x or lower are also not affected. Whilst we could force all users who ran 1.15.0 to do the above recreate-table call, this PR proposes an alternative: Just add the unique constraint back in for 1.15.x. This won't have any long term effects - just some wasted space for the unnecessary index. Fix #16936 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Changelog 1.15.1 (#16925)v1.15.1zeripath2021-09-021-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ## [1.15.1](https://github.com/go-gitea/gitea/releases/tag/v1.15.1) - 2021-09-02 * BUGFIXES * Allow BASIC authentication access to /:owner/:repo/releases/download/* (#16916) (#16923) * Prevent leave changes dialogs due to autofill fields (#16912) (#16920) * Ignore review comment when ref commit is missed (#16905) (#16919) * Fix wrong attachment removal (#16915) (#16917) * Gitlab Migrator: dont ignore reactions of last request (#16903) (#16913) * Correctly return the number of Repositories for Organizations (#16807) (#16911) * Test if LFS object is accessible (#16865) (#16904) * Fix git.Blob.DataAsync(): close pipe since we return a NopCloser (#16899) (#16900) * Fix dump and restore respository (#16698) (#16898) * Repare and Improve GetDiffRangeWithWhitespaceBehavior (#16894) (#16895) * Fix wiki raw commit diff/patch view (#16891) (#16892) * Ensure wiki repos are all closed (#16886) (#16888) * List limited and private orgs if authenticated on API (#16866) (#16879) * Simplify split diff view generation and remove JS dependency (#16775) (#16863) * Ensure that the default visibility is set on the user create page (#16845) (#16862) * In Render tolerate not being passed a context (#16842) (#16858) * Upgrade xorm to v1.2.2 (#16663) & Add test to ensure that dumping of login sources remains correct (#16847) (#16848) * Report the correct number of pushes on the feeds (#16811) (#16822) * Add primary_key to issue_index (#16813) (#16820) * Prevent NPE on empty commit (#16812) (#16819) * Fix branch pagination error (#16805) (#16816) * Add missing return to handleSettingRemoteAddrError (#16794) (#16795) * Remove spurious / from issues.opened_by (#16793) * Ensure that template compilation panics are sent to the logs (#16788) (#16792) * Update caddyserver/certmagic (#16789) (#16790) Signed-off-by: Andrew Thornton <art27@cantab.net>
* Allow BASIC authentication access to /:owner/:repo/releases/download/* ↵zeripath2021-09-024-10/+14
| | | | | | | | | | | (#16916) (#16923) Backport #16916 Duplicate #15987 to allow access to releases download through BASIC authentication. Fix #16914 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Prevent leave changes dialogs due to autofill fields (#16912) (#16920)zeripath2021-09-022-2/+2
| | | | | | | | | | Backport #16912 Add ignore-dirty to /user/settings/account Add autocomplete="off" to push_mirror_address form on /:owner/:repo/settings Fix #16861 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Ignore review comment when ref commit is missed (#16905) (#16919)Lunny Xiao2021-09-021-1/+2
| | | backport #16905
* Fix wrong attachment removal (#16915) (#16917)wxiaoguang2021-09-021-20/+11
| | | Backport #16917
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-06 20:38:57 +0000