summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix label display on new issues (#13590)silverwind2020-11-176-40/+26
| | | | | | | | | | | | | | | | | | * Fix label display on new issues PR #13570 broke label rendering for new issues and pulls because missed the fact that the code was relying on the DOM elements being toggled by JavaScript. On top of that, the label rendering for new issues and pull was using an outdated template which I consolidated in a new shared template. * remove wrapper element and style tweaks * style tweaks * use shared template for whole label list Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Change markdown font weight to 600 (#13584)silverwind2020-11-161-4/+4
| | | | | | | Previously it was reduced globally from 700 to 500 but it actually needs to be 600 to match GitHub's rendering. Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: zeripath <art27@cantab.net>
* Fix Fomatic Build (#13595)silverwind2020-11-161-2/+2
| | | Port of #13593 to 1.14
* [skip ci] Updated translations via CrowdinGiteaBot2020-11-161-10/+10
|
* Migration: Gitlab: Support Subdirectory (#13563)65432020-11-161-0/+18
| | | Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Fix comment triangles and tweak inline comment margins (#13554)silverwind2020-11-163-46/+18
| | | | - Fix various miscolored comment bubble triangles - Tweak padding on inline comment boxes
* Use mount but not register for chi routes (#13555)Lunny Xiao2020-11-166-16/+32
| | | | | | | | | | | | | | | * Use mount but not register for chi routes * Fix test * Fix test * Fix test * Fix comment * turn back unnecessary change * Remove the timout middleware since some operations may spend much time.
* When building rootless docker image move chown&chmod to build stage (#13578)Lauris BH2020-11-151-2/+1
| | | | | | | | | | | | | * When building rootless docker image move chown&chmod to build stage Fixes #13577 * Fix command newlines * Move chown to COPY command * Seems to be working also without chmod Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Add tab-size support for Firefox (#13576)Dmitry Doroshev2020-11-151-0/+1
| | | | Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Render diff stats server-side (#13579)silverwind2020-11-154-29/+12
| | | Eliminates a flash on page load on the diff stat bars.
* CSS color variables, less bold font weight and more (#13567)silverwind2020-11-1520-225/+221
| | | | | | | | | | | | | | | | | * CSS color variables, less bold font weight - Define color variables for fully saturated colors and apply them where it made sense - Add background color helper classes - Globally reduce bold font weight from 700 to 500 - Remove border from timeline icons - Unify dropzone styling - Various border style consolidations * attempt to fix test * another attempt at tests * fix contains
* Enable syntax highlighting for *.tmpl on GitHub (#13571)silverwind2020-11-151-0/+1
| | | | | | Go templates are syntactically very similar to handlebars, this enabled their syntax highlighting on GitHub. Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Fix issue label rendering (#13570)silverwind2020-11-153-10/+33
| | | | | | | | | | | * Fix issue label rendering Prevent rendering of inactive labels and make them wrap inline. Fixes: https://github.com/go-gitea/gitea/issues/13566 * also don't render the placeholder Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* [skip ci] Updated translations via CrowdinGiteaBot2020-11-153-0/+5
|
* Add markdown support in organization description (#13549)wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf2020-11-152-1/+5
| | | | | | | | | | Similarly to how you can write some markdown in user profile description, you can now use the same feature in organization description. As discussed in discord. kudos to @mrsdizzie and @zeripath visualization: ![image](https://user-images.githubusercontent.com/61180606/99115919-8004a200-25f3-11eb-8bbd-ab33de2cabb3.png)
* Add email validity check (#13475)Chris Shyi2020-11-1413-2/+163
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Improve error feedback for duplicate deploy keys Instead of a generic HTTP 500 error page, a flash message is rendered with the deploy key page template so inform the user that a key with the intended title already exists. * API returns 422 error when key with name exists * Add email validity checking Add email validity checking for the following routes: [Web interface] 1. User registration 2. User creation by admin 3. Adding an email through user settings [API] 1. POST /admin/users 2. PATCH /admin/users/:username 3. POST /user/emails * Add further tests * Add signup email tests * Add email validity check for linking existing account * Address PR comments * Remove unneeded DB session * Move email check to updateUser Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* [API] Only Return Json (#13511)65432020-11-145-48/+103
| | | | | | | | | | | | | | | | | * Let Branch and Raw Endpoint return json error if not found * Revert "RM RepoRefByTypeForAPI and move needed parts into GetRawFile directly" This reverts commit d826d08577b23765cb3c257e7a861191d1aa9a04. * more similar to RepoRefByType * dedub-code * API should just speak JSON * nice name Co-authored-by: zeripath <art27@cantab.net>
* API: Fix GetQueryBeforeSince (#13559)65432020-11-145-23/+43
|
* Use monaco for the git hook editor (#13552)silverwind2020-11-137-62/+74
| | | | | | | Migrate git hook editor to monaco, replacing CodeMirror. Had to do a few refactors to make the monaco instantiation generic enough to be of use. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* missing quotes in default value slice (#13550)Patrick Aljord2020-11-131-1/+1
| | | | Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* unify layout between auth pages (#13547)Norwin2020-11-136-96/+94
| | | Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Fix issue label spacing and hover (#13553)silverwind2020-11-133-9/+3
| | | | Fixes: https://github.com/go-gitea/gitea/issues/13545 Regressed by: https://github.com/go-gitea/gitea/pull/13458
* Use existing analyzer module for language detection for highlighting (#13522)mrsdizzie2020-11-131-2/+5
| | | | | | | | | | | | | * Use existing analyzer module for language detction for highlighting Thanks @lafriks for pointing out we can reuse existing code for more reliable language detection here. * Update modules/highlight/highlight.go Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Make heatmap colors more distinct (#13533)silverwind2020-11-131-4/+4
| | | | | | | | | | | * Make heatmap colors more distinct Fixes: https://github.com/go-gitea/gitea/issues/13529 * use opaque colors * make first color less opaque Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Add missed sync branch/tag webhook (#13538)Lunny Xiao2020-11-131-0/+8
| | | | Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* proper signature validation (#13523)Cacciuc2020-11-131-1/+1
| | | | | | | | | $header_signature could be a typed float (start with 0e and then only numbers) and a float does equal a string when comparing with typed juggle. eg: 0e123 != "abc" does return false, but 0e123 !== "abc" returns true. you previously could circumvent the signature check when providing a header signature in the float format (0e...) Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Fix blame line alignment (#13542)silverwind2020-11-131-0/+1
| | | | | | | | | We can't wrap code in blame because it's essentially two tables side-by-side which will misalign them when one line gets larger. Fixes: https://github.com/go-gitea/gitea/issues/13540 Regressed by: https://github.com/go-gitea/gitea/pull/13415 Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* [skip ci] Updated translations via CrowdinGiteaBot2020-11-132-3/+8
|
* Reindent manifest.json (#13544)silverwind2020-11-131-30/+30
| | | Now it's properly indented to 2-space.
* Introduce go chi web framework as frontend of macaron, so that we can move ↵Lunny Xiao2020-11-1349-249/+4796
| | | | | | | | | routes from macaron to chi step by step (#7420) * When route cannot be found on chi, go to macaron * Stick chi version to 1.5.0 * Follow router log setting
* Various style fixes (#13534)silverwind2020-11-137-58/+38
| | | | | | | | | | | * Various style fixes - Fix the rest of the monochrome borders for arc-green - Fix close icon position on system notice modal and padding - Fix selectable table color for arc-green * proper fix for close icon Co-authored-by: Lauris BH <lauris@nix.lv>
* Prevent git operations for inactive users (#13527)Lunny Xiao2020-11-132-10/+44
| | | | | | | | | | | * prevent git operations for inactive users * Some fixes * Deny push to the repositories which's owner is inactive * deny operations also when user is ProhibitLogin Co-authored-by: zeripath <art27@cantab.net>
* [skip ci] Updated translations via CrowdinGiteaBot2020-11-121-0/+13
|
* Form styling adjustments (#13501)silverwind2020-11-126-207/+157
| | | | | | | | | | | | | | * Form styling adjustments - Move all form-related styling to _forms.less - Defined new form-related variables - Fix spinner on frontpage repo search - Add new rounded-* helpers and fix repo search radius * misc arc green tweaks Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lauris BH <lauris@nix.lv>
* Lazy-load issue reviewers and assignees avatars (#13526)silverwind2020-11-121-10/+14
| | | | | | | The avatars inside the dropdowns were previously fetched every time a Pull Request was opened resulting in potential unnecessary downloads. This lazy-loads through the newish loading=lazy attribute. Also did a few minor adjustments on the file.
* [skip ci] Updated translations via CrowdinGiteaBot2020-11-111-3/+3
|
* Disallow urlencoded new lines in git protocol paths if there is a port (#13521)zeripath2020-11-111-0/+3
| | | Signed-off-by: Andrew Thornton <art27@cantab.net>
* Include OriginalAuthor in Reaction constraint (#13505)zeripath2020-11-103-7/+47
| | | | | | | | | | | | | | | | | When migrating repositories with reactions with deleted users, the original author id may be -1. This means that it is possible to end up attempting to create multiple reactions with the same [ Type, IssueID, CommentID, UserID, OriginalAuthorID ] thus breaking the constraints. On SQLite this appears to cause a deadlock but on other dbs this will cause the migration to fail. This PR extends the constraint to include the original author username in the constraint. Fix #13271 Signed-off-by: Andrew Thornton <art27@cantab.net>
* fix: issue tracker link redirection (#13504)wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf2020-11-101-2/+2
| | | | | | | | | | kudos to @zeripath * in case there is a remote issue tracker configured, the git graph view PR and issue links now correctly point to the issue tracker location, whereas if literally pointing at 'pulls', you could have ended up back at the local instance after clicking the link (which, obviously haven't had the pull/issue) Signed-off-by: wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf <a_mirre@utb.cz>
* Make heatmap shades linear (#13500)silverwind2020-11-101-1/+1
| | | | | | Previously, shades were 50%, 60%, 70%, 80%, 100%. Make them linearily increasing instead at 60%, 70%, 80%, 90%, 100%. Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Switch from SimpleMDE to EasyMDE (#13333)zeripath2020-11-1011-48/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Switch from SimpleMDE to EasyMDE Signed-off-by: Andrew Thornton <art27@cantab.net> * use webpack to webpack the easymde css Signed-off-by: Andrew Thornton <art27@cantab.net> * move css to only css Signed-off-by: Andrew Thornton <art27@cantab.net> * move loading codemirror modes and addons back in to footer.tmpl Signed-off-by: Andrew Thornton <art27@cantab.net> * Fix arc-green Signed-off-by: Andrew Thornton <art27@cantab.net> * as per @silverwind * reinstall codemirror Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
* Fix tooltips and issue dependency styles (#13458)silverwind2020-11-1015-145/+163
| | | | | | | | | - Convert all tooltips to JS-based ones, fixing overflow issues - Restyle issue dependencies/dependants - Move popup styles to base style - CSS Helper tweaks - Unify pseudo element selectors and lint for it Fixes: https://github.com/go-gitea/gitea/issues/13400
* [skip ci] Updated translations via CrowdinGiteaBot2020-11-101-1/+1
|
* Some improvements for v156 (#13497)Lunny Xiao2020-11-101-7/+12
|
* Added title and action buttons to Project view page (#13437)Mohammad Hadi Hosseinpour2020-11-093-2/+57
| | | | | | | | | | | | | | * Added title and action buttons to Project view page * Changed octicon for project close action * Fix indentation in templates/repo/projects/view.tmpl Co-authored-by: zeripath <art27@cantab.net> * Fix indentation templates/repo/projects/view.tmpl (2nd) Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: zeripath <art27@cantab.net>
* Prevent panic on git blame by limiting lines to 4096 bytes at most (#13470)zeripath2020-11-091-10/+32
| | | | | | | | Fix #12440 Closes #13192 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Fix broken .comment > .content caused by #13457 (#13482)Cirno the Strongest2020-11-091-0/+2
| | | Co-authored-by: Lauris BH <lauris@nix.lv>
* Fix panic bug in handling multiple references in commit (#13486)zeripath2020-11-102-29/+95
| | | | | | | | | | | | | | | | | | | | | | * Fix panic bug in handling multiple references in commit The issue lay in determining the position of matches on a second run round a commit message in FindAllIssueReferences. Fix #13483 Signed-off-by: Andrew Thornton <art27@cantab.net> * Extract function and make testable Signed-off-by: Andrew Thornton <art27@cantab.net> * Fix the comment Signed-off-by: Andrew Thornton <art27@cantab.net> * cleaning up the comments a bit more Signed-off-by: Andrew Thornton <art27@cantab.net>
* [skip ci] Updated translations via CrowdinGiteaBot2020-11-091-9/+9
|
* Change search and filter icons to SVG (#13473)silverwind2020-11-0911-25/+25
| | | | | | Unfortunately, the Fomantic CSS relies on i.icon instead of .icon so a wrapper is necessary for these with an accompanying class to center the icon.