summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Changelog for 1.19.3 (#24495)v1.19.3techknowlogick2023-05-031-0/+13
| | | | Co-authored-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: John Olheiser <john.olheiser@gmail.com>
* Fix api error message if fork exists (#24487) (#24493)Giteabot2023-05-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #24487 by @fnetX On the @Forgejo instance of Codeberg, we discovered that forking a repo which is already forked now returns a 500 Internal Server Error, which is unexpected. This is an attempt at fixing this. The error message in the log: ~~~ 2023/05/02 08:36:30 .../api/v1/repo/fork.go:147:CreateFork() [E] [6450cb8e-113] ForkRepository: repository is already forked by user [uname: ...., repo path: .../..., fork path: .../...] ~~~ The service that is used for forking returns a custom error message which is not checked against. About the order of options: The case that the fork already exists should be more common, followed by the case that a repo with the same name already exists for other reasons. The case that the global repo limit is hit is probably not the likeliest. --------- Co-authored-by: Otto Richter (fnetX) <git@fralix.ovh>
* Enable whitespace rendering on selection in Monaco (#24444) (#24485)Giteabot2023-05-021-1/+0
| | | | | | | | | | | | | Backport #24444 by @silverwind Remove the [renderWhitespace](https://microsoft.github.io/monaco-editor/docs.html#interfaces/editor.IEditorOptions.html#renderWhitespace) override, so the default value of `selection` takes over and makes whitespace visible on selection. <img width="128" alt="Screenshot 2023-04-30 at 19 09 41" src="https://user-images.githubusercontent.com/115237/235366707-d598268d-03cc-4839-a195-c460bddae99b.png"> Co-authored-by: silverwind <me@silverwind.io>
* nightly tagtechknowlogick2023-05-011-4/+4
|
* Remove less/_repository.less (#24467)wxiaoguang2023-05-011-3604/+0
|
* Skip known flaky `queue` tests on CI environment (#24443)silverwind2023-04-302-0/+8
| | | Backport of https://github.com/go-gitea/gitea/pull/24419 to 1.19.
* nightly tag for docker imagestechknowlogick2023-04-301-4/+4
|
* Improve milestone filter on issues page (#22423) (#24440)Giteabot2023-04-308-91/+99
| | | | | | | | | | | | | Backport #22423 by @lunny Now we have `All milestones`, `No milestones`, `Open milestones` and `Closed milestones`. Fix #11924 Fix #22411 <img width="1166" alt="image" src="https://user-images.githubusercontent.com/81045/212243375-95eea035-a972-44b8-8088-53db614cb07e.png"> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Fix incorrect CurrentUser check for docker rootless (#24435)wxiaoguang2023-04-291-8/+14
| | | | | | | | | | | | | | | | Many users report that 1.19 has a regression bug: the rootless image can't start if the UID is not 1000. https://github.com/go-gitea/gitea/issues/23632#issuecomment-1524589213 https://discourse.gitea.io/t/gitea-doesnt-start-after-update-to-1-19/6920/9 The problem is that the IsRunUserMatchCurrentUser logic is fragile, the "SSH" config is not ready when it executes. This PR is just a quick fix for 1.19. For 1.20, we need a clear and stable solution.
* Fix user-cards format (#24428) (#24431)Giteabot2023-04-292-2/+4
| | | | | | | Backport #24428 by @KN4CK3R Fixes #24418 Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* getting the tag list does not require being signed in (#24413) (#24416)Giteabot2023-04-291-1/+1
| | | | | | | Backport #24413 by @earl-warren Fixes: https://codeberg.org/forgejo/forgejo/issues/681 Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com>
* Changelog 1.19.2 (#24365)v1.19.2John Olheiser2023-04-281-0/+47
| | | | | Add changelog for 1.19.2 Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix auth check bug (#24382) (#24387)Giteabot2023-04-272-10/+41
| | | | | | | | | | | Backport #24382 by @lunny Fix https://github.com/go-gitea/gitea/pull/24362/files#r1179095324 `getAuthenticatedMeta` has checked them, these code are duplicated one. And the first invokation has a wrong permission check. `DownloadHandle` should require read permission but not write. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Add tags list for repos whose release setting is disabled (#23465) (#24369)Zettat1232023-04-279-231/+280
| | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #23465 Close #23427 Co-Author: @wxiaoguang If a repo's release setting is enabled, the logic has't changed. Clicking the "Tags" button will jump to `/{user}/{repo}/tags` and `templates/repo/release/list.tmpl` template will be used. <img src="https://user-images.githubusercontent.com/15528715/224939362-bd8974fd-08b0-4f79-a114-3389d15847ca.png" width="600px" /> If the release setting is disabled, clicking the "Tags" button will still jump to `/{user}/{repo}/tags` but a new template `templates/repo/tag/list.tmpl` will be used. <img src="https://user-images.githubusercontent.com/15528715/233834564-74741e49-f4e9-47c8-ac12-e306642798dc.png" width="600px" /> Since both templates above need to render the tags list, I moved the tags list to a shared template located in `templates/repo/tag/table.tmpl`.
* Require repo scope for PATs for private repos and basic authentication ↵Giteabot2023-04-2611-7/+117
| | | | | | | | | | | | | (#24362) (#24364) Backport #24362 by @jolheiser > The scoped token PR just checked all API routes but in fact, some web routes like `LFS`, git `HTTP`, container, and attachments supports basic auth. This PR added scoped token check for them. Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Fix no edit/close/delete button in org repo project view page (#24349)yp053272023-04-261-2/+2
| | | Backport #24301
* Fix Monaco IOS keyboard button (#24341) (#24347)Giteabot2023-04-261-0/+15
| | | | | | | | | | | | | | | | Backport #24341 by @silverwind Fix https://github.com/go-gitea/gitea/issues/16188. Turns out the element was completely misaligned by fomantic styles. Add most of the original styles in `!important` form to fix. Tapping the button doesn't do anything useful in Simulator.app, but I guess it's still better to not outright hide it in case it has a possiblity to work. <img width="121" alt="image" src="https://user-images.githubusercontent.com/115237/234379685-4e67f8cd-7e91-4bcc-8e17-9d5b2ebed6cd.png"> Co-authored-by: silverwind <me@silverwind.io>
* Fix wrong error info in RepoRefForAPI (#24344) (#24351)Giteabot2023-04-261-1/+1
| | | | | Backport #24344 by @yp05327 Co-authored-by: yp05327 <576951401@qq.com>
* Fix broken clone script on an empty archived repo (#24339) (#24348)Giteabot2023-04-261-1/+1
| | | | | | | | | | Backport #24339 by @yardenshoham I made it render the script even if the repo is archived - Fixes #24324 Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: Yarden Shoham <git@yardenshoham.com>
* Don't set meta `theme-color` by default (#24340) (#24346)Giteabot2023-04-264-7/+6
| | | | | | | | | | | | | | | | | | | | | | Backport #24340 by @silverwind Fixes https://github.com/go-gitea/gitea/issues/24321. By not setting this meta tag, Safari will use body color for chrome and out-of-viewport areas, which looks much better then static mismatching green. As per [MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name/theme-color) it's really only Apple browsers who still support this tag, most others have dropped support. Before: <img width="347" alt="Screenshot 2023-04-25 at 19 59 13" src="https://user-images.githubusercontent.com/115237/234363180-0fe667ef-5469-4f5f-b31a-c9d73aff10ac.png"> After: <img width="361" alt="Screenshot 2023-04-25 at 20 00 00" src="https://user-images.githubusercontent.com/115237/234363185-e2d2b62f-0133-4316-944d-b614ffb84eb0.png"> Co-authored-by: silverwind <me@silverwind.io>
* Add --font-weight-bold and set previous bold to 601 (#24307) (#24331)wxiaoguang2023-04-2510-14/+18
| | | | | | | | | | Backport #24307 Fix #24305 According to MDN, "bold" starts from 700, some fonts do not provide "bolding" for weight 600 Manually backport, no CSS conflict.
* Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC ↵Giteabot2023-04-251-1/+1
| | | | | | | | | | | | | (#24035) (#24333) Backport #24035 by @garymoon This change prevents Gitea from bypassing the manual approval process for newly registered users when OIDC is used. - Resolves https://github.com/go-gitea/gitea/issues/23392 Signed-off-by: Gary Moon <gary@garymoon.net> Co-authored-by: Gary Moon <garymoon@users.noreply.github.com>
* Wrap too long push mirror addresses (#21120) (#24334)Giteabot2023-04-251-1/+1
| | | | | | | | | | | | | Backport #21120 by @JakobDev I noticed that it is possible to break the push mirror list by entering a too long URL. This should fix it. | Before | After | |--------------|-----------| |![Before](https://user-images.githubusercontent.com/15185051/189294585-333965d1-0f0f-48e2-96d5-e04b84b55ae3.png)|![After](https://user-images.githubusercontent.com/15185051/189294619-301e271c-b89b-4bc0-9c11-9536bd0302be.png)| Co-authored-by: JakobDev <jakobdev@gmx.de>
* Fix typo in API route (#24310) (#24332)Giteabot2023-04-252-28/+26
| | | | | | | | Backport #24310 by @silverwind Continuation of https://github.com/go-gitea/gitea/pull/23995 Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: bilogic <946010+bilogic@users.noreply.github.com>
* Remove org users who belong to no teams (#24247) (#24313)Giteabot2023-04-241-4/+13
| | | | | | | | Backport #24247 by @yp05327 Fix #24128 Co-authored-by: yp05327 <576951401@qq.com> Co-authored-by: silverwind <me@silverwind.io>
* Unify nightly naming across binaries and docker images (#24116) (#24308)Giteabot2023-04-243-6/+11
| | | | | | | | | | | | Backport #24116 by @techknowlogick Proposal found here: https://github.com/go-gitea/gitea/issues/23654 TODO: make non-breaking (can we publish docker image using dev and nightly prefix? at same time). if anyone has advice please comment :) If this PR is merged, then I can add redirects to the downloads site. Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Upgrade act (#24298) (#24300)Giteabot2023-04-242-3/+3
| | | | | | | | | | | | Backport #24298 by @Zettat123 Upgrade act to version `v0.243.4` - Support `configuration variables` ([#43](https://gitea.com/gitea/act/pulls/43)) - Support specifying command for `services` containers ([#50](https://gitea.com/gitea/act/pulls/50)) Co-authored-by: Zettat123 <zettat123@gmail.com>
* Fix bug when deleting wiki with no code write permission (#24274) (#24295)Giteabot2023-04-231-1/+7
| | | | | | | | Backport #24274 by @lunny Fix #24125 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
* Handle canceled workflow as a warning instead of a fail (#24282) (#24292)Giteabot2023-04-231-1/+3
| | | | | | | | | | Backport #24282 by @wolfogre Follow what Drone CI does: ![image](https://user-images.githubusercontent.com/9418365/233829853-d1c30a30-10cc-4b97-a134-793a79d46d85.png) Co-authored-by: Jason Song <i@wolfogre.com>
* Load reviewer for comments when dismissing a review (#24281) (#24288)Giteabot2023-04-231-2/+10
|
* Only delete secrets belonging to its owner (#24284) (#24286)Giteabot2023-04-234-2/+8
| | | | | Backport #24284 by @KN4CK3R Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* fix calReleaseNumCommitsBehind (#24148) (#24197)oliverpool2023-04-2253-21/+934
| | | | | | | | | | | | | | | Backport #24148 `repoCtx.CommitsCount` is not reliably the commit count of the default branch (Repository.GetCommitsCount depends on what is currently displayed). _contributed in the context of @forgejo_ --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
* Fix footer display (#24251) (#24269)wxiaoguang2023-04-223-69/+59
| | | | | | | | | | | | | | | | Backport #24251 Fix #24249 Diff with ignoring spaces: https://github.com/go-gitea/gitea/pull/24269/files?diff=split&w=1 Manually tested ![image](https://user-images.githubusercontent.com/2114189/233766806-18eb18ad-0c4d-44f7-b0fc-b40466c64445.png) Co-authored-by: Lauris BH <lauris@nix.lv>
* Fix owner team access mode value in team_unit table (#24224)yp053272023-04-221-3/+4
| | | | | Partly backport #23675 Co-authored-by: Giteabot <teabot@gitea.io>
* Fix access token issue on some public endpoints (#24194) (#24259)Giteabot2023-04-212-14/+20
| | | | | | | | | | Backport #24194 by @harryzcy - [x] Identify endpoints that should be public - [x] Update integration tests Fix #24159 Co-authored-by: harryzcy <harry@harryzheng.com>
* Show commit history for closed/merged PRs (#24238) (#24261)Giteabot2023-04-211-2/+4
| | | | | | | | | | | | | | | | | | | | | Backport #24238 by @wxiaoguang Close #24237 Before: <details> ![image](https://user-images.githubusercontent.com/2114189/233424875-a69c6dad-df4a-483e-b796-36c6459af2d6.png) </details> After: ![image](https://user-images.githubusercontent.com/2114189/233424712-60a296de-017b-49a8-89b2-5925ff452646.png) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix label color, fix divider in dropdown (#24215) (#24244)Giteabot2023-04-201-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | Backport #24215 by @silverwind Two small CSS fixes: 1. Fix basic primary label hover: Before: <img width="172" alt="Screenshot 2023-04-19 at 20 00 32" src="https://user-images.githubusercontent.com/115237/233161903-eec2de54-1a58-44ac-a6ef-2d77157317f6.png"> After: <img width="179" alt="Screenshot 2023-04-19 at 20 05 29" src="https://user-images.githubusercontent.com/115237/233162028-995404ac-5852-4d03-821f-6eb4a918a9e3.png"> 2. Fix border color of divider in dropdown and remove margin so it looks better with hover effect, as discussed in https://github.com/go-gitea/gitea/pull/24143: <img width="205" alt="Screenshot 2023-04-19 at 20 03 24" src="https://user-images.githubusercontent.com/115237/233162102-3f4a4142-9634-4c95-acf0-be57072ce7eb.png"> <img width="311" alt="Screenshot 2023-04-19 at 20 03 55" src="https://user-images.githubusercontent.com/115237/233162109-faa616f6-02e4-43d3-95fa-66787a7f914c.png"> Co-authored-by: silverwind <me@silverwind.io>
* Fix issue attachment handling (#24202) (#24221)wxiaoguang2023-04-208-130/+132
| | | | | | | | | | | | | | Backport #24202 Close #24195 Fix the bug: 1. The old code doesn't handle `removedfile` event correctly 2. The old code doesn't provide attachments for type=CommentTypeReview --------- Co-authored-by: silverwind <me@silverwind.io>
* Add run status in action view page (#24223)yp053272023-04-202-1/+10
| | | Backport #23212
* Vertical widths of containers removed (#24184) (#24211)Giteabot2023-04-202-4/+2
| | | | | | | | | | | | Backport #24184 by @krzysztofjeziorny A vertical overflow appears in Firefox 112/MacOS 12.6 when the system setting for scrollbars is to "Always" show them. Here, the fixed 100vw container widths are removed, which removes the overflow. It is, however, only simulated in Developer Tools in latest Firefox and Chromium, so please test on a Gitea installation. Co-authored-by: Krzysztof Jeziorny <872730+krzysztofjeziorny@users.noreply.github.com>
* Don't list root repository on compare page if pulls not allowed (#24183) ↵Giteabot2023-04-191-1/+1
| | | | | | | | | (#24210) Backport #24183 by @lunny Fix #24165 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Fix template error in pull request with deleted head repo (#24192) (#24216)Giteabot2023-04-191-1/+1
| | | | | | | | Backport #24192 by @brechtvl Rendering of Allow Edits from Maintainers did not check if the head repo exists, while other parts of the page handle it gracefully. Co-authored-by: Brecht Van Lommel <brecht@blender.org>
* Fix incorrect CORS default values (#24206) (#24217)Giteabot2023-04-191-2/+3
| | | | | | | | | | | | Backport #24206 by @wxiaoguang Document: ``` ;ALLOW_DOMAIN = * ;METHODS = GET,HEAD,POST,PUT,PATCH,DELETE,OPTIONS ``` Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Use correct locale key for forks page (#24172) (#24175)Giteabot2023-04-171-1/+1
| | | | | | | | | | Backport #24172 by @jolheiser https://github.com/go-gitea/gitea/blob/4014200021a1997283c779a815fe9e5febf1fda1/options/locale/locale_en-US.ini#L873 https://github.com/go-gitea/gitea/blob/4014200021a1997283c779a815fe9e5febf1fda1/options/locale/locale_en-US.ini#L943 Co-authored-by: John Olheiser <john.olheiser@gmail.com>
* Fix Org edit page bugs: renaming detection, maxlength (#24161) (#24171)Giteabot2023-04-174-25/+17
| | | | | | | | | | | | | Backport #24161 by @wxiaoguang ## Before * The renaming detection is wrong (eg: pasting a new name into the input doesn't trigger the detection) * The renaming prompt layout is not good * Some MaxSize/maxlength rules is missing Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Support converting varchar to nvarchar for mssql database (#24105) (#24168)Giteabot2023-04-172-11/+43
| | | | | | | | | | | | | | | Backport #24105 by @lunny In #12269, all string fields of struct will generate a NVARCHAR column in database, but for those Gitea instances installed before that PR, users have to convert columns themselves. In this PR, we update the `./gitea admin convert` commands to support both MySQL and MSSQL database converting. Previously, it only supported converting `utf8 -> utf8mb4` for MySQL. Now, it will check the database types. If it's MSSQL, it will convert `VARCHAR -> NVARCHAR` as well. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Use 1.18's aria role for dropdown menus (#24144) (#24155)wxiaoguang2023-04-171-2/+2
| | | | | Backport #24144 Co-authored-by: silverwind <me@silverwind.io>
* Update redis library to support redis v7 (#24114) (#24156)Patrick Schratz2023-04-179-26/+38
| | | | | | | backports #24114 --------- Co-authored-by: techknowlogick <hello@techknowlogick.com>
* Sort repo topic labels by name (#24123) (#24153)wxiaoguang2023-04-173-10/+7
| | | | | | | | | Backport #24123 Close #24077 Manually backported and tested. <img width="330" alt="image" src="https://user-images.githubusercontent.com/2114189/232283645-92cc85dd-ba16-44a9-a7ef-5712b9d285e9.png">
* Set EasyMDE heading font-size to the same size as the resulting markdown ↵wxiaoguang2023-04-161-0/+26
| | | | | | | | | | (#24151) (#24152) Backport #24151 Fix #23816 <img width="519" alt="image" src="https://user-images.githubusercontent.com/2114189/232283304-21f56e82-d80e-4199-9b14-74699d80cd20.png">