summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* read-only checkboxes don't appear and don't entirely act the way one might ↵Giteabot2023-06-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | expect (#25573) (#25602) Backport #25573 by @saegl5 This pull request fades read-only checkboxes and checkmark, and it makes the checkboxes act more read-only/disabled by not changing the border-color when clicked. Examples using light mode: | Before | After | | - | - | | ![Kapture 2023-06-28 at 00 20 45](https://github.com/go-gitea/gitea/assets/63764270/0899fd5c-18a9-4290-9ba9-d3cf71033cf8) | ![Kapture 2023-06-28 at 00 23 12](https://github.com/go-gitea/gitea/assets/63764270/0db9be14-e16c-42ed-8fb1-999928fd1d25) | | ![Kapture 2023-06-28 at 00 25 22](https://github.com/go-gitea/gitea/assets/63764270/65c6c380-b928-4e6c-b403-3655d3565896) | ![Kapture 2023-06-28 at 00 27 28](https://github.com/go-gitea/gitea/assets/63764270/d8c2a019-e07c-43a1-a7fa-93c0d4e01900) | | | read-only checkboxes and checkmark are faded<br>and the checkboxes act more read-only/disabled | Fixes/Closes/Resolves #25076 Co-authored-by: Ed Silkworth <ed.silkworth@icloud.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Redirect to package after version deletion (#25594) (#25599)KN4CK3R2023-06-302-12/+16
| | | | | | | | | | | | | Related #25559 Current behaviour: 1. Deletion of a package version 2. Redirect to the owners package list New behaviour: 1. Deletion of a package version 2.1. If there are more versions available, redirect to the package again 2.2. If there are no versions available, redirect to the owners package list
* Add documentation about supported workflow trigger events (#25582) (#25589)Giteabot2023-06-292-0/+40
| | | | | | | | | Backport #25582 by @Zettat123 Right now Gitea doesn't support all [Events that trigger workflows](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows). This PR lists the supported events to help users write workflow files. Co-authored-by: Zettat123 <zettat123@gmail.com>
* Reduce table padding globally (#25568) (#25577)Giteabot2023-06-291-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25568 by @silverwind Fomantic's tables have too much padding. Reduce it so we have more information density in them. Especially the admin tables need this because they are bursting already because of column count. ## Admin repolist before and after <img width="909" alt="Screenshot 2023-06-28 at 20 27 55" src="https://github.com/go-gitea/gitea/assets/115237/954c925c-8db5-47ce-ae51-a2168b857014"> <img width="897" alt="Screenshot 2023-06-28 at 20 36 03" src="https://github.com/go-gitea/gitea/assets/115237/0bddc09a-9117-48b3-a17e-3d34c58d8d3d"> ## Other tables <img width="1230" alt="Screenshot 2023-06-28 at 20 36 22" src="https://github.com/go-gitea/gitea/assets/115237/38f555b6-a7ce-416a-9f1f-706eaf18863b"> <img width="1236" alt="Screenshot 2023-06-28 at 20 26 37" src="https://github.com/go-gitea/gitea/assets/115237/82b2878e-358c-4dc2-a6b4-c66e43cd2dfb"> <img width="1231" alt="Screenshot 2023-06-28 at 20 59 30" src="https://github.com/go-gitea/gitea/assets/115237/c6a92e55-a3a3-4c80-9a0d-50aebb49886c"> Files table is unaffected because it has custom padding already. Co-authored-by: silverwind <me@silverwind.io>
* Fix milestones deletion (#25583) (#25584)Giteabot2023-06-292-2/+2
| | | | | | | | | | Backport #25583 by @HesterG Close #25557 Fix regression from #25315 `data-id` is still needed for deleting milestone. Co-authored-by: HesterG <hestergong@gmail.com>
* Do not prepare oauth2 config if it is not enabled, do not write config in ↵wxiaoguang2023-06-293-10/+21
| | | | | | | | | | | | some sub-commands (#25567) (#25576) Backport #25567 Ref: * https://github.com/go-gitea/gitea/issues/25377#issuecomment-1609757289 And some sub-commands like "generate" / "docs", they do not need to use the ini config
* Fix content holes in Actions task logs file (#25560) (#25566)Giteabot2023-06-286-5/+98
| | | | | | | | | | | | | | | | | | | Backport #25560 by @wolfogre Fix #25451. Bugfixes: - When stopping the zombie or endless tasks, set `LogInStorage` to true after transferring the file to storage. It was missing, it could write to a nonexistent file in DBFS because `LogInStorage` was false. - Always update `ActionTask.Updated` when there's a new state reported by the runner, even if there's no change. This is to avoid the task being judged as a zombie task. Enhancement: - Support `Stat()` for DBFS file. - `WriteLogs` refuses to write if it could result in content holes. Co-authored-by: Jason Song <i@wolfogre.com>
* Use correct response code in push mirror creation response in v1_json.tmpl ↵Giteabot2023-06-282-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | (#25476) (#25571) Backport #25476 by @GeorgDangl In the process of doing a bit of automation via the API, we've discovered a _small_ issue in the Swagger definition. We tried to create a push mirror for a repository, but our generated client raised an exception due to an unexpected status code. When looking at this function: https://github.com/go-gitea/gitea/blob/3c7f5ed7b5bff347198cbb26492e6354ea42733b/routers/api/v1/repo/mirror.go#L236-L240 We see it defines `201 - Created` as response: https://github.com/go-gitea/gitea/blob/3c7f5ed7b5bff347198cbb26492e6354ea42733b/routers/api/v1/repo/mirror.go#L260-L262 But it actually returns `200 - OK`: https://github.com/go-gitea/gitea/blob/3c7f5ed7b5bff347198cbb26492e6354ea42733b/routers/api/v1/repo/mirror.go#L373 So I've just updated the Swagger definitions to match the code😀 Co-authored-by: Georg Dangl <10274404+GeorgDangl@users.noreply.github.com>
* Fix bugs related to notification endpoints (#25548) (#25562)Giteabot2023-06-283-4/+4
| | | | | | | | | | Backport #25548 by @Zettat123 This PR - fixes #25545 - fixes two incorrect `reqToken()` in `/notifications` endpoints (caused by #24767) Co-authored-by: Zettat123 <zettat123@gmail.com>
* Align language menu icon and fit the footer area (#25556) (#25563)Giteabot2023-06-282-6/+14
| | | | | | | | | | | | | | | | | | | | | | | | Backport #25556 by @wxiaoguang Close #25551 ## Before ![image](https://github.com/go-gitea/gitea/assets/2114189/f35aebeb-9c86-4632-8c1f-1c90aa757640) ## After ![image](https://github.com/go-gitea/gitea/assets/2114189/4a623687-6c6d-442a-a4f9-07dadeb9fc6d) ---- ![image](https://github.com/go-gitea/gitea/assets/2114189/6a4e5ecf-b88b-4c22-98c3-21898bd41bc5) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix sub-command log level (#25537) (#25553)wxiaoguang2023-06-2811-18/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25537 More fix for #24981 * #24981 Close #22361, #25552 * #22361 * #25552 There were many patches for Gitea's sub-commands to satisfy the facts: * Some sub-commands shouldn't output any log, otherwise the git protocol would be broken * Sometimes the users want to see "verbose" or "quiet" outputs That's a longstanding problem, and very fragile. This PR is only a quick patch for the problem. In the future, the sub-command system should be refactored to a clear solution. ---- Other changes: * Use `ReplaceAllWriters` to replace `RemoveAllWriters().AddWriters(writer)`, then it's an atomic operation. * Remove unnecessary `syncLevelInternal` calls, because `AddWriters/addWritersInternal` already calls it.
* Change `Regenerate Secret` button display (#25534) (#25541)Giteabot2023-06-271-1/+1
| | | | | | | | | | | Backport #25534 by @KN4CK3R Fixes #25527 Preview: ![grafik](https://github.com/go-gitea/gitea/assets/1666336/a84ad1ba-43e6-42e5-a0e2-585fb226875d) Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Fix admin-dl-horizontal (#25512) (#25535)Giteabot2023-06-273-31/+26
| | | | | | | | | | | | | Backport #25512 by @wxiaoguang ![image](https://github.com/go-gitea/gitea/assets/2114189/fb731e07-da30-4470-8200-73b5ca8b78f1) ![image](https://github.com/go-gitea/gitea/assets/2114189/85930b6f-5df7-437f-863f-423f3b81dd26) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: HesterG <hestergong@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
* Fix rerun icon on action view component (#25531) (#25536)Giteabot2023-06-271-2/+2
| | | | | | | | | | | | | | | | | | | | | Backport #25531 by @HesterG Right now rerun icon on action view component will not be seen when duration text length is long, because the wrapper `job-brief-info` has a fixed width, and the svg is squeezed. The way to fix this in this PR is to change width to `fit-content` and exchange position of duration text and rerun svg. Before (rerun svg not shown on hover): <img width="1401" alt="Screen Shot 2023-06-27 at 12 53 41" src="https://github.com/go-gitea/gitea/assets/17645053/bb3f62ec-8c56-4dbc-96f1-718b50426d91"> After: <img width="1409" alt="Screen Shot 2023-06-27 at 12 50 59" src="https://github.com/go-gitea/gitea/assets/17645053/620aa02c-2326-408d-a763-453f48f42c40"> Co-authored-by: HesterG <hestergong@gmail.com>
* Fix input `line-height` cutting off `g` (#25334) (#25533)Giteabot2023-06-271-0/+5
| | | | | | | | | | | | | | | | | | Backport #25334 by @hiifong Fix the incomplete display of input text Before: ![image](https://github.com/go-gitea/gitea/assets/89133723/6bd8ca29-a096-46a8-bd23-fb833f45186f) ![image](https://github.com/go-gitea/gitea/assets/89133723/27e51e62-7150-45cd-8606-09317d462d70) After: ![image](https://github.com/go-gitea/gitea/assets/89133723/8d0db5d3-d768-42b4-9a75-0b8816f0a299) ![image](https://github.com/go-gitea/gitea/assets/89133723/4193adc9-b635-4ed6-8e11-715ec5150563) Co-authored-by: hiifong <i@hiif.ong> Co-authored-by: silverwind <me@silverwind.io>
* Changelog for v1.20.0-rc2 (#25474)65432023-06-271-0/+549
| | | | | | | as title --------- Co-authored-by: techknowlogick <matti@mdranta.net>
* Allow change line of admin-dl-horizontal dt (#25508) (#25516)HesterG2023-06-261-3/+0
| | | | | | | | | | | | | | | | | | | As https://github.com/go-gitea/gitea/pull/25515#issuecomment-1606626886 says, still need this backport Close #25389 After: <img width="915" alt="Screen Shot 2023-06-26 at 11 00 12" src="https://github.com/go-gitea/gitea/assets/17645053/45026447-cf50-4603-ade3-7b80a9023c20"> admin/dashboard: <img width="957" alt="Screen Shot 2023-06-26 at 10 59 51" src="https://github.com/go-gitea/gitea/assets/17645053/f4f95bbe-f747-46f1-8fbd-5778a19ebef7"> Co-authored-by: Giteabot <teabot@gitea.io>
* Add Adopt repository event and handler (#25497) (#25518)Giteabot2023-06-265-11/+29
| | | | | | | | | Backport #25497 by @lunny Fix #14304 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Clarify the reason why the user can't add a new email if there is a pending ↵Giteabot2023-06-262-0/+5
| | | | | | | | | | activation (#25509) (#25514) Backport #25509 by @wxiaoguang ![image](https://github.com/go-gitea/gitea/assets/2114189/cff20df0-ad0c-4140-b8e2-5782cad8a53a) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix CLI sub-command handling (#25501) (#25517)Giteabot2023-06-261-8/+7
| | | | | | | | | | | | | | Backport #25501 by @wxiaoguang A regression of #25330 : The nil "Action" should be treated as "help" In old releases: `./gitea admin` show helps After #25330: `./gitea admin` panics (although the code returned `nil` if action is nil, but Golang's quirk is: nil in interface is not nil) With this PR: `./gitea admin` shows helps as the old releases. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Improve loadprojects for issue list (#25468) (#25493)Giteabot2023-06-267-30/+41
|
* Document creating an API key from the CLI (#25504)lonix12023-06-251-0/+8
| | | | | | | Related to https://github.com/go-gitea/gitea/issues/25503 --------- Co-authored-by: delvh <dev.lh@web.de>
* Fine tune "dropdown button" icon (#25442) (#25499)Giteabot2023-06-253-17/+43
| | | | | | | | | | | Backport #25442 by @wxiaoguang ![image](https://github.com/go-gitea/gitea/assets/2114189/143e043d-85c9-43a4-85ae-ca55f507f738) ---- ![image](https://github.com/go-gitea/gitea/assets/2114189/bcba03a5-732e-4139-bc35-96a7f8bfcb88) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Use InitWorkPathAndCfgProvider for environment-to-ini to avoid unnecessary ↵v1.20.0-rc2Giteabot2023-06-242-3/+7
| | | | | | | | | | | | | | | | | | | checks (#25480) (#25488) Backport #25480 by @wxiaoguang Fix #25481 The `InitWorkPathAndCommonConfig` calls `LoadCommonSettings` which does many checks like "current user is root or not". Some commands like "environment-to-ini" shouldn't do such check, because it might be run with "root" user at the moment (eg: the docker's setup script) ps: in the future, the docker's setup script should be improved to avoid Gitea's command running with "root" Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Revert "Make buttons in a modal form have proper type. (#25446) (#25478)" ↵wxiaoguang2023-06-241-2/+0
| | | | | | | | (#25484) There is a side effect because some modal doesn't have a proper "ok" button. This reverts commit 050c38ca19cce06040741321e7871121981c76f4.
* Fix wrong warn messages in migration steps (#25475) (#25487)Giteabot2023-06-243-4/+7
|
* Make buttons in a modal form have proper type. (#25446) (#25478)Denys Konovalov2023-06-241-0/+2
| | | | | | | | | | Backport #25446 by @wxiaoguang Fix #25438 All non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter". Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Improve wiki sidebar and TOC (#25460) (#25477)Giteabot2023-06-2411-117/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25460 by @wxiaoguang Close #20976 Close #20975 1. Fix the bug: the TOC in footer was incorrectly rendered as main content's TOC 2. Fix the layout: on mobile, the TOC is put above the main content, while the sidebar is put below the main content 3. Auto collapse the TOC on mobile ps: many styles of "wiki.css" are moved from old css files, so leave nits to following PRs. ### for desktop ![image](https://github.com/go-gitea/gitea/assets/2114189/6c84201c-0648-465a-99e6-c53cdaee53c0) ### for mobile ![image](https://github.com/go-gitea/gitea/assets/2114189/9cb4fdfe-b6ab-4e6f-ae82-219ddb8fa27e) ### other changed pages <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/ef077736-2c3e-4e3d-82fe-d9bf1ebcca98) ![image](https://github.com/go-gitea/gitea/assets/2114189/bb528429-ad5f-4258-a5c4-05f997c624ea) </details> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix repo search broken because of profile page added (#25455) (#25467)v1.20.0-rc1Giteabot2023-06-231-0/+2
| | | | | | | | Backport #25455 by @lunny Fix #25433 Caused by #23260 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Make "dismiss" content shown correctly (#25461) (#25465)Giteabot2023-06-232-2/+1
| | | | | | | | | | Backport #25461 by @wxiaoguang Close #25127 ![image](https://github.com/go-gitea/gitea/assets/2114189/7d6be811-8e4a-4982-a5e4-857d171758d4) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Gitea version in Makefile (#25456) (#25457)John Olheiser2023-06-231-2/+2
| | | | | Backport-ish of #25456 Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Support Drone building binaries tootechknowlogick2023-06-221-0/+18
|
* Remove test string (#25447) (#25448)Denys Konovalov2023-06-221-1/+1
| | | | | | Backport #25447 Remove test string on delete project button, I overlooked it in a previous PR
* Refactor path & config system (#25330) (#25416)wxiaoguang2023-06-2231-458/+649
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25330 # The problem There were many "path tricks": * By default, Gitea uses its program directory as its work path * Gitea tries to use the "work path" to guess its "custom path" and "custom conf (app.ini)" * Users might want to use other directories as work path * The non-default work path should be passed to Gitea by GITEA_WORK_DIR or "--work-path" * But some Gitea processes are started without these values * The "serv" process started by OpenSSH server * The CLI sub-commands started by site admin * The paths are guessed by SetCustomPathAndConf again and again * The default values of "work path / custom path / custom conf" can be changed when compiling # The solution * Use `InitWorkPathAndCommonConfig` to handle these path tricks, and use test code to cover its behaviors. * When Gitea's web server runs, write the WORK_PATH to "app.ini", this value must be the most correct one, because if this value is not right, users would find that the web UI doesn't work and then they should be able to fix it. * Then all other sub-commands can use the WORK_PATH in app.ini to initialize their paths. * By the way, when Gitea starts for git protocol, it shouldn't output any log, otherwise the git protocol gets broken and client blocks forever. The "work path" priority is: WORK_PATH in app.ini > cmd arg --work-path > env var GITEA_WORK_DIR > builtin default The "app.ini" searching order is: cmd arg --config > cmd arg "work path / custom path" > env var "work path / custom path" > builtin default ## ⚠️ BREAKING If your instance's "work path / custom path / custom conf" doesn't meet the requirements (eg: work path must be absolute), Gitea will report a fatal error and exit. You need to set these values according to the error log.
* Move some regexp out of functions (#25430) (#25445)John Olheiser2023-06-222-4/+6
| | | | | | | Partial backport of #25430 Not a bug, but worth backporting for efficiency. Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix `Permission` in API returned repository struct (#25388) (#25441)Giteabot2023-06-2222-153/+174
| | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25388 by @wolfogre The old code generates `structs.Repository.Permissions` with only `access.Permission.AccessMode`, however, it should check the units too, or the value could be incorrect. For example, `structs.Repository.Permissions.Push` could be false even the doer has write access to code unit. Should fix https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128 (Not reported by it, I just found it when I was looking into this bug) --- Review tips: The major changes are - `modules/structs/repo.go` https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7 - `services/convert/repository.go` https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101 And other changes are passive. Co-authored-by: Jason Song <i@wolfogre.com>
* Diff page enhancements (#25398) (#25437)Giteabot2023-06-224-9/+10
| | | | | | | | | | | | | | | | | | | | | | Backport #25398 by @silverwind Two small tweaks: 1. Vertically center arrow here when editing a PR: <img width="405" alt="Screenshot 2023-06-20 at 19 48 49" src="https://github.com/go-gitea/gitea/assets/115237/1d63764d-9fd9-467e-8a8e-9258c06475eb"> 2. Use 2-row layout on diff viewed status and show it again on mobile: <img width="142" alt="Screenshot 2023-06-20 at 19 51 21" src="https://github.com/go-gitea/gitea/assets/115237/3046e782-163c-4f87-910c-a22066de8f1b"> Mobile view: <img width="370" alt="Screenshot 2023-06-20 at 19 44 40" src="https://github.com/go-gitea/gitea/assets/115237/9cf56347-7323-4d05-99a5-17ad215ee44d"> Co-authored-by: silverwind <me@silverwind.io>
* Change default email domain for LDAP users (#25425) (#25434)Giteabot2023-06-222-2/+2
| | | | | | | | | Backport #25425 by @Zettat123 Fixes #21169 Change `localhost` to `localhost.local` Co-authored-by: Zettat123 <zettat123@gmail.com>
* Various UI fixes (#25264) (#25431)Giteabot2023-06-2214-28/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25264 by @silverwind Numerous small UI fixes: - Fix double border in collaborator list - Fix system notice table background - Mute links in repo and org lists - Downsize projects edit buttons - Improve milestones and project list rendering - Condense milestone list entry to a single line of "metas" - Mute ".." button in repo files list <img width="899" alt="Screenshot 2023-06-14 at 21 19 23" src="https://github.com/go-gitea/gitea/assets/115237/40d70006-5f76-49ad-b43c-4343ec3311e1"> <img width="905" alt="Screenshot 2023-06-14 at 21 18 29" src="https://github.com/go-gitea/gitea/assets/115237/46ef39ea-ab26-452d-89b0-a55d0cfacfdb"> <img width="270" alt="Screenshot 2023-06-14 at 21 14 09" src="https://github.com/go-gitea/gitea/assets/115237/aa16e833-a03b-4231-bc7c-159a6a6bee19"> <img width="409" alt="Screenshot 2023-06-14 at 21 12 13" src="https://github.com/go-gitea/gitea/assets/115237/b5242d41-f87a-4837-b0cf-9cc4c1f43daf"> <img width="286" alt="Screenshot 2023-06-14 at 21 10 03" src="https://github.com/go-gitea/gitea/assets/115237/d0c36e47-651b-4d34-ad95-3d59474a7c3e"> <img width="928" alt="Screenshot 2023-06-14 at 21 05 24" src="https://github.com/go-gitea/gitea/assets/115237/fc3b713e-d252-40f5-b6ba-6e5a741ab500"> <img width="217" alt="Screenshot 2023-06-14 at 21 02 01" src="https://github.com/go-gitea/gitea/assets/115237/c4c33376-18d6-4820-aff5-f508f6d351a0"> <img width="79" alt="Screenshot 2023-06-14 at 20 42 43" src="https://github.com/go-gitea/gitea/assets/115237/034b5950-c0bf-473b-a2f7-0c27a0259f29"> <img width="607" alt="Screenshot 2023-06-14 at 21 00 42" src="https://github.com/go-gitea/gitea/assets/115237/fba2d3fd-bd3e-4daf-8b2f-530a1c99c8bc"> Co-authored-by: silverwind <me@silverwind.io>
* Show outdated comments in files changed tab (#24936) (#25428)sebastian-sauer2023-06-2218-38/+115
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #24936 If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on). **Screenshots** ![image](https://github.com/go-gitea/gitea/assets/1135157/63ab9571-a9ee-4900-9f02-94ab0095f9e7) ![image](https://github.com/go-gitea/gitea/assets/1135157/78f7c225-8d76-46f5-acfd-9b8aab988a6c) When resolved and outdated: ![image](https://github.com/go-gitea/gitea/assets/1135157/6ece9ebd-c792-4aa5-9c35-628694e9d093) Option to enable/disable this (stored in user settings - default is disabled): ![image](https://github.com/go-gitea/gitea/assets/1135157/ed99dfe4-76dc-4c12-bd96-e7e62da50ab5) ![image](https://github.com/go-gitea/gitea/assets/1135157/e837a052-e92e-4a28-906d-9db5bacf93a6) fixes #24913 Co-authored-by: silverwind <me@silverwind.io>
* Use "utf8mb4" for MySQL by default (#25432)wxiaoguang2023-06-225-36/+11
| | | | | | TBH, I don't see much difference from `Remove "CHARSET" config option for MySQL, always use "utf8mb4"` #25413 Close #25413
* Fix missing commit message body when the message has leading newlines ↵Giteabot2023-06-212-3/+59
| | | | | | | | | | | | | (#25418) (#25422) Backport #25418 by @wolfogre Commit with `echo "\nmessage after a blank line\nsecond line of the message" | git commit --cleanup=verbatim -F -` and push. <img width="1139" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/f9a2c28c-e307-4c78-9e31-3d3ace7b9274"> Co-authored-by: Jason Song <i@wolfogre.com>
* Avoid polluting config file when "save" (#25395) (#25406)Giteabot2023-06-217-16/+94
| | | | | | | | | | | | | | | | | Backport #25395 by @wxiaoguang That's a longstanding INI package problem: the "MustXxx" calls change the option values, and the following "Save" will save a lot of garbage options into the user's config file. Ideally we should refactor the INI package to a clear solution, but it's a huge work. A clear workaround is what this PR does: when "Save", load a clear INI instance and save it. Partially fix #25377, the "install" page needs more fine tunes. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Use the new download domain replace the old (#25405) (#25409)Giteabot2023-06-2115-29/+29
| | | | | | | Backport #25405 by @lunny As title. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Fix dropdown icon layout on diff page (#25397) (#25403)Giteabot2023-06-216-14/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25397 by @wxiaoguang Address https://github.com/go-gitea/gitea/pull/25163#issuecomment-1599207916 Remove the unused "icon-button". And fix the layout: Without the dropdown icon: ``` {{svg "gitea-whitespace"}} ``` ![image](https://github.com/go-gitea/gitea/assets/2114189/58a524ba-f289-4982-aea2-6f9f9f9cbdcf) With the dropdown icon: ``` {{svg "gitea-whitespace" 16 "gt-mr-3"}} {{svg "octicon-triangle-down" 14 "dropdown icon"}} ``` ![image](https://github.com/go-gitea/gitea/assets/2114189/eb99168b-5d49-40a7-8665-5296cbb4e486) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix blank dir message when uploading files from web editor (#25391) (#25400)Giteabot2023-06-201-1/+5
| | | | | | | Backport #25391 by @lunny Fix #7883 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Use Actions git context instead of dynamically created buildkit one (#25381) ↵Giteabot2023-06-202-4/+2
| | | | | | | | | | | | | | | | (#25383) Backport #25381 by @techknowlogick The [docker/build-push-action@v2 action](https://github.com/docker/build-push-action) by default ignores the checkout created using the actions/checkout@v2 action. When you pass a git build context to docker build, it wouldn't include the .git directory. By passing `context: .` to the build step then it'll use the Actions git context which includes the git fetch from the earlier step. Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Update JS dependencies, remove space after emoji completion (#25266) (#25352)silverwind2023-06-2012-196/+220
| | | | | | | | | | | | | | | | | Manual backport of #25266 because of lockfile conflicts. - Update all JS dependencies - Enable stylint [`media-feature-name-value-no-unknown`](https://stylelint.io/user-guide/rules/media-feature-name-value-no-unknown) - Make use of new features in webpack and text-expander-element - Tested Swagger and Mermaid To explain the `text-expander-element` change: Before this version, the element added a unavoidable space after emoji completion. Now that https://github.com/github/text-expander-element/pull/36 is in, we gain control over this space and I opted to remove it for emoji completion and retain it for `@` mentions. Co-authored-by: Giteabot <teabot@gitea.io>
* Fix LDAP sync when Username Attribute is empty (#25278) (#25379)Giteabot2023-06-202-30/+83
| | | | | | | | | | | | | | | | | | Backport #25278 by @Zettat123 Fix #21072 ![image](https://github.com/go-gitea/gitea/assets/15528715/96b30beb-7f88-4a60-baae-2e5ad8049555) Username Attribute is not a required item when creating an authentication source. If Username Attribute is empty, the username value of LDAP user cannot be read, so all users from LDAP will be marked as inactive by mistake when synchronizing external users. This PR improves the sync logic, if username is empty, the email address will be used to find user. Co-authored-by: Zettat123 <zettat123@gmail.com>
* Fetch all git data for embedding correct version in docker image (#25361) ↵Giteabot2023-06-202-0/+6
| | | | | | | | | (#25373) Backport #25361 by @techknowlogick Fix #25350 Co-authored-by: techknowlogick <techknowlogick@gitea.io>