aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Macaron 1.5 (#12596)techknowlogick2020-08-2753-638/+2595
| | | | | | | | | | | | | | * update macaron to v1.5 of fork * update macaron to v1.5 of fork * test gzip PR * add push method impl to context_tests * use proper gzip commit Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Git migration UX (#12619)John Olheiser2020-08-2820-177/+269
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Initial work Signed-off-by: jolheiser <john.olheiser@gmail.com> * Implementation Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix gitlab and token cloning Signed-off-by: jolheiser <john.olheiser@gmail.com> * Imports and JS Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix test Signed-off-by: jolheiser <john.olheiser@gmail.com> * Linting Signed-off-by: jolheiser <john.olheiser@gmail.com> * Generate swagger Signed-off-by: jolheiser <john.olheiser@gmail.com> * Move mirror toggle and rename options Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* [skip ci] Updated translations via CrowdinGiteaBot2020-08-272-0/+2
|
* Fix ellipsis in files table (#12617)silverwind2020-08-272-6/+7
| | | | | | | Turns out text ellispsis does not work in combination with flexbox and while wrapping in a display:block can help in some cases, I could not get this to work properly so this changes the truncate to inline-block again and reduces the clickable area to just vertical expansion from the links.
* Extract Swagger CSS to its own file (#12616)silverwind2020-08-263-27/+32
|
* Add link to home page on swagger ui (#12601)赵智超2020-08-262-5/+21
| | | | | | | | | | | | | | | | | * Add link to home page on swagger ui Signed-off-by: a1012112796 <1012112796@qq.com> * translate * Apply review suggestion * Move to right, Thanks @silverwind * tweaks Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Fix file table overflows (#12603)silverwind2020-08-265-34/+52
| | | | | | | | | - Fix overflow regression from https://github.com/go-gitea/gitea/pull/12553. - Fix submodule columns stretching the table - Refactor template to share more HTML nodes - Introduce CSS helper classes Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Escape Email in forgot_password.tmpl (#12610)zeripath2020-08-261-1/+1
| | | Signed-off-by: Andrew Thornton <art27@cantab.net>
* Mark Cache with ini tag (#12605)John Olheiser2020-08-261-1/+1
| | | Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Reindent Less to 2-space (#12602)silverwind2020-08-2522-5843/+5837
| | | Reindent and unify codebase to 2-space indentation.
* update to latest golangci-lint (v1.30.0) (#12597)techknowlogick2020-08-251-1/+1
|
* Open transaction when adding Avatar email-hash pairs to the DB (#12577)zeripath2020-08-241-1/+12
| | | | | | | | | | | | | | | | | | | | | When adding Avatar email-hash pairs we simply want the DB table to represent a Set. We don't care if the hash-pair is already present, so we just simply Insert and ignore the error. Unfortunately this seems to cause some DBs to log the duplicate insert to their logs - looking like a bug a in Gitea. Now, there is no standard way in SQL to say Insert but if there's an error ignore it. MySQL has INSERT IGNORE, PostgreSQL >= 9.5 has INSERT ... ON CONFLICT DO NOTHING, but I do not believe that SQLite or MSSQL have variants. This PR places the insert in a transaction which we are happy to fail if there is an error - hopefully this will stop the unnecessary logging. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Update JWT docs in example config (#12591)techknowlogick2020-08-241-2/+2
| | | | | | | | | | | | | * Update JWT docs in example config align with way we have `LFS_JWT_SECRET` in config Fix #12590 * Update custom/conf/app.example.ini Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: John Olheiser <john.olheiser@gmail.com>
* go1.15 on windows (#12589)techknowlogick2020-08-242-17/+7
| | | | | * go1.15 on windows * update xgo to use node14
* OpenGraph: use repo avatar if exist (#12586)65432020-08-242-1/+10
|
* [skip ci] Updated translations via CrowdinGiteaBot2020-08-242-0/+2
|
* Add cron running API (#12421)zeripath2020-08-246-0/+232
| | | | | | | | | | | | | | | | | | | * Add cron running API Signed-off-by: Andrew Thornton <art27@cantab.net> * Apply suggestions from code review * placate-swagger Signed-off-by: Andrew Thornton <art27@cantab.net> * return not found Signed-off-by: Andrew Thornton <art27@cantab.net> * Apply suggestions from code review Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Fix emoji replacements, make emoji images consistent (#12567)silverwind2020-08-235-4/+5
| | | | | | | - Fix emoji not being replaced in issue title change text - Make the image attributes consistent, add alt, remove align Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Change tab width go,tmpl,html to 2 (#12572)silverwind2020-08-231-1/+1
| | | | | | Make it easier to edit deeply nested code. I plan to convert Less to 2-space so that we have standardized indentation width in the codebase. Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Reaction picker display improvements (#12576)silverwind2020-08-232-7/+28
| | | | | | | | - Remove overly thin font-width on counter - Add hover effect on reaction picker - Change colors on arc-green to green to match the theme Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: zeripath <art27@cantab.net>
* Fix signing.wont_sign.%!s(<nil>) if Require Signing commits but not signed ↵zeripath2020-08-233-4/+7
| | | | | | | | | | | | | | | | | | | | | in (#12581) signing.wont_sign.%!s(<nil>) will be displayed if the repository needs signed commits but the user is not logged in. This is displayed because of complicated logic in the the template repo/issue/view_content/pull.tmpl and a shortcut in the code of routers/repo/issue.go This PR adds a default value of notsignedin if users are not signed in, which although our templates will not show will prevent custom templates from showing the above. It also fixes the template to avoid showing signing errors if the user is not authorized to sign. Replaces #12564 Close #12564 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Increase clickable area on files table links (#12553)silverwind2020-08-233-35/+34
|
* [skip ci] Updated translations via CrowdinGiteaBot2020-08-231-1/+4
|
* Initial support for push options (#12169)John Olheiser2020-08-236-0/+118
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Initial support for push options Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix misspelling 🤦 Signed-off-by: jolheiser <john.olheiser@gmail.com> * Fix formatting after conflict resolution * defer close git repo * According the GitLab documentation, git >= 2.10 Signed-off-by: jolheiser <john.olheiser@gmail.com> * Words are hard. Thanks @mrsdizzie :sweat_smile: Co-authored-by: mrsdizzie <info@mrsdizzie.com> * Only update if there are push options Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: mrsdizzie <info@mrsdizzie.com>
* Add email notify for new release (#12463)赵智超2020-08-234-0/+139
| | | | | | * Add email notify for new release Signed-off-by: a1012112796 <1012112796@qq.com>
* Ensure that the detected charset order is set in chardet test (#12574)zeripath2020-08-231-5/+23
| | | | | | | | | | | | | | | TestToUTF8WithFallback is the cause of recurrent spurious test failures even despite code to set the detected charset order. The reason why this happens is because the preferred detected charset order is not being initialised for these tests. This PR simply ensures that this is set at the start of each test and would allow different tests to be written to allow differing orders. Replaces #12571 Close #12571 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Fix bug on migration 147 (#12565)Lunny Xiao2020-08-221-38/+60
|
* Fix diff path unquoting (#12554)zeripath2020-08-222-30/+34
| | | | | | | | | | | | | | | | | * Fix diff path unquoting services/gitdiff/gitdiff.go whereby there it assumed that the path would always be quoted on both sides This PR simplifies the code here and uses fmt.Fscanf to parse the strings as necessary. Fix #12546 Signed-off-by: Andrew Thornton <art27@cantab.net> * Add testcase as per @mrsdizzie Signed-off-by: Andrew Thornton <art27@cantab.net>
* Set utf8mb4 as the default charset on MySQL if CHARSET is unset (#12563)zeripath2020-08-221-1/+3
| | | | | | | | | | | | MySQL in its infinite wisdom determines that UTF8 does not mean UTF8. Our install scripts know about this and will set CHARSET to utf8mb4 if we users choose this but... users who do not explicitly set this variable will default to utf8mb3 without knowing it. This PR changes the unset CHARSET value to utf8mb4 if users choose to use mysql. Signed-off-by: Andrew Thornton <art27@cantab.net>
* Skip SSPI authentication attempts for /api/internal (#12556)zeripath2020-08-223-1/+8
| | | | | | | | | | | | | | | * Skip SSPI authentication attempts for /api/internal SSPI fails badly on authentication attempts to /api/internal which it can never succesfully authenticate. Fix #11260 Signed-off-by: Andrew Thornton <art27@cantab.net> * Update oauth2.go Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lauris BH <lauris@nix.lv>
* Hide 'New Project board' button for users that are not signed in (#12547)wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf2020-08-225-106/+112
| | | | | | | | | | | | | | | | | | | | | | | | | | * hide: 'New Project board' button * there is no reason to show the button for users that are not signed in * update template: specifies the condition together with another one as per lafriks' suggestion in the comment * chore: add proper user authorization check * chore: also hide button if repo is archived * chore: show project board edit/delete menu to authorized users only * chore: drop the redundant IsSigned check * CanWriteIssues and CanWritePulls implies (and requires) signed in user * Add CanWriteProjects and properly assert permissions Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* [skip ci] Updated translations via CrowdinGiteaBot2020-08-221-6/+6
|
* Speed up licenses.txt build during development, add additionalModules (#12510)silverwind2020-08-213-2/+12
| | | | | | | | - Emit static string for licenses.txt during development for faster builds - Manually add @primer/octicons to licenses.txt because it's never directy imported. Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* [skip ci] Updated translations via CrowdinGiteaBot2020-08-212-0/+6
|
* Disable password complexity check default (#12557)mrsdizzie2020-08-213-4/+7
| | | | | | | * Disable password complexity check default These features enourange bad passwords/are annoying for people using better password methods, and at minimum we shouldn't force that as a default for obvious reasons. Disable any default check to avoid regular complaints. * fix copy paste format
* Allow addition of gpg keyring with multiple keys (#12487)zeripath2020-08-214-67/+85
| | | | | | | Related #6778 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
* [skip ci] Updated translations via CrowdinGiteaBot2020-08-211-2/+2
|
* Prevent NPE on commenting on lines with invalidated comments (with ↵zeripath2020-08-213-1/+135
| | | | | | | | | | | | | | | | | | | | | | migration) (#12549) * Prevent NPE on commenting on lines with invalidated comments Only check for a review if we are replying to a previous review. Prevent the NPE in #12239 by assuming that a comment without a Review is non-pending. Fix #12239 Signed-off-by: Andrew Thornton <art27@cantab.net> * Add hack around to show the broken comments Signed-off-by: Andrew Thornton <art27@cantab.net> * Add migration and remove template hacks Signed-off-by: Andrew Thornton <art27@cantab.net>
* Support Force-update in Mirror and improve Tracing in mirror (#12242)zeripath2020-08-201-1/+33
| | | | | | | | | | | | | | | | | * Remove double indirect in NewColoredIDValue Signed-off-by: Andrew Thornton <art27@cantab.net> * Handle forced-update in mirror.go Signed-off-by: Andrew Thornton <art27@cantab.net> * Add tracing Signed-off-by: Andrew Thornton <art27@cantab.net> * As per @lafriks Signed-off-by: Andrew Thornton <art27@cantab.net>
* fix typos (#12545)Success2020-08-202-2/+2
| | | | | | | * fix typo in app.ini * fix typo in git hook module Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* [skip ci] Updated translations via CrowdinGiteaBot2020-08-201-0/+48
|
* Use Node 14 on CI (#12512)silverwind2020-08-201-4/+4
| | | | | | | | | | | * Use Node 14 on CI Node 14 is sufficiently stable now, use it on CI. * also run build on node 14 Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: zeripath <art27@cantab.net>
* Add placeholder text for "Add SSH/GPG Key" forms (#12533)Bagas Sanjaya2020-08-203-2/+4
| | | | | | | | | | | | * Add placeholder text for "Add SSH/GPG Key" forms This commit add placeholder text for both Add SSH key and Add GPG key forms. * Localize placeholders Changes requested by @zeripath Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Fix typos (#12542)Gjergji Ramku2020-08-204-7/+7
| | | Signed-off-by: Gjergji Ramku <gjergjiramku@gmail.com>
* Default empty merger list to those with write permissions (#12535)zeripath2020-08-203-4/+9
| | | | | Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Show 2FA info on Admin Pannel: Users List (#12515)65432020-08-204-1/+5
|
* Report error if API merge is not allowed (#12528)zeripath2020-08-191-3/+13
| | | | | | | | | | #12496 demonstrated that the API merge needs to return some information as to why a merge has been disallowed with a status code 422. This PR ensures that a reason is always returned. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
* Set z-index for sticky diff box lower (#12537)zeripath2020-08-191-1/+1
| | | | | Fix #12525 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Add security policy to repo (#12536)techknowlogick2020-08-191-0/+10
|
* Remove hardcoded ES indexername (#12521)Wim2020-08-181-1/+1
|