summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* update snapcraft.yaml for core18 and latest features (#11300)Sergio Schvezov2020-05-086-341/+27
| | | | | | | Removing some of the complexity, together with the install and configure hook. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
* Add default CommitID for create pull review api (#11334)赵智超2020-05-081-0/+19
| | | | | | | | If user create pull review through api but not set CommitID, I think it's necessary to use last headCommitID as default seting, or this review will be considered as stale review which is wrong Signed-off-by: a1012112796 <1012112796@qq.com>
* Prevent timer leaks in Workerpool and others (#11333)zeripath2020-05-085-29/+32
| | | | | | | | | | | | | | | | There is a potential memory leak in `Workerpool` due to the intricacies of `time.Timer` stopping. Whenever a `time.Timer` is `Stop`ped its channel must be cleared using a `select` if the result of the `Stop()` is `false`. Unfortunately in `Workerpool` these were checked the wrong way round. However, there were a few other places that were not being checked. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Add NotifySyncPushCommits to indexer notifier (#11309)zeripath2020-05-081-0/+9
| | | | | | | | Thanks to @simon-on-gh for tracking down the issue. Fix #11200 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Split some words from template to improve translation. (#11221)L0veSunshine2020-05-082-6/+11
| | | | | | | | | | | | * split some words from template * split some words from template * add " " to mustache expression * split some words from template Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Add EventSource support (#11235)zeripath2020-05-0717-27/+676
| | | | | | If the browser supports EventSource switch to use this instead of polling notifications. Signed-off-by: Andrew Thornton art27@cantab.net
* When deleting a tracked time through the API return 404 not 500 (#11319)65432020-05-071-0/+4
|
* Manage port in submodule refurl (#11305)zeripath2020-05-071-3/+7
| | | | | | | | | | | | | | | | | | | | | * Manage port in submodule refurl Fix #11304 Signed-off-by: Andrew Thornton <art27@cantab.net> * fix lint Signed-off-by: Andrew Thornton <art27@cantab.net> * URLJoin is causes a cyclic dependency and possibly isn't what what we want anyway Signed-off-by: Andrew Thornton <art27@cantab.net> * Protect against leading .. in scp syntax Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
* Prevent multiple listings of organization when creating a repository (#11303)65432020-05-071-6/+6
| | | | | | | | | | | prevent double entries in results of GetOrgsCanCreateRepoByUserID I first try to only add GroupBy directly but xorm return broken user objects ... ... solution was to just query related UserIDs(OrgIDs) first and return OrgUsers based on this IDs close #11258 Co-authored-by: zeripath <art27@cantab.net>
* [skip ci] Updated translations via CrowdinGiteaBot2020-05-071-1/+93
|
* Adding advanced label set. (#11298)opyale2020-05-071-0/+26
| | | Add an advanced label set to contrib
* Protect default branch against deletion (#11115)65432020-05-063-1/+14
| | | | | | Although default branch is not offered for deletion in the templates, we need to prevent it both at the router level and in the pre-receive hook. Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
* Load Repo Topics on blame view (#11307)65432020-05-052-6/+19
| | | Fix #11280
* api.Context.NotFound(...) should tolerate nil (#11288)zeripath2020-05-051-0/+5
| | | | | | | | | | | | | There is an unfortunate signature change with the api.Context NotFound function; whereas the normal modules/context/Context NotFound function requires an error or nil, the api.Context variant will panic with an NPE if a nil is provided. This PR will allow api.Context.NotFound to tolerate a being passed a nil. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
* Change the style in admin notice content view from <p> to <pre> (#11301)赵智超2020-05-052-2/+2
| | | | | | That's because many notic have more than one lines. So I think pre is more better to used in here than p Signed-off-by: a1012112796 <1012112796@qq.com>
* Update JS dependencies (#11297)silverwind2020-05-052-375/+487
| | | | | | | | Contains an apparently important bug fix for highlight.js [1], otherwise nothing of interest. [1] https://github.com/highlightjs/highlight.js/releases/tag/10.0.2 Co-authored-by: zeripath <art27@cantab.net>
* Allow unauthenticated users to compare (#11240)Kyle Evans2020-05-047-41/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * routers: make /compare route available to unauthenticated users Remove some bits of the compare interface if the user isn't signed in. Notably, they don't need to see the "New Pull Request" button box nor the hidden form that would fail to submit due to the POST request continuing to require proper privileges. Follow-up commits will improve the UI a bit around this, removing some "Pull Request" verbiage in favor of "Compare." * ui: home: show "compare" button for unauthenticated users This change requires pulling in the BaseRepo unconditionally and recording if the pull request is in-fact not allowed (.PullRequestCtx.Allowed). If the user isn't allowed to create a pull request, either because this isn't a fork or same-fork branch PRs aren't allowed, then we'll name the button "Compare" instead of "Pull Request." * ui: branch list: use the new Compare language when available When viewing the branch listing as an unauthenticated user, you'll get "Pull Request" buttons. use the new "Compare" verbiage instead, which matches GitHub behavior when you can't issue a pull request from the branches. Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Fix Create new branch (#11294)zeripath2020-05-041-1/+1
| | | | | Fix #11212 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Fix; declare DOMAIN variable for docker setup (#10780)Adrian POIGET2020-05-043-2/+5
| | | | | | | | In the /install form, the value for SSH Server Domain is taken form the DOMAIN variable and overwrites SSH_DOMAIN environment variable set the first time if nothing done Co-authored-by: Adrian POIGET <adrian.poiget@viveris.fr>
* Update lunny/levelqueue to 0.3.0 (#11285)guillep2k2020-05-048-9/+34
| | | Co-authored-by: Guillermo Prandi <guillep2k@users.noreply.github.com>
* Fix orgs not being displayed on create repo form (#11279)Cirno the Strongest2020-05-031-8/+12
|
* Restore checkbox rendering and prevent poor sanitization of spans (#11277)zeripath2020-05-034-3/+21
| | | | | | | | | | | | | | | | | * Add test Signed-off-by: Andrew Thornton <art27@cantab.net> * Restore checkbox rendering and prevent poor sanitization of spans Signed-off-by: Andrew Thornton <art27@cantab.net> * Also fix preview context Signed-off-by: Andrew Thornton <art27@cantab.net> * Also fix preview context Signed-off-by: Andrew Thornton <art27@cantab.net>
* repo: milestone: make /milestone/:id endpoint accessible (#11264)Kyle Evans2020-05-031-3/+8
| | | | | | | | | | | Previously, this required authentication, but there's not actually any privileged information on this page. Move the endpoint out of the group that requires sign-in. It still requires the ability to read issues and pull requests, so private repositories (for instance) will not be exposed. Fixes #10312 Fixes #11233
* [skip ci] Updated translations via CrowdinGiteaBot2020-05-031-1/+8
|
* cmd: dump: check value of skip-repository flag (#11254)Kyle Evans2020-05-031-1/+1
| | | | | | This is a boolean flag; simply checking if it's set isn't enough, we must check the value as well. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Sendmail should create a process on the gitea system and have a default ↵zeripath2020-05-036-4/+25
| | | | | | | | | | | | timeout (#11256) * Make sure that sendmail processes register with the process manager * Provide a timeout for these (initially of 5 minutes) * Add configurable value and tie in to documentation * Tie in to the admin config page. Signed-off-by: Andrew Thornton <art27@cantab.net>
* [skip ci] Updated translations via CrowdinGiteaBot2020-05-022-0/+9
|
* Fix bug about comment attachment (#11272)Lunny Xiao2020-05-021-2/+2
|
* Show pull request selection even when unrelated branches (#11239)zeripath2020-05-022-4/+1
| | | | | | | | Fix #10525 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* [skip ci] Updated translations via CrowdinGiteaBot2020-05-0214-28/+0
|
* API: Add pull review endpoints (#11224)65432020-05-0212-26/+1580
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * API: Added pull review read only endpoints * Update Structs, move Conversion, Refactor * refactor * lint & co * fix lint + refactor * add new Review state, rm unessesary, refacotr loadAttributes, convert patch to diff * add DeletePullReview * add paggination * draft1: Create & submit review * fix lint * fix lint * impruve test * DONT use GhostUser for loadReviewer * expose comments_count of a PullReview * infent GetCodeCommentsCount() * fixes * fix+impruve * some nits * Handle Ghosts :ghost: * add TEST for GET apis * complete TESTS * add HTMLURL to PullReview responce * code format as per @lafriks * update swagger definition * Update routers/api/v1/repo/pull_review.go Co-authored-by: David Svantesson <davidsvantesson@gmail.com> * add comments Co-authored-by: Thomas Berger <loki@lokis-chaos.de> Co-authored-by: David Svantesson <davidsvantesson@gmail.com>
* Remove last traces of has-emoji class (#11263)mrsdizzie2020-05-0123-59/+68
| | | | | | Now that emojify.js has been removed, get rid of all instances of has-emoji class that was only used for that. Support for rendering shortcodes should remain in all of these places so it should still work the same. Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Lauris BH <lauris@nix.lv>
* cmd: dump: add an -L/--skip-log option (#11253)Kyle Evans2020-04-301-1/+10
| | | | | | | | | | Not all dumps need to include the logs, in a similar vain to not all dumps needing to include repositories; these may be subject to different backup mechanisms/constraints. Add a simple option to let them be excluded from the dump to simplify workflows that need to exclude them or not collect in the first place. Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: zeripath <art27@cantab.net>
* Return issue subscription status from API subscribe (#10966)65432020-04-303-4/+35
| | | | | * [API] issue subscription indicate by http status * CI.restart()
* Fix spelling mistake with Rewiew (#11262)zeripath2020-04-307-15/+15
| | | Signed-off-by: Andrew Thornton <art27@cantab.net>
* Refactor UpdateOAuth2Application (#11034)65432020-04-303-24/+30
| | | | | Following on from #11008 refactor UpdateOAuth2Application
* [skip ci] Updated translations via CrowdinGiteaBot2020-04-3025-50/+0
|
* Fix creation of Organization repos by Users with max created personal repos ↵Andrew Bezold2020-04-303-6/+17
| | | | | | | | | | | | | | | | | (#11183) * Fix creation of Org repos Fix go-gitea#9269 * Change variable name to appease linter * Update PR with suggestions Add a note for user.CanCreateRepo() about failure assumptions Change repo.create help message Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Add a 'this' to issue close/reopened messages (#11204)silverwind2020-04-302-4/+14
| | | | | | | | * add a 'this' to issue close/reopened messages * add 'this issue/pull request' and create new localization entries Co-authored-by: Lauris BH <lauris@nix.lv>
* When using API CreateRelease set created_unix to the tag commit time (#11218)Jason Duan2020-04-301-1/+1
|
* Propose an explanation how to restart gracefully gitea after an update (#10866)Km2020-04-301-0/+12
| | | | | Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Lauris BH <lauris@nix.lv>
* Update JS dependencies, min Node.js version 10.13 (#11246)silverwind2020-04-305-97/+112
| | | | | | | `less-loader` now dictates a minimum Node.js version of 10.13.0, released 2018-10-30 so I've updated this requirement to match. https://github.com/webpack-contrib/less-loader/releases/tag/v6.0.0
* Use keys.openpgp.org instead of pgp.mit.edu (#11249)zeripath2020-04-301-2/+2
| | | | | | | | | | | | | | | | The SKS Keyserver network has been under attack with poisoned certificates since at least 2019. Downloading a poisoned certificate has the awful side-effect of completely breaking your keyring and most software has now moved off the network and uses the keys.openpgp.org which has a different protocol instead - in fact one whereby emails are verified. For more details regarding the attack see: https://gist.github.com/rjhansen/67ab921ffb4084c865b3618d6955275f See: https://keys.openpgp.org/about and https://keys.openpgp.org/about/faq Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Allow emoji short code in labels (#11250)mrsdizzie2020-04-306-21/+20
| | | | | | | | | | | | | | | | | | | | | * Allow emoji short code in labels As title, turn :alias: type short code into emojis when rendering labels to match previous behavior * Update models/issue_label.go Co-Authored-By: John Olheiser <john.olheiser@gmail.com> * render text in templates not code * remove has-emoji class 🧙‍♀️ * fix new issue form Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Patch fomantic-ui to workaround build issue (#11244)silverwind2020-04-305-116/+266
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Patch fomantic-ui to workaround build issue Better workaround than https://github.com/go-gitea/gitea/issues/10653 for https://github.com/fomantic/Fomantic-UI/issues/1356. It does not seem like we're getting a new Fomantic-UI release anytime soon, so this patches it after node_modules installation. Fixes: https://github.com/go-gitea/gitea/issues/11243 Fixes: https://github.com/go-gitea/gitea/issues/10679 * copy instead of patch * update package-lock.json * Update Makefile Co-Authored-By: Sorien <Sorien@users.noreply.github.com> * Update web_src/fomantic/css.js Co-Authored-By: zeripath <art27@cantab.net> Co-authored-by: Sorien <Sorien@users.noreply.github.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
* [API] ListIssues add filter for milestones (#10148)65432020-04-3010-29/+102
| | | | | | | | | * Refactor Issue Filter Func * ListIssues add filter for milestones * as per @lafriks * documentation ...
* Fix submit review form (#11252)zeripath2020-04-302-2/+11
| | | | | | | | | | | | | | | | | * Fix submit review form Signed-off-by: Andrew Thornton <art27@cantab.net> * placate lint Signed-off-by: Andrew Thornton <art27@cantab.net> * try something different Signed-off-by: Andrew Thornton <art27@cantab.net> * Update web_src/less/_base.less Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Don't allow registration via the web form, when ↵n0emis2020-04-291-2/+3
| | | | | | | AllowOnlyExternalRegistration is True (#11248) * Don't allow registration via the web form, when AllowOnlyExternalRegistration is True * Show Disabled Registration message if DisableRegistration or AllowOnlyExternalRegistration options are true
* Fix sanitizer config - multiple rules (#11133)Alexander Scheel2020-04-294-39/+38
| | | | | | | | | | | | | | | | | | | | | | | | In #9888, it was reported that my earlier pull request #9075 didn't quite function as expected. I was quite hopeful the `ValuesWithShadow()` worked as expected (and, I thought my testing showed it did) but I guess not. @zeripath proposed an alternative syntax which I like: ```ini [markup.sanitizer.1] ELEMENT=a ALLOW_ATTR=target REGEXP=something [markup.sanitizer.2] ELEMENT=a ALLOW_ATTR=target REGEXP=something ``` This was quite easy to adopt into the existing code. I've done so in a semi-backwards-compatible manner: - The value from `.Value()` is used for each element. - We parse `[markup.sanitizer]` and all `[markup.sanitizer.*]` sections and add them as rules. This means that existing configs will load one rule (not all rules). It also means people can use string identifiers (`[markup.sanitiser.KaTeX]`) if they prefer, instead of numbered ones. Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
* BugFix: updateLabel can updated not allowed fields #11242 (#11242)65432020-04-283-9/+16
|
generated by cgit v1.2.3 (git 2.39.1) at 2025-02-12 20:45:15 +0000