summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix commit status icon when in subdirectory (#20285)silverwind2022-07-153-7/+9
| | | | | | When viewing a subdirectory and the latest commit to that directory in the table, the commit status icon incorrectly showed the status of the HEAD commit instead of the latest for that directory.
* Fix eslint parsing errors, remove eslint-plugin-html (#20323)silverwind2022-07-157-90/+18
| | | | | | | | | | | Introduce a separate .eslintrc in the Vue components folder to selectively enable vue-eslint-parser there, so that the rest of the files can use eslint's core parser which can deal with hashbangs. The fact that the eslint-disable comments worked in HTML was a unintended side-effect of the files being parsed via vue-eslint-parser, so I had to disable the parsing of these files in .eslintrc.yaml to make it work, and finally decided to remove eslint-plugin-html as it causes more issues than it solves.
* Include login_name in adminCreateUser response (#20283)Baekjun Kim2022-07-153-0/+10
| | | | `login_name` (Authentication Sign-in Name) is not included in the response of `adminUserCreate` API. This PR is to return user-specified `login_name` if there is one.
* Add allow_rebase_update, default_delete_branch_after_merge to repository api ↵Bian Jiaping2022-07-153-66/+82
| | | | | | | response (#20079) `PATCH /repos/{owner}/{repo}` API allows users to update `allow_rebase_update`, `default_delete_branch_after_merge`, but `GET /repos/{owner}/{repo}` API does not return these two options, and API users has no other ways to find the state of these two options. This PR add `allow_rebase_update`, `default_delete_branch_after_merge` to repository query api response.
* Allow to specify colors for text in markup (#20363)Gusted2022-07-152-0/+14
| | | | `<span style="color: red">Hello World!</span>` will now be accepted by Bluemonday, other properties are still disallowed by Bluemonday.
* [skip ci] Updated translations via Crowdin65432022-07-1517-17/+15
|
* update xorm.io/xorm v1.3.2-0.20220714055524-c3bce556200f (#20371)65432022-07-142-3/+3
| | | | | | | Xorm 1.3.2-0.20220714055524 contains a fix for interpreting db column sizes. Prior to this fix xorm would assume that the size of a column was within the range of an `int`. This is correct on 64bit machines where `int` is typical equivalent to `int64` however, on 32bit machines `int` tends to be `int32`. Unfortunately the size of a LONGTEXT field is actually `max_uint32`, thus using `strconv.Atoi` on these fields will fail and thus #20161 occurs on 32 bit arm. Xorm 1.3.2-0.20220714055524 changes this field to use int64 instead. Fix #20161
* Add order by for assignee no sort issue (#20053)Tyrone Yeh2022-07-144-3/+11
| | | Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Make sure `repo_dir` is an empty directory or doesn't exist before ↵a10121127962022-07-141-1/+18
| | | | 'dump-repo' (#20205)
* Fix English mistakes in some Markdown documents (#20274)Jeremy2022-07-144-42/+55
|
* Fix versions check for busybox `sh` (#20358)silverwind2022-07-143-5/+5
| | | | | | `printf` in busybox emits a ugly 'invalid number' error when formatting string variables are present. Avoid that by reducing the go version check to just two digits, which ought to be enough as patch-level go versions are meant to be compatible. Avoid error on node-check as well.
* Unbreak release pipeline (#20356)silverwind2022-07-141-2/+4
| | | | | | Downgrade release pipeline to node 16 until xgo updates its base OS to a version with a compatible glibc. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Add option to purge users (#18064)zeripath2022-07-1416-51/+221
| | | | | | | Add the ability to purge users when deleting them. Close #15588 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Fix icon margin in user/settings/repos (#20281)Baoshuo Ren2022-07-141-5/+5
|
* Fix org label open count, including close count issue (#20353)Tyrone Yeh2022-07-141-0/+2
| | | Fixed using organization tags to see open issues in the tag list including closed issues count
* [skip ci] Updated translations via Crowdinzeripath2022-07-1419-19/+5
|
* Prevent context deadline error propagation in GetCommitsInfo (#20346)zeripath2022-07-141-3/+5
| | | | | | | | | | | | | | * Prevent context deadline error propagation in GetCommitsInfo Although `WalkGitLog` tries to test for `context.DeadlineExceededErr` there is a small chance that the error will propagate to the reader before it is recognised. This will cause the error to propagate up to `renderDirectoryFiles` and cause a http status 500. Here we check that the error passed is a `DeadlineExceededErr` via error.Is Fix #20329 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Add missing return for when topic isn't found (#20351)Gusted2022-07-131-0/+1
| | | Add missing return to DeleteTopic API when the topic is not found.
* Upgrade to Node 18 on CI (#20340)silverwind2022-07-131-9/+9
| | | | | | | | | * Upgrade to Node 18 on CI Should be pretty stable now. * restart ci Co-authored-by: 6543 <6543@obermui.de>
* Fix checks in PR for empty commits #19603 (#20290)Ing. Jaroslav Šafka2022-07-137-9/+58
| | | | | | * Fixes issue #19603 (Not able to merge commit in PR when branches content is same, but different commit id) * fill HeadCommitID in PullRequest * compare real commits ID as check for merging * based on @zeripath patch in #19738
* Use default values when provided values are empty (#20318)Gusted2022-07-131-0/+13
| | | | | | | | | | | | * Use default values when provided values are empty - When provided values are empty like `:3000` would imply that host is empty, use the default value. - Resolves #20316 * Update database.go Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Add tests for the host checking logic, clarify the behaviors (#20328)wxiaoguang2022-07-135-8/+54
| | | | | | Before, the combination of AllowedDomains/BlockedDomains/AllowLocalNetworks is confusing. This PR adds tests for the logic, clarify the behaviors.
* Changelog for 1.16.9 (update) (#20341) (#20343)65432022-07-131-1/+7
| | | * Changelog for 1.16.9 (update)
* Fix various typos (#20338)luzpaz2022-07-1227-34/+34
| | | | | | | * Fix various typos Found via `codespell -q 3 -S ./options/locale,./options/license,./public/vendor -L actived,allways,attachements,ba,befores,commiter,pullrequest,pullrequests,readby,splitted,te,unknwon` Co-authored-by: zeripath <art27@cantab.net>
* Correctly handle draft releases without a tag (#20314)Chongyi Zheng2022-07-121-2/+1
| | | | | Fixes #20313. `errors.Is(err, git.ErrNotExist{})` is not working
* Add write check for creating Commit status (#20332)Gusted2022-07-121-1/+1
| | | | | | - Add write code checks for creating new commit status - Regression #5314 Co-authored-by: zeripath <art27@cantab.net>
* Remove blue text on migrate page (#20273)silverwind2022-07-122-2/+2
| | | | | | | * Remove blue text on migrate page * remove Safe Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Updated dead link to Madeleine.js source (#20322)BurritoVoid2022-07-111-1/+1
|
* [skip ci] Updated translations via Crowdinsilverwind2022-07-121-0/+3
|
* Add spectral linter for Swagger (#20321)silverwind2022-07-117-101/+2904
| | | | | | | | | | [spectral](https://github.com/stoplightio/spectral) lints openapi/swagger files for mistakes of which it has identified a few and which I've fixed. I had to put it into `lint-frontend` because it depends on node_modules so can not run on Drone during the backend target. I plan to refactor these targets later to `lint-js` and `lint-go` so that they are categorized based on the tool dependencies.
* Store read access in access for team repo's (#20275)Gusted2022-07-111-1/+7
| | | | | | | | - Currently when a Team has read access to a organization's non-private repository, their access won't be stored in the database. This caused issue for code that rely on read access being stored. So from now-on if we see that the repository is owned by a organization don't increase the minMode to write permission. - Resolves #20083
* [skip ci] Updated translations via CrowdinGusted2022-07-111-0/+1
|
* Vertical align avatar at middle (#20302)Gusted2022-07-101-1/+1
| | | | | | | | - Currently the avatar in the navbar is being vertically aligned to the top, this caused that the icon besides it isn't being at the middle of the avatar. Use the `vm` helper class to force the `vertical-align` to be `middle`. - Resolves #20292
* Changed scroll to auto for some UI elements. (#20294)KN4CK3R2022-07-104-5/+5
| | | | Addition to: Show scrollbar when necessary #20142 Fixes the "empty" scrollbars with Firefox.
* Add hint to GNUPGHOME environment variable (#20134)Steven Kriegler2022-07-101-3/+3
| | | | | | | | | | | | | | * Add hint for GNUPGHOME environment variable With #19732, the default location for the `.gnupg` folder has changed. To mitigate this breaking change, users can specify the home directory for gnupg via `$GNUPGHOME` environment variable to keep using their current location. * Update docs/content/doc/advanced/signing.en-us.md Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: zeripath <art27@cantab.net>
* Refactor SSH init code, fix directory creation for TrustedUserCAKeys file ↵wxiaoguang2022-07-104-29/+63
| | | | | | | | | | | | | | | | (#20299) * Refactor SSH init code, fix directory creation for TrustedUserCAKeys file * Update modules/ssh/init.go Co-authored-by: zeripath <art27@cantab.net> * fix lint copyright * Update modules/ssh/init.go Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* [skip ci] Updated translations via CrowdinGusted2022-07-108-8/+4
|
* Use dedicated draft PR icon when possible (#20303)Gusted2022-07-093-2/+11
| | | | | | | | | | * Use dedicated draft PR icon when possible - Currently the generic pull-request icon is used for draft PR's. This patch changes that by using the dedicated icon for this. - Resolves #20296 * Use draft title
* Update goldmark (#20300)Gusted2022-07-092-3/+3
| | | | | Update goldmark to v1.4.13 to fix a issue with quotes after a empty list item(See https://github.com/yuin/goldmark/issues/313) and downstream issue https://codeberg.org/Codeberg/Community/issues/645
* Do not create empty ".ssh" directory when loading config (#20289)wxiaoguang2022-07-091-3/+1
| | | | | | Creating the directory automatically is not correct. In other places for ssh key writing (RewriteAllPrincipalKeys / appendAuthorizedKeysToFile, etc), the directory will still be created when updating the keys. This PR will resolve the confusing and annoying problem: the dummy and empty ".ssh" directory in new git home.
* Implement sync push mirror on commit (#19411)Chongyi Zheng2022-07-0812-98/+208
| | | | | | | | | Support synchronizing with the push mirrors whenever new commits are pushed or synced from pull mirror. Related Issues: #18220 Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Use git.HOME_PATH for Git HOME directory (#20114)wxiaoguang2022-07-088-27/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add git.HOME_PATH * add legacy file check * Apply suggestions from code review Co-authored-by: zeripath <art27@cantab.net> * pass env GNUPGHOME to git command, move the existing .gitconfig to new home, make the fix for 1.17rc more clear. * set git.HOME_PATH for docker images to default HOME * Revert "set git.HOME_PATH for docker images to default HOME" This reverts commit f120101ddc267cef74e4f4b92c783d5fc8e275a1. * force Gitea to use a stable GNUPGHOME directory * extra check to ensure only process dir or symlink for legacy files * refactor variable name * The legacy dir check (for 1.17-rc1) could be removed with 1.18 release, since users should have upgraded from 1.17-rc to 1.17-stable * Update modules/git/git.go Co-authored-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com> * remove initFixGitHome117rc * Update git.go * Update docs/content/doc/advanced/config-cheat-sheet.en-us.md Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Add tooltip to repo icons in explore page (#20241)Baoshuo Ren2022-07-071-2/+2
| | | | | * Add label to repo icons in explore page Co-authored-by: silverwind <me@silverwind.io>
* Fix NPE when using non-numeric (#20277)Gusted2022-07-071-2/+3
| | | | | | - This code is only valid when `refNumeric` exist(otherwise we didn't find such numeric PR and can skip that check) and give a free-pas to the "BEFORE" check when `ref` is nil. - Resolves #20109
* Modify milestone search keywords to be case insensitive (#20266)Tyrone Yeh2022-07-061-1/+1
| | | Milestone search keywords are now sensitive, this modification is changed to insensitive
* Fix toolip on mobile notification bell (#20270)zeripath2022-07-061-1/+1
| | | | | | | | Unfortunately there is a bug in #20108 where the translation call was not updated to use `.locale` from `.i18n`. This PR updates the template to use `.locale`. Signed-off-by: Andrew Thornton <art27@cantab.net>
* Allow RSA 2047 bit keys (#20272)zeripath2022-07-063-3/+3
| | | | | | | | | Unfortunately it appears that 2048 bit RSA keys can occasionally be created in such a way that they appear to have 2047 bit length. This PR simply changes our defaults to allow these. Fix #20249 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Refix notification bell placement (#20251)zeripath2022-07-062-3/+3
| | | | | | | | | | | | | | | The use of `m-4 text black` for the notification bell results in this icon being shifted upwards. Instead we should use the `item` class but adjust `not-mobile` and `mobile-only` to make their `display: none` settings `!important`. (As an aside: This is probably one of the only times we should use `!important` in our less files and the rest should be avoided or removed.) Ref #20069 Revert #20236 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Bump mermaid from 9.1.1 to 9.1.2 (#20256)dependabot[bot]2022-07-062-16/+16
| | | | | | | | | | | | | | | | Bumps [mermaid](https://github.com/knsv/mermaid) from 9.1.1 to 9.1.2. - [Release notes](https://github.com/knsv/mermaid/releases) - [Changelog](https://github.com/mermaid-js/mermaid/blob/develop/CHANGELOG.md) - [Commits](https://github.com/knsv/mermaid/compare/9.1.1...9.1.2) --- updated-dependencies: - dependency-name: mermaid dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* EscapeFilter the group dn membership (#20200)zeripath2022-07-051-1/+1
| | | | | | | | | The uid provided to the group filter must be properly escaped using the provided ldap.EscapeFilter function. Fix #20181 Signed-off-by: Andrew Thornton <art27@cantab.net>