summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix required error for token name (#28267) (#28284)Giteabot2023-11-291-1/+1
| | | | | | | | | | | | Backport #28267 by @earl-warren - Say to the binding middleware which locale should be used for the required error. - Resolves https://codeberg.org/forgejo/forgejo/issues/1683 (cherry picked from commit 5a2d7966127b5639332038e9925d858ab54fc360) Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com> Co-authored-by: Gusted <postmaster@gusted.xyz>
* Fix issue will be detected as pull request when checking `First-time ↵Giteabot2023-11-291-1/+1
| | | | | | | | | contributor` (#28237) (#28271) Backport #28237 by @yp05327 Fix #28224 Co-authored-by: yp05327 <576951401@qq.com>
* Check for v prefix on tags for release clean name (#28257) (#28270)Giteabot2023-11-282-2/+2
| | | | Co-authored-by: John Olheiser <john.olheiser@gmail.com>
* Use full width for project boards (#28225) (#28245)Giteabot2023-11-273-53/+59
| | | | | | | Backport #28225 by @denyskon Inspired by #28182 Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
* Increase "version" when update the setting value to a same value as before ↵Giteabot2023-11-282-1/+13
| | | | | | | | | | (#28243) (#28244) Backport #28243 Setting the same value should not trigger DuplicateKey error, and the "version" should be increased Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Revert move installation/upgrade-from-gogs.md in 1.21 (#28235)yp053272023-11-272-0/+2
| | | https://github.com/go-gitea/gitea/pull/28233#discussion_r1405539630
* Fix links in docs (#28234) (#28238)Giteabot2023-11-273-3/+3
| | | | | | | | | | | | | Backport #28234 by @yp05327 Follow #28191 Changes: - `(doc/administration/config-cheat-sheet.md` is incorrect: ![image](https://github.com/go-gitea/gitea/assets/18380374/1c417dd7-61a0-49ba-8d50-871fd4c9bf20) - remove `../../` Co-authored-by: yp05327 <576951401@qq.com>
* Change log for 1.21.1 (#28222)v1.21.1Lunny Xiao2023-11-261-0/+27
| | | | | | | As title. --------- Co-authored-by: delvh <dev.lh@web.de>
* Fix comment permissions (#28213) (#28216)Lunny Xiao2023-11-2541-129/+441
| | | | | | | backport #28213 This PR will fix some missed checks for private repositories' data on web routes and API routes.
* Fix actions when tagging (#28061) (#28218)Giteabot2023-11-252-1/+9
| | | | | | | | Backport #28061 by @lunny close https://github.com/go-gitea/gitea/issues/28053 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Docs: Replace deprecated IS_TLS_ENABLED mailer setting in email setup ↵Giteabot2023-11-252-2/+2
| | | | | | | | | | | | | | | (#28205) (#28208) Backport #28205 by @CodeShakingSheep In the [docs for email setup](https://docs.gitea.com/administration/email-setup) `mailer.IS_TLS_ENABLED` is mentioned which was replaced by `mailer.PROTOCOL` in release 1.18.0 according to https://blog.gitea.com/release-of-1.18.0/ . This change wasn't reflected in the docs for email setup. I just replaced the deprecated mailer setting. Co-authored-by: CodeShakingSheep <19874562+CodeShakingSheep@users.noreply.github.com>
* Fix some incorrect links in docs (#28191) (#28201)Giteabot2023-11-247-7/+5
| | | | | | | | | | | | Backport #28191 by @yp05327 https://gitea.com/gitea/gitea-docusaurus/actions/runs/661/jobs/0#jobstep-9-39 I noticed that there are many warning logs in building docs. It is causing 404 in docs.gitea.com now, so we need to fix it. And there are also some other problems in v1.19 which can not be done in this PR. Co-authored-by: yp05327 <576951401@qq.com>
* Fix delete-orphaned-repos (#28200) (#28202)pitpalme2023-11-241-2/+2
| | | | | | | | | Backport #28200 gitea doctor failed at checking and fixing 'delete-orphaned-repos', because table name 'user' needs quoting to be correctly recognized by at least PostgreSQL. fixes #28199
* Use full width for PR comparison (#28182) (#28186)Giteabot2023-11-231-2/+2
| | | | | | | | | | | | | | Backport #28182 by @lng2020 Follow-up #22844 close #28142 Before ![ksnip_20231123-183906](https://github.com/go-gitea/gitea/assets/70063547/78428a22-b0a0-45f9-9458-7fd5ec73aa29) After ![full](https://github.com/go-gitea/gitea/assets/70063547/047242cf-9d6c-4b3a-9f92-54102740c27e) Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
* Make CORS work for oauth2 handlers (#28184) (#28185)Giteabot2023-11-233-0/+10
| | | | | | | | | | Backport #28184 Fix #25473 Although there was `m.Post("/login/oauth/access_token", CorsHandler()...`, it never really worked, because it still lacks the "OPTIONS" handler. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix missing buttons (#28179) (#28181)Giteabot2023-11-231-0/+4
| | | | | | | | | | | | | Backport #28179 by @lng2020 fix #28173 regression #25948 That PR is supposed to only change the style but somehow delete a code snippet. See the diff(https://github.com/go-gitea/gitea/pull/25948/files#diff-7c36d66fe058f4ff9f2beaac73cf710dca45b350d0dd98daf806828a4745fe62L125-L129) for details. Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Revert "Fix EOL handling in web editor" (#28101) (#28172)Giteabot2023-11-223-22/+6
| | | | | | | | Backport #28101 by @lng2020 Reverts go-gitea/gitea#27141 close #28097 Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
* Fix swagger title (#28164) (#28167)Giteabot2023-11-222-2/+2
| | | | | | | | | Backport #28164 by @yp05327 ![image](https://github.com/go-gitea/gitea/assets/18380374/380859b2-a643-42fd-b53e-78c93c05c826) Don't know why there's a `.` behind. 🤔 Co-authored-by: yp05327 <576951401@qq.com>
* Fix the description about the default setting for action in quick start ↵Giteabot2023-11-222-2/+2
| | | | | | | | | | | | document (#28160) (#28168) Backport #28160 by @yp05327 Since #27054, Actions are enabled by default. so we should also edit the document. 😃 ps: I think this should be backport to 1.21.0. Co-authored-by: yp05327 <576951401@qq.com>
* Add guide page to actions when there's no workflows (#28145) (#28153)Giteabot2023-11-224-0/+16
| | | | | | | | | | | | | Backport #28145 by @yp05327 Before: ![image](https://github.com/go-gitea/gitea/assets/18380374/599d40c1-9b8d-4189-9286-c9c36fb780dd) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/848a73d1-aaec-478f-93a7-adcc7ee18907) Co-authored-by: yp05327 <576951401@qq.com>
* Do not display search box when there's no packages yet (#28146) (#28159)Giteabot2023-11-221-0/+2
| | | | | | | | | | | | | | | | | Backport #28146 by @yp05327 Before: ![image](https://github.com/go-gitea/gitea/assets/18380374/3012f544-7ff5-4ccb-ac80-ce24d50abe97) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/4084312a-9ac0-4103-8c93-ea178ae24493) ![image](https://github.com/go-gitea/gitea/assets/18380374/3c47d175-0735-476d-8979-da2bc0a4fc95) ![image](https://github.com/go-gitea/gitea/assets/18380374/033c6a81-d1f7-4426-8063-5793d0b47462) Co-authored-by: yp05327 <576951401@qq.com>
* Fix no ActionTaskOutput table waring (#28149) (#28152)Giteabot2023-11-211-0/+4
| | | | | | | | | | | | | | | | | | | Backport #28149 by @yp05327 Reproduce: - Create a new Gitea instance - Register a runner - Create a repo and add a workflow - Check the log, you will see warnings: ![image](https://github.com/go-gitea/gitea/assets/18380374/5f1278e0-114b-48bc-8113-8ba1404d9975) It comes from: ![image](https://github.com/go-gitea/gitea/assets/18380374/c2807831-e137-4229-9536-87f6114c8a5b) The reason is that we forgot registering `ActionTaskOutput` model. So `action_table_output` table will be missing in your db. Co-authored-by: yp05327 <576951401@qq.com>
* Fix empty action run title (#28113) (#28148)Giteabot2023-11-212-1/+2
| | | | | | | Backport #28113 by @lunny Fix #27901 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Use "is-loading" to avoid duplicate form submit for code comment (#28143) ↵Giteabot2023-11-211-19/+28
| | | | | | | | | | | | | | | | (#28147) Backport #28143 by @wxiaoguang Compare by ignoring spaces: https://github.com/go-gitea/gitea/pull/28143/files?diff=split&w=1 When the form is going to be submitted, add the "is-loading" class to show an indicator and avoid user UI events. When the request finishes (success / error), remove the "is-loading" class to make user can interact the UI. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix typo in `packages.cleanup.success` (#28133) (#28136)Giteabot2023-11-201-1/+1
| | | | | | | | Backport #28133 by @wolfogre Follow https://github.com/go-gitea/gitea/pull/28129#discussion_r1398971596 Co-authored-by: Jason Song <i@wolfogre.com>
* Add missing `packages.cleanup.success` (#28129) (#28132)Giteabot2023-11-201-0/+1
| | | | | Backport #28129 by @wolfogre Co-authored-by: Jason Song <i@wolfogre.com>
* Update docs for docusaurus v3 (#28126)John Olheiser2023-11-205-10/+10
| | | Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Fix Matrix and MSTeams nil dereference (#28089) (#28105)Giteabot2023-11-1711-6/+155
| | | | | | | | | | | Backport #28089 by @KN4CK3R Fixes #28088 Fixes #28094 Added missing tests. Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Change default size of attachments and repo files (#28100) (#28106)Giteabot2023-11-172-2/+2
| | | | | | | | Backport #28100 by @lng2020 https://github.com/go-gitea/gitea/pull/27946 forgets to change them in code. Sorry about that. Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
* Fix incorrect pgsql conn builder behavior (#28085) (#28098)Giteabot2023-11-172-9/+11
| | | | | | | Backport #28085 by @wxiaoguang Fix #28083 and fix the tests Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix permissions for Token DELETE endpoint to match GET and POST (#27610) ↵Giteabot2023-11-172-3/+30
| | | | | | | | | | | | | | | (#28099) Backport #27610 by @evantobin Fixes #27598 In #27080, the logic for the tokens endpoints were updated to allow admins to create and view tokens in other accounts. However, the same functionality was not added to the DELETE endpoint. This PR makes the DELETE endpoint function the same as the other token endpoints and adds unit tests Co-authored-by: Evan Tobin <me@evantob.in>
* Fix system config cache expiration timing (#28072) (#28090)Giteabot2023-11-161-8/+10
| | | | | | | | | | Backport #28072 To avoid unnecessary database access, the `cacheTime` should always be set if the revision has been checked. Fix #28057 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Restricted users only see repos in orgs which their team was assigned to ↵Giteabot2023-11-141-5/+5
| | | | | | | | | | | (#28025) (#28051) Backport #28025 by @6543 --- *Sponsored by Kithara Software GmbH* Co-authored-by: 6543 <m.huber@kithara.com>
* Add v1.21.0 changelog (#28005) (#28048)v1.21.0Denys Konovalov2023-11-141-1/+448
| | | | | | | | | Backport changelog for v1.21.0 as Giteabot doesn't seem to be in the mood for it --------- Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: silverwind <me@silverwind.io>
* enable system users for comment.LoadPoster (#28014) (#28032)Giteabot2023-11-142-1/+38
| | | | | | | | | | | | | | | | Backport #28014 by @earl-warren System users (Ghost, ActionsUser, etc) have a negative id and may be the author of a comment, either because it was created by a now deleted user or via an action using a transient token. The GetPossibleUserByID function has special cases related to system users and will not fail if given a negative id. Refs: https://codeberg.org/forgejo/forgejo/issues/1425 (cherry picked from commit 6a2d2fa24390116d31ae2507c0a93d423f690b7b) Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com>
* Fix viewing wiki commit on empty repo (#28040) (#28044)Giteabot2023-11-141-1/+0
| | | | | | | | | Backport #28040 by @JakobDev Fixes https://codeberg.org/forgejo/forgejo/issues/1758 For some weird reason we need to cast this nil. Co-authored-by: JakobDev <jakobdev@gmx.de>
* Add word break to the repo list in admin settings page (#28034) (#28035)Giteabot2023-11-141-2/+2
| | | | | | | | | | | | | Backport #28034 by @yp05327 Before: ![image](https://github.com/go-gitea/gitea/assets/18380374/ed464937-e20d-4f5b-b997-e86c2d96469d) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/471e77b3-516e-4ae9-b901-0cf8745eb9aa) Co-authored-by: yp05327 <576951401@qq.com>
* fixed duplicate attachments on dump on windows (#28019) (#28031)Giteabot2023-11-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | Backport #28019 by @anudeepreddy Hi, This PR fixes #27988. The use of `path.join`(which uses `/` as the file separator) to construct paths and comparing them with paths constructed using `filepath.join`(which uses platform specific file separator) is the root cause of this issue. The desired behavior is to ignore attachments when dumping data directory. Due to the what's mentioned above, the function `addRecursiveExclude` is not actually ignoring the attachments directory and is being written to the archive. The attachment directory is again added to the archive (with different file separator as mentioned in the issue) causing a duplicate entry on windows. The solution is to use `filepath.join` in `addResursiveExclude` to construct `currentAbsPath`. Co-authored-by: Anudeep Reddy <anudeepc85@gmail.com>
* Dont leak private users via extensions (#28023) (#28029)Giteabot2023-11-141-0/+5
| | | | | | Backport #28023 by @6543 there was no check in place if a user could see a other user, if you append e.g. `.rss`
* Change default size of issue/pr attachments and repo file (#27946) (#28017)Giteabot2023-11-133-8/+8
| | | | | | | | Backport #27946 by @lng2020 As title. Some attachments and file sizes can easily be larger than these limits Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
* Fix wrong xorm Delete usage(backport for 1.21) (#28002)Nanguan Lin2023-11-121-1/+1
| | | | | manually backport for https://github.com/go-gitea/gitea/pull/27995 The conflict is `ctx` and `db.Defaultctx`.
* Move some JS code from `fomantic.js` to standalone files (#27994) (#28001)Giteabot2023-11-128-93/+100
| | | | | | | | | | | | | | | Backport #27994 by @wxiaoguang To improve maintainability, this PR: 1. Rename `web_src/js/modules/aria` to `web_src/js/modules/fomantic` (the code there are all for aria of fomantic) 2. Move api/transition related code to `web_src/js/modules/fomantic/api.js` and `web_src/js/modules/fomantic/transition.js` No logic is changed. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Render email addresses as such if followed by punctuation (#27987) (#27992)Giteabot2023-11-112-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | Backport #27987 by @yardenshoham Added the following characters to the regular expression for the email: - , - ; - ? - ! Also added a test case. - Fixes #27616 # Before ![image](https://github.com/go-gitea/gitea/assets/20454870/c57eac26-f281-43ef-a51d-9c9a81b63efa) # After ![image](https://github.com/go-gitea/gitea/assets/20454870/fc7d5c08-4350-4af0-a7f0-d1444d2d75af) Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: Yarden Shoham <git@yardenshoham.com>
* Show error toast when file size exceeds the limits (#27985) (#27986)Giteabot2023-11-101-0/+4
| | | | | | | | | | | Backport #27985 by @lng2020 As title. Before that, there was no alert at all. After: ![error_toast](https://github.com/go-gitea/gitea/assets/70063547/c54ffeed-76f8-4c3a-b5dc-b9b3e0f8fc76) Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
* Fix citation error when the file size is larger than 1024 bytes (#27958) ↵Giteabot2023-11-081-5/+2
| | | | | | | | | | | | (#27965) Backport #27958 by @yp05327 Mentioned in: https://github.com/go-gitea/gitea/pull/27931#issuecomment-1798016960 Same to #25131, so use the same method to fix this problem. Co-authored-by: yp05327 <576951401@qq.com>
* Add word-break to repo description in home page (#27924) (#27957)Giteabot2023-11-082-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #27924 by @yp05327 In #25315, @denyskon fixed UI on mobile view. But for the repo description, on desktop view there's no word-break. So maybe we can just add `gt-word-break` to fix it on both mobile view and desktop view. Before: desktop view: ![image](https://github.com/go-gitea/gitea/assets/18380374/a7659f5b-fbe9-400a-8cc2-cca44778556e) mobile view: ![image](https://github.com/go-gitea/gitea/assets/18380374/611f1b81-58ac-4213-b165-5c73e24ca79e) After: desktop view: ![image](https://github.com/go-gitea/gitea/assets/18380374/f21bf3a7-f6aa-457d-9bfa-5c57659c68b1) mobile view(almost same?) ![image](https://github.com/go-gitea/gitea/assets/18380374/ad2d1a4d-1172-402c-b5fc-5e910657847d) Co-authored-by: yp05327 <576951401@qq.com> Co-authored-by: silverwind <me@silverwind.io>
* Document REACTION_MAX_USER_NUM setting option (#27954) (#27959)Giteabot2023-11-082-0/+4
| | | | | | | | | | Backport #27954 by @6543 as title --- *Sponsored by Kithara Software GmbH* Co-authored-by: 6543 <m.huber@kithara.com>
* Fix rendering assignee changed comments without assignee (#27927) (#27952)Giteabot2023-11-071-24/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #27927 by @invliD When an assignee changed event comment is rendered, most of it is guarded behind the assignee ID not being 0. However, if it is 0, that results in quite broken rendering for that comment and the next one. This can happen, for example, when repository data imported from outside of Gitea is incomplete. This PR makes sure comments with an assignee ID of 0 are not rendered at all. --- Screenshot before: <img width="272" alt="Bildschirm­foto 2023-11-05 um 20 12 18" src="https://github.com/go-gitea/gitea/assets/42910/7d629d76-fee4-4fe5-9e3a-bf524050cead"> The comments in this screenshot are: 1. A regular text comment 2. A user being unassigned 3. A user being assigned 4. The title of the PR being changed Comments 2 and 3 are rendered without any text, which indents the next comment and does not leave enough vertical space. Co-authored-by: Sebastian Brückner <code@nik.dev>
* Add word break to release title (#27942) (#27947)Giteabot2023-11-071-1/+1
| | | | | | | | | | | | | Backport #27942 by @yp05327 Before: ![image](https://github.com/go-gitea/gitea/assets/18380374/74c925e0-15ae-4602-8b56-0b69f54a5e7a) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/027c34ef-0cbc-4156-a198-44bf5dd924e2) Co-authored-by: yp05327 <576951401@qq.com>
* Update environment-to-ini flag parsing (#27914) (#27940)Giteabot2023-11-061-12/+16
| | | | | | | | | | | | Backport #27914 by @fashberg This Fixes #27913 This commit updates `environment-to-ini` to be compatible with update urfave/cli/v2 Doc: <https://cli.urfave.org/v2/examples/combining-short-options/> Co-authored-by: Folke <folke@ashberg.de>