summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Avoid issue info panic (#29625) (#29632)Giteabot2024-03-061-3/+7
| | | | | | | Backport #29625 by wxiaoguang Fix #29624 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Avoid unexpected panic in graceful manager (#29629) (#29630)wxiaoguang2024-03-062-2/+18
| | | Backport #29629
* Fix wrong line number in code search result (#29260) (#29623)Giteabot2024-03-064-47/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | Backport #29260 by @yp05327 Fix #29136 Before: The result is a table and all line numbers are all in one row. ![image](https://github.com/go-gitea/gitea/assets/18380374/7a18b354-e257-4f57-a5ca-f6d37378edf6) ![image](https://github.com/go-gitea/gitea/assets/18380374/98416e11-89b5-4b4f-920b-91bcf041a87f) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/f189e436-9046-4431-926a-cd0deb58e8f1) ![image](https://github.com/go-gitea/gitea/assets/18380374/07d213ed-2401-4b7f-b951-5df7dc776af4) ~~Updated:~~ ~~added `active` class to the target line.~~ ![image](https://github.com/go-gitea/gitea/assets/18380374/0b274e48-048a-4c66-ba95-df515212ec08) Co-authored-by: yp05327 <576951401@qq.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* bump protobuf module (#29617) (#29619)techknowlogick2024-03-062-3/+3
| | | backport #29617
* Add missing database transaction for new issue (#29490) (#29607)Lunny Xiao2024-03-057-26/+31
| | | | | | When creating an issue, inserting issue, assign users and set project should be in the same transaction. Backport #29490
* Make "/user/login" page redirect if the current user has signed in (#29583) ↵wxiaoguang2024-03-054-12/+65
| | | | | (#29599) Backport #29583
* Add a trailing slash to dashboard links (#29555) (#29573)wxiaoguang2024-03-045-9/+32
| | | Backport #29555
* Fix workflow trigger event IssueChangeXXX bug (#29559) (#29565)Giteabot2024-03-041-2/+14
| | | | | | | | | | Backport #29559 by @yp05327 Bugs from #29308 Follow #29467 partly fix #29558 Co-authored-by: yp05327 <576951401@qq.com>
* Fix 500 when pushing release to an empty repo (#29554) (#29564)Giteabot2024-03-031-0/+5
| | | | | | | | | | Backport #29554 by @lng2020 As title. The former code directly used `ctx.Repo.GitRepo`, causing 500. https://github.com/go-gitea/gitea/blob/22b4f0c09f1de5e581929bd10f39833d30d2c482/routers/api/v1/repo/release.go#L241 Co-authored-by: Nanguan Lin <nanguanlin6@gmail.com>
* Only use supported sort order for "explore/users" page (#29430) (#29443)wxiaoguang2024-03-035-9/+83
| | | | | | | | | | | | | | Backport #29430 Thanks to inferenceus : some sort orders on the "explore/users" page could list users by their lastlogintime/updatetime. It leaks user's activity unintentionally. This PR makes that page only use "supported" sort orders. Removing the "sort orders" could also be a good solution, while IMO at the moment keeping the "create time" and "name" orders is also fine, in case some users would like to find a target user in the search result, the "sort order" might help.
* Fix incorrect cookie path for AppSubURL (#29534) (#29552)Giteabot2024-03-032-2/+6
| | | | | | Backport #29534 Regression of #24107 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* gitea.service: Remove syslog.target (#29550) (#29551)Giteabot2024-03-031-1/+0
| | | | | | | | | | | Backport #29550 by @C0rn3j Remove syslog.target from service file, this target hasn't existed for over a decade. https://github.com/systemd/systemd/blob/6aa8d43ade72e24c9426e604f7fc4b7582b9db7c/NEWS#L72-L73 Co-authored-by: Martin <spleefer90@gmail.com>
* Fix incorrect redirection when creating a PR fails (#29537) (#29543)Giteabot2024-03-025-24/+6
| | | | | | | Backport #29537 by wxiaoguang This is only a quick fix to make it easier to backport. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix queue worker incorrectly stopped when there are still more items in the ↵Giteabot2024-03-023-9/+42
| | | | | | | | | | | queue (#29532) (#29546) Backport #29532 Without `case <-t.C`, the workers would stop incorrectly, the test won't pass. For the worse case, there might be only one running worker processing the queue items for long time because other workers are stopped. The root cause is related to the logic of doDispatchBatchToWorker. It isn't a serious problem at the moment, so keep it as-is.
* Fix incorrect relative/absolute URL usages (#29531) (#29547)Giteabot2024-03-024-6/+17
| | | | | | | | Backport #29531 by wxiaoguang Add two "HTMLURL" methods for PackageDescriptor. And rename "FullWebLink" to "VersionWebLink" Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix incorrect subpath in links (#29535) (#29541)Giteabot2024-03-024-4/+4
| | | | | | | | | | Backport #29535 by wxiaoguang * `$referenceUrl`: it is constructed by "Issue.Link", which already has the "AppSubURL" * `window.location.href`: AppSubURL could be empty string, so it needs the trailing slash Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix issue link does not support quotes (#29484) (#29487) (#29536)Giteabot2024-03-022-2/+6
| | | | | | | | | Backport #29487 by @charles7668 Close #29484 ![圖片](https://github.com/go-gitea/gitea/assets/30816317/b27e6e16-67e0-469c-8e04-30180c585890) Co-authored-by: charles <30816317+charles7668@users.noreply.github.com>
* Fix issue & comment history bugs (#29525) (#29527)Giteabot2024-03-023-7/+26
| | | | | | | | | | Backport #29525 by @wxiaoguang * Follow #17746: `HasIssueContentHistory` should use expr builder to make sure zero value (0) be respected. * Add "doer" check to make sure `canSoftDeleteContentHistory` only be called by sign-in users. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Set pre-step status to `skipped` if job is skipped (#29489) (#29523)Giteabot2024-03-011-0/+3
| | | | | | | | | | | | | | | | | | | Backport #29489 by @sillyguodong close #27496 1. Set pre-step (Set up job) status to `skipped` if job is skipped. 2. Apart from pre-step, the other steps should also be set to `skipped`. The status of other steps are reported from the runner side. This will be completed by this PR: https://gitea.com/gitea/act_runner/pulls/500 before: ![image](https://github.com/go-gitea/gitea/assets/33891828/4bac2ba9-66de-4679-b7ed-fbae459c0c54) after: ![image](https://github.com/go-gitea/gitea/assets/33891828/ead4871a-4e0f-4bb1-9fb4-37f4fdb78dfc) Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com>
* Update FAQ about git hook problems (#29495) (#29496)Giteabot2024-02-292-4/+8
| | | | | | | | Backport #29495 by @wolfogre Close https://github.com/go-gitea/gitea/issues/29338#issuecomment-1970363817 Co-authored-by: Jason Song <i@wolfogre.com>
* Improve contrast on blame timestamp, fix double border (#29482) (#29485)Giteabot2024-02-291-1/+5
| | | | | | | | | | | | | | | | | | Backport #29482 by @silverwind Before, double border on top, bad contrast on dark: <img width="155" alt="Screenshot 2024-02-29 at 02 06 17" src="https://github.com/go-gitea/gitea/assets/115237/fc0f1e08-a5ce-47ed-9eb6-135eed5a1abb"> <img width="126" alt="Screenshot 2024-02-29 at 02 07 28" src="https://github.com/go-gitea/gitea/assets/115237/38ae8483-8d9b-484c-8909-d4466131ea16"> After, no double border on top, good contrast: <img width="154" alt="Screenshot 2024-02-29 at 02 20 20" src="https://github.com/go-gitea/gitea/assets/115237/ad91282b-e9f5-4f41-8f5e-6ba28db3beac"> <img width="147" alt="Screenshot 2024-02-29 at 02 20 38" src="https://github.com/go-gitea/gitea/assets/115237/7ee2ec92-e72a-4981-aec3-98fc8e579bae"> Co-authored-by: silverwind <me@silverwind.io>
* Fix wrong test usage of `AppSubURL` (#29459) (#29488)Giteabot2024-02-292-31/+26
| | | | | | | | Backport #29459 by @KN4CK3R The tests use an invalid `setting.AppSubURL`. The wrong behaviour disturbs other PRs like #29222 and #29427. Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Fix/Improve `processWindowErrorEvent` (#29407) (#29480)Giteabot2024-02-291-21/+36
| | | | | | | | | | | | Backport #29407 by @silverwind - `e.error` can be undefined in some cases which would raise an error inside this error handler, fixed that. - The displayed message mentions looking into the console, but in my case of error from `ResizeObserver` there was nothing there, so add this logging. I think this logging was once there but got lost during refactoring. Co-authored-by: silverwind <me@silverwind.io>
* Fix counter display number incorrectly displayed on the page (#29448) (#29478)Giteabot2024-02-281-0/+2
| | | | | | | | | | | | | | | | | | Backport #29448 by @charles7668 issue : #28239 The counter number script uses the 'checkbox' attribute to determine whether an item is selected or not. However, the input event only increments the counter value, and when more items are displayed, it does not update all previously loaded items. As a result, the display becomes incorrect because it triggers the update counter script, but checkboxes that are selected without the 'checked' attribute are not counted Co-authored-by: charles <30816317+charles7668@users.noreply.github.com>
* Fix workflow trigger event bugs (#29467) (#29475)Giteabot2024-02-282-1/+10
| | | | | | | | | | Backport #29467 by @Zettat123 1. Fix incorrect `HookEventType` for issue-related events in `IssueChangeAssignee` 2. Add `case "types"` in the `switch` block in `matchPullRequestEvent` to avoid warning logs Co-authored-by: Zettat123 <zettat123@gmail.com>
* Fix URL calculation in clone input box (#29470) (#29473)Giteabot2024-02-282-9/+18
| | | | | | | | | | Backport #29470 by @silverwind Ported the function as-is and added comments so we don't forget about this in the future. Fixes: https://github.com/go-gitea/gitea/issues/29462 Co-authored-by: silverwind <me@silverwind.io>
* The job should always run when `if` is `always()` (#29464) (#29469)Giteabot2024-02-282-1/+76
| | | | | | | | | | | | | | | Backport #29464 by @Zettat123 Fix #27906 According to GitHub's [documentation](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idneeds), a job should always run when its `if` is `always()` > If you would like a job to run even if a job it is dependent on did not succeed, use the `always()` conditional expression in `jobs.<job_id>.if`. Co-authored-by: Zettat123 <zettat123@gmail.com>
* Fix missed return (#29450) (#29453)Giteabot2024-02-271-0/+1
| | | | | Backport #29450 by @lunny Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Fix template bug (#27581) (#29446)Lunny Xiao2024-02-271-1/+2
| | | | Fix #29152 Backport #27581
* Update docs about `DEFAULT_ACTIONS_URL` (#29442) (#29445)Jason Song2024-02-272-18/+17
| | | | | Backport #29442. Follow #25581.
* Not trigger all jobs any more, when re-running the first job (#29439) (#29441)Giteabot2024-02-271-3/+8
| | | | | | | | | | | Backport #29439 by @sillyguodong Previously, it will be treated as "re-run all jobs" when `jobIndex == 0`. So when you click re-run button on the first job, it triggers all the jobs actually. Caused by #26535. Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com>
* Ignore empty repo for CreateRepository in action notifier (#29416) (#29424)Giteabot2024-02-261-0/+3
| | | | | | | Backport #29416 by @yp05327 Fix #29415 Co-authored-by: yp05327 <576951401@qq.com>
* Fix incorrect tree path value for patch editor (#29377) (#29421)Giteabot2024-02-261-2/+2
| | | | | | | | | | Backport #29377 by wxiaoguang Regression of #18718. When submitting the form, EditRepoFileForm.TreePath is marked as "Required", so the value can't be empty. The value is not used by backend, so use a meaningful dummy value for it. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Change log for 1.21.7 (#29411)v1.21.7Lunny Xiao2024-02-261-0/+15
| | | | | | | This is an emergency release to fix the bug #29402. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Add missing space (#29393) (#29399)Giteabot2024-02-261-1/+1
| | | | | Backport #29393 by @KN4CK3R Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* enforce maxlength in frontend (#29389) (#29396)Giteabot2024-02-255-8/+9
| | | | | | | | | | | | | | Backport #29389 by @zokkis Set maxlength attribute in frontend to long file-name ![image](https://github.com/go-gitea/gitea/assets/72873130/15111614-55ab-4583-acb2-15c25997601d) ![image](https://github.com/go-gitea/gitea/assets/72873130/4105ddd8-4973-4da8-b3ab-4cfae1b45554) (same for branch-name and commit-summary) Co-authored-by: Tim-Niclas Oelschläger <72873130+zokkis@users.noreply.github.com>
* Users with `read` permission of pull requests can be assigned too (#27263) ↵Giteabot2024-02-242-3/+5
| | | | | | | | | | (#29372) Backport #27263 by @lunny This PR will also keep the consistent between list assigned users and check assigned users. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Do not double close reader (#29354) (#29370)Giteabot2024-02-242-4/+11
| | | | | | | | Backport #29354 by @KN4CK3R Fixes #29346 Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Display friendly error message (#29105) (#29363)Lunny Xiao2024-02-241-7/+7
| | | | | | | | Backport #29105 `ctx.Error` only displays the text but `ctx.ServerError` renders the usual error page. Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Docker Tag Information in Docs (#29047) (#29362)Lunny Xiao2024-02-241-0/+10
| | | | | | | | | Backport #29047 Add more details for the docker tag when using container registry. Co-authored-by: wienans <40465543+wienans@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Fix validity of the FROM email address not being checked (#29347) (#29360)Giteabot2024-02-242-0/+7
| | | | | | | | | | Backport #29347 by @carlosfelgueiras Fixes #27188. Introduces a check on the installation that tries to parse the FROM address. If it fails, shows a new error message to the user. Co-authored-by: Carlos Felgueiras <carlosfelgueiras@tecnico.ulisboa.pt> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Fix project counter in organization/individual profile (#28068) (#29361)Lunny Xiao2024-02-243-0/+23
| | | | | | | | | | | | | | | | | Fix #28052 Backport #28068 Before: ![image](https://github.com/go-gitea/gitea/assets/18380374/5f299983-4b38-4d68-ac0e-4be3c62c0558) ![image](https://github.com/go-gitea/gitea/assets/18380374/f0e12afd-483b-4882-80e9-0261beb3fe0c) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/47cccb7b-bb35-4a7d-9c5b-83133be0323a) ![image](https://github.com/go-gitea/gitea/assets/18380374/77825c0c-4bf2-4762-83a2-1a5a173cc22d) Co-authored-by: yp05327 <576951401@qq.com>
* Fix incorrect tests in 1.21 (#29366)wxiaoguang2024-02-241-25/+26
| | | | | | The submitted tests in the patch for the XSS fix is not right. To test, it should test "what should happen", but not "what doesn't exist" or "what is processed/decoded".
* Fix tarball/zipball download bug (#29342) (#29352)Giteabot2024-02-232-1/+6
| | | | | | | | | | | Backport #29342 by @Zettat123 Fix #29249 ~~Use the `/repos/{owner}/{repo}/archive/{archive}` API to download.~~ Apply #26430 to archive download URLs. Co-authored-by: Zettat123 <zettat123@gmail.com>
* Adjust changelog for v1.21.6 to move prs to correct labels (#29339)Lunny Xiao2024-02-231-12/+10
| | | | | | | | When releasing, the releaser should read all the pull requests carefully and do some adjustments because some of pull requests' labels are not right when it's merged. And the changelog tool needs to be adjusted. If one pull request has both `bug` and `API`, it should mark it as `bug` but not `API`.
* Add Changelog v1.21.6 (#29335)v1.21.665432024-02-221-3/+58
|
* Fix XSS vulnerabilities (#29336)65432024-02-226-8/+93
| | | | | | | | | | | - The Wiki page did not sanitize author name - the reviewer name on a "dismiss review" comment is also affected - the migration page has some spots --------- Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-authored-by: jolheiser <john.olheiser@gmail.com>
* Don't show third-party JS errors in production builds (#29303) (#29333)Giteabot2024-02-221-3/+12
| | | | | | | | | | | | Backport #29303 by @silverwind So we don't get issues like https://github.com/go-gitea/gitea/issues/29080 and https://github.com/go-gitea/gitea/issues/29273 any more. Only active in [production builds](https://webpack.js.org/guides/production/#specify-the-mode), in non-production the errors will still show. Co-authored-by: silverwind <me@silverwind.io>
* Remove SSH workaround (#27893) (#29332)65432024-02-223-14/+5
| | | | | | | | | Backport #27893 - Update github.com/gliderlabs/ssh to include https://github.com/gliderlabs/ssh/commit/02f9d573009f8c13755b6b90fa14a4f549b17b22. - Resolves https://codeberg.org/forgejo/forgejo/issues/1230 Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com>
* Only log error when tag sync fails (#29295) (#29327)Giteabot2024-02-221-1/+3
| | | | | | | | | | | Backport #29295 by @lunny Fix #28843 This PR will bypass the pushUpdateTag to database failure when syncAllTags. An error log will be recorded. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-02-05 18:01:50 +0000