summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Remove scheduled action tasks if the repo is archived (#30224)Zettat1232024-04-014-2/+29
| | | Fix #30220
* Refactor file view & render (#30227)wxiaoguang2024-04-017-33/+40
| | | The old code is inconsistent and fragile, and the UI isn't right.
* Refactor DeleteInactiveUsers, fix bug and add tests (#30206)wxiaoguang2024-04-013-33/+45
| | | | | | | | | 1. check `IsActive` before calling `IsLastAdminUser`. 2. Fix some comments and error messages. 3. Don't `return err` if "removing file" fails in `DeleteUser`. 4. Remove incorrect `DeleteInactiveEmailAddresses`. Active users could also have inactive emails, and inactive emails do not support "olderThan" 5. Add tests
* [skip ci] Updated licenses and gitignoresGiteaBot2024-04-013-0/+35
|
* Add `/options/license` and `/options/gitignore` to `.ignore` (#30219)silverwind2024-03-311-1/+3
| | | | Ignore this folder in tools like `rg` or `ag`. Also sorted the entries alphabetically.
* Remove fomantic input module (#30194)silverwind2024-03-3111-812/+207
| | | | Another pure CSS module. Some styling is part of the `form` module which will likely follow next.
* Remove most jQuery function calls from the repository topic box (#30191)Yarden Shoham2024-03-315-75/+54
| | | | | | | | | Remove most jQuery function calls --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Prevent flash of dropdown menu on labels list (#30215)silverwind2024-03-312-1/+7
| | | | | | | | | | | | On the labels list, This `left` class caused the dropdown content to flash on page load until JS had hidden it. Remove it as I see no purpose to it. <img width="215" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/9e1de97f-dd89-41e0-9229-5c4a786ba762"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Remove jQuery class from the `repo-issue.js` file (#30192)Yarden Shoham2024-03-311-70/+85
| | | | | | | | | | | | | | | | | | Switched from jQuery class functions to plain JavaScript `classList`. Tested the following functionalities and they work as before: - delete issue comment - cancel code comment - update (merge or rebase) pull request - re-request review - reply to code comment - show/hide outdated comments - add code comment - edit issue title --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: silverwind <me@silverwind.io>
* Ignore fomantic folder in linters (#30200)silverwind2024-03-312-0/+2
| | | | We are not linting these files but editor integrations will still try to lint, disable that.
* Remove `modifies/frontend` from labeler (#30198)silverwind2024-03-311-7/+0
| | | | | | | Remove this label, I find it barely useful and we already have more useful labels like `modifies/js`. Backport so that we can eventually delete that label. Co-authored-by: Giteabot <teabot@gitea.io>
* Make a distinction between `active` and `selected` in the issue author ↵Yarden Shoham2024-03-311-1/+3
| | | | | dropdown (#30207) Signed-off-by: Yarden Shoham <git@yardenshoham.com>
* Move and simplify tab-size helpers (#30196)silverwind2024-03-312-80/+17
| | | | | Tailwind does not support. Dropped the vendor-prefix. Co-authored-by: Giteabot <teabot@gitea.io>
* Fix markdown color code detection (#30208)wxiaoguang2024-03-312-3/+26
| | | | | When reviewing PRs, some color names might be mentioned, the `transformCodeSpan` (which calls `css.ColorHandler`) considered it as a valid color, but actually it shouldn't be rendered as a color codespan.
* Do not allow different storage configurations to point to the same directory ↵wxiaoguang2024-03-3112-47/+75
| | | | | (#30169) Replace #29171
* Fix GPG subkey verify (#30193)KN4CK3R2024-03-311-0/+4
| | | | | Fixes #30189 Can't verify subkeys if they are not loaded.
* [skip ci] Updated translations via CrowdinGiteaBot2024-03-311-1/+1
|
* Fix unclickable checkboxes (#30195)silverwind2024-03-312-5/+14
| | | | | | | | | | | | | | Fix https://github.com/go-gitea/gitea/issues/30185, regression from https://github.com/go-gitea/gitea/pull/30162. The checkboxes were unclickable because the label was positioned over the checkbox with `padding`. Now it uses `margin` so the checkbox itself will be clickable in all cases. Secondly, I changed the for/id linking to also add missing `for` attributes when `id` is present. The other way around (only `for` present) is currently not handled and I think there are likey no occurences in the code and introducing new non-generated `id`s might cause problems elsewhere if we do, so I skipped on that.
* Remove jQuery class from the issue author dropdown (#30188)Yarden Shoham2024-03-301-7/+13
| | | | | | | - Switched from jQuery class functions to plain JavaScript `classList` - Tested the issue author dropdown functionality and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: Giteabot <teabot@gitea.io>
* Remove jQuery class from the comment edit history (#30186)Yarden Shoham2024-03-301-2/+5
| | | | | | | - Switched from jQuery class functions to plain JavaScript `classList` - Tested the comment edit history functionality and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: Giteabot <teabot@gitea.io>
* Remove jQuery class from the repository branch settings (#30184)Yarden Shoham2024-03-301-13/+18
| | | | | | | - Switched from jQuery class functions to plain JavaScript `classList` - Tested the repository branch settings functionality and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com>
* [skip ci] Updated translations via CrowdinGiteaBot2024-03-3027-1049/+888
|
* Use Crowdin action for translation sync (#30054)Denys Konovalov2024-03-302-22/+23
| | | | | | | | | | | Switch from the old self-built action to the official one. We get: - config managed inside the repo - automatic upload when source file changes - automatic invalidation if source string changes (tested) - automatic download of new translation files Tested both upload and download.
* Remove jQuery class from the project page (#30183)Yarden Shoham2024-03-301-22/+23
| | | | | | - Switched from jQuery class functions to plain JavaScript `classList` - Tested the edit column modal functionality and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com>
* Remove jQuery class from the comment context menu (#30179)Yarden Shoham2024-03-301-1/+1
| | | | | | | | | - Switched from jQuery class functions to plain JavaScript - Tested the comment context menu functionality and it works as before --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: silverwind <me@silverwind.io>
* Include encoding in signature payload (#30174)KN4CK3R2024-03-293-0/+75
| | | | | | | | | | | | | Fixes #30119 Include the encoding in the signature payload. before ![grafik](https://github.com/go-gitea/gitea/assets/1666336/01ab94a3-8af5-4d6f-be73-a10b65a15421) after ![grafik](https://github.com/go-gitea/gitea/assets/1666336/3a37d438-c70d-4d69-b178-d170e74aa683)
* Add `stylelint-value-no-unknown-custom-properties` and convert stylelint ↵silverwind2024-03-296-225/+265
| | | | | | | | | | | config to js (#30117) Add [`stylelint-value-no-unknown-custom-properties`](https://github.com/csstools/stylelint-value-no-unknown-custom-properties) which lints for undefined CSS variables. No current violations. To make it work properly with editor integrations, I had to convert the config to JS to be able to pass absolute paths to the plugin, but this is a needed change anyways.
* Remove jQuery class from the commit button (#30178)Yarden Shoham2024-03-291-2/+2
| | | | | | | | | | | - Switched from jQuery class functions to plain JavaScript `classList` - Tested the commit button disabled toggling functionality and it works as before --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>
* Remove jQuery class from the diff view (#30176)Yarden Shoham2024-03-292-25/+32
| | | | | | | | | - Switched from jQuery class functions to plain JavaScript `classList` - Tested the diff view functionality and it works as before --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: silverwind <me@silverwind.io>
* Remove jQuery class from the notification count (#30172)Yarden Shoham2024-03-291-7/+5
| | | | | | | | | | - Switched from jQuery class functions to plain JavaScript `classList` - Tested the notification count and it works as before --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
* Remove jQuery class from the code range selection (#30173)Yarden Shoham2024-03-291-3/+5
| | | | | | - Switched from jQuery class functions to plain JavaScript `classList` - Tested the code range selection functionality and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com>
* Fix:the rounded corners of the folded file are not displayed correctly (#29953)HEREYUA2024-03-291-1/+2
| | | | | | | | | | | | | | | | | | Fix: [#29933](https://github.com/go-gitea/gitea/issues/29933) **Before** ![image](https://github.com/go-gitea/gitea/assets/37935145/71ec80f6-5896-4e4a-b686-4d792c11ebe2) **After** ![image](https://github.com/go-gitea/gitea/assets/37935145/81348a61-946a-4562-881d-8d873e50228f) --------- Co-authored-by: silverwind <me@silverwind.io>
* Add setting to disable user features when user login type is not plain (#29615)Jack Hay2024-03-299-16/+84
| | | | | | | | | ## Changes - Adds setting `EXTERNAL_USER_DISABLE_FEATURES` to disable any supported user features when login type is not plain - In general, this is necessary for SSO implementations to avoid inconsistencies between the external account management and the linked account - Adds helper functions to encourage correct use
* Remove jQuery class from the image diff (#30140)Yarden Shoham2024-03-291-9/+20
| | | | | | | | | | - Switched from jQuery class functions to plain JavaScript `classList` - Tested the image diff and it works as before --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Remove fomantic checkbox module (#30162)silverwind2024-03-2918-1730/+181
| | | | | | | | | | | | | | | | | | | CSS is pretty slim already and the `.ui.toggle.checkbox` sliders on admin page also still work. The only necessary JS is the one that links `input` and `label` so that it can be toggled via label. All checkboxes except the markdown ones render at `--checkbox-size: 16px` now. <img width="174" alt="Screenshot 2024-03-28 at 22 15 10" src="https://github.com/go-gitea/gitea/assets/115237/3455c1bb-166b-47e4-9847-2d20dd1f04db"> <img width="499" alt="Screenshot 2024-03-28 at 21 00 07" src="https://github.com/go-gitea/gitea/assets/115237/412be2b3-d5a0-478a-b17b-43e6bc12e8ce"> <img width="83" alt="Screenshot 2024-03-28 at 22 14 34" src="https://github.com/go-gitea/gitea/assets/115237/d8c89838-a420-4723-8c49-89405bb39474"> --------- Co-authored-by: delvh <dev.lh@web.de>
* Refactor topic Find functions and add more tests for pagination (#30127)Lunny Xiao2024-03-297-32/+70
| | | This also fixed #22238
* replace jquery-minicolors with coloris (#30055)silverwind2024-03-2918-106/+224
| | | | | | | | | | | | | | | | | | Get rid of one more jQuery dependant and have a nicer color picker as well. Now there is only a single global color picker init because that is all that's necessary because the elements are present on the page when the init code runs. The init is slightly weird because the module only takes a selector instead of DOM elements directly. The label modals now also perform form validation because previously it was possible to trigger a 500 error `Color cannot be empty.` by clearing out the color value on labels. <img width="867" alt="Screenshot 2024-03-25 at 00 21 05" src="https://github.com/go-gitea/gitea/assets/115237/71215c39-abb1-4881-b5c1-9954b4a89adb"> <img width="860" alt="Screenshot 2024-03-25 at 00 20 48" src="https://github.com/go-gitea/gitea/assets/115237/a12cb68f-c38b-4433-ba05-53bbb4b1023e">
* Add API for `Variables` (#29520)sillyguodong2024-03-2816-74/+2102
| | | | | | | close #27801 --------- Co-authored-by: silverwind <me@silverwind.io>
* Fix `DEFAULT_SHOW_FULL_NAME=false` has no effect in commit list and commit ↵yp053272024-03-283-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | graph page (#30096) Fix #20446 This PR will fix the username in: repo home page ![image](https://github.com/go-gitea/gitea/assets/18380374/347c0f70-ea42-432d-aae3-bf87a7e07ae1) repo commit list page ![image](https://github.com/go-gitea/gitea/assets/18380374/b3b1f5d5-c371-4222-ac2e-64b8994c7551) repo commit graph page ![image](https://github.com/go-gitea/gitea/assets/18380374/01b7117c-3aea-4d7d-8bd1-35e5ea942821) pr commit page ![image](https://github.com/go-gitea/gitea/assets/18380374/4d180c30-2150-4348-8eeb-0b4b2559ec19) Will not fix: wiki revisions page: ![image](https://github.com/go-gitea/gitea/assets/18380374/b49df6bf-d751-4374-b7ea-1ac85e2739e3) ps: the author name is `FullName` by default
* Fix migration v292 (#30153)v1.22.0-rc0Lunny Xiao2024-03-286-134/+162
| | | | | | | | | | | | | Fix https://github.com/go-gitea/gitea/pull/29874#discussion_r1542227686 - The migration of v292 will miss many projects. These projects will have no default board. This PR introduced a new migration number and removed v292 migration. - This PR also added the missed transactions on project-related operations. - Only `SetDefaultBoard` will remove duplicated defaults but not in `GetDefaultBoard`
* Adjust VS Code debug filename match in .gitignore (#30158)Paweł Bogusławski2024-03-281-1/+1
|
* Prevent re-review and dismiss review actions on closed and merged PRs (#30065)Kemal Zebari2024-03-289-11/+170
| | | | | | | | | | | | | | | | | | | Resolves #29965. --- Manually tested this by: - Following the [installation](https://docs.gitea.com/next/installation/install-with-docker#basics) guide (but built a local Docker image instead) - Creating 2 users, one who is the `Owner` of a newly-created repository and the other a `Collaborator` - Had the `Collaborator` create a PR that the `Owner` reviews - `Collaborator` resolves conversation and `Owner` merges PR And with this change we see that we can no longer see re-request review button for the `Owner`: <img width="1351" alt="Screenshot 2024-03-25 at 12 39 18 AM" src="https://github.com/go-gitea/gitea/assets/60799661/bcd9c579-3cf7-474f-a51e-b436fe1a39a4">
* Render code tags in commit messages (#30146)silverwind2024-03-282-4/+4
| | | | | | | | | | | | | | | | | | Extend https://github.com/go-gitea/gitea/pull/21432 to commit messages. Color is changed because the markup code block bg does not offer enough contrast on varying backgrounds. <img width="568" alt="Screenshot 2024-03-27 at 19 52 55" src="https://github.com/go-gitea/gitea/assets/115237/ddc9307e-f32f-4e97-8b88-91f88ced2a36"> <img width="573" alt="Screenshot 2024-03-27 at 19 53 33" src="https://github.com/go-gitea/gitea/assets/115237/14b30fd2-bf28-46b8-9e82-eb60a28f6bf2"> <img width="422" alt="Screenshot 2024-03-27 at 19 53 01" src="https://github.com/go-gitea/gitea/assets/115237/a12136b5-c02b-460c-9830-f830542987ae"> <img width="397" alt="Screenshot 2024-03-27 at 19 53 27" src="https://github.com/go-gitea/gitea/assets/115237/c9f05d81-c73e-468e-98e9-e5929bc0da3e"> <img width="333" alt="Screenshot 2024-03-27 at 19 53 07" src="https://github.com/go-gitea/gitea/assets/115237/06b5a9f9-f95d-46b6-8c57-df0b02555652"> <img width="279" alt="Screenshot 2024-03-27 at 19 53 21" src="https://github.com/go-gitea/gitea/assets/115237/b06a0afc-ddd8-48ae-b557-a6dc47802e68">
* Bump `@github/relative-time-element` to v4.4.0 (#30154)Yarden Shoham2024-03-282-5/+5
| | | | | I tested and all timestamps work as before. Signed-off-by: Yarden Shoham <git@yardenshoham.com>
* Migrate font-family to tailwind (#30118)silverwind2024-03-2819-31/+37
| | | | | | | | | | | Enable us to use tailwind's [`font-family`](https://tailwindcss.com/docs/font-family) classes as well as remove `gt-mono` in favor of `tw-font-mono`. I also merged the "compensation" to one selector, previously this was two different values 0.9em and 0.95em. I did not declare a `serif` font because I don't think there will ever be a use case for those. Command ran: ```sh perl -p -i -e 's#gt-mono#tw-font-mono#g' web_src/js/**/* templates/**/*
* Move from `max( id )` to `max( index )` for latest commit statuses (#30076)YR Chen2024-03-281-47/+73
| | | | | | | | | | | | | | | | This PR replaces the use of `max( id )`, and instead using ``max( `index` )`` for determining the latest commit status. Building business logic over an `auto_increment` primary key like `id` is risky and there’re already plenty of discussions on the Internet. There‘s no guarantee for `auto_increment` values to be monotonic, especially upon failures or with a cluster. In the specific case, we met the problem of commit statuses being outdated when using TiDB as the database. As [being documented](https://docs.pingcap.com/tidb/stable/auto-increment), `auto_increment` values assigned to an `insert` statement will only be monotonic on a per server (node) basis. Closes #30074.
* Remember login for a month by default (#30150)delvh2024-03-284-4/+4
| | | | | | | | | | | | | | | Previously, the default was a week. As most instances don't set the setting, this leads to a bad user experience by default. ## :warning: Breaking If your instance requires a high level of security, you may want to set `[security].LOGIN_REMEMBER_DAYS` so that logins are not valid as long. --------- Co-authored-by: Jason Song <i@wolfogre.com>
* Apply to become a maintainer (#30151)HEREYUA2024-03-281-0/+1
| | | | | PRs:https://github.com/go-gitea/gitea/pulls?q=is%3Apr+author%3AHEREYUA+is%3Aclosed Discord: hereyua
* Refactor markdown render (#30139)wxiaoguang2024-03-288-257/+364
| | | | Only split the file into small ones (and rename AttentionTypes to attentionTypes)
* Drag-and-drop improvements for projects and issue pins (#29875)silverwind2024-03-286-10/+27
| | | | | | | | | | | | | | | 1. Add "grabbing" cursor while dragging items: ![](https://github.com/go-gitea/gitea/assets/115237/c60845ff-7544-4215-aeaa-408e8c4ef03a) 2. Make project board only drag via their header, not via their whole body. ![](https://github.com/go-gitea/gitea/assets/115237/62c27f3d-993a-481d-9cc3-b6226b4c5d61) 3. Fix some cursor problems in projects 4. Move shared options into `createSortable`.