aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Update go tool dependencies (#32916)silverwind2024-12-198-14/+11
| | | | | | | | | | | | | | | | | Update all go tool dependencies to latest version. WIP because I think there are new gopls errors, would like to confirm them on CI first. Here is from a local run: ``` modules/markup/markdown/goldmark.go:115:37-53: unnecessary type arguments modules/markup/html.go:45:32-49: unnecessary type arguments modules/markup/internal/renderinternal.go:20:33-49: unnecessary type arguments modules/markup/common/linkify.go:27:32-49: unnecessary type arguments modules/util/time_str.go:28:39-63: unnecessary type arguments routers/web/repo/pull.go:704:19: impossible condition: non-nil == nil modules/util/util_test.go:248:14-23: unused parameter: other ``` ~~Backport because the `gxz` update might have security benefits.~~
* Relax the version checking for Arch packages (#32908)Exploding Dragon2024-12-192-2/+11
| | | | | | | | | | | | It is mentioned in https://man.archlinux.org/man/PKGBUILD.5: 'The variable is not allowed to contain colons, forward slashes, hyphens, or whitespace.' `_` is also an allowed character, and some software in the Arch Linux AUR uses this naming convention. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Refactor repo-projects.ts (#32892)silverwind2024-12-198-239/+152
| | | | | | | | | | - Remove jQuery - Add types to all functions - Tested all modified functionality --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Add more load functions to make sure the reference object loaded (#32901)Lunny Xiao2024-12-192-0/+9
| | | Fix #32897
* [skip ci] Updated translations via CrowdinGiteaBot2024-12-193-0/+15
|
* bump x/net (#32896)techknowlogick2024-12-182-3/+3
|
* Move RepoBranchTagSelector init outside the SFC (#32890)silverwind2024-12-183-47/+38
| | | | | SFCs shouldn't export anything besides their component, and this eliminates one issue with tsc, while apparently also solving a hack. It seems to work as before, also when multiples are on the same page.
* Fix Arch package metadata introduced incorrect field (#32881)Exploding Dragon2024-12-183-1/+12
| | | | | | Incorrect content was introduced while generating the index, which has now been removed, and the missing fields have been added. ![](https://github.com/user-attachments/assets/4fbb8884-337e-43b1-939f-a5ba687f7ffd)
* Move delete deploy keys into service layer (#32201)Lunny Xiao2024-12-187-66/+61
|
* Move RepoTransfer from models to models/repo sub package (#32506)Lunny Xiao2024-12-1830-389/+383
| | | | | | | | | | | | | `RepoTransfer` now is at models, but if we want to move it into `repo` model, it will depend on `Team`. So this PR also makes repo model depend on org model to make it possible. Just refactor, no code change. - [x] Move `DeleteOrganization` from `models/organization` to service layer - [x] Move `AccessibleTeamReposEnv` to `models/repo` - [x] Move `RepoTransfer` from `models` to `models/repo` - [x] Merge `getUserTeamIDs` and `GetUserTeamIDs`, Merge `GetUserTeams` and `getUserTeams`. - [x] Remove `Team`'s `Repos []*repo_model.Repository` to avoid dependency recycle.
* Change pprof labels to be prometheus compatible (#32865)TheFox0x72024-12-184-10/+16
| | | | | Enables scrapping pprof endpoint for continuous profiling Closes: https://github.com/go-gitea/gitea/issues/32854
* Move eslint config to javascript (#32869)silverwind2024-12-182-967/+999
| | | | | | | In preparation for migrating to eslint flat config, move the config file to javascript. Additional changes: - `no-undef` is now disabled as it's no longer needed with typescript - `no-restricted-globals` config is simplified
* [skip ci] Updated translations via CrowdinGiteaBot2024-12-182-20/+712
|
* Fix various trivial problems (#32861)wxiaoguang2024-12-1712-4/+38
| | | | | | | | | | | | | | 1. add/improve comments to help future readers could understand the problem more easily. 2. add an error log to LDAP with username fallback 3. use `or` instead of `Iif` for "repo/branch_dropdown" (`Iif` was a mistake, but it doesn't really affect the UI) 4. add `tw-font-mono` style to container digest to match dockerhub 5. fix a bug in RepoBranchTagSelector: the form is not updated when there is no click to an item --------- Co-authored-by: delvh <dev.lh@web.de>
* [skip ci] Updated translations via CrowdinGiteaBot2024-12-174-4/+171
|
* Improve Actions status aggregations (#32860)v1.24.0-devwxiaoguang2024-12-162-9/+31
| | | | | | Make the result the same as GitHub: * all skipped, then result is skipped * any cancelled, then result cancelled
* Fix incomplete Actions status aggregations (#32859)wxiaoguang2024-12-166-38/+106
| | | fix #32857
* Do not display `attestation-manifest` and use short sha256 instead of full ↵hiifong2024-12-162-5/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sha256 (#32851) Related: #24973 Before: ![image](https://github.com/user-attachments/assets/bca17900-5075-4d15-af7a-c71bf8979c04) After: ![image](https://github.com/user-attachments/assets/c5a24e3b-763b-4463-80db-d4dbd89f7dc4) Index: ```json { "schemaVersion": 2, "mediaType": "application/vnd.oci.image.index.v1+json", "manifests": [ { "mediaType": "application/vnd.oci.image.manifest.v1+json", "digest": "sha256:5967afffdfde104ca1459286a72346baaef8b70ac153325d7a6cd85c7734ac6e", "size": 672, "platform": { "architecture": "amd64", "os": "linux" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "digest": "sha256:f9abfcc55320f9ff1f38eeb7dbb4bea10b29c7febfa49ccd7aab9fa02403b9f0", "size": 672, "platform": { "architecture": "arm64", "os": "linux" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "digest": "sha256:d70ad19d00c19e40691045cbddc3e8a5a4454c31cc454d1132b13bcaf35b6d46", "size": 566, "annotations": { "vnd.docker.reference.digest": "sha256:5967afffdfde104ca1459286a72346baaef8b70ac153325d7a6cd85c7734ac6e", "vnd.docker.reference.type": "attestation-manifest" }, "platform": { "architecture": "unknown", "os": "unknown" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "digest": "sha256:73bc233bf4eac96a404ce3e0430b698831a4ea7050c878d5f76d1d1f133751dd", "size": 566, "annotations": { "vnd.docker.reference.digest": "sha256:f9abfcc55320f9ff1f38eeb7dbb4bea10b29c7febfa49ccd7aab9fa02403b9f0", "vnd.docker.reference.type": "attestation-manifest" }, "platform": { "architecture": "unknown", "os": "unknown" } } ] } ``` --------- Co-authored-by: silverwind <me@silverwind.io>
* Leave MAINTAINERS and the organization (#32820)yp053272024-12-161-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ## Why join I didn’t talk about myself before, so some people may think that I am an employee from the company. So I think it is necessary to talk about why and how I joined. At the begining, my boss gave me a task to find a git software which can self hosted in on-premise. Then I found that there are not many project which meet our needs. But finally, I found Gitea. A easy use, easy maintenance, and without a good machine you can also run it. At that time, I just finished my previous work which is using helm to deploy something in K8s. So I tried to use Gitea’s helm chart to deploy in my work PC to see whether we can use it. But soon, I found a bug, and reported it (https://gitea.com/gitea/helm-chart/issues/382), but after about 1 month, there’s no fix. So I try to check the source code, and I found that it is caused by Gitea’s code and it is easy to fix it. So I created an issue (https://github.com/go-gitea/gitea/issues/22523) in Gitea. But unfortunately, after a long time again, it is still not fixed. So I tried to finish it by myself. I’m not a pro programmer, coding is just my hobby since I was 13 or 14 years old. (I will tell the reason later), I even don’t know the workflow about the contribution of OSS, so maybe I did some bad things at the early time, I apologize. But the people here are very kind, at that time, I start to consider whether it has worth to recommend to my boss. So I started to use it, but I found more and more bugs in a short time. Japanese company is very sensitive to it, so I gave up to recommend. But I can try to fix them! Because I can learn too many things during the contribution, not just about the programing but also the usage of other tools and the general contribution rule in the world of OSS. It let me grow up, and to become (maybe) a perfect full-stack engineer which is my dream. (Why it is my dream? I made a wrong decision in my college, I took/followed the advice of my parent, choosed communications engineering instead of computer science which is my favorite thing) # Why leave Several days ago, there’s an [article](https://juejin.cn/post/7446578471901626420#comment) came into my eye. Something about JiHu (GitLab Ltd in China) start to file a lawsuit to the company which is using GitLab CE version which is under MIT License. So people start to find other git service/application to avoid it. And in the this article, a project called Fogejo is mentioned. It says it is a hard-fork of Gitea. But I don’t know the meaning of `hard-fork`, so I access the home page of this project to find where it comes from. Finally, I found it here: https://forgejo.org/compare-to-gitea/#why-was-forgejo-created. They said: > As of early 2024, Forgejo is developed independently of Gitea, as a “hard-fork”. `hard-fork` has a quotation, so the meaning is not the original meaning of it, but they said `as`, which means `like` or `similar` I think. So just focus on the words before `as` is ok, because `hard-fork` is a simile, `As of early 2024, Forgejo is developed independently of Gitea` is what they want to say. In my mind, this means: since early 2024 Forgejo’s codes (new changes) are all written by themselves, and emphasize that these changes are not related to Gitea, because they can simply say `As of early 2024, Forgejo is developed independently, as a “hard-fork”` But after I check the commit history, I can still find some strange commits in recent month: https://codeberg.org/forgejo/forgejo/commits/branch/forgejo/search?q=author%3Ayp05327&all= The author is me, but the commit is signed by someone I even never heard. Considering the words they said above, it feels/sounds like my work has become their work. Although Gitea is under MIT license, is this allowed in the OSS world? Even it is allowed, I can not accept it personally. So I created a issue to ask them: https://codeberg.org/forgejo/forgejo/issues/6236 https://codeberg.org/forgejo/discussions/issues/251 Finally, it seems that they understood the problem and promised to improve it. But I also required a public statement to explain it which means they need to apologize, otherwise it is hard to the users who believe these are all their work know it, and it seems they ignored some of my words again? So it is hard for me to believe they will really make changes and post the apologize. If they did, I will consider to come back. Otherwise, I think there’s no worth to continually contribute to any OSS project, so I decided to leave. ps: TOC voting is still ongoing, please remove me from the list. And I will leave the organization after the merge. At the end, thanks to all people who have helped me to finish the contribution and teach me new knowledges.
* [skip ci] Updated licenses and gitignoresGiteaBot2024-12-162-0/+11
|
* Fix bug on action list deleted branch (#32848)Lunny Xiao2024-12-165-4/+72
| | | | | | | | Fix https://github.com/go-gitea/gitea/issues/32761#issuecomment-2540946064 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix remaining typescript issues, enable `tsc` (#32840)silverwind2024-12-1624-134/+152
| | | | | | | | | | | | Fixes 79 typescript errors. Discovered at least two bugs in `notifications.ts`, and I'm pretty sure this feature was at least partially broken and may still be, I don't really know how to test it. After this, only like ~10 typescript errors remain in the codebase but those are harder to solve. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Repo file list enhancements (#32835)silverwind2024-12-154-15/+37
| | | | | | | | | | | | 1. restore background color 2. fix border radius on top/bottom and on hover 3. parent link is now full-row again, much easier to click 4. parent link now uses directory icon, matching github 5 changed grid layout to remove auto width on file name column which could get too small. 6. mobile layout now shows more of the filename. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Refactor some LDAP code (#32849)wxiaoguang2024-12-156-173/+259
|
* Enable tenv and testifylint rules (#32852)TheFox0x72024-12-15113-282/+272
| | | | Enables tenv and testifylint linters closes: https://github.com/go-gitea/gitea/issues/32842
* Tweak repo sidebar (#32847)silverwind2024-12-159-131/+141
| | | | | | | | | | | | | | | | | | | | | | | Before and after: <img width="218" alt="Screenshot 2024-12-15 at 04 53 53" src="https://github.com/user-attachments/assets/299b1f0a-ba72-47c6-b662-a9d540d4d741" /> <img width="222" alt="Screenshot 2024-12-15 at 04 53 41" src="https://github.com/user-attachments/assets/5a2b5332-e324-4d20-82e9-21d1c850e826" /> Diff without whitespace: https://github.com/go-gitea/gitea/pull/32847/files?diff=unified&w=1 The `tw-mt-2` is fine even if the element renders empty: <img width="387" alt="image" src="https://github.com/user-attachments/assets/76a976e4-ba2e-48a5-9248-c361552a937a" /> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Remove translation to issue add time because the format is fixed should not ↵Lunny Xiao2024-12-152-2/+1
| | | | | | be translated (#32850) The input content should always be `1h 2m 3s` and will be the same on different UI languages. So the translation is wrong.
* Fine tune ssh related comments and code (#32846)wxiaoguang2024-12-151-6/+6
| | | | Add more comments to explain the ssh problem, and rename `sshConn` to `sshSession`
* Update golangci-lint to v1.62.2, fix issues (#32845)silverwind2024-12-1513-36/+36
| | | Update it and fix new issues related to `redefines-builtin-id`
* In some lfs server implementations, they require the ref attribute. (#32838)hiifong2024-12-151-1/+4
| | | | | | | | | Fix: #32611 In some lfs server implementations, they require the ref attribute. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix SSPI button visibility when SSPI is the only enabled method (#32841)mevius42024-12-152-2/+2
|
* Fix overflow on org header (#32837)silverwind2024-12-142-7/+2
|
* Refactor markdown math render (#32831)wxiaoguang2024-12-1410-151/+137
| | | Add more tests
* Add User-Agent for gitea's self-implemented lfs client. (#32832)hiifong2024-12-141-3/+6
|
* Improve JSX/TSX support in code editor (#32833)silverwind2024-12-141-4/+11
| | | | | | | | | | | | | | | | | Two tweaks to Monaco to improve JSX/TSX support. 1. Certain language features like JSX/TSX only work when passing `uri` (containing the filename), do this. 2. Set the `jsx` compiler option to avoid error annotations Before: <img width="441" alt="Screenshot 2024-12-13 at 15 11 33" src="https://github.com/user-attachments/assets/dac245a7-e80f-4249-8e09-13124b03d12a" /> After: <img width="441" alt="Screenshot 2024-12-13 at 15 10 46" src="https://github.com/user-attachments/assets/726ad712-d116-438d-88da-bc40534b6860" />
* Upgrade htmx to 2.0.4 (#32834)Yarden Shoham2024-12-142-5/+5
| | | | | | | | | Release notes: https://github.com/bigskysoftware/htmx/releases/tag/v2.0.4 Tested `Star`, `Watch`, and the admin dashboard page. All functionality remains unchanged. Signed-off-by: Yarden Shoham <git@yardenshoham.com>
* Fix missing outputs for jobs with matrix (#32823)Zettat1232024-12-148-18/+230
| | | | | | | Fix #32795 If a job uses a matrix, multiple `ActionRunJobs` may have the same `JobID`. We need to merge the outputs of these jobs to make them available to the jobs that need them.
* Allow to fork repository into the same owner (#32819)wxiaoguang2024-12-145-5/+44
| | | | | | | | | | | | This feature is experimental, not fully tested, and may be changed in the future. It is only designed for users who really need it: set `[repository].ALLOW_FORK_INTO_SAME_OWNER=true` in your app.ini Doc: https://gitea.com/gitea/docs/pulls/122 ![image](https://github.com/user-attachments/assets/38d08c23-9cfc-49d8-9321-ff81edf65395)
* Fix various UI bugs (#32821)wxiaoguang2024-12-137-30/+47
|
* Add missing two sync feed for refs/pull (#32815)Lunny Xiao2024-12-131-0/+12
| | | Fowllow #32659
* Fix misuse of PublicKeyCallback (#32810)wxiaoguang2024-12-133-11/+65
| | | Only upgrading the ssh package is not enough.
* Fix bug of branch/tag selector in the issue sidebar (#32744)hiifong2024-12-136-7/+26
| | | | | | | Fix: #32731 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix lfs migration (#32812)hiifong2024-12-122-1/+3
| | | Fix: #32803
* Avoid MacOS keychain dialog in integration tests (#32813)Rowan Bohde2024-12-121-0/+5
| | | | | | | | | | | | | | | | Mac's git installation ships with a system wide config that configures the credential helper `osxkeychain`, which will prompt the user with a dialog. ``` $ git config list --system credential.helper=osxkeychain ``` By setting the environment variable [`GIT_CONFIG_NOSYSTEM=true`](https://git-scm.com/docs/git-config#ENVIRONMENT), Git will not load the system wide config, preventing the dialog from populating. Closes #26717
* Update actionlint.yamltechknowlogick2024-12-121-0/+2
|
* Detect whether action view branch was deleted (#32764)Lunny Xiao2024-12-127-9/+69
| | | | | Fix #32761 ![图片](https://github.com/user-attachments/assets/a5a7eef8-0fea-4242-b199-1b0b73d9bbdb)
* Add "n commits" link to contributors in contributors graph page (#32799)Chai-Shi2024-12-123-4/+25
| | | | | | | | | | | | Fixes Issue #29365 and inherit PR #29429 - I should extend the #29429 fork but the fork is not synced, so I created another PR. - Use `silenced` class for the link, as in #29847 --------- Co-authored-by: Ben Chang <ben_chang@htc.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix "unicode escape" JS error (#32806)wxiaoguang2024-12-123-15/+16
| | | | | | | | | | | | | | | | | | | | | <details> ![image](https://github.com/user-attachments/assets/98aef2fb-791e-4b4a-b2ac-e880f8a52040) ![image](https://github.com/user-attachments/assets/532673ae-c4cf-4d84-a5c6-93e6eacd341c) ![image](https://github.com/user-attachments/assets/2a241a3d-b7f6-44ca-89d9-9d68386fbf3e) ![image](https://github.com/user-attachments/assets/1251e43d-41f2-42d1-a23b-3182e3812c3d) </details> --------- Co-authored-by: silverwind <me@silverwind.io>
* use dedicated runners for release artifacts (#32811)techknowlogick2024-12-123-9/+9
| | | | GH runners are having trouble, so switch the remaining release jobs to use dedicated runners.
* Make API "compare" accept commit IDs (#32801)wxiaoguang2024-12-1210-121/+151
|