aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix API repository object format missed (#31118)Lunny Xiao2024-05-281-0/+1
| | | Fix #31117
* Fix DashboardRepoList margin (#31121)silverwind2024-05-281-2/+0
| | | | | | Fixes: https://github.com/go-gitea/gitea/issues/31115 <img width="476" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/ba508ba9-b02d-47c6-ad9f-495101c81330">
* Update JS dependencies (#31120)silverwind2024-05-283-328/+331
| | | | | | | - Add `eslint-plugin-no-use-extend-native` to exclude list because it requires flat config - Exclude `@github/text-expander-element` because new version has broken positioning - Tested mermaid, monaco, swagger, chartjs
* [skip ci] Updated translations via CrowdinGiteaBot2024-05-2827-66/+52
|
* Prevent simultaneous editing of comments and issues (#31053)metiftikci2024-05-2721-27/+172
| | | | | | | | | | | fixes #22907 Tested: - [x] issue content edit - [x] issue content change tasklist - [x] pull request content edit - [x] pull request change tasklist ![issue-content-edit](https://github.com/go-gitea/gitea/assets/29250154/a0828889-fb96-4bc4-8600-da92e3205812)
* Update demo site location from try.gitea.io -> demo.gitea.com (#31054)Lunny Xiao2024-05-2717-37/+30
|
* Move documents under actions (#31110)Lunny Xiao2024-05-273-9/+3
| | | Move secrets and badge under actions
* Update pip related commands for docker (#31106)wxiaoguang2024-05-272-8/+4
| | | | | Thanks to graelo and silverwind for figuring out the problem. Fix #31101
* Fix missing memcache import (#31105)wxiaoguang2024-05-271-0/+2
| | | Fix #31102
* feat: add support for a credentials chain for minio access (#31051)Rowan Bohde2024-05-276-9/+169
| | | | | | | | | | | | | We wanted to be able to use the IAM role provided by the EC2 instance metadata in order to access S3 via the Minio configuration. To do this, a new credentials chain is added that will check the following locations for credentials when an access key is not provided. In priority order, they are: 1. MINIO_ prefixed environment variables 2. AWS_ prefixed environment variables 3. a minio credentials file 4. an aws credentials file 5. EC2 instance metadata
* Rename project board -> column to make the UI less confusing (#30170)Lunny Xiao2024-05-2744-775/+725
| | | | | | | | | | | | | This PR split the `Board` into two parts. One is the struct has been renamed to `Column` and the second we have a `Template Type`. But to make it easier to review, this PR will not change the database schemas, they are just renames. The database schema changes could be in future PRs. --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: yp05327 <576951401@qq.com>
* Simplify review UI (#31062)delvh2024-05-271-14/+19
| | | | | | | | | | | | | | | | | | | | | | Instead of always displaying all available actions as buttons, merge them into a single dropdown menu, same as GitHub. That decreases visual overload and is more mobile-friendly, while not losing any functionality. ## Screenshots <details><summary>Before</summary> ![grafik](https://github.com/go-gitea/gitea/assets/51889757/b957fab0-4cc7-4cf5-a6c8-33f571be7b19) </details> <details><summary>After (unexpanded)</summary> ![grafik](https://github.com/go-gitea/gitea/assets/51889757/c8fd3428-4092-4295-bd55-c243409ba90d) </details> <details><summary>After (expanded)</summary> ![grafik](https://github.com/go-gitea/gitea/assets/51889757/c0eada91-54be-42ce-9db1-0db56d971438) </details>
* Prevent tab shifting, remove extra margin on fluid pages (#31090)silverwind2024-05-276-14/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Extend concept of https://github.com/go-gitea/gitea/pull/29831 to all tabular menus, there were only three left that weren't already `<overflow-menu>`. <img width="634" alt="Screenshot 2024-05-27 at 00 42 16" src="https://github.com/go-gitea/gitea/assets/115237/d9a7e219-d05e-40a1-9e93-777f9a8a90dd"> <img width="965" alt="Screenshot 2024-05-27 at 00 29 32" src="https://github.com/go-gitea/gitea/assets/115237/e6ed71b1-11fb-4a74-9adb-af4524286cff"> 2. Remove extra padding on `fluid padded` container like for example PR diff view. The page margin is already correctly sized via `.ui.container`, so this was just extraneous padding that looked ugly. Before: <img width="1351" alt="Screenshot 2024-05-27 at 00 45 11" src="https://github.com/go-gitea/gitea/assets/115237/4b45fd11-b1b2-4fbb-a618-26eb22be9472"> After: <img width="1344" alt="Screenshot 2024-05-27 at 00 45 22" src="https://github.com/go-gitea/gitea/assets/115237/d09593eb-6c7f-45e7-85b6-f0050047004b"> 3. Replace `gt-word-break` with `tw-break-anywhere` in issue-title, fixing overflow. Before: <img width="1333" alt="Screenshot 2024-05-27 at 00 50 14" src="https://github.com/go-gitea/gitea/assets/115237/64d15d04-b456-401e-a972-df636965f0eb"> After: <img width="1316" alt="Screenshot 2024-05-27 at 00 50 26" src="https://github.com/go-gitea/gitea/assets/115237/ed1ce830-1408-414b-8263-eeaf773f52c8">
* Improve the handling of `jobs.<job_id>.if` (#31070)Zettat1232024-05-272-16/+16
| | | | | | | | | | | | | | | | | | | Fix #25897 Fix #30322 #29464 cannot handle some complex `if` conditions correctly because it only checks `always()` literally. In fact, it's not easy to evaluate the `if` condition on the Gitea side because evaluating it requires a series of contexts. But act_runner is able to evaluate the `if` condition before running the job (for more information, see [`gitea/act`](https://gitea.com/gitea/act/src/commit/517d11c67126bd97c88e2faabda0832fff482258/pkg/runner/run_context.go#L739-L753)) . So we can use act_runner to check the `if` condition. In this PR, how to handle a blocked job depends on its `needs` and `if`: - If not all jobs in `needs` completed successfully and the job's `if` is empty, set the job status to `StatusSkipped` - In other cases, the job status will be set to `StatusWaiting`, and then act_runner will check the `if` condition and run the job if the condition is met
* Fix possible ui 500 if workflow's job is nil (#31092)Lunny Xiao2024-05-272-0/+9
| | | Fix #31087
* Fix border radius on hovered secondary menu (#31089)silverwind2024-05-271-1/+4
| | | | | | | | Presumably a regression from https://github.com/go-gitea/gitea/pull/30325, these menus were showing a border radius on hover, which is fixed with this change. <img width="154" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/eafdc1c5-3cf5-48d1-86c4-21c58f92cfaf">
* [skip ci] Updated licenses and gitignoresGiteaBot2024-05-275-0/+98
|
* Make gitea webhooks openproject compatible (#28435)André Rosenhammer2024-05-268-23/+102
| | | | | | | This PR adds some fields to the gitea webhook payload that [openproject](https://www.openproject.org/) expects to exists in order to process the webhooks. These fields do exists in Github's webhook payload so adding them makes Gitea's native webhook more compatible towards Github's.
* Change `--border-radius-circle` to `--border-radius-full` (#30936)silverwind2024-05-254-5/+5
| | | | | | Percentage-based `border-radius` [creates undesirable ellipse](https://jsfiddle.net/silverwind/j9ko5wnt/4/) on non-square content. Instead, use pixel value and use same wording `full` like tailwind does, but increast to 99999px over their 9999px.
* Fix `View File` button link if branch deleted on pull request files pages ↵metiftikci2024-05-251-1/+1
| | | | | (#31063) as title
* [skip ci] Updated translations via CrowdinGiteaBot2024-05-242-1/+2
|
* Support setting the `default` attribute of the issue template dropdown field ↵Zettat1232024-05-233-1/+118
| | | | | | | | | | (#31045) Fix #31044 According to [GitHub issue template documentation](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#attributes-for-dropdown), the `default` attribute can be used to specify the preselected option for a dropdown field.
* Alpine 3.20 has been released (#31047)techknowlogick2024-05-232-4/+4
|
* [skip ci] Updated translations via CrowdinGiteaBot2024-05-231-2/+2
|
* align s3 files with docker naming (#31050)techknowlogick2024-05-222-2/+2
| | | | docker images have `-nightly`, this will append the same to binaries uploaded to s3.
* Sync up deleted branches & action assets related cleanup documentation (#31022)Kemal Zebari2024-05-222-1/+20
| | | | Syncs up docs associated to actions and deleted branch cleanup i.e. in custom/app.example.ini and the config cheat sheet.
* Update Actions documentation missing feature (#31034)Lunny Xiao2024-05-222-0/+8
| | | | | | | | | Fix https://github.com/go-gitea/gitea/issues/25897#issuecomment-2117145391 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: yp05327 <576951401@qq.com>
* Add nix flake for dev shell (#30967)65432024-05-222-0/+98
| | | | | | | | | | | To try it you need **nix** installed `nix-daemon ` running and your user has to be member of the **nix-users** group. Or use NixOS. then by just: ```sh nix develop -c $SHELL ``` a dedicated development environment with all needed packages will be created.
* [skip ci] Updated translations via CrowdinGiteaBot2024-05-221-1/+3
|
* Fix wrong display of recently pushed notification (#25812)yp053272024-05-2126-72/+508
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's a bug in #25715: If user pushed a commit into another repo with same branch name, the no-related repo will display the recently pushed notification incorrectly. It is simple to fix this, we should match the repo id in the sql query. ![image](https://github.com/go-gitea/gitea/assets/18380374/9411a926-16f1-419e-a1b5-e953af38bab1) The latest commit is 2 weeks ago. ![image](https://github.com/go-gitea/gitea/assets/18380374/52f9ab22-4999-43ac-a86f-6d36fb1e0411) The notification comes from another repo with same branch name: ![image](https://github.com/go-gitea/gitea/assets/18380374/a26bc335-8e5b-4b9c-a965-c3dc3fa6f252) After: In forked repo: ![image](https://github.com/go-gitea/gitea/assets/18380374/ce6ffc35-deb7-4be7-8b09-184207392f32) New PR Link will redirect to the original repo: ![image](https://github.com/go-gitea/gitea/assets/18380374/7b98e76f-0c75-494c-9462-80cf9f98e786) In the original repo: ![image](https://github.com/go-gitea/gitea/assets/18380374/5f6a821b-e51a-4bbd-9980-d9eb94a3c847) New PR Link: ![image](https://github.com/go-gitea/gitea/assets/18380374/1ce8c879-9f11-4312-8c32-695d7d9af0df) In the same repo: ![image](https://github.com/go-gitea/gitea/assets/18380374/64b56073-4d0e-40c4-b8a0-80be7a775f69) New PR Link: ![image](https://github.com/go-gitea/gitea/assets/18380374/96e1b6a3-fb98-40ee-b2ee-648039fb0dcf) 08/15 Update: Follow #26257, added permission check and logic fix mentioned in https://github.com/go-gitea/gitea/pull/26257#discussion_r1294085203 2024/04/25 Update: Fix #30611 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* use existing oauth grant for public client (#31015)Denys Konovalov2024-05-211-2/+17
| | | | | | | | | | Do not try to create a new authorization grant when one exists already, thus preventing a DB-related authorization issue. Fix https://github.com/go-gitea/gitea/pull/30790#issuecomment-2118812426 --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
* Fix automerge will not work because of some events haven't been triggered ↵Lunny Xiao2024-05-217-63/+344
| | | | | | | | | | | | | | | | | (#30780) Replace #25741 Close #24445 Close #30658 Close #20646 ~Depends on #30805~ Since #25741 has been rewritten totally, to make the contribution easier, I will continue the work in this PR. Thanks @6543 --------- Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Don't include link of deleted branch when listing branches (#31028)Kemal Zebari2024-05-211-1/+1
| | | | | | | | | | | | From https://github.com/go-gitea/gitea/issues/31018#issuecomment-2119622680. This commit removes the link to a deleted branch name because it returns a 404 while it is in this deleted state. GitHub also throws a 404 when navigating to a branch link that was just deleted, but this deleted branch is removed from the branch list after a page refresh. Since with Gitea this deleted branch would be kept around for quite some time (well, until the "cleanup deleted branches" cron job begins), it makes sense to not have this as a link that users can navigate to.
* [skip ci] Updated translations via CrowdinGiteaBot2024-05-211-0/+5
|
* Refactor sha1 and time-limited code (#31023)wxiaoguang2024-05-208-98/+122
| | | | | | | Remove "EncodeSha1", it shouldn't be used as a general purpose hasher (just like we have removed "EncodeMD5" in #28622) Rewrite the "time-limited code" related code and write better tests, the old code doesn't seem quite right.
* Return `access_denied` error when an OAuth2 request is denied (#30974)Zettat1232024-05-203-2/+13
| | | | | | | | | | | | | | According to [RFC 6749](https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1), when the resource owner or authorization server denied an request, an `access_denied` error should be returned. But currently in this case Gitea does not return any error. For example, if the user clicks "Cancel" here, an `access_denied` error should be returned. <img width="360px" src="https://github.com/go-gitea/gitea/assets/15528715/be31c09b-4c0a-4701-b7a4-f54b8fe3a6c5" />
* Avoid 500 panic error when uploading invalid maven package file (#31014)wxiaoguang2024-05-204-2/+20
| | | | | | | PackageDescriptor.Metadata might be nil (and maybe not only for maven). This is only a quick fix. The new `if` block is written intentionally to avoid unnecessary indenting to the existing code.
* Fix incorrect "blob excerpt" link when comparing files (#31013)wxiaoguang2024-05-203-6/+47
| | | | | | | When comparing files between the base repo and forked repo, the "blob excerpt" link should point to the forked repo, because the commit doesn't exist in base repo. Co-authored-by: Giteabot <teabot@gitea.io>
* Fix project column title overflow (#31011)wxiaoguang2024-05-203-22/+16
| | | | | | By the way: * Re-format the "color.go" to Golang code style * Remove unused `overflow-y: scroll;` from `.project-column` because there is `overflow: visible`
* Fix data-race during testing (#30999)wxiaoguang2024-05-203-20/+36
| | | Fix #30992
* Fix "force private" logic (#31012)wxiaoguang2024-05-2016-18/+19
| | | | | When creating a repo, the "FORCE_PRIVATE" config option should be respected, `readonly` doesn't work for checkbox, so it should use `disabled` attribute.
* [skip ci] Updated licenses and gitignoresGiteaBot2024-05-205-0/+269
|
* Improve reverse proxy documents and clarify the AppURL guessing behavior ↵wxiaoguang2024-05-195-61/+78
| | | | | | | | | | | | (#31003) Fix #31002 1. Mention Make sure `Host` and `X-Fowarded-Proto` headers are correctly passed to Gitea 2. Clarify the basic requirements and move the "general configuration" to the top 3. Add a comment for the "container registry" 4. Use 1.21 behavior if the reverse proxy is not correctly configured Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Fix bug on avatar (#31008)Lunny Xiao2024-05-193-10/+24
| | | Co-authored-by: silverwind <me@silverwind.io>
* Clean up revive linter config, tweak golangci output (#30980)silverwind2024-05-181-5/+3
| | | | | | | | | The `errorCode` and `warningCode` options were removed at some point, they are not recognized by golangci-lint any more at least and they do not match their published json schema. `confidence` and `ignore-generated-header` are at the default value so does not need to be configured. https://golangci-lint.run/usage/linters/#revive
* Simplify mirror repository API logic (#30963)wxiaoguang2024-05-173-11/+5
| | | Fix #30921
* [skip ci] Updated translations via CrowdinGiteaBot2024-05-171-0/+2
|
* Upgrade `tqdm` dependency (#30996)silverwind2024-05-161-4/+4
| | | | | Result of `make update-py` Fixes: https://github.com/go-gitea/gitea/security/dependabot/65
* Fix JS error when editing a merged PR's title (#30990)wxiaoguang2024-05-162-5/+6
|
* template: `label` fix correct input id (#30987)Frank Villaro-Dixon2024-05-161-1/+1
| | | Signed-off-by: Frank Villaro-Dixon <frank@villaro-dixon.eu>