aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add more package registry paths to the labeler (#27032)JakobDev2023-09-121-0/+3
| | | Found this while working on #26960
* Extract auth middleware from service (#27028)KN4CK3R2023-09-124-266/+262
| | | | | | Related #27027 Extract the router logic from `services/auth/middleware.go` into `routers/web` <-> `routers/common` <-> `routers/api`.
* S3: log human readable error on connection failure (#26856)Earl Warren2023-09-122-0/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | Should BucketExists (HeadBucket) fail because of an error related to the connection rather than the existence of the bucket, no information is available and the admin is left guessing. https://docs.aws.amazon.com/AmazonS3/latest/API/API_HeadBucket.html > This action is useful to determine if a bucket exists and you have > permission to access it. The action returns a 200 OK if the bucket > exists and you have permission to access it. > > If the bucket does not exist or you do not have permission to access > it, the HEAD request returns a generic 400 Bad Request, 403 > Forbidden or 404 Not Found code. A message body is not included, so > you cannot determine the exception beyond these error codes. GetBucketVersioning is used instead and exclusively dedicated to asserting if using the connection does not return a BadRequest. If it does the NewMinioStorage logs an error and returns. Otherwise it keeps going knowing that BucketExists is not going to fail for reasons unrelated to the existence of the bucket and the permissions to access it. (cherry picked from commit d1df4b3bc62e5e61893a923f1c4b58f084eb03af) Refs: https://codeberg.org/forgejo/forgejo/issues/1338
* [skip ci] Updated translations via CrowdinGiteaBot2023-09-121-1/+1
|
* Fix "delete" modal dialog for issue/PR (#27015)wxiaoguang2023-09-113-3/+15
| | | | | | | | | | | Close #27012 By the way, rename the single-word ID to a long ID. ![image](https://github.com/go-gitea/gitea/assets/2114189/9f05ecc3-0a3d-4612-85e0-da60f7a45d2e) ![image](https://github.com/go-gitea/gitea/assets/2114189/9133808c-bd89-4265-99c5-83b986bd266f)
* Fix context cache bug & enable context cache for dashabord commits' authors ↵Lunny Xiao2023-09-118-87/+72
| | | | | | | | | | | (#26991) Unfortunately, when a system setting hasn't been stored in the database, it cannot be cached. Meanwhile, this PR also uses context cache for push email avatar display which should avoid to read user table via email address again and again. According to my local test, this should reduce dashboard elapsed time from 150ms -> 80ms .
* fix: typo (#27009)MomentQYC2023-09-111-1/+1
|
* Use secure cookie for HTTPS sites (#26999)wxiaoguang2023-09-114-5/+5
| | | | | | | | | | | If the AppURL(ROOT_URL) is an HTTPS URL, then the COOKIE_SECURE's default value should be true. And, if a user visits an "http" site with "https" AppURL, they won't be able to login, and they should have been warned. The only problem is that the "language" can't be set either in such case, while I think it is not a serious problem, and it could be fixed easily if needed. ![image](https://github.com/go-gitea/gitea/assets/2114189/7bc9a859-dcc1-467d-bc7c-1dd6a10389e3)
* Add fetch wrappers, ignore network errors in actions view (#26985)silverwind2023-09-114-28/+79
| | | | | | | | | | | | | | | 1. Introduce lightweight `fetch` wrapper functions that automatically sets csfr token, content-type and use it in `RepoActionView.vue`. 2. Fix a specific issue on `RepoActionView.vue` where a fetch network error is shortly visible during page reload sometimes. It can be reproduced by F5-in in quick succession on the actions view page and was also producing a red error box on the page. Once approved, we can replace all current `fetch` uses in UI with this in another PR. --------- Co-authored-by: Giteabot <teabot@gitea.io>
* [skip ci] Updated translations via CrowdinGiteaBot2023-09-111-143/+284
|
* Add some more labels to labeler (#26987)silverwind2023-09-101-2/+9
| | | | | | | | - Add more automatic labels - Consistently use `**` glob for recursive directory globs. --------- Co-authored-by: techknowlogick <techknowlogick@gitea.com>
* Fix INI parsing for value with trailing slash (#26995)wxiaoguang2023-09-102-2/+20
| | | Fix #26977 (a temp fix)
* Correct the database.LOG_SQL default value in config cheat sheet (#26997)Infinoid2023-09-102-2/+2
| | | | | The default is false, fix the docs to reflect that. Fixes: #26989
* Improve "language stats" UI (#26968)wxiaoguang2023-09-105-144/+62
| | | | | | | | | | | Before: * The layout is quite complex * The UI flickers when switch the stats (https://try.gitea.io/) After: * Simplify the code * The UI doesn't flicker
* [skip ci] Updated translations via CrowdinGiteaBot2023-09-101-109/+216
|
* Update chroma to v2.9.1 (#26990)silverwind2023-09-092-3/+3
|
* Improve issue list layout (#26983)wxiaoguang2023-09-093-11/+26
| | | | | | | | Align everything with a new layout. * Use "baseline" for some special elements, the "flex-item-icon" is for the issue list only at the moment and I think it should be general enough now (but not using "flex-item-leading" anymore in this case). * Make the labels stretch themselves.
* [skip ci] Updated translations via CrowdinGiteaBot2023-09-092-22/+44
|
* Move some functions to service layer (#26969)Lunny Xiao2023-09-0822-748/+733
|
* Lock yamllint and update indirect python deps (#26979)silverwind2023-09-082-98/+108
| | | | I forgot to lock `yamllint` to exact version, so did that and regenerated `poetry.lock` as well.
* Chroma color tweaks (#26978)silverwind2023-09-082-17/+21
|
* Add a new column schedule_id for action_run to track (#26975)Lunny Xiao2023-09-087-20/+37
| | | | | | | | Fix #26971 And the UI now will display it's scheduled but not triggered by a push. <img width="954" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/d211845c-457e-4c3e-af1f-a0d654d3f365">
* Improve flex list UI (#26970)wxiaoguang2023-09-0814-26/+23
| | | | | | | | | | | | | | | | | | | | 1. There is already `gt-ac`, so no need to introduce `flex-item-center` 2. The `flex-item-baseline` and `.flex-item-icon svg { margin-top: 1px }` seem to be a tricky patch, they don't resolve the root problem, and still cause misalignment in some cases. * The root problem is: the "icon" needs to align with the sibling "title" * So, make the "icon" and the "title" both have the same height 3. `flex-text-inline` could only be used if the element is really "inline", otherwise its `vertical-align` would make the box size change. In most cases, `flex-text-block` is good enough. ![image](https://github.com/go-gitea/gitea/assets/2114189/1b7acfc2-b1c7-4e9c-a983-2fa932026479) --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>
* Clarify the git command Stdin hanging problem (#26967)wxiaoguang2023-09-082-17/+12
|
* Add v1.20.4 changelog (#26974)Lunny Xiao2023-09-081-0/+28
| | | | | | | frontport from #26966 --------- Co-authored-by: techknowlogick <techknowlogick@gitea.com>
* Check newly added node type before "attachDirAuto" (#26972)wxiaoguang2023-09-081-1/+1
|
* Expanding documentation in queue.go (#26889)zareck2023-09-081-13/+48
| | | | | | | | | A set of terminology, along with a broader description, can help more people engage with the Gitea queue system, providing insights and ensuring its correct use. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* move repository deletion to service layer (#26948)Lunny Xiao2023-09-0853-476/+567
| | | Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Add `yamllint` (#26965)silverwind2023-09-0714-187/+281
| | | | | | | | | So that https://github.com/go-gitea/gitea/pull/26964 does not happen again. Merge this after that PR. Config is based on [node's](https://github.com/nodejs/node/blob/main/.yamllint.yaml). --------- Co-authored-by: techknowlogick <techknowlogick@gitea.com>
* Fix yaml quoting (#26964)silverwind2023-09-071-14/+14
| | | | | Yaml [does not like](https://github.com/go-gitea/gitea/actions/runs/6115139962/job/16598147278?pr=26568) keys that start with `*` so let's quote all globs.
* [skip ci] Updated translations via CrowdinGiteaBot2023-09-083-26/+38
|
* Add `actions/labeler` (#26962)silverwind2023-09-072-0/+45
| | | | | Implements https://github.com/GiteaBot/gitea-backporter/issues/93 using [`actions/labeler`](https://github.com/actions/labeler). Very basic configuration, can be extended later.
* Team invite url fix when registration disabled (#26950)Jack Hay2023-09-071-2/+2
| | | | | This is a follow-on to https://github.com/go-gitea/gitea/pull/26550 and fixes the case where the team invite links to the registration page if it is disabled in settings.
* Refactor dashboard/feed.tmpl (#26956)CaiCandong2023-09-072-30/+39
| | | | - ~~Refactor `ActionType` to `models/activities/action_type.go`~~ - Replace the magic number in `feed.tmlp` with `InAction`
* Improve hint when uploading a too large avatar (#26935)Lunny Xiao2023-09-073-3/+3
| | | | | | | | | | Fix #26390 --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: silverwind <me@silverwind.io>
* Replace `util.SliceXxx` with `slices.Xxx` (#26958)CaiCandong2023-09-0716-110/+46
|
* Add reverseproxy auth for API back with default disabled (#26703)Lunny Xiao2023-09-074-3/+14
| | | | | | | | | | | | | | | This feature was removed by #22219 to avoid possible CSRF attack. This PR takes reverseproxy auth for API back but with default disabled. To prevent possbile CSRF attack, the responsibility will be the reverseproxy but not Gitea itself. For those want to enable this `ENABLE_REVERSE_PROXY_AUTHENTICATION_API`, they should know what they are doing. --------- Co-authored-by: Giteabot <teabot@gitea.io>
* Add "dir=auto" for input/textarea elements by default (#26735)wxiaoguang2023-09-073-0/+42
| | | | Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>
* Fix schedule actions still running even if workflow disalbed (#26939)Lunny Xiao2023-09-071-0/+10
| | | Fix #26782
* Fix the missing repo count (#26942)Nanguan Lin2023-09-071-0/+12
| | | | | | | | The commit (https://github.com/go-gitea/gitea/commit/958d148043a6ace08776b1fd5ec0a5859144dea0) forgot two pages :stuck_out_tongue_closed_eyes: ![ksnip_20230906-182626](https://github.com/go-gitea/gitea/assets/70063547/6da529e9-3028-46fb-8065-abfd804a078b) BTW, the `leave` button is in a weird position
* Improve SSH Key / GPG Key / Deploy Key UI (#26949)wxiaoguang2023-09-074-35/+35
| | | | | | | | | | | 1. In many cases, the `flex-list` has previous and next `gt-hidden` siblings, so relax the CSS selector to remove all ".segument .flex-list" paddings. 2. Make the "Add key" button can toggle 3. Move help message into the related segment(panel). Otherwise users would misread the message, eg: the SSH help seemed for GPG because they are so near 4. Move modal element into the segment element, otherwise it affects the layout
* [skip ci] Updated translations via CrowdinGiteaBot2023-09-071-2/+17
|
* Update nginx recommendations (#26924)silverwind2023-09-061-0/+2
| | | | | | | | - `Connection` and `Upgrade` [needed for websockets](https://www.nginx.com/blog/websocket-nginx/) - ~~`X-Real-IP` unnecessary and duplicate with `X-Forwarded-For`. [chi checks both headers](https://github.com/go-chi/chi/blob/master/middleware/realip.go), but XFF is definitely the more "standard" one.~~
* docs: Update Profile README information (#26947)Panagiotis "Ivory" Vasilopoulos2023-09-061-2/+2
| | | Follow-up of https://github.com/go-gitea/gitea/pull/26295
* Fix scoped label layout (#26932)wxiaoguang2023-09-061-1/+2
| | | Fix #26931
* Move createrepository from module to service layer (#26927)Lunny Xiao2023-09-0626-482/+510
| | | | Repository creation depends on many models, so moving it to service layer is better.
* Add a documentation note for Windows Service (#26938)KazzmanK2023-09-061-0/+9
| | | | | | Service may fail to start at boot time with timeout Resolves #26934 Co-authored-by: Nikolay Kobzarev <n.kobzarev@aeronavigator.ru>
* allow "latest" to be used in release vTag when downloading file (#26748)merlleu2023-09-061-4/+17
| | | | | | | | | | | | | | | | | | Hello, In the discord I saw [someone](https://discord.com/channels/322538954119184384/1069795723178160168/1145061200644800514) complaining that you can't use the "latest" keyword as release tag to download a specific file: In his example: https://www.uberwald.me/gitea/public/fvtt-ecryme/releases/latest/system.json However the latest keyword works for the release page, so I think it's a good thing to implement this on the release attachment download url too. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Extract common code to new template (#26933)Kerwin Bryant2023-09-065-46/+32
| | | Same as #26903
* Show always repo count in header (#26842)JakobDev2023-09-060-0/+0
| | | | | | | | | | | | | | | | | A few pages don't load the repo count of an user/org, so it is not shown in the header. This happens mostly on org pages, but the package settings applies to the user page as well. Before: ![Screenshot 2023-08-31 at 12-45-36 Gitea Git with a cup of tea](https://github.com/go-gitea/gitea/assets/15185051/14a59998-2cf9-4771-82f4-5d1d6fcb31f4) After: ![grafik](https://github.com/go-gitea/gitea/assets/15185051/ff055aa0-7cde-49be-9522-437bf970be1d) Seen on #26826 Regression of #25928