summaryrefslogtreecommitdiffstats
path: root/web_src
Commit message (Collapse)AuthorAgeFilesLines
* Fix UI regression of asciinema player (#26159) (#26162)Giteabot2023-07-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Backport #26159 by @wolfogre It was caused by updating `asciinema-player`, the upstream changed the CSS class prefix: `https://github.com/asciinema/asciinema-player/commit/40505e479e8ba6833f178a3b7e85503c72491614` <details> <summary>Before:</summary> <img width="1320" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/b91a2cf5-c1da-43d6-bac2-bc278728b11e"> </details> <details> <summary>After:</summary> <img width="1311" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/c9872d25-e0bb-43d4-8b1e-d87c6b03c0a2"> </details> Co-authored-by: Jason Song <i@wolfogre.com>
* Display deprecated warning in admin panel pages as well as in the log file ↵Lunny Xiao2023-07-261-0/+23
| | | | | | | | | | | | | | | (#26094) (#26154) backport #26094 Temporily resolve #25915 Related #25994 This PR includes #26007 's changes but have a UI to prompt administrator about the deprecated settings as well as the log or console warning. Then users will have enough time to notice the problem and don't have surprise like before. <img width="1293" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/c33355f0-1ea7-4fb3-ad43-cd23cd15391d">
* Increase table cell horizontal padding (#26140) (#26142)Giteabot2023-07-261-1/+1
| | | | | | | | | | | | | | Backport #26140 by @silverwind Extract from https://github.com/go-gitea/gitea/pull/26043, just the padding increase. Before and After (hard to notice, but it's there): <img width="427" alt="Screenshot 2023-07-25 at 19 37 12" src="https://github.com/go-gitea/gitea/assets/115237/9543dcda-eccb-4739-b7dd-06b076108ab4"> <img width="420" alt="Screenshot 2023-07-25 at 19 37 26" src="https://github.com/go-gitea/gitea/assets/115237/0a9c3724-81a1-4c67-a13b-4b728a51fc3a"> Co-authored-by: silverwind <me@silverwind.io>
* Improve commit graph alignment and truncating (#26112) (#26127)Giteabot2023-07-251-1/+6
| | | | | | | | | | | Backport #26112 by @wxiaoguang Fix #26101 ![image](https://github.com/go-gitea/gitea/assets/2114189/7507d201-822e-4534-8b20-e659d56b1268) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix escape problems in the branch selector (#25875) (#26103)Giteabot2023-07-251-4/+4
| | | | | | | Backport #25875 by @yp05327 Fix #25865 Co-authored-by: yp05327 <576951401@qq.com>
* Fix commit status color on dashboard repolist (#25993) (#25998)Giteabot2023-07-191-1/+1
| | | | | | | | | Backport #25993 by @silverwind Followup to https://github.com/go-gitea/gitea/pull/25935 which has missed to change the icon on the repolist because the logic is not shared with templates. Co-authored-by: silverwind <me@silverwind.io>
* avoid hard-coding height in language dropdown menu (#25986) (#25997)Giteabot2023-07-201-2/+1
| | | | | | | | | | | | | | Backport #25986 by @earl-warren This commit removes the hard-coded height of 500px, using that as a max-height instead. The height of items in the dropdown menu, assuming a default font size of 16px, is 36px, so the old CSS would cause overly large dropdown menus in instances where less than 14 languages are offered. Refs: https://codeberg.org/forgejo/forgejo/pulls/1000 Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com> Co-authored-by: rome-user <rome-user@noreply.codeberg.org>
* Show the mismatched ROOT_URL warning on the sign-in page if OAuth2 is ↵Giteabot2023-07-193-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | enabled (#25947) (#25972) Backport #25947 by @wolfogre Since OAuth2 will callback the root URL, if the user starts signing in from a wrong host, Gitea will return 500 because it cannot find the session. <details> <summary>How to reproduce</summary> <img width="901" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/2c2e255c-e13e-4a11-9be7-b226bee54920"> <img width="1014" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/b31cfcf6-a320-483d-9ce5-ba8562f065e1"> </details> So show the mismatched ROOT_URL warning on the sign-in page if OAuth2 is enabled. <img width="1015" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/99e80b17-c790-49a3-bbf2-2bd9396a7daa"> Co-authored-by: Jason Song <i@wolfogre.com>
* Make `add line comment` buttons focusable (#25894) (#25896)Giteabot2023-07-151-0/+4
| | | | | | | | | | | | Backport #25894 by @sebastian-sauer Use a real button and add an aria-label. Additionally, show the button whenever it is focused. See https://codeberg.org/forgejo/forgejo/issues/998 for explanation. Our handling of this button is now equal to that of GitHub. Nothing has changed visually. Co-authored-by: sebastian-sauer <sauer.sebastian@gmail.com>
* Make "install page" respect environment config (#25648) (#25799)wxiaoguang2023-07-101-18/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25648 Replace #25580 Fix #19453 The problem was: when users set "GITEA__XXX__YYY" , the "install page" doesn't respect it. So, to make the result consistent and avoid surprising end users, now the "install page" also writes the environment variables to the config file. And, to make things clear, there are enough messages on the UI to tell users what will happen. There are some necessary/related changes to `environment-to-ini.go`: * The "--clear" flag is removed and it was incorrectly written there. The "clear" operation should be done if INSTALL_LOCK=true * The "--prefix" flag is removed because it's never used, never documented and it only causes inconsistent behavior. The only conflict during backport is "ui divider" in templates/install.tmpl
* Clarify "text-align" CSS helpers, fix clone button padding (#25763) (#25764)wxiaoguang2023-07-104-7/+8
| | | | | | Backport #25763 Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>
* Fix notification list bugs (#25781) (#25787)Giteabot2023-07-091-1/+1
| | | | | | | | | | | | | Backport #25781 by @wxiaoguang Fix #25627 1. `ctx.Data["Link"]` should use relative URL but not AppURL 2. The `data-params` is incorrect because it doesn't contain "page". JS can simply use "window.location.search" to construct the AJAX URL 3. The `data-xxx` and `id` in notification_subscriptions.tmpl were copied&pasted, they don't have affect. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Always pass 6-digit hex color to monaco (#25780) (#25782)silverwind2023-07-095-55/+26
| | | | | | | | | | | | | | | Backport https://github.com/go-gitea/gitea/pull/25780, clean cherry-pick. Monaco can not deal with color formats other than 6-digit hex, so we convert the colors for it via new [`tinycolor2`](https://github.com/bgrins/TinyColor) dependency (5kB minzipped). Also, with the addition of the module, we can replace the existing `hexToRGBColor` usage, I verified it is compatible with the current tests before removing the function. Fixes: https://github.com/go-gitea/gitea/issues/25770
* Several fixes for mobile UI (#25634) (#25689)Denys Konovalov2023-07-074-31/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25634 Resolves https://github.com/go-gitea/gitea/issues/25622 <details> <summary>Screenshots</summary> ![Bildschirmfoto vom 2023-07-02 20-47-34](https://github.com/go-gitea/gitea/assets/47871822/a8a0bff6-9ae3-48f3-b008-00c196a3f8fd) ![Bildschirmfoto vom 2023-07-02 20-47-45](https://github.com/go-gitea/gitea/assets/47871822/172a0021-af74-4690-aa67-0e66688ce733) ![Bildschirmfoto vom 2023-07-02 20-48-37](https://github.com/go-gitea/gitea/assets/47871822/14572ebd-0106-4c8a-ba27-b6b631375ee6) ![Bildschirmfoto vom 2023-07-02 20-49-08](https://github.com/go-gitea/gitea/assets/47871822/7c0ba3aa-1712-482c-aae9-13394dbdaf8a) ![Bildschirmfoto vom 2023-07-02 20-50-28](https://github.com/go-gitea/gitea/assets/47871822/8bd68e26-099a-4abd-8817-16d52af13167) ![Bildschirmfoto vom 2023-07-02 20-51-46](https://github.com/go-gitea/gitea/assets/47871822/3beab8c6-3747-4829-be50-bafaed11000c) ![Bildschirmfoto vom 2023-07-02 20-54-12](https://github.com/go-gitea/gitea/assets/47871822/51f82ef3-a32c-4c27-9056-e8711ed469cc) </details> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>
* Fix position of org follow button (#25688) (#25692)Giteabot2023-07-051-0/+1
| | | | | | | | | | | | | | | | Backport #25688 by @silverwind This has recently regressed it seems. Put it back into same position as https://github.com/go-gitea/gitea/pull/24345. Before: <img width="1246" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/bb410c29-5539-4dad-8351-8da8470f7091"> After: <img width="1236" alt="Screenshot 2023-07-04 at 21 19 13" src="https://github.com/go-gitea/gitea/assets/115237/072e0e83-defd-484d-8861-33d73fa0e446"> Co-authored-by: silverwind <me@silverwind.io>
* Prevent duplicate image loading (#25675) (#25684)Giteabot2023-07-041-1/+2
| | | | | | | Backport #25675 by @delvh Regression of #25672. Co-authored-by: delvh <dev.lh@web.de>
* Actions list enhancements (#25601) (#25678)silverwind2023-07-043-11/+24
| | | | | | | | | | | | Backport https://github.com/go-gitea/gitea/pull/25601 to 1.20. Various small enhancements to the actions list. Before and after: <img width="1264" alt="Screenshot 2023-06-30 at 00 11 40" src="https://github.com/go-gitea/gitea/assets/115237/bb4162ee-cdcf-4a73-b05e-f9521562edbb"> <img width="1264" alt="Screenshot 2023-06-30 at 00 09 51" src="https://github.com/go-gitea/gitea/assets/115237/52a70ea9-4bb3-406e-904b-0fdaafde9582"> Co-authored-by: Giteabot <teabot@gitea.io>
* Prevent SVG shrinking (#25652) (#25669)silverwind2023-07-043-10/+42
| | | | | | | | | | | | | | Backport https://github.com/go-gitea/gitea/pull/25652 This will prevent the most common cases of SVG shrinking because lack of space. I evaluated multiple options and this seems to be the one with the least impact in size and processing cost, so I went with it. Unfortunately, CSS can not dynamically convert `16` obtained from `attr()` to `16px`, or else a generic solution for all sizes would have been possible. But a solution is [in sight](https://developer.mozilla.org/en-US/docs/Web/CSS/attr#type-or-unit) with `attr(width px)` but no browser supports it currently.
* Fix show more for image on diff page (#25672) (#25673)Giteabot2023-07-041-0/+2
| | | | | | | | | | | | | | | | | | Backport #25672 by @HesterG Right now when clicking on loadmore on files change page, if the loaded content is image, it will be always in load status: https://github.com/go-gitea/gitea/assets/17645053/39e449b6-067a-474c-9443-9dd98d5bbfe2 This PR fixes this by adding `initImageDiff ` to `onShowMoreFiles ` After: https://github.com/go-gitea/gitea/assets/17645053/87bbb13e-0064-4a6e-a7ad-0f0060eb8bff Co-authored-by: HesterG <hestergong@gmail.com>
* Fix UI misalignment on user setting page (#25629) (#25656)Giteabot2023-07-031-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25629 by @wxiaoguang Fix #25628 Diff with ignoring space: https://github.com/go-gitea/gitea/pull/25629/files?diff=unified&w=1 The "modal" shouldn't appear between "ui attached segment", otherwise these segments lose margin-top. After the fix: <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/ac15e73d-4ca8-416a-950d-ffc912c6ab61) ![image](https://github.com/go-gitea/gitea/assets/2114189/eb431336-4d21-4e44-8beb-8919595a83c8) ![image](https://github.com/go-gitea/gitea/assets/2114189/dffaed88-5ba2-419d-a241-24cb200f757c) ![image](https://github.com/go-gitea/gitea/assets/2114189/e8c5a03e-e16a-4c94-a1a5-7845d4e1a824) </details> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Make "cancel" buttons have proper type in modal forms (#25618) (#25641)wxiaoguang2023-07-032-0/+28
| | | | | | | | | | | Replace #25446, fix #25438 All "cancel" buttons which do not have "type" should not submit the form, should not be triggered by "Enter". This is a complete fix for all modal dialogs. The major change is "modules/aria/modal.js", "devtest" related code is for demo/test purpose.
* Reduce table padding globally (#25568) (#25577)Giteabot2023-06-291-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25568 by @silverwind Fomantic's tables have too much padding. Reduce it so we have more information density in them. Especially the admin tables need this because they are bursting already because of column count. ## Admin repolist before and after <img width="909" alt="Screenshot 2023-06-28 at 20 27 55" src="https://github.com/go-gitea/gitea/assets/115237/954c925c-8db5-47ce-ae51-a2168b857014"> <img width="897" alt="Screenshot 2023-06-28 at 20 36 03" src="https://github.com/go-gitea/gitea/assets/115237/0bddc09a-9117-48b3-a17e-3d34c58d8d3d"> ## Other tables <img width="1230" alt="Screenshot 2023-06-28 at 20 36 22" src="https://github.com/go-gitea/gitea/assets/115237/38f555b6-a7ce-416a-9f1f-706eaf18863b"> <img width="1236" alt="Screenshot 2023-06-28 at 20 26 37" src="https://github.com/go-gitea/gitea/assets/115237/82b2878e-358c-4dc2-a6b4-c66e43cd2dfb"> <img width="1231" alt="Screenshot 2023-06-28 at 20 59 30" src="https://github.com/go-gitea/gitea/assets/115237/c6a92e55-a3a3-4c80-9a0d-50aebb49886c"> Files table is unaffected because it has custom padding already. Co-authored-by: silverwind <me@silverwind.io>
* Align language menu icon and fit the footer area (#25556) (#25563)Giteabot2023-06-281-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | Backport #25556 by @wxiaoguang Close #25551 ## Before ![image](https://github.com/go-gitea/gitea/assets/2114189/f35aebeb-9c86-4632-8c1f-1c90aa757640) ## After ![image](https://github.com/go-gitea/gitea/assets/2114189/4a623687-6c6d-442a-a4f9-07dadeb9fc6d) ---- ![image](https://github.com/go-gitea/gitea/assets/2114189/6a4e5ecf-b88b-4c22-98c3-21898bd41bc5) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix admin-dl-horizontal (#25512) (#25535)Giteabot2023-06-271-18/+13
| | | | | | | | | | | | | Backport #25512 by @wxiaoguang ![image](https://github.com/go-gitea/gitea/assets/2114189/fb731e07-da30-4470-8200-73b5ca8b78f1) ![image](https://github.com/go-gitea/gitea/assets/2114189/85930b6f-5df7-437f-863f-423f3b81dd26) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: HesterG <hestergong@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
* Fix rerun icon on action view component (#25531) (#25536)Giteabot2023-06-271-2/+2
| | | | | | | | | | | | | | | | | | | | | Backport #25531 by @HesterG Right now rerun icon on action view component will not be seen when duration text length is long, because the wrapper `job-brief-info` has a fixed width, and the svg is squeezed. The way to fix this in this PR is to change width to `fit-content` and exchange position of duration text and rerun svg. Before (rerun svg not shown on hover): <img width="1401" alt="Screen Shot 2023-06-27 at 12 53 41" src="https://github.com/go-gitea/gitea/assets/17645053/bb3f62ec-8c56-4dbc-96f1-718b50426d91"> After: <img width="1409" alt="Screen Shot 2023-06-27 at 12 50 59" src="https://github.com/go-gitea/gitea/assets/17645053/620aa02c-2326-408d-a763-453f48f42c40"> Co-authored-by: HesterG <hestergong@gmail.com>
* Fix input `line-height` cutting off `g` (#25334) (#25533)Giteabot2023-06-271-0/+5
| | | | | | | | | | | | | | | | | | Backport #25334 by @hiifong Fix the incomplete display of input text Before: ![image](https://github.com/go-gitea/gitea/assets/89133723/6bd8ca29-a096-46a8-bd23-fb833f45186f) ![image](https://github.com/go-gitea/gitea/assets/89133723/27e51e62-7150-45cd-8606-09317d462d70) After: ![image](https://github.com/go-gitea/gitea/assets/89133723/8d0db5d3-d768-42b4-9a75-0b8816f0a299) ![image](https://github.com/go-gitea/gitea/assets/89133723/4193adc9-b635-4ed6-8e11-715ec5150563) Co-authored-by: hiifong <i@hiif.ong> Co-authored-by: silverwind <me@silverwind.io>
* Allow change line of admin-dl-horizontal dt (#25508) (#25516)HesterG2023-06-261-3/+0
| | | | | | | | | | | | | | | | | | | As https://github.com/go-gitea/gitea/pull/25515#issuecomment-1606626886 says, still need this backport Close #25389 After: <img width="915" alt="Screen Shot 2023-06-26 at 11 00 12" src="https://github.com/go-gitea/gitea/assets/17645053/45026447-cf50-4603-ade3-7b80a9023c20"> admin/dashboard: <img width="957" alt="Screen Shot 2023-06-26 at 10 59 51" src="https://github.com/go-gitea/gitea/assets/17645053/f4f95bbe-f747-46f1-8fbd-5778a19ebef7"> Co-authored-by: Giteabot <teabot@gitea.io>
* Fine tune "dropdown button" icon (#25442) (#25499)Giteabot2023-06-251-0/+11
| | | | | | | | | | | Backport #25442 by @wxiaoguang ![image](https://github.com/go-gitea/gitea/assets/2114189/143e043d-85c9-43a4-85ae-ca55f507f738) ---- ![image](https://github.com/go-gitea/gitea/assets/2114189/bcba03a5-732e-4139-bc35-96a7f8bfcb88) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Revert "Make buttons in a modal form have proper type. (#25446) (#25478)" ↵wxiaoguang2023-06-241-2/+0
| | | | | | | | (#25484) There is a side effect because some modal doesn't have a proper "ok" button. This reverts commit 050c38ca19cce06040741321e7871121981c76f4.
* Make buttons in a modal form have proper type. (#25446) (#25478)Denys Konovalov2023-06-241-0/+2
| | | | | | | | | | Backport #25446 by @wxiaoguang Fix #25438 All non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter". Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Improve wiki sidebar and TOC (#25460) (#25477)Giteabot2023-06-247-71/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25460 by @wxiaoguang Close #20976 Close #20975 1. Fix the bug: the TOC in footer was incorrectly rendered as main content's TOC 2. Fix the layout: on mobile, the TOC is put above the main content, while the sidebar is put below the main content 3. Auto collapse the TOC on mobile ps: many styles of "wiki.css" are moved from old css files, so leave nits to following PRs. ### for desktop ![image](https://github.com/go-gitea/gitea/assets/2114189/6c84201c-0648-465a-99e6-c53cdaee53c0) ### for mobile ![image](https://github.com/go-gitea/gitea/assets/2114189/9cb4fdfe-b6ab-4e6f-ae82-219ddb8fa27e) ### other changed pages <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/ef077736-2c3e-4e3d-82fe-d9bf1ebcca98) ![image](https://github.com/go-gitea/gitea/assets/2114189/bb528429-ad5f-4258-a5c4-05f997c624ea) </details> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Diff page enhancements (#25398) (#25437)Giteabot2023-06-222-3/+2
| | | | | | | | | | | | | | | | | | | | | | Backport #25398 by @silverwind Two small tweaks: 1. Vertically center arrow here when editing a PR: <img width="405" alt="Screenshot 2023-06-20 at 19 48 49" src="https://github.com/go-gitea/gitea/assets/115237/1d63764d-9fd9-467e-8a8e-9258c06475eb"> 2. Use 2-row layout on diff viewed status and show it again on mobile: <img width="142" alt="Screenshot 2023-06-20 at 19 51 21" src="https://github.com/go-gitea/gitea/assets/115237/3046e782-163c-4f87-910c-a22066de8f1b"> Mobile view: <img width="370" alt="Screenshot 2023-06-20 at 19 44 40" src="https://github.com/go-gitea/gitea/assets/115237/9cf56347-7323-4d05-99a5-17ad215ee44d"> Co-authored-by: silverwind <me@silverwind.io>
* Various UI fixes (#25264) (#25431)Giteabot2023-06-224-12/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25264 by @silverwind Numerous small UI fixes: - Fix double border in collaborator list - Fix system notice table background - Mute links in repo and org lists - Downsize projects edit buttons - Improve milestones and project list rendering - Condense milestone list entry to a single line of "metas" - Mute ".." button in repo files list <img width="899" alt="Screenshot 2023-06-14 at 21 19 23" src="https://github.com/go-gitea/gitea/assets/115237/40d70006-5f76-49ad-b43c-4343ec3311e1"> <img width="905" alt="Screenshot 2023-06-14 at 21 18 29" src="https://github.com/go-gitea/gitea/assets/115237/46ef39ea-ab26-452d-89b0-a55d0cfacfdb"> <img width="270" alt="Screenshot 2023-06-14 at 21 14 09" src="https://github.com/go-gitea/gitea/assets/115237/aa16e833-a03b-4231-bc7c-159a6a6bee19"> <img width="409" alt="Screenshot 2023-06-14 at 21 12 13" src="https://github.com/go-gitea/gitea/assets/115237/b5242d41-f87a-4837-b0cf-9cc4c1f43daf"> <img width="286" alt="Screenshot 2023-06-14 at 21 10 03" src="https://github.com/go-gitea/gitea/assets/115237/d0c36e47-651b-4d34-ad95-3d59474a7c3e"> <img width="928" alt="Screenshot 2023-06-14 at 21 05 24" src="https://github.com/go-gitea/gitea/assets/115237/fc3b713e-d252-40f5-b6ba-6e5a741ab500"> <img width="217" alt="Screenshot 2023-06-14 at 21 02 01" src="https://github.com/go-gitea/gitea/assets/115237/c4c33376-18d6-4820-aff5-f508f6d351a0"> <img width="79" alt="Screenshot 2023-06-14 at 20 42 43" src="https://github.com/go-gitea/gitea/assets/115237/034b5950-c0bf-473b-a2f7-0c27a0259f29"> <img width="607" alt="Screenshot 2023-06-14 at 21 00 42" src="https://github.com/go-gitea/gitea/assets/115237/fba2d3fd-bd3e-4daf-8b2f-530a1c99c8bc"> Co-authored-by: silverwind <me@silverwind.io>
* Show outdated comments in files changed tab (#24936) (#25428)sebastian-sauer2023-06-222-10/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #24936 If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on). **Screenshots** ![image](https://github.com/go-gitea/gitea/assets/1135157/63ab9571-a9ee-4900-9f02-94ab0095f9e7) ![image](https://github.com/go-gitea/gitea/assets/1135157/78f7c225-8d76-46f5-acfd-9b8aab988a6c) When resolved and outdated: ![image](https://github.com/go-gitea/gitea/assets/1135157/6ece9ebd-c792-4aa5-9c35-628694e9d093) Option to enable/disable this (stored in user settings - default is disabled): ![image](https://github.com/go-gitea/gitea/assets/1135157/ed99dfe4-76dc-4c12-bd96-e7e62da50ab5) ![image](https://github.com/go-gitea/gitea/assets/1135157/e837a052-e92e-4a28-906d-9db5bacf93a6) fixes #24913 Co-authored-by: silverwind <me@silverwind.io>
* Fix dropdown icon layout on diff page (#25397) (#25403)Giteabot2023-06-212-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25397 by @wxiaoguang Address https://github.com/go-gitea/gitea/pull/25163#issuecomment-1599207916 Remove the unused "icon-button". And fix the layout: Without the dropdown icon: ``` {{svg "gitea-whitespace"}} ``` ![image](https://github.com/go-gitea/gitea/assets/2114189/58a524ba-f289-4982-aea2-6f9f9f9cbdcf) With the dropdown icon: ``` {{svg "gitea-whitespace" 16 "gt-mr-3"}} {{svg "octicon-triangle-down" 14 "dropdown icon"}} ``` ![image](https://github.com/go-gitea/gitea/assets/2114189/eb99168b-5d49-40a7-8665-5296cbb4e486) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Update JS dependencies, remove space after emoji completion (#25266) (#25352)silverwind2023-06-201-1/+3
| | | | | | | | | | | | | | | | | Manual backport of #25266 because of lockfile conflicts. - Update all JS dependencies - Enable stylint [`media-feature-name-value-no-unknown`](https://stylelint.io/user-guide/rules/media-feature-name-value-no-unknown) - Make use of new features in webpack and text-expander-element - Tested Swagger and Mermaid To explain the `text-expander-element` change: Before this version, the element added a unavoidable space after emoji completion. Now that https://github.com/github/text-expander-element/pull/36 is in, we gain control over this space and I opted to remove it for emoji completion and retain it for `@` mentions. Co-authored-by: Giteabot <teabot@gitea.io>
* Fix label list divider (#25312) (#25372)Giteabot2023-06-192-1/+1
| | | | | | | | | | | | | | | | | | | | Backport #25312 by @wxiaoguang We only needs 2 lines to hide the dividers. ``` $dropdownLabelFilter.dropdown('setting', {'hideDividers': 'empty'}); $dropdownLabelFilter.dropdown('refreshItems'); ``` Other code blocks are refactored by the way. ![image](https://github.com/go-gitea/gitea/assets/2114189/74989996-fcea-4df4-b534-b06f7957939a) ![image](https://github.com/go-gitea/gitea/assets/2114189/ee3b3761-b96e-4fb5-b646-e9d3117e5f40) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* fix issue filters on mobile view (#25368) (#25371)Giteabot2023-06-191-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25368 by @denyskon Fix #24846 applying the solution proposed by @silverwind <details> <summary>Screenshots</summary> ![Bildschirmfoto vom 2023-06-19 12-20-54](https://github.com/go-gitea/gitea/assets/47871822/3f4e4536-38c4-451b-bfc0-a7c39acd37f0) ![Bildschirmfoto vom 2023-06-19 12-21-02](https://github.com/go-gitea/gitea/assets/47871822/3403ecc2-4d7f-4acd-b0c0-1b7a10228ff7) ![Bildschirmfoto vom 2023-06-19 12-21-16](https://github.com/go-gitea/gitea/assets/47871822/ef28a2bf-b7cc-4aec-b54b-99d2cc46a1f6) ![Bildschirmfoto vom 2023-06-19 12-21-21](https://github.com/go-gitea/gitea/assets/47871822/f8cd72a5-379e-410b-b0ef-d58895719370) ![Bildschirmfoto vom 2023-06-19 12-21-28](https://github.com/go-gitea/gitea/assets/47871822/34c78301-820c-4106-a086-ae81dc97eb91) ![Bildschirmfoto vom 2023-06-19 12-21-48](https://github.com/go-gitea/gitea/assets/47871822/b677adf1-3a48-42c8-befe-fa9d2679f0a3) </details> Replaces #25335 Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
* Fix UI on mobile view (#25315) (#25340)Giteabot2023-06-185-51/+133
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25315 by @denyskon Various fixes to pages or elements which were looking ugly on mobile. <details> <summary>Screenshots</summary> ![Bildschirmfoto vom 2023-06-17 20-38-41](https://github.com/go-gitea/gitea/assets/47871822/30b5d3ce-df3b-43eb-a4c2-c3790667fb9d) ![Bildschirmfoto vom 2023-06-17 20-39-27](https://github.com/go-gitea/gitea/assets/47871822/27c07b25-3602-4fb2-b34d-d5e875e054e9) ![Bildschirmfoto vom 2023-06-17 20-41-27](https://github.com/go-gitea/gitea/assets/47871822/dacdbb4e-e3dd-4b94-abf0-c68e3d64bd3b) ![Bildschirmfoto vom 2023-06-17 20-41-48](https://github.com/go-gitea/gitea/assets/47871822/72432c35-7c4a-4c7f-a767-3562f26a5c14) ![Bildschirmfoto vom 2023-06-17 20-42-37](https://github.com/go-gitea/gitea/assets/47871822/737c26ed-1910-4467-98ef-e8769bbbe6f0) ![Bildschirmfoto vom 2023-06-17 20-42-52](https://github.com/go-gitea/gitea/assets/47871822/1813b4bc-43c0-4912-8acb-5d799c090bf3) ![Bildschirmfoto vom 2023-06-17 20-43-06](https://github.com/go-gitea/gitea/assets/47871822/136466e8-34e5-419d-97ec-5202ff819fd2) ![Bildschirmfoto vom 2023-06-17 20-43-42](https://github.com/go-gitea/gitea/assets/47871822/59270bb2-d661-4a84-8504-3e50f771f767) ![Bildschirmfoto vom 2023-06-17 20-44-44](https://github.com/go-gitea/gitea/assets/47871822/494e274d-3771-4141-9419-0a4bbd8b7f64) </details> Co-authored by: @silverwind Co-authored-by: Denys Konovalov <kontakt@denyskon.de> Co-authored-by: silverwind <me@silverwind.io>
* Remove EasyMDE focus outline on text (#25328) (#25332)Giteabot2023-06-181-0/+4
| | | | | | | | | | | | | | | | | | Backport #25328 by @silverwind EasyMDE in Firefox currently shows a ugly outline in the fake textarea the CodeMirror uses. Hide it. Before: <img width="845" alt="Screenshot 2023-06-18 at 02 54 09" src="https://github.com/go-gitea/gitea/assets/115237/dc406166-9ad5-4a9b-9581-002b5cdcc6df"> After: <img width="870" alt="Screenshot 2023-06-18 at 02 54 24" src="https://github.com/go-gitea/gitea/assets/115237/ddd78759-2cf2-4385-b863-7576fec25c34"> Co-authored-by: silverwind <me@silverwind.io>
* Remove more unused Fomantic variants (#25292) (#25323)Giteabot2023-06-174-1887/+16
| | | | | | | | | | | | | Backport #25292 by @silverwind Save another 50KB of CSS by removing unused and useless Fomantic variants. Removed the last instance of a `tertiary` button and fixed a TODO: <img width="509" alt="Screenshot 2023-06-15 at 22 34 36" src="https://github.com/go-gitea/gitea/assets/115237/8a16ae7b-2b17-439b-a096-60a52724e3d6"> Co-authored-by: silverwind <me@silverwind.io>
* Fix some UI alignments (#25277) (#25290)Giteabot2023-06-162-15/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25277 by @wxiaoguang Fixes: https://github.com/go-gitea/gitea/issues/25282 Fix the problems: 1. The `repo-button-row` had various patches before, this PR makes it consistent 2. The "Add File" has wrong CSS class "icon", remove it 3. The "Add File" padding was overridden by "!important", fix it by `.repo-button-row .button.dropdown` with comment 4. The selector `.ui.segments ~ .ui.top.attached.header` is incorrect, it should use `+` The `repo-button-row` is only used on 3 pages: ![image](https://github.com/go-gitea/gitea/assets/2114189/16057ff0-7d30-41ca-ac13-70d074364566) ![image](https://github.com/go-gitea/gitea/assets/2114189/cbe2acb1-07b6-48f3-9f28-407a75f8c4ed) ![image](https://github.com/go-gitea/gitea/assets/2114189/341416b3-f6a8-466f-a140-361ee80e53a7) ![image](https://github.com/go-gitea/gitea/assets/2114189/3d4b7857-ef99-4a3f-a667-9890714a096d) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Remove fomantic inverted variations (#25286) (#25289)Giteabot2023-06-152-4333/+38
| | | | | | | | Backport #25286 by @silverwind Remove all Fomantic `inverted` variations, we are no using any of them. This reduces the index CSS bundle by 98kB. Co-authored-by: silverwind <me@silverwind.io>
* Fix issue and commit status popup padding (#25254) (#25288)Giteabot2023-06-152-0/+2
| | | | | | | | | | | | | | Backport #25254 by @wxiaoguang Close #25249 Use "dialog" for the role ![image](https://github.com/go-gitea/gitea/assets/2114189/2b5b7552-48bc-4ecf-947b-34917232cff9) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
* Show OAuth2 errors to end users (#25261) (#25271)Giteabot2023-06-151-0/+6
| | | | | | | | | | | | | | | | Backport #25261 by @wxiaoguang Partially fix #23936 ![image](https://github.com/go-gitea/gitea/assets/2114189/8aa7f3ad-a5f0-42ce-a478-289a03bd08a3) ![image](https://github.com/go-gitea/gitea/assets/2114189/bb901e7d-485a-47a5-b68d-9ebe7013a6b2) ![image](https://github.com/go-gitea/gitea/assets/2114189/9a1ce0f3-f011-4baf-8e2f-cc6304bc9703) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Use flex to align SVG and text (#25163) (#25260)Giteabot2023-06-147-65/+86
| | | | | | | | | | | | | | | | Backport #25163 by @wxiaoguang The code can be as simple as: ```html <div class="flex-text-block">{{svg "octicon-alert"}} {{svg "octicon-x"}} text (block)</div> <div><div class="flex-text-inline">{{svg "octicon-alert"}} {{svg "octicon-x"}} text</div> (inline)</div> <div><button class="ui red button">{{svg "octicon-alert" 24}} {{svg "octicon-x" 24}} text</button></div> ``` ![image](https://github.com/go-gitea/gitea/assets/2114189/1d3c10f1-0bc7-4c26-b236-bad537d5c465) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Revert overflow: overlay (revert #21850) (#25231) (#25239)Giteabot2023-06-135-16/+7345
| | | | | | | | | | | | | | | | | | | | | | | Backport #25231 by @wxiaoguang It causes not only one issue like #25221 (the footer width was also affected by that change and was fixed some time ago) The problem of "overflow: overlay" (#21850) is: * It's not widely supported and is non-standard https://caniuse.com/css-overflow-overlay * It's not widely tested in Gitea (some standard layout like `ui container + ui grid` may break it). * The benefit seems smaller than the problems it brings. So, I think it is good to revert it. ---- Let's leave enough time for testing and reviewing. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
* Change access token UI to select dropdowns (#25109) (#25230)Giteabot2023-06-133-106/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25109 by @jtran The current UI to create API access tokens uses checkboxes that have a complicated relationship where some need to be checked and/or disabled in certain states. It also requires that a user interact with it to understand what their options really are. This branch changes to use `<select>`s. It better fits the available options, and it's closer to [GitHub's UI](https://github.com/settings/personal-access-tokens/new), which is good, in my opinion. It's more mobile friendly since the tap-areas are larger. If we ever add more permissions, like Maintainer, there's a natural place that doesn't take up more screen real-estate. This branch also fixes a few minor issues: - Hide the error about selecting at least one permission after second submission - Fix help description to call it "authorization" since that's what permissions are about (not authentication) Related: #24767. <img width="883" alt="Screenshot 2023-06-07 at 5 07 34 PM" src="https://github.com/go-gitea/gitea/assets/10803/6b63d807-c9be-4a4b-8e53-ecab6cbb8f76"> --- When it's open: <img width="881" alt="Screenshot 2023-06-07 at 5 07 59 PM" src="https://github.com/go-gitea/gitea/assets/10803/2432c6d0-39c2-4ca4-820e-c878ffdbfb69"> Co-authored-by: Jonathan Tran <jon@allspice.io>
* Use inline SVG for built-in OAuth providers (#25171) (#25234)Giteabot2023-06-1312-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport #25171 by @silverwind The plan is that all built-in auth providers use inline SVG for more flexibility in styling and to get the GitHub icon to follow `currentcolor`. This only removes the `public/img/auth` directory and adds the missing svgs to our svg build. It should map the built-in providers to these SVGs and render them. If the user has set a Icon URL, it should render that as an `img` tag instead. ``` gitea-azure-ad gitea-bitbucket gitea-discord gitea-dropbox gitea-facebook gitea-gitea gitea-gitlab gitea-google gitea-mastodon gitea-microsoftonline gitea-nextcloud gitea-twitter gitea-yandex octicon-mark-github ``` GitHub logo is now white again on dark theme: <img width="431" alt="Screenshot 2023-06-12 at 21 45 34" src="https://github.com/go-gitea/gitea/assets/115237/27a43504-d60a-4132-a502-336b25883e4d"> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix task list checkbox toggle to work with YAML front matter (#25184) (#25227)Giteabot2023-06-131-0/+8
| | | | | | | | | | | | Backport #25184 by @jtran Fixes #25160. `data-source-position` of checkboxes in a task list was incorrect whenever there was YAML front matter. This would result in issue content or PR descriptions getting corrupted with random `x` or space characters when a user checked or unchecked a task. Co-authored-by: Jonathan Tran <jon@allspice.io>