summaryrefslogtreecommitdiffstats
path: root/web_src
Commit message (Collapse)AuthorAgeFilesLines
* Align language menu icon and fit the footer area (#25556)wxiaoguang2023-06-281-5/+13
| | | | Close #25551
* Add custom ansi colors and CSS variables for them (#25546)silverwind2023-06-285-21/+96
| | | | | | | | | | | | | | | | | | | Use our existing color palette to map to the 16 basic ansi colors. This is backwards-compatible because it aliases the existing color names. Side note: I think the colors in `console.css` for console file rendering are incomplete, but fixing those is out of scope here imo. Before and after: <img width="542" alt="Screenshot 2023-06-28 at 00 26 12" src="https://github.com/go-gitea/gitea/assets/115237/86d41884-bc47-4e85-8aec-621eb7320f0b"> <img width="546" alt="Screenshot 2023-06-28 at 00 28 24" src="https://github.com/go-gitea/gitea/assets/115237/39fa3b37-d49e-49b1-b6bc-390ac8ca24b2"> --------- Co-authored-by: Giteabot <teabot@gitea.io>
* Update JS dependencies and misc tweaks (#25540)silverwind2023-06-273-6/+6
| | | | | | | | | | | | - Update all JS dependencies - Enable `declaration-property-unit-disallowed-list` to forbid `em` on `line-height` - Rename dependency update targets to `update-js` and `update-py` and document them - Remove margin on Asciicast viewer - Tested Swagger, Katex, Asciicast <img width="1243" alt="Screenshot 2023-06-27 at 19 51 05" src="https://github.com/go-gitea/gitea/assets/115237/2d2722a0-2aa7-4f4c-b8bd-17e1f3637b78">
* Fix rerun icon on action view component (#25531)HesterG2023-06-271-2/+2
| | | | | | | | | | | | | | | | | Right now rerun icon on action view component will not be seen when duration text length is long, because the wrapper `job-brief-info` has a fixed width, and the svg is squeezed. The way to fix this in this PR is to change width to `fit-content` and exchange position of duration text and rerun svg. Before (rerun svg not shown on hover): <img width="1401" alt="Screen Shot 2023-06-27 at 12 53 41" src="https://github.com/go-gitea/gitea/assets/17645053/bb3f62ec-8c56-4dbc-96f1-718b50426d91"> After: <img width="1409" alt="Screen Shot 2023-06-27 at 12 50 59" src="https://github.com/go-gitea/gitea/assets/17645053/620aa02c-2326-408d-a763-453f48f42c40">
* Fix admin-dl-horizontal (#25512)wxiaoguang2023-06-271-18/+13
| | | | | | | | | | | ![image](https://github.com/go-gitea/gitea/assets/2114189/fb731e07-da30-4470-8200-73b5ca8b78f1) ![image](https://github.com/go-gitea/gitea/assets/2114189/85930b6f-5df7-437f-863f-423f3b81dd26) --------- Co-authored-by: HesterG <hestergong@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
* Fix input `line-height` cutting off `g` (#25334)hiifong2023-06-271-0/+5
| | | | | | | | | | | | | | | | | | Fix the incomplete display of input text Before: ![image](https://github.com/go-gitea/gitea/assets/89133723/6bd8ca29-a096-46a8-bd23-fb833f45186f) ![image](https://github.com/go-gitea/gitea/assets/89133723/27e51e62-7150-45cd-8606-09317d462d70) After: ![image](https://github.com/go-gitea/gitea/assets/89133723/8d0db5d3-d768-42b4-9a75-0b8816f0a299) ![image](https://github.com/go-gitea/gitea/assets/89133723/4193adc9-b635-4ed6-8e11-715ec5150563) --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>
* Add toasts to UI (#25449)silverwind2023-06-2710-5/+192
| | | | | Fixes https://github.com/go-gitea/gitea/issues/24353 In some case like async success/error, it is useful to show toasts in UI.
* Fix migrate page layout on mobile (#25507)silverwind2023-06-261-3/+22
| | | | | | | | | | | | Fixes: https://github.com/go-gitea/gitea/issues/25462 On supporting browsers, text in description is [wrapped equally](https://caniuse.com/css-text-wrap-balance). <img width="488" alt="Screenshot 2023-06-26 at 00 17 21" src="https://github.com/go-gitea/gitea/assets/115237/cb8e3a50-6225-4a8c-a6c0-f35a17d2af76"> <img width="1254" alt="Screenshot 2023-06-26 at 00 14 51" src="https://github.com/go-gitea/gitea/assets/115237/0885404e-973e-45ce-b41e-5cb265a4cd1e">
* Allow change line of admin-dl-horizontal dt (#25508)HesterG2023-06-261-3/+0
| | | | | | | | | | | | | | Close #25389 After: <img width="915" alt="Screen Shot 2023-06-26 at 11 00 12" src="https://github.com/go-gitea/gitea/assets/17645053/45026447-cf50-4603-ade3-7b80a9023c20"> admin/dashboard: <img width="957" alt="Screen Shot 2023-06-26 at 10 59 51" src="https://github.com/go-gitea/gitea/assets/17645053/f4f95bbe-f747-46f1-8fbd-5778a19ebef7">
* Fine tune "dropdown button" icon (#25442)wxiaoguang2023-06-251-0/+11
| | | | | | | ![image](https://github.com/go-gitea/gitea/assets/2114189/143e043d-85c9-43a4-85ae-ca55f507f738) ---- ![image](https://github.com/go-gitea/gitea/assets/2114189/bcba03a5-732e-4139-bc35-96a7f8bfcb88)
* Revert "Make buttons in a modal form have proper type. (#25446)" (#25485)wxiaoguang2023-06-251-2/+0
| | | | | | There is a side effect because some modal doesn't have a proper "ok" button. This reverts commit a954c93a68072042aa7dad717b6fa002c83a58fb.
* Highlight viewed files differently in the PR filetree (#24956)sebastian-sauer2023-06-252-2/+15
| | | | | | | | | ![image](https://github.com/go-gitea/gitea/assets/1135157/009d8026-15a1-4d18-8548-1c3642978f57) fixes #24566 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* fix tags line no margin see #25255 (#25280)hiifong2023-06-241-4/+0
| | | | | | | This is my first pr, there are many things I don't understand very well, I am very sorry, I rearranged the code and opened this new pr. Now: ![image](https://github.com/go-gitea/gitea/assets/89133723/5acd9d81-2152-4966-9372-1fbf902ed073)
* Navbar fixes (#25402)silverwind2023-06-242-4/+9
| | | | | | | | | | | | | | | | Fixes: https://github.com/go-gitea/gitea/issues/25444 Followup for some regressions from https://github.com/go-gitea/gitea/pull/25343. Before and after: <img width="219" alt="Screenshot 2023-06-21 at 00 25 20" src="https://github.com/go-gitea/gitea/assets/115237/08fe8e01-0a16-4cdf-ad4d-0a9048408e9e"> <img width="220" alt="Screenshot 2023-06-21 at 00 25 32" src="https://github.com/go-gitea/gitea/assets/115237/be25ae69-6ed0-4af5-8eeb-d7b210e7c124"> Fixes mobile button background and margins: <img width="836" alt="Screenshot 2023-06-21 at 00 39 58" src="https://github.com/go-gitea/gitea/assets/115237/d76ac1e9-747f-477c-9a42-b73e129b72ee">
* Improve wiki sidebar and TOC (#25460)wxiaoguang2023-06-237-71/+79
| | | | | | | | | | | | | | Close #20976 Close #20975 1. Fix the bug: the TOC in footer was incorrectly rendered as main content's TOC 2. Fix the layout: on mobile, the TOC is put above the main content, while the sidebar is put below the main content 3. Auto collapse the TOC on mobile ps: many styles of "wiki.css" are moved from old css files, so leave nits to following PRs.
* Make buttons in a modal form have proper type. (#25446)wxiaoguang2023-06-231-0/+2
| | | | | | | | | Fix #25438 All non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter". Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>
* Update octicons and use `octicon-file-directory-symlink` (#25453)silverwind2023-06-221-1/+2
| | | | | | | | Make use of the [new octicon](https://github.com/primer/octicons/issues/945) that indicates a symlink to a directory: <img width="189" alt="Screenshot 2023-06-22 at 22 50 57" src="https://github.com/go-gitea/gitea/assets/115237/a70690ea-ebfc-48fe-af23-cdc33bcb2098">
* Diff page enhancements (#25398)silverwind2023-06-222-3/+2
| | | | | | | | | | | | | | | | | | Two small tweaks: 1. Vertically center arrow here when editing a PR: <img width="405" alt="Screenshot 2023-06-20 at 19 48 49" src="https://github.com/go-gitea/gitea/assets/115237/1d63764d-9fd9-467e-8a8e-9258c06475eb"> 2. Use 2-row layout on diff viewed status and show it again on mobile: <img width="142" alt="Screenshot 2023-06-20 at 19 51 21" src="https://github.com/go-gitea/gitea/assets/115237/3046e782-163c-4f87-910c-a22066de8f1b"> Mobile view: <img width="370" alt="Screenshot 2023-06-20 at 19 44 40" src="https://github.com/go-gitea/gitea/assets/115237/9cf56347-7323-4d05-99a5-17ad215ee44d">
* Introduce shared template for search inputs (#25338)silverwind2023-06-221-1/+1
| | | | | | | | | | | | - Set [type=search](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/search) - Disable spellcheck - Set maxLength 255 that I found in `templates/repo/issue/search.tmpl` - Remove unnecessary `max-width`, it does nothing --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Giteabot <teabot@gitea.io>
* Switch to ansi_up for ansi rendering in actions (#25401)silverwind2023-06-224-76/+67
| | | Fixes: https://github.com/go-gitea/gitea/issues/24777
* Various UI fixes (#25264)silverwind2023-06-214-12/+7
| | | | | | | | | | | Numerous small UI fixes: - Fix double border in collaborator list - Fix system notice table background - Mute links in repo and org lists - Downsize projects edit buttons - Improve milestones and project list rendering - Condense milestone list entry to a single line of "metas" - Mute ".." button in repo files list
* Show outdated comments in files changed tab (#24936)sebastian-sauer2023-06-212-10/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on). **Screenshots** ![image](https://github.com/go-gitea/gitea/assets/1135157/63ab9571-a9ee-4900-9f02-94ab0095f9e7) ![image](https://github.com/go-gitea/gitea/assets/1135157/78f7c225-8d76-46f5-acfd-9b8aab988a6c) When resolved and outdated: ![image](https://github.com/go-gitea/gitea/assets/1135157/6ece9ebd-c792-4aa5-9c35-628694e9d093) Option to enable/disable this (stored in user settings - default is disabled): ![image](https://github.com/go-gitea/gitea/assets/1135157/ed99dfe4-76dc-4c12-bd96-e7e62da50ab5) ![image](https://github.com/go-gitea/gitea/assets/1135157/e837a052-e92e-4a28-906d-9db5bacf93a6) fixes #24913 --------- Co-authored-by: silverwind <me@silverwind.io>
* Fine tune project board label colors and modal content background (#25419)HesterG2023-06-212-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - The label text color on project board is not contrasting enough, changed to colors that are same as places that also used `useLightTextOnBackground` function ([util_render.go](https://github.com/go-gitea/gitea/blob/2cdf260f42d178d23a8db70db35664511aeab31e/modules/templates/util_render.go#L136-L141), [Context Popup](https://github.com/go-gitea/gitea/blob/2cdf260f42d178d23a8db70db35664511aeab31e/web_src/js/components/ContextPopup.vue#L81-L84)) - background of modal `content` is `#ffffff` (from fomantic) right now, which does not look good on dark mode, so changed to `var(--color-body)` Before: <img width="1378" alt="Screen Shot 2023-06-21 at 14 24 13" src="https://github.com/go-gitea/gitea/assets/17645053/1527ca28-c884-4ca9-a4be-7a72ad1a093a"> <img width="900" alt="Screen Shot 2023-06-21 at 14 25 52" src="https://github.com/go-gitea/gitea/assets/17645053/fab82116-7376-4027-a0a4-9eedf9fb0a30"> After: <img width="1383" alt="Screen Shot 2023-06-21 at 14 19 33" src="https://github.com/go-gitea/gitea/assets/17645053/fe0997e7-fee6-4522-bc4e-545088ec1cc8"> <img width="797" alt="Screen Shot 2023-06-21 at 14 32 42" src="https://github.com/go-gitea/gitea/assets/17645053/b0591af0-950c-4448-9430-34d6c7215971">
* Add actor and status dropdowns to run list (#25118)HesterG2023-06-211-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | Part of #25042 1. Added actor and status dropdowns first in case something is offtrack and PR is too large. 2. Also added "No results matched." and "The workflow has no runs yet.", and "No results matched." will show if there is no filter results and there is no workflows (with [reference to github action](https://github.com/go-gitea/gitea/actions/workflows/files-changed.yml?query=actor%3AGiteaBot)) Demo: https://github.com/go-gitea/gitea/assets/17645053/6e76292c-4c1f-450d-8b48-99944cfc920c TODOs: - [x] Get available status (same as those in `aggregateJobStatus`) instead of getting from database - [x] Use `JOIN` to get actors, actors order by name - [x] Make self on top
* Fix dropdown icon layout on diff page (#25397)wxiaoguang2023-06-202-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Address https://github.com/go-gitea/gitea/pull/25163#issuecomment-1599207916 Remove the unused "icon-button". And fix the layout: Without the dropdown icon: ``` {{svg "gitea-whitespace"}} ``` ![image](https://github.com/go-gitea/gitea/assets/2114189/58a524ba-f289-4982-aea2-6f9f9f9cbdcf) With the dropdown icon: ``` {{svg "gitea-whitespace" 16 "gt-mr-3"}} {{svg "octicon-triangle-down" 14 "dropdown icon"}} ``` ![image](https://github.com/go-gitea/gitea/assets/2114189/eb99168b-5d49-40a7-8665-5296cbb4e486)
* Support configuration variables on Gitea Actions (#24724)sillyguodong2023-06-202-22/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-Author: @silverwind @wxiaoguang Replace: #24404 See: - [defining configuration variables for multiple workflows](https://docs.github.com/en/actions/learn-github-actions/variables#defining-configuration-variables-for-multiple-workflows) - [vars context](https://docs.github.com/en/actions/learn-github-actions/contexts#vars-context) Related to: - [x] protocol: https://gitea.com/gitea/actions-proto-def/pulls/7 - [x] act_runner: https://gitea.com/gitea/act_runner/pulls/157 - [x] act: https://gitea.com/gitea/act/pulls/43 #### Screenshoot Create Variable: ![image](https://user-images.githubusercontent.com/33891828/236758288-032b7f64-44e7-48ea-b07d-de8b8b0e3729.png) ![image](https://user-images.githubusercontent.com/33891828/236758174-5203f64c-1d0e-4737-a5b0-62061dee86f8.png) Workflow: ```yaml test_vars: runs-on: ubuntu-latest steps: - name: Print Custom Variables run: echo "${{ vars.test_key }}" - name: Try to print a non-exist var run: echo "${{ vars.NON_EXIST_VAR }}" ``` Actions Log: ![image](https://user-images.githubusercontent.com/33891828/236759075-af0c5950-368d-4758-a8ac-47a96e43b6e2.png) --- This PR just implement the org / user (depends on the owner of the current repository) and repo level variables, The Environment level variables have not been implemented. Because [Environment](https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment#about-environments) is a module separate from `Actions`. Maybe it would be better to create a new PR to do it. --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
* Navbar styling rework (#25343)silverwind2023-06-203-96/+139
| | | | | | | | | | | | | | | | | | | | | | | - Extract navbar CSS to own file - Reduce height from 52px to 50px - Give every item a hover effect of of 36px, including the logo and on mobile - Consistent horizontal padding of 10px left and right <img width="549" alt="Screenshot 2023-06-18 at 13 41 16" src="https://github.com/go-gitea/gitea/assets/115237/0b00d101-253e-4b1f-9ee2-322d60fb2e26"> <img width="98" alt="Screenshot 2023-06-18 at 14 03 43" src="https://github.com/go-gitea/gitea/assets/115237/4ef5d98b-4d1e-45de-822e-c2c844e19876"> <img width="234" alt="Screenshot 2023-06-18 at 14 03 18" src="https://github.com/go-gitea/gitea/assets/115237/a4d9b04b-83de-42aa-a9ce-f010a9690688"> <img width="873" alt="Screenshot 2023-06-18 at 13 58 28" src="https://github.com/go-gitea/gitea/assets/115237/8cb8e31e-2adf-40c8-ae3f-d00d011b4d1b"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
* rename tributeValues to mentionValues (#25375)silverwind2023-06-204-5/+5
| | | | Very simple change, just rename this variable so it does not feature the name of the module.
* Fix sidebar label dropdown divider (#25359)HesterG2023-06-191-1/+1
| | | | | | | | | | | | | | | Follow #25312 Also fix the label dropdown on sidebar Before: <img width="1345" alt="Screen Shot 2023-06-19 at 08 55 05" src="https://github.com/go-gitea/gitea/assets/17645053/3a98e871-b482-4ecb-8ce2-74df67fb65a7"> After: <img width="1408" alt="Screen Shot 2023-06-19 at 08 57 17" src="https://github.com/go-gitea/gitea/assets/17645053/09af15cc-1250-49b3-98b6-5b1a2b9021cb">
* Fix issue filters on mobile view (#25368)Denys Konovalov2023-06-191-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | Fix #24846 applying the solution proposed by @silverwind <details> <summary>Screenshots</summary> ![Bildschirmfoto vom 2023-06-19 12-20-54](https://github.com/go-gitea/gitea/assets/47871822/3f4e4536-38c4-451b-bfc0-a7c39acd37f0) ![Bildschirmfoto vom 2023-06-19 12-21-02](https://github.com/go-gitea/gitea/assets/47871822/3403ecc2-4d7f-4acd-b0c0-1b7a10228ff7) ![Bildschirmfoto vom 2023-06-19 12-21-16](https://github.com/go-gitea/gitea/assets/47871822/ef28a2bf-b7cc-4aec-b54b-99d2cc46a1f6) ![Bildschirmfoto vom 2023-06-19 12-21-21](https://github.com/go-gitea/gitea/assets/47871822/f8cd72a5-379e-410b-b0ef-d58895719370) ![Bildschirmfoto vom 2023-06-19 12-21-28](https://github.com/go-gitea/gitea/assets/47871822/34c78301-820c-4106-a086-ae81dc97eb91) ![Bildschirmfoto vom 2023-06-19 12-21-48](https://github.com/go-gitea/gitea/assets/47871822/b677adf1-3a48-42c8-befe-fa9d2679f0a3) </details> Replaces #25335
* Fix loading state regression in markup content (#25349)silverwind2023-06-191-1/+11
| | | | | | | | | | | | | | | Fix regressions from https://github.com/go-gitea/gitea/pull/25219: Math before and after: <img width="630" alt="Screenshot 2023-06-18 at 16 00 52" src="https://github.com/go-gitea/gitea/assets/115237/f2a01e4b-31ca-407c-8fc3-f0aec569b48e"> <img width="680" alt="Screenshot 2023-06-18 at 16 03 44" src="https://github.com/go-gitea/gitea/assets/115237/faab8e39-f088-45ab-b460-15fc3654c99d"> Mermain before and after: <img width="810" alt="Screenshot 2023-06-18 at 15 58 56" src="https://github.com/go-gitea/gitea/assets/115237/d8c24e81-4702-4e17-b791-7dffe090c068"> <img width="786" alt="Screenshot 2023-06-18 at 15 58 37" src="https://github.com/go-gitea/gitea/assets/115237/3a268e10-c071-410d-a66e-8c4427d1d61c">
* Batch delete issue and improve tippy opts (#25253)wxiaoguang2023-06-194-41/+71
| | | | | 1. Add "batch delete" button for selected issues, close #22273 2. Address the review in https://github.com/go-gitea/gitea/pull/25219#discussion_r1229266083
* Fix label list divider (#25312)wxiaoguang2023-06-182-1/+1
| | | | | | | | | | | | | | | | We only needs 2 lines to hide the dividers. ``` $dropdownLabelFilter.dropdown('setting', {'hideDividers': 'empty'}); $dropdownLabelFilter.dropdown('refreshItems'); ``` Other code blocks are refactored by the way. ![image](https://github.com/go-gitea/gitea/assets/2114189/74989996-fcea-4df4-b534-b06f7957939a) ![image](https://github.com/go-gitea/gitea/assets/2114189/ee3b3761-b96e-4fb5-b646-e9d3117e5f40)
* Fix incorrect link-action event target (#25306)wxiaoguang2023-06-181-3/+3
| | | | | | | | | | | A regression of #25210 The `e.target` is not "this", eg: `<button link-action><svg></button>`, then `this` should be `button` but `e.target` is `svg`. I will propose a clearer and complete solution for these "link-action" "show-modal" elements after #24724 Co-authored-by: Giteabot <teabot@gitea.io>
* Fix UI on mobile view (#25315)Denys Konovalov2023-06-185-51/+133
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Various fixes to pages or elements which were looking ugly on mobile. <details> <summary>Screenshots</summary> ![Bildschirmfoto vom 2023-06-17 20-38-41](https://github.com/go-gitea/gitea/assets/47871822/30b5d3ce-df3b-43eb-a4c2-c3790667fb9d) ![Bildschirmfoto vom 2023-06-17 20-39-27](https://github.com/go-gitea/gitea/assets/47871822/27c07b25-3602-4fb2-b34d-d5e875e054e9) ![Bildschirmfoto vom 2023-06-17 20-41-27](https://github.com/go-gitea/gitea/assets/47871822/dacdbb4e-e3dd-4b94-abf0-c68e3d64bd3b) ![Bildschirmfoto vom 2023-06-17 20-41-48](https://github.com/go-gitea/gitea/assets/47871822/72432c35-7c4a-4c7f-a767-3562f26a5c14) ![Bildschirmfoto vom 2023-06-17 20-42-37](https://github.com/go-gitea/gitea/assets/47871822/737c26ed-1910-4467-98ef-e8769bbbe6f0) ![Bildschirmfoto vom 2023-06-17 20-42-52](https://github.com/go-gitea/gitea/assets/47871822/1813b4bc-43c0-4912-8acb-5d799c090bf3) ![Bildschirmfoto vom 2023-06-17 20-43-06](https://github.com/go-gitea/gitea/assets/47871822/136466e8-34e5-419d-97ec-5202ff819fd2) ![Bildschirmfoto vom 2023-06-17 20-43-42](https://github.com/go-gitea/gitea/assets/47871822/59270bb2-d661-4a84-8504-3e50f771f767) ![Bildschirmfoto vom 2023-06-17 20-44-44](https://github.com/go-gitea/gitea/assets/47871822/494e274d-3771-4141-9419-0a4bbd8b7f64) </details> Co-authored by @silverwind --------- Co-authored-by: silverwind <me@silverwind.io>
* Update JS dependencies, remove space after emoji completion (#25266)silverwind2023-06-181-1/+3
| | | | | | | | | | | | | | | | | - Update all JS dependencies - Enable stylint [`media-feature-name-value-no-unknown`](https://stylelint.io/user-guide/rules/media-feature-name-value-no-unknown) - Make use of new features in webpack and text-expander-element - Tested Swagger and Mermaid To explain the `text-expander-element` change: Before this version, the element added a unavoidable space after emoji completion. Now that https://github.com/github/text-expander-element/pull/36 is in, we gain control over this space and I opted to remove it for emoji completion and retain it for `@` mentions. --------- Co-authored-by: Giteabot <teabot@gitea.io>
* Add `stylelint-declaration-block-no-ignored-properties` (#25284)silverwind2023-06-181-3/+0
| | | | | | Add [stylelint-declaration-block-no-ignored-properties](https://github.com/kristerkari/stylelint-declaration-block-no-ignored-properties) and fix discovered issue. There is no visual difference in these markup code blocks.
* Remove EasyMDE focus outline on text (#25328)silverwind2023-06-181-0/+4
| | | | EasyMDE in Firefox currently shows an ugly outline in the fake textarea the CodeMirror uses. Hide it.
* add `stylelint-stylistic` (#25285)silverwind2023-06-1710-27/+14
| | | | | | Add [stylelint-stylistic](https://github.com/elirasza/stylelint-stylistic), autofix all issues with two manual tweaks. This restores all the stylistic rules removed in Stylelint 15.
* Remove more unused Fomantic variants (#25292)silverwind2023-06-174-1887/+16
| | | | | | | | | Save another 50KB of CSS by removing unused and useless Fomantic variants. Removed the last instance if a `tertiary` button and fixed a TODO: <img width="509" alt="Screenshot 2023-06-15 at 22 34 36" src="https://github.com/go-gitea/gitea/assets/115237/8a16ae7b-2b17-439b-a096-60a52724e3d6">
* Use fetch to send requests to create issues/comments (#25258)wxiaoguang2023-06-162-16/+25
| | | | | | | | | | | | | | | | Follow #23290 Network error won't make content lost. And this is a much better approach than "loading-button". The UI is not perfect and there are still some TODOs, they can be done in following PRs, not a must in this PR's scope. <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/c94ba958-aa46-4747-8ddf-6584deeed25c) </details>
* Fix some UI alignments (#25277)wxiaoguang2023-06-152-15/+12
| | | | | | | | | | | | | | Fixes: https://github.com/go-gitea/gitea/issues/25282 Fix the problems: 1. The `repo-button-row` had various patches before, this PR makes it consistent 2. The "Add File" has wrong CSS class "icon", remove it 3. The "Add File" padding was overridden by "!important", fix it by `.repo-button-row .button.dropdown` with comment 4. The selector `.ui.segments ~ .ui.top.attached.header` is incorrect, it should use `+`
* Remove fomantic inverted variations (#25286)silverwind2023-06-152-4333/+38
| | | | Remove all Fomantic `inverted` variations, we are no using any of them. This reduces the index CSS bundle by 98kB.
* Fix issue and commit status popup padding (#25254)wxiaoguang2023-06-152-0/+2
| | | | | | | | | | | | | Close #25249 Use "dialog" for the role ![image](https://github.com/go-gitea/gitea/assets/2114189/2b5b7552-48bc-4ecf-947b-34917232cff9) --------- Co-authored-by: silverwind <me@silverwind.io>
* Show OAuth2 errors to end users (#25261)wxiaoguang2023-06-151-0/+6
| | | | | | | | | | | | Partially fix #23936 ![image](https://github.com/go-gitea/gitea/assets/2114189/8aa7f3ad-a5f0-42ce-a478-289a03bd08a3) ![image](https://github.com/go-gitea/gitea/assets/2114189/bb901e7d-485a-47a5-b68d-9ebe7013a6b2) ![image](https://github.com/go-gitea/gitea/assets/2114189/9a1ce0f3-f011-4baf-8e2f-cc6304bc9703)
* Use flex to align SVG and text (#25163)wxiaoguang2023-06-147-65/+86
| | | | | | | | | | | | | | | | The code can be as simple as: ```html <div class="flex-text-block">{{svg "octicon-alert"}} {{svg "octicon-x"}} text (block)</div> <div><div class="flex-text-inline">{{svg "octicon-alert"}} {{svg "octicon-x"}} text</div> (inline)</div> <div><button class="ui red button">{{svg "octicon-alert" 24}} {{svg "octicon-x" 24}} text</button></div> ``` ![image](https://github.com/go-gitea/gitea/assets/2114189/1d3c10f1-0bc7-4c26-b236-bad537d5c465) --------- Co-authored-by: Giteabot <teabot@gitea.io>
* Change form actions to fetch for submit review box (#25219)HesterG2023-06-146-23/+125
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-author: @wxiaoguang Close #25096 The way to fix it in this PR is to change form submit to fetch using formData, and add flags to avoid post repeatedly. Should be able to apply to more forms that have the same issue after this PR. In the demo below, 'approve' is clicked several times, and then 'comment' is clicked several time after 'request changes' clicked. After: https://github.com/go-gitea/gitea/assets/17645053/beabeb1d-fe66-4b76-b048-4f022b4e83a0 Update: screenshots from /devtest > ![image](https://user-images.githubusercontent.com/2114189/245680011-ee4231e0-a53d-4c2a-a9c2-71ccd98005cc.png) > > ![image](https://user-images.githubusercontent.com/2114189/245680057-9215d348-63d8-406d-8828-17e171163aaa.png) > > ![image](https://user-images.githubusercontent.com/2114189/245680148-89d7b3d1-d7b6-442f-b69e-eadaee112482.png) --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Revert overflow: overlay (revert #21850) (#25231)wxiaoguang2023-06-135-16/+7345
| | | | | | | | | | | | | | | | | | | | | | | It causes not only one issue like #25221 (the footer width was also affected by that change and was fixed some time ago) The problem of "overflow: overlay" (#21850) is: * It's not widely supported and is non-standard https://caniuse.com/css-overflow-overlay * It's not widely tested in Gitea (some standard layout like `ui container + ui grid` may break it). * The benefit seems smaller than the problems it brings. So, I think it is good to revert it. ---- Let's leave enough time for testing and reviewing. --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: silverwind <me@silverwind.io>
* Improve AJAX link and modal confirm dialog (#25210)wxiaoguang2023-06-132-100/+57
| | | | | | | | | | | | | | | | | | | | | | Clarify the "link-action" behavior: > // A "link-action" can post AJAX request to its "data-url" > // Then the browser is redirect to: the "redirect" in response, or "data-redirect" attribute, or current URL by reloading. And enhance the "link-action" to support showing a modal dialog for confirm. A similar general approach could also help PRs like https://github.com/go-gitea/gitea/pull/22344#discussion_r1062883436 > // If the "link-action" has "data-modal-confirm(-html)" attribute, a confirm modal dialog will be shown before taking action. And a lot of duplicate code can be removed now. A good framework design can help to avoid code copying&pasting. --------- Co-authored-by: silverwind <me@silverwind.io>
* Use inline SVG for built-in OAuth providers (#25171)silverwind2023-06-1312-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The plan is that all built-in auth providers use inline SVG for more flexibility in styling and to get the GitHub icon to follow `currentcolor`. This only removes the `public/img/auth` directory and adds the missing svgs to our svg build. It should map the built-in providers to these SVGs and render them. If the user has set a Icon URL, it should render that as an `img` tag instead. ``` gitea-azure-ad gitea-bitbucket gitea-discord gitea-dropbox gitea-facebook gitea-gitea gitea-gitlab gitea-google gitea-mastodon gitea-microsoftonline gitea-nextcloud gitea-twitter gitea-yandex octicon-mark-github ``` GitHub logo is now white again on dark theme: <img width="431" alt="Screenshot 2023-06-12 at 21 45 34" src="https://github.com/go-gitea/gitea/assets/115237/27a43504-d60a-4132-a502-336b25883e4d"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>