From a159c3175f5f60a9de00f4d3c73787ffa6c63ddd Mon Sep 17 00:00:00 2001 From: silverwind Date: Mon, 22 Nov 2021 09:19:01 +0100 Subject: Add new JS linter rules (#17699) * Add new JS linter rules Adds a few useful rules from eslint-plugin-github. Notable changes: - Forbid dataset usage, its camel-casing behaviour makes it hard to grep for attributes. - Forbid .then() and .catch(), we should generally prefer await for new code. For rare cases where they are useful, a eslint-disable-line directive can be set. - Add docs js to linting * also enable github/array-foreach * small tweak Co-authored-by: Andrew Thornton Co-authored-by: techknowlogick Co-authored-by: wxiaoguang --- build/generate-images.js | 2 +- build/generate-svg.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'build') diff --git a/build/generate-images.js b/build/generate-images.js index b8284b1be2..ab4073dfcc 100755 --- a/build/generate-images.js +++ b/build/generate-images.js @@ -80,5 +80,5 @@ async function main() { ]); } -main().then(exit).catch(exit); +main().then(exit).catch(exit); // eslint-disable-line github/no-then diff --git a/build/generate-svg.js b/build/generate-svg.js index 29b7d47693..53ec000d12 100755 --- a/build/generate-svg.js +++ b/build/generate-svg.js @@ -54,5 +54,5 @@ async function main() { ]); } -main().then(exit).catch(exit); +main().then(exit).catch(exit); // eslint-disable-line github/no-then -- cgit v1.2.3