From 638dd24cec6f2951ecd4550165b858138c4c3f40 Mon Sep 17 00:00:00 2001 From: Andrey Nering Date: Sat, 26 Nov 2016 10:08:31 -0200 Subject: Fix HTTP headers for issue attachment download - Download filename was wrong for files other than images. Example: It was `download` instead of `file.pdf` - PDF was downloading instead of showing on browser --- cmd/web.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'cmd') diff --git a/cmd/web.go b/cmd/web.go index 3d0c977798..f5553cdf00 100644 --- a/cmd/web.go +++ b/cmd/web.go @@ -336,11 +336,7 @@ func runWeb(ctx *cli.Context) error { } defer fr.Close() - ctx.Header().Set("Cache-Control", "public,max-age=86400") - ctx.Header().Set("Content-Disposition", fmt.Sprintf(`inline; filename="%s"`, attach.Name)) - // Fix #312. Attachments with , in their name are not handled correctly by Google Chrome. - // We must put the name in " manually. - if err = repo.ServeData(ctx, "\""+attach.Name+"\"", fr); err != nil { + if err = repo.ServeData(ctx, attach.Name, fr); err != nil { ctx.Handle(500, "ServeData", err) return } -- cgit v1.2.3