From e67659bf8e76763bdfdfe02d87359255b7acd19b Mon Sep 17 00:00:00 2001 From: Unknwon Date: Wed, 12 Aug 2015 04:49:51 +0800 Subject: fix serve attachment content type --- cmd/web.go | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'cmd') diff --git a/cmd/web.go b/cmd/web.go index decad7d34f..6ca771e230 100644 --- a/cmd/web.go +++ b/cmd/web.go @@ -338,9 +338,19 @@ func runWeb(ctx *cli.Context) { return } + fr, err := os.Open(attach.LocalPath()) + if err != nil { + ctx.Handle(500, "Open", err) + return + } + defer fr.Close() + // Fix #312. Attachments with , in their name are not handled correctly by Google Chrome. // We must put the name in " manually. - ctx.ServeFileContent(attach.LocalPath(), "\""+attach.Name+"\"") + if err = repo.ServeData(ctx, "\""+attach.Name+"\"", fr); err != nil { + ctx.Handle(500, "ServeData", err) + return + } }) m.Post("/issues/attachments", repo.UploadIssueAttachment) }, ignSignIn) -- cgit v1.2.3