From bac4b78e0908c0cb01a3842436950c7bcf793cf9 Mon Sep 17 00:00:00 2001 From: David Svantesson Date: Wed, 4 Dec 2019 02:08:56 +0100 Subject: Branch protection: Possibility to not use whitelist but allow anyone with write access (#9055) * Possibility to not use whitelist but allow anyone with write access * fix existing test * rename migration function * Try to give a better name for migration step * Clear settings if higher level setting is not set * Move official reviews to db instead of counting approvals each time * migration * fix * fix migration * fix migration * Remove NOT NULL from EnableWhitelist as migration isn't possible * Fix migration, reviews are connected to issues. * Fix SQL query issues in GetReviewersByPullID. * Simplify function GetReviewersByIssueID * Handle reviewers that has been deleted * Ensure reviews for test is in a well defined order * Only clear and set official reviews when it is an approve or reject. --- integrations/git_test.go | 1 + 1 file changed, 1 insertion(+) (limited to 'integrations/git_test.go') diff --git a/integrations/git_test.go b/integrations/git_test.go index 3ca4cc54c2..b504cd7524 100644 --- a/integrations/git_test.go +++ b/integrations/git_test.go @@ -383,6 +383,7 @@ func doProtectBranch(ctx APITestContext, branch string, userToWhitelist string) req := NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/%s/settings/branches/%s", url.PathEscape(ctx.Username), url.PathEscape(ctx.Reponame), url.PathEscape(branch)), map[string]string{ "_csrf": csrf, "protected": "on", + "enable_push": "whitelist", "enable_whitelist": "on", "whitelist_users": strconv.FormatInt(user.ID, 10), }) -- cgit v1.2.3