From c97494a4f4a0e8ba5453e293bcebb76274062b99 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Sat, 2 May 2020 02:20:51 +0200 Subject: API: Add pull review endpoints (#11224) * API: Added pull review read only endpoints * Update Structs, move Conversion, Refactor * refactor * lint & co * fix lint + refactor * add new Review state, rm unessesary, refacotr loadAttributes, convert patch to diff * add DeletePullReview * add paggination * draft1: Create & submit review * fix lint * fix lint * impruve test * DONT use GhostUser for loadReviewer * expose comments_count of a PullReview * infent GetCodeCommentsCount() * fixes * fix+impruve * some nits * Handle Ghosts :ghost: * add TEST for GET apis * complete TESTS * add HTMLURL to PullReview responce * code format as per @lafriks * update swagger definition * Update routers/api/v1/repo/pull_review.go Co-authored-by: David Svantesson * add comments Co-authored-by: Thomas Berger Co-authored-by: David Svantesson --- models/fixtures/pull_request.yml | 4 ++-- models/fixtures/review.yml | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) (limited to 'models/fixtures') diff --git a/models/fixtures/pull_request.yml b/models/fixtures/pull_request.yml index da9566bc48..b555da83ef 100644 --- a/models/fixtures/pull_request.yml +++ b/models/fixtures/pull_request.yml @@ -8,7 +8,7 @@ base_repo_id: 1 head_branch: branch1 base_branch: master - merge_base: 1234567890abcdef + merge_base: 4a357436d925b5c974181ff12a994538ddc5a269 has_merged: true merger_id: 2 @@ -22,7 +22,7 @@ base_repo_id: 1 head_branch: branch2 base_branch: master - merge_base: fedcba9876543210 + merge_base: 4a357436d925b5c974181ff12a994538ddc5a269 has_merged: false - diff --git a/models/fixtures/review.yml b/models/fixtures/review.yml index 87621012ff..35d3dee2e6 100644 --- a/models/fixtures/review.yml +++ b/models/fixtures/review.yml @@ -60,6 +60,8 @@ reviewer_id: 4 issue_id: 3 content: "New review 5" + commit_id: 8091a55037cd59e47293aca02981b5a67076b364 + stale: true updated_unix: 946684813 created_unix: 946684813 - @@ -77,5 +79,6 @@ reviewer_id: 100 issue_id: 3 content: "a deleted user's review" + official: true updated_unix: 946684815 - created_unix: 946684815 \ No newline at end of file + created_unix: 946684815 -- cgit v1.2.3