From 58c124cc4f3076b9524f68c2161e362c2148dffa Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Sun, 16 Feb 2025 04:24:07 -0800 Subject: Move commits signature and verify functions to service layers (#33605) No logic change, just move functions. --- models/git/commit_status.go | 40 ---------------------------------------- 1 file changed, 40 deletions(-) (limited to 'models/git/commit_status.go') diff --git a/models/git/commit_status.go b/models/git/commit_status.go index ad3624bbc9..5432eea55e 100644 --- a/models/git/commit_status.go +++ b/models/git/commit_status.go @@ -496,51 +496,11 @@ type SignCommitWithStatuses struct { *asymkey_model.SignCommit } -// ParseCommitsWithStatus checks commits latest statuses and calculates its worst status state -func ParseCommitsWithStatus(ctx context.Context, oldCommits []*asymkey_model.SignCommit, repo *repo_model.Repository) ([]*SignCommitWithStatuses, error) { - newCommits := make([]*SignCommitWithStatuses, 0, len(oldCommits)) - - for _, c := range oldCommits { - commit := &SignCommitWithStatuses{ - SignCommit: c, - } - statuses, _, err := GetLatestCommitStatus(ctx, repo.ID, commit.ID.String(), db.ListOptions{}) - if err != nil { - return nil, err - } - - commit.Statuses = statuses - commit.Status = CalcCommitStatus(statuses) - newCommits = append(newCommits, commit) - } - return newCommits, nil -} - // hashCommitStatusContext hash context func hashCommitStatusContext(context string) string { return fmt.Sprintf("%x", sha1.Sum([]byte(context))) } -// ConvertFromGitCommit converts git commits into SignCommitWithStatuses -func ConvertFromGitCommit(ctx context.Context, commits []*git.Commit, repo *repo_model.Repository) ([]*SignCommitWithStatuses, error) { - validatedCommits, err := user_model.ValidateCommitsWithEmails(ctx, commits) - if err != nil { - return nil, err - } - signedCommits, err := asymkey_model.ParseCommitsWithSignature( - ctx, - validatedCommits, - repo.GetTrustModel(), - func(user *user_model.User) (bool, error) { - return repo_model.IsOwnerMemberCollaborator(ctx, repo, user.ID) - }, - ) - if err != nil { - return nil, err - } - return ParseCommitsWithStatus(ctx, signedCommits, repo) -} - // CommitStatusesHideActionsURL hide Gitea Actions urls func CommitStatusesHideActionsURL(ctx context.Context, statuses []*CommitStatus) { idToRepos := make(map[int64]*repo_model.Repository) -- cgit v1.2.3