From 99283415bcbaa8acfe4d249ce3040de2f3a8b006 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Tue, 16 May 2023 03:02:10 +0800 Subject: Refactor Pull Mirror and fix out-of-sync bugs (#24732) The "mirror" table and "repository" table might be out-of-sync in some cases. It means that "IsMirror=true" but "Mirror=nil" This PR removes unnecessary "Mirror" field, rename "Mirror" to "PullMirror" and fix nil panic bug. Screenshot of changed templates: ![image](https://github.com/go-gitea/gitea/assets/2114189/c0f2bdfc-5911-43ea-b989-b19619de4235) ![image](https://github.com/go-gitea/gitea/assets/2114189/1078b41a-484f-4c06-8c2f-edb9e658275d) --- models/repo/repo.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'models/repo') diff --git a/models/repo/repo.go b/models/repo/repo.go index 7cbd5867b7..00e875407c 100644 --- a/models/repo/repo.go +++ b/models/repo/repo.go @@ -149,8 +149,8 @@ type Repository struct { IsEmpty bool `xorm:"INDEX"` IsArchived bool `xorm:"INDEX"` IsMirror bool `xorm:"INDEX"` - *Mirror `xorm:"-"` - Status RepositoryStatus `xorm:"NOT NULL DEFAULT 0"` + + Status RepositoryStatus `xorm:"NOT NULL DEFAULT 0"` RenderingMetas map[string]string `xorm:"-"` DocumentRenderingMetas map[string]string `xorm:"-"` -- cgit v1.2.3