From 8f00979f732c976b75086f75ab7e776d2ee18771 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Sat, 8 Apr 2023 14:21:50 +0800 Subject: Drop "unrolled/render" package (#23965) None of the features of `unrolled/render` package is used. The Golang builtin "html/template" just works well. Then we can improve our HTML render to resolve the "$.root.locale.Tr" problem as much as possible. Next step: we can have a template render pool (by Clone), then we can inject global functions with dynamic context to every `Execute` calls. Then we can use `{{Locale.Tr ....}}` directly in all templates , no need to pass the `$.root.locale` again and again. --- modules/context/context.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'modules/context') diff --git a/modules/context/context.go b/modules/context/context.go index 1eff1459a1..04f8a9bd3d 100644 --- a/modules/context/context.go +++ b/modules/context/context.go @@ -42,14 +42,13 @@ import ( "gitea.com/go-chi/session" chi "github.com/go-chi/chi/v5" "github.com/minio/sha256-simd" - "github.com/unrolled/render" "golang.org/x/crypto/pbkdf2" ) // Render represents a template render type Render interface { TemplateLookup(tmpl string) *template.Template - HTML(w io.Writer, status int, name string, binding interface{}, htmlOpt ...render.HTMLOptions) error + HTML(w io.Writer, status int, name string, data interface{}) error } // Context represents context of a request. -- cgit v1.2.3